246 lines
8.4 KiB
TypeScript
Raw Normal View History

Refactor redux pattern from top-level to ducks (#1936) * Add a new route for AddressBook * Further templating of the AddressBook view * Add initial functionality to handle a table of existing address labels * Make the linter happy * Adjust paths * Factor out TableRow and add common functionality * Add initial Redux boilerplate for addressBook | fix minor linting issues * Swap out terminology and types * Connect up to Redux * Connect data for AddressBookTable to Redux * Use temporary fields for addition * Remove alignment and index column * Stopping point * Adjust the sizing of rows to be consistent * Initial implementation of a dropdown for the address field * Minor styling to dropdown * Stopping point * Apply a focus concept onto the factory * Add keyboard controls for the address field dropdown * Adjust label of address field when it matches an addressBook entry * Properly handle attempting to blur a non-existent component * Minor styling changes on dropdown box * Standardize address casing, add accessibility to dropdown * Create an addressLabel component * Pass refs correctly and fix some typings * Exact version * Add module name mapping for shared/keycodes * addressBook reducer tests * Add functionality to DeterministicModal * Minor changes / Add test for addressBook selectors * Move out AddressBookTable to a component * Typing, translation and restructuring * More typing and translation fixes * More linting fixes * More type changes * Variable name for dropdown background * Fix TS type errors, lint errors, remove unused props * Used a different selector and removed method: AddressBookTable * Linter was mad * Linter mad again :( * Add a translation and adjust styling of AddressBookTable * Move the onBlur to a class method * Prevent the default behavior of up/down/enter for dropdown * Let's do it this way instead * Adjust the styling on DeterministicWalletModal labels * Change `AddressBookTable` into a pseudo-table using section and div * Use readable keys vs. keycodes * Put the dropdown in InputFactory and position it correctly * Sanitation of label adding and changing * Prevent duplicate labels in AddressBook and Row * Add a box shadow and use `invalid` class insted of custom * Use emphasis vs strong for address in dropdown * Display the label undernearth the input vs. changing it * Isolate AccountAddress into its own component * Introduce interactivity to AccountAddress * Fully incorporate with Redux * Validation for AccountAddress * Add validation notifications for address field on AddressBookTable * Minor formatting * Adjust wrappage for optimal flexboxxing * Make AddressBookTable responsive * Show an invalid input in "real time" instead of only on submit * Real time input validation for AddressBookTableRow * Responsive-ize the To address dropdown * Hide identicons instead at small enough screen sizes * Fix repsonsiveness of dropdown further * Fix responsiveness of table rows and inputs * Truncate account info and switch identicons to the right for consistency * Use classnames instead of targetting element directly for DWM * Display a notice if the entered query doesnt match a label and isnt an addr * Don't show an error on the To address if its a label entry * Display an error under AddressBookTableRow in real time * Display errors in real time for AddressBookTable temp inputs * Add realtime validation to AccountAddress * Ensure toChecksumAddress is used when entering labels to address manager * Show errors even after blurring. * Create a ducks/ implementation for addressBook * Duck-ize notifications * Duck-ize customTokens * Duck-ize deterministicWallets * Only show errors on address/label entry if they have been blurred * On certain inputs, show an invalid input immediately * spec files in same directory * Rename top-level redux directory * Duck-ize gas * Add displayed errors for labels with 0x and labels containing ens * Move ENS checking validation out * Add a saga for addLabelForAddress * Completely revamp the redux side of Address Manager and test it all * Adjust components to use new redux addressBook * Incorporate new redux into AddressBookTableRow and clean up for linter * Make linter and tests happy * Another reduxy overhaul * Still fixing it * More redux updates * Finalize redux stuff. * Incorporate new reduxy way into AddressBookTable & Row * Incorporate redux changes into Account Address * Small tests fix * Add and fix some selector tests * Addressing Will's comments * Shortened visibility class for line length reasons. * Incorporate ducks pattern on updates addressBook * Fix typeerror * Migrate messages to ducks * For Henry * Duckify onboardStatus * Duckify paritySigner * Duckify rates * Duckify transactions * Duckerize wallet * Reduckerate config * Adjust exports and tests of every duck so far * Duckify ENS * Duckerificate schedule * Duckificate swap * Actually use the new sagas; fix a circular dependency problem. * Duckify transaction (phew) * Add basics to redux/ directory * Remove non-ducked redux stuff * First sweep of redux/ directory * Combine redundant imports * Fix more linting stuff. * A few more type fixes * Welp... now I know not to use index. * Sweep components/ * Sweep through containers/ * Im really starting to get frustrated * The dawn of a new age. * Linter fixes. * De-flatten config/ reducers * Do my thang on config selectors * Adjust all references to config * Split up ens reducers * Wrap up de-nesting ENS * Big boy refactor * Split transaction into its reducers * Fix reducers in transaction/ * Stopping point * Adjust references to transaction from components * Fix references to selectors * Nest broadcast actions * Nest field actions * Nest meta actions * Nest network actions * Nest sign actions * Nest broadcast types * Nested fields types * Nest meta types * Nested network types * Nested sign types * Implement transaction saga changes * Huh? No prepush problems? * Update snappshot * Reintroduce deleted tests * A few missing tests found * Found three missing transaction tests * Found more tests * Found the rest of the tests, woohoo. * Renamed TypeKeys in TRANSACTION * Specify TRANSACTION_BROADCAST * Pretty up these imports * Specify TRANSACTION_FIELDS * Specify TRANSACTION_META * Specify TRANSACTION_NETWORK * Specify TRANSACTION_SIGN * Adjust imports and add translations * Update config snapshot * Post-merge * Temporary fix for DW/Config sagas so Daniel can continue smoke testing * Remove first circulat dependency * Fix more circular dependencies * Properly structure config indices * Further restructure config * Prepare for idea * Target directly from within features/ * Remove that circular dependency -- woohoo * Remove the circular dependency from Web3Wallet, temporarily comment some tests pending assistance * Un-comment the component-in-redux phenomenon * Move onLoad to the store file * Adjust addressBook imports/exports * Adjusted imports/exports for customTokens * Adjust imports/exports of deterministicWallets * Adjust imports/exports of ens * Restructure imports/exports of gas * Restructure imports/exports for message * Adjust imports/exports of notifications * Restructure onboardStatus imports/exports * Restructure paritySigner imports/exports * Restructure rates imports/exports * Restructure schedule imports/exports * Fix broadcastweb3handler test * Restructure swap imports/exports/ * Restructure transactionS imports/exports * Restructured wallet imports and exports * Hoist all necessary selectors aside from config/**/* and transaction/**/* * Hoist all top-level selectors from transaction * [Fix] Estimate Gas on Value Field Change (#1942) @ skubakdj * Implement right-click context menu (#1780) @ bryanwb * No Private Keys Online (#1466) @ wbobeirne * Fix Stuck Node on Metamask Logout (#1951) @ wbobeirne * [Fix] Make ENS Value Consistent (#1956) @ skubakdj * Auto token add (#1808) @ HenryNguyen5 * Electron Ledger + Trezor Support (#1836) @ wbobeirne * Fix Context Menu Popup Parameters (#1957) * Add RSK network w/ network agnostic refactors (#1939) @ wbobeirne * Change displayed notification back in helpers.tsx * Remove newline on shell files * Re-add newlines * Remove newling on .travis.yml * Prettier two files * Re-add index.scss import in OnboardModal * Restructure transaction subdirectories * Everything in transaction/ except for sagas * Restructure transaction imports/exports * Nest broadcast sagas * Nest fields * Nest meta * Nest network * Nest sign * Use generic names for reduxy stuff in the same directory to save space * Do everything every in the whole wide world
2018-06-17 20:53:00 -05:00
import BN from 'bn.js';
import { SagaIterator, buffers, delay } from 'redux-saga';
import {
apply,
put,
select,
take,
actionChannel,
call,
fork,
race,
cancel,
takeEvery
} from 'redux-saga/effects';
import { AddressMessage } from 'config';
import { INode } from 'libs/nodes/INode';
import { IWallet } from 'libs/wallet';
import { Nonce } from 'libs/units';
import { makeTransaction, getTransactionFields, IHexStrTransaction } from 'libs/transaction';
import { IGetTransaction } from 'features/types';
import { AppState } from 'features/reducers';
import * as derivedSelectors from 'features/selectors';
import * as configMetaTypes from 'features/config/meta/types';
import * as configMetaSelectors from 'features/config/meta/selectors';
import * as configNodesSelectors from 'features/config/nodes/selectors';
import { walletTypes, walletSelectors } from 'features/wallet';
import { scheduleActions, scheduleSelectors } from 'features/schedule';
import { notificationsActions } from 'features/notifications';
import { transactionFieldsTypes, transactionFieldsActions } from '../fields';
import * as transactionTypes from '../types';
import * as types from './types';
import * as actions from './actions';
//#region From
/*
* This function will be called during transaction serialization / signing
*/
export function* handleFromRequest(): SagaIterator {
const walletInst: AppState['wallet']['inst'] = yield select(walletSelectors.getWalletInst);
try {
if (!walletInst) {
throw Error();
}
const fromAddress: string = yield apply(walletInst, walletInst.getAddressString);
yield put(actions.getFromSucceeded(fromAddress));
} catch {
yield put(
notificationsActions.showNotification('warning', 'Your wallets address could not be fetched')
);
yield put(actions.getFromFailed());
}
}
export const fromSaga = takeEvery(
types.TransactionNetworkActions.GET_FROM_REQUESTED,
handleFromRequest
);
//#endregion From
//#region Gas
export function* shouldEstimateGas(): SagaIterator {
while (true) {
const action:
| transactionFieldsTypes.SetToFieldAction
| transactionFieldsTypes.SetValueFieldAction
| transactionFieldsTypes.SetDataFieldAction
| transactionTypes.SwapEtherToTokenAction
| transactionTypes.SwapTokenToTokenAction
| transactionTypes.SwapTokenToEtherAction
| configMetaTypes.ToggleAutoGasLimitAction
| transactionFieldsTypes.SetValueFieldAction = yield take([
transactionFieldsTypes.TransactionFieldsActions.TO_FIELD_SET,
transactionFieldsTypes.TransactionFieldsActions.VALUE_FIELD_SET,
transactionFieldsTypes.TransactionFieldsActions.DATA_FIELD_SET,
transactionTypes.TransactionActions.ETHER_TO_TOKEN_SWAP,
transactionTypes.TransactionActions.TOKEN_TO_TOKEN_SWAP,
transactionTypes.TransactionActions.TOKEN_TO_ETHER_SWAP,
configMetaTypes.CONFIG_META.TOGGLE_AUTO_GAS_LIMIT
]);
const isOffline: boolean = yield select(configMetaSelectors.getOffline);
const autoGasLimitEnabled: boolean = yield select(configMetaSelectors.getAutoGasLimitEnabled);
const message: AddressMessage | undefined = yield select(
derivedSelectors.getCurrentToAddressMessage
);
if (isOffline || !autoGasLimitEnabled || (message && message.gasLimit)) {
continue;
}
// invalid field is a field that the value is null and the input box isnt empty
// reason being is an empty field is valid because it'll be null
const invalidField =
(action.type === transactionFieldsTypes.TransactionFieldsActions.TO_FIELD_SET ||
action.type === transactionFieldsTypes.TransactionFieldsActions.DATA_FIELD_SET ||
action.type === transactionFieldsTypes.TransactionFieldsActions.VALUE_FIELD_SET) &&
!action.payload.value &&
action.payload.raw !== '';
if (invalidField) {
continue;
}
const { transaction }: IGetTransaction = yield select(derivedSelectors.getTransaction);
const { gasLimit, gasPrice, nonce, chainId, ...rest }: IHexStrTransaction = yield call(
getTransactionFields,
transaction
);
// gas estimation calls with
// '0x' as an address (contract creation)
// fail, so instead we set it as undefined
// interestingly, the transaction itself as '0x' as the
// to address works fine.
if (rest.to === '0x') {
rest.to = undefined as any;
}
yield put(actions.estimateGasRequested(rest));
}
}
export function* estimateGas(): SagaIterator {
const requestChan = yield actionChannel(
types.TransactionNetworkActions.ESTIMATE_GAS_REQUESTED,
buffers.sliding(1)
);
while (true) {
const autoGasLimitEnabled: boolean = yield select(configMetaSelectors.getAutoGasLimitEnabled);
const isOffline = yield select(configMetaSelectors.getOffline);
if (isOffline || !autoGasLimitEnabled) {
continue;
}
const { payload }: types.EstimateGasRequestedAction = yield take(requestChan);
// debounce 250 ms
yield call(delay, 250);
const node: INode = yield select(configNodesSelectors.getNodeLib);
const walletInst: IWallet = yield select(walletSelectors.getWalletInst);
try {
const from: string = yield apply(walletInst, walletInst.getAddressString);
const txObj = { ...payload, from };
const { gasLimit } = yield race({
gasLimit: apply(node, node.estimateGas, [txObj]),
timeout: call(delay, 10000)
});
if (gasLimit) {
const gasSetOptions = {
raw: gasLimit.toString(),
value: gasLimit
};
const scheduling: boolean = yield select(scheduleSelectors.isSchedulingEnabled);
if (scheduling) {
yield put(scheduleActions.setScheduleGasLimitField(gasSetOptions));
} else {
yield put(transactionFieldsActions.setGasLimitField(gasSetOptions));
}
yield put(actions.estimateGasSucceeded());
} else {
yield put(actions.estimateGasTimedout());
yield call(localGasEstimation, payload);
}
} catch (e) {
yield put(actions.estimateGasFailed());
yield call(localGasEstimation, payload);
}
}
}
export function* localGasEstimation(payload: types.EstimateGasRequestedAction['payload']) {
const tx = yield call(makeTransaction, payload);
const gasLimit = yield apply(tx, tx.getBaseFee);
yield put(
transactionFieldsActions.setGasLimitField({ raw: gasLimit.toString(), value: gasLimit })
);
}
export function* setAddressMessageGasLimit() {
const autoGasLimitEnabled: boolean = yield select(configMetaSelectors.getAutoGasLimitEnabled);
const message: AddressMessage | undefined = yield select(
derivedSelectors.getCurrentToAddressMessage
);
if (autoGasLimitEnabled && message && message.gasLimit) {
yield put(
transactionFieldsActions.setGasLimitField({
raw: message.gasLimit.toString(),
value: new BN(message.gasLimit)
})
);
}
}
export const gas = [
fork(shouldEstimateGas),
fork(estimateGas),
takeEvery(transactionFieldsTypes.TransactionFieldsActions.TO_FIELD_SET, setAddressMessageGasLimit)
];
//#endregion Gas
//#region Nonce
export function* handleNonceRequest(): SagaIterator {
const nodeLib: INode = yield select(configNodesSelectors.getNodeLib);
const walletInst: AppState['wallet']['inst'] = yield select(walletSelectors.getWalletInst);
const isOffline: boolean = yield select(configMetaSelectors.getOffline);
try {
if (isOffline || !walletInst) {
return;
}
const fromAddress: string = yield apply(walletInst, walletInst.getAddressString);
const retrievedNonce: string = yield apply(nodeLib, nodeLib.getTransactionCount, [fromAddress]);
const base10Nonce = Nonce(retrievedNonce);
yield put(transactionFieldsActions.inputNonce(base10Nonce.toString()));
yield put(actions.getNonceSucceeded(retrievedNonce));
} catch {
yield put(
notificationsActions.showNotification('warning', 'Your addresses nonce could not be fetched')
);
yield put(actions.getNonceFailed());
}
}
export function* handleNonceRequestWrapper(): SagaIterator {
const nonceRequest = yield fork(handleNonceRequest);
yield take(walletTypes.WalletActions.SET);
yield cancel(nonceRequest);
}
//leave get nonce requested for nonce refresh later on
export const nonceSaga = takeEvery(
[types.TransactionNetworkActions.GET_NONCE_REQUESTED, walletTypes.WalletActions.SET],
handleNonceRequestWrapper
);
//#endregion Nonce
export const networkSaga = [fromSaga, ...gas, nonceSaga];