MyCrypto/spec/sagas/addressBook.spec.ts

314 lines
8.2 KiB
TypeScript
Raw Normal View History

Address Manager (#1657) * Add a new route for AddressBook * Further templating of the AddressBook view * Add initial functionality to handle a table of existing address labels * Make the linter happy * Adjust paths * Factor out TableRow and add common functionality * Add initial Redux boilerplate for addressBook | fix minor linting issues * Swap out terminology and types * Connect up to Redux * Connect data for AddressBookTable to Redux * Use temporary fields for addition * Remove alignment and index column * Stopping point * Adjust the sizing of rows to be consistent * Initial implementation of a dropdown for the address field * Minor styling to dropdown * Stopping point * Apply a focus concept onto the factory * Add keyboard controls for the address field dropdown * Adjust label of address field when it matches an addressBook entry * Properly handle attempting to blur a non-existent component * Minor styling changes on dropdown box * Standardize address casing, add accessibility to dropdown * Create an addressLabel component * Pass refs correctly and fix some typings * Exact version * Add module name mapping for shared/keycodes * addressBook reducer tests * Add functionality to DeterministicModal * Minor changes / Add test for addressBook selectors * Move out AddressBookTable to a component * Typing, translation and restructuring * More typing and translation fixes * More linting fixes * More type changes * Variable name for dropdown background * Fix TS type errors, lint errors, remove unused props * Used a different selector and removed method: AddressBookTable * Linter was mad * Linter mad again :( * Add a translation and adjust styling of AddressBookTable * Move the onBlur to a class method * Prevent the default behavior of up/down/enter for dropdown * Let's do it this way instead * Adjust the styling on DeterministicWalletModal labels * Change `AddressBookTable` into a pseudo-table using section and div * Use readable keys vs. keycodes * Put the dropdown in InputFactory and position it correctly * Sanitation of label adding and changing * Prevent duplicate labels in AddressBook and Row * Add a box shadow and use `invalid` class insted of custom * Use emphasis vs strong for address in dropdown * Display the label undernearth the input vs. changing it * Isolate AccountAddress into its own component * Introduce interactivity to AccountAddress * Fully incorporate with Redux * Validation for AccountAddress * Add validation notifications for address field on AddressBookTable * Minor formatting * Adjust wrappage for optimal flexboxxing * Make AddressBookTable responsive * Show an invalid input in "real time" instead of only on submit * Real time input validation for AddressBookTableRow * Responsive-ize the To address dropdown * Hide identicons instead at small enough screen sizes * Fix repsonsiveness of dropdown further * Fix responsiveness of table rows and inputs * Truncate account info and switch identicons to the right for consistency * Use classnames instead of targetting element directly for DWM * Display a notice if the entered query doesnt match a label and isnt an addr * Don't show an error on the To address if its a label entry * Display an error under AddressBookTableRow in real time * Display errors in real time for AddressBookTable temp inputs * Add realtime validation to AccountAddress * Ensure toChecksumAddress is used when entering labels to address manager * Show errors even after blurring. * Only show errors on address/label entry if they have been blurred * On certain inputs, show an invalid input immediately * Add displayed errors for labels with 0x and labels containing ens * Move ENS checking validation out * Add a saga for addLabelForAddress * Completely revamp the redux side of Address Manager and test it all * Adjust components to use new redux addressBook * Incorporate new redux into AddressBookTableRow and clean up for linter * Make linter and tests happy * Another reduxy overhaul * Still fixing it * More redux updates * Finalize redux stuff. * Incorporate new reduxy way into AddressBookTable & Row * Incorporate redux changes into Account Address * Small tests fix * Add and fix some selector tests * Addressing Will's comments * Shortened visibility class for line length reasons.
2018-05-21 18:10:51 -05:00
import { runSaga } from 'redux-saga';
import { translateRaw } from 'translations';
import { ADDRESS_BOOK_TABLE_ID } from 'components/AddressBookTable';
import {
handleChangeAddressLabelEntry,
handleSaveAddressLabelEntry,
handleRemoveAddressLabelEntry
} from 'sagas/addressBook';
import {
setAddressLabel,
clearAddressLabel,
setAddressLabelEntry,
changeAddressLabelEntry,
saveAddressLabelEntry,
clearAddressLabelEntry,
removeAddressLabelEntry,
AddressLabel
Address Manager (#1657) * Add a new route for AddressBook * Further templating of the AddressBook view * Add initial functionality to handle a table of existing address labels * Make the linter happy * Adjust paths * Factor out TableRow and add common functionality * Add initial Redux boilerplate for addressBook | fix minor linting issues * Swap out terminology and types * Connect up to Redux * Connect data for AddressBookTable to Redux * Use temporary fields for addition * Remove alignment and index column * Stopping point * Adjust the sizing of rows to be consistent * Initial implementation of a dropdown for the address field * Minor styling to dropdown * Stopping point * Apply a focus concept onto the factory * Add keyboard controls for the address field dropdown * Adjust label of address field when it matches an addressBook entry * Properly handle attempting to blur a non-existent component * Minor styling changes on dropdown box * Standardize address casing, add accessibility to dropdown * Create an addressLabel component * Pass refs correctly and fix some typings * Exact version * Add module name mapping for shared/keycodes * addressBook reducer tests * Add functionality to DeterministicModal * Minor changes / Add test for addressBook selectors * Move out AddressBookTable to a component * Typing, translation and restructuring * More typing and translation fixes * More linting fixes * More type changes * Variable name for dropdown background * Fix TS type errors, lint errors, remove unused props * Used a different selector and removed method: AddressBookTable * Linter was mad * Linter mad again :( * Add a translation and adjust styling of AddressBookTable * Move the onBlur to a class method * Prevent the default behavior of up/down/enter for dropdown * Let's do it this way instead * Adjust the styling on DeterministicWalletModal labels * Change `AddressBookTable` into a pseudo-table using section and div * Use readable keys vs. keycodes * Put the dropdown in InputFactory and position it correctly * Sanitation of label adding and changing * Prevent duplicate labels in AddressBook and Row * Add a box shadow and use `invalid` class insted of custom * Use emphasis vs strong for address in dropdown * Display the label undernearth the input vs. changing it * Isolate AccountAddress into its own component * Introduce interactivity to AccountAddress * Fully incorporate with Redux * Validation for AccountAddress * Add validation notifications for address field on AddressBookTable * Minor formatting * Adjust wrappage for optimal flexboxxing * Make AddressBookTable responsive * Show an invalid input in "real time" instead of only on submit * Real time input validation for AddressBookTableRow * Responsive-ize the To address dropdown * Hide identicons instead at small enough screen sizes * Fix repsonsiveness of dropdown further * Fix responsiveness of table rows and inputs * Truncate account info and switch identicons to the right for consistency * Use classnames instead of targetting element directly for DWM * Display a notice if the entered query doesnt match a label and isnt an addr * Don't show an error on the To address if its a label entry * Display an error under AddressBookTableRow in real time * Display errors in real time for AddressBookTable temp inputs * Add realtime validation to AccountAddress * Ensure toChecksumAddress is used when entering labels to address manager * Show errors even after blurring. * Only show errors on address/label entry if they have been blurred * On certain inputs, show an invalid input immediately * Add displayed errors for labels with 0x and labels containing ens * Move ENS checking validation out * Add a saga for addLabelForAddress * Completely revamp the redux side of Address Manager and test it all * Adjust components to use new redux addressBook * Incorporate new redux into AddressBookTableRow and clean up for linter * Make linter and tests happy * Another reduxy overhaul * Still fixing it * More redux updates * Finalize redux stuff. * Incorporate new reduxy way into AddressBookTable & Row * Incorporate redux changes into Account Address * Small tests fix * Add and fix some selector tests * Addressing Will's comments * Shortened visibility class for line length reasons.
2018-05-21 18:10:51 -05:00
} from 'actions/addressBook';
import { getInitialState } from '../selectors/helpers';
describe('addressBook: Sagas', () => {
const initialState = getInitialState();
const getState = () => ({
...initialState,
addressBook: {
...initialState.addressBook,
addresses: {},
labels: {},
entries: {}
}
});
const id = '0';
const address = '0x081f37708032d0a7b3622591a8959b213fb47d6f';
const label = 'Foo';
describe('handleChangeAddressLabelEntry', () => {
it('should successfully change an address label entry with no errors', async () => {
const action = changeAddressLabelEntry({
id,
address,
label
});
const dispatched: string[] = [];
await runSaga(
{
dispatch: (dispatching: string) => dispatched.push(dispatching),
getState
},
handleChangeAddressLabelEntry,
action
);
expect(dispatched).toEqual([
setAddressLabelEntry({
id,
address,
temporaryAddress: address,
addressError: undefined,
label,
temporaryLabel: label,
labelError: undefined
})
]);
});
it('should change a temporary address and error when an error occurs, but not the address', async () => {
const action = changeAddressLabelEntry({
id,
address: '0', // Invalid ETH address
label
});
const dispatched: string[] = [];
await runSaga(
{
dispatch: (dispatching: string) => dispatched.push(dispatching),
getState
},
handleChangeAddressLabelEntry,
action
);
expect(dispatched).toEqual([
setAddressLabelEntry({
id,
address: '',
temporaryAddress: '0',
addressError: translateRaw('INVALID_ADDRESS'),
label,
temporaryLabel: label,
labelError: undefined
})
]);
});
it('should change a temporary label and error when an error occurs, but not the label', async () => {
const action = changeAddressLabelEntry({
id,
address,
label: 'F' // Invalid label length
});
const dispatched: string[] = [];
await runSaga(
{
dispatch: (dispatching: string) => dispatched.push(dispatching),
getState: () => getState()
},
handleChangeAddressLabelEntry,
action
);
expect(dispatched).toEqual([
setAddressLabelEntry({
id,
address,
temporaryAddress: address,
addressError: undefined,
label: '',
temporaryLabel: 'F',
labelError: translateRaw('INVALID_LABEL_LENGTH')
})
]);
});
});
describe('handleSaveAddressLabelEntry', () => {
it('should flash an error without saving when an address or label error exists', async () => {
const state = {
...getState(),
addressBook: {
...getState().addressBook,
entries: {
ADDRESS_BOOK_TABLE_ID: {
id: ADDRESS_BOOK_TABLE_ID,
address: '0',
temporaryAddress: '0',
addressError: translateRaw('INVALID_ADDRESS'),
label,
temporaryLabel: label,
labelError: undefined
}
}
}
};
const action = saveAddressLabelEntry(ADDRESS_BOOK_TABLE_ID);
const dispatched: string[] = [];
await runSaga(
{
dispatch: (dispatching: string) => dispatched.push(dispatching),
getState: () => state
},
handleSaveAddressLabelEntry,
action
);
expect(dispatched.length).toEqual(1);
});
it('should successfully create a new entry and clear the temporary entry', async () => {
const state = {
...getState(),
addressBook: {
...getState().addressBook,
entries: {
ADDRESS_BOOK_TABLE_ID: {
id: ADDRESS_BOOK_TABLE_ID,
address,
temporaryAddress: address,
label,
temporaryLabel: label
}
}
}
};
const action = saveAddressLabelEntry(ADDRESS_BOOK_TABLE_ID);
const dispatched: string[] = [];
await runSaga(
{
dispatch: (dispatching: string) => dispatched.push(dispatching),
getState: () => state
},
handleSaveAddressLabelEntry,
action
);
expect(dispatched).toEqual([
clearAddressLabel(address),
setAddressLabel({
address,
label
}),
setAddressLabelEntry({
id: '1',
address,
temporaryAddress: address,
addressError: undefined,
label,
temporaryLabel: label,
labelError: undefined
}),
setAddressLabelEntry({
id: ADDRESS_BOOK_TABLE_ID,
address: '',
temporaryAddress: '',
addressError: undefined,
label: '',
temporaryLabel: '',
labelError: undefined
})
]);
});
it('should successfully overwrite an existing address label entry with no errors', async () => {
const state = {
...getState(),
addressBook: {
...getState().addressBook,
entries: {
[id]: {
id,
address,
temporaryAddress: address,
label,
temporaryLabel: label
}
}
}
};
const action = saveAddressLabelEntry(id);
const dispatched: string[] = [];
await runSaga(
{
dispatch: (dispatching: string) => dispatched.push(dispatching),
getState: () => state
},
handleSaveAddressLabelEntry,
action
);
expect(dispatched).toEqual([
clearAddressLabel(address),
setAddressLabel({
address,
label
}),
setAddressLabelEntry({
id,
address,
temporaryAddress: address,
addressError: undefined,
label: 'Foo',
temporaryLabel: 'Foo',
labelError: undefined
})
]);
});
});
describe('handleRemoveAddressLabelEntry', () => {
it('should simply return if the requested entry is non-existent', async () => {
const action = removeAddressLabelEntry('Foo');
const dispatched: string[] = [];
await runSaga(
{
dispatch: (dispatching: string) => dispatched.push(dispatching),
getState: () => getState()
},
handleRemoveAddressLabelEntry,
action
);
expect(dispatched.length).toEqual(0);
});
it('should remove the address, the label, and the entry from the book', async () => {
const state = {
...getState(),
addressBook: {
...getState().addressBook,
addresses: {
[address]: label
},
labels: {
label: address
},
entries: {
[id]: {
id,
address,
temporaryAddress: address,
addressError: undefined,
label,
temporaryLabel: label,
labelError: undefined
}
}
}
};
const action = removeAddressLabelEntry(id);
const dispatched: AddressLabel[] = [];
Address Manager (#1657) * Add a new route for AddressBook * Further templating of the AddressBook view * Add initial functionality to handle a table of existing address labels * Make the linter happy * Adjust paths * Factor out TableRow and add common functionality * Add initial Redux boilerplate for addressBook | fix minor linting issues * Swap out terminology and types * Connect up to Redux * Connect data for AddressBookTable to Redux * Use temporary fields for addition * Remove alignment and index column * Stopping point * Adjust the sizing of rows to be consistent * Initial implementation of a dropdown for the address field * Minor styling to dropdown * Stopping point * Apply a focus concept onto the factory * Add keyboard controls for the address field dropdown * Adjust label of address field when it matches an addressBook entry * Properly handle attempting to blur a non-existent component * Minor styling changes on dropdown box * Standardize address casing, add accessibility to dropdown * Create an addressLabel component * Pass refs correctly and fix some typings * Exact version * Add module name mapping for shared/keycodes * addressBook reducer tests * Add functionality to DeterministicModal * Minor changes / Add test for addressBook selectors * Move out AddressBookTable to a component * Typing, translation and restructuring * More typing and translation fixes * More linting fixes * More type changes * Variable name for dropdown background * Fix TS type errors, lint errors, remove unused props * Used a different selector and removed method: AddressBookTable * Linter was mad * Linter mad again :( * Add a translation and adjust styling of AddressBookTable * Move the onBlur to a class method * Prevent the default behavior of up/down/enter for dropdown * Let's do it this way instead * Adjust the styling on DeterministicWalletModal labels * Change `AddressBookTable` into a pseudo-table using section and div * Use readable keys vs. keycodes * Put the dropdown in InputFactory and position it correctly * Sanitation of label adding and changing * Prevent duplicate labels in AddressBook and Row * Add a box shadow and use `invalid` class insted of custom * Use emphasis vs strong for address in dropdown * Display the label undernearth the input vs. changing it * Isolate AccountAddress into its own component * Introduce interactivity to AccountAddress * Fully incorporate with Redux * Validation for AccountAddress * Add validation notifications for address field on AddressBookTable * Minor formatting * Adjust wrappage for optimal flexboxxing * Make AddressBookTable responsive * Show an invalid input in "real time" instead of only on submit * Real time input validation for AddressBookTableRow * Responsive-ize the To address dropdown * Hide identicons instead at small enough screen sizes * Fix repsonsiveness of dropdown further * Fix responsiveness of table rows and inputs * Truncate account info and switch identicons to the right for consistency * Use classnames instead of targetting element directly for DWM * Display a notice if the entered query doesnt match a label and isnt an addr * Don't show an error on the To address if its a label entry * Display an error under AddressBookTableRow in real time * Display errors in real time for AddressBookTable temp inputs * Add realtime validation to AccountAddress * Ensure toChecksumAddress is used when entering labels to address manager * Show errors even after blurring. * Only show errors on address/label entry if they have been blurred * On certain inputs, show an invalid input immediately * Add displayed errors for labels with 0x and labels containing ens * Move ENS checking validation out * Add a saga for addLabelForAddress * Completely revamp the redux side of Address Manager and test it all * Adjust components to use new redux addressBook * Incorporate new redux into AddressBookTableRow and clean up for linter * Make linter and tests happy * Another reduxy overhaul * Still fixing it * More redux updates * Finalize redux stuff. * Incorporate new reduxy way into AddressBookTable & Row * Incorporate redux changes into Account Address * Small tests fix * Add and fix some selector tests * Addressing Will's comments * Shortened visibility class for line length reasons.
2018-05-21 18:10:51 -05:00
await runSaga(
{
dispatch: (dispatching: AddressLabel) => dispatched.push(dispatching),
Address Manager (#1657) * Add a new route for AddressBook * Further templating of the AddressBook view * Add initial functionality to handle a table of existing address labels * Make the linter happy * Adjust paths * Factor out TableRow and add common functionality * Add initial Redux boilerplate for addressBook | fix minor linting issues * Swap out terminology and types * Connect up to Redux * Connect data for AddressBookTable to Redux * Use temporary fields for addition * Remove alignment and index column * Stopping point * Adjust the sizing of rows to be consistent * Initial implementation of a dropdown for the address field * Minor styling to dropdown * Stopping point * Apply a focus concept onto the factory * Add keyboard controls for the address field dropdown * Adjust label of address field when it matches an addressBook entry * Properly handle attempting to blur a non-existent component * Minor styling changes on dropdown box * Standardize address casing, add accessibility to dropdown * Create an addressLabel component * Pass refs correctly and fix some typings * Exact version * Add module name mapping for shared/keycodes * addressBook reducer tests * Add functionality to DeterministicModal * Minor changes / Add test for addressBook selectors * Move out AddressBookTable to a component * Typing, translation and restructuring * More typing and translation fixes * More linting fixes * More type changes * Variable name for dropdown background * Fix TS type errors, lint errors, remove unused props * Used a different selector and removed method: AddressBookTable * Linter was mad * Linter mad again :( * Add a translation and adjust styling of AddressBookTable * Move the onBlur to a class method * Prevent the default behavior of up/down/enter for dropdown * Let's do it this way instead * Adjust the styling on DeterministicWalletModal labels * Change `AddressBookTable` into a pseudo-table using section and div * Use readable keys vs. keycodes * Put the dropdown in InputFactory and position it correctly * Sanitation of label adding and changing * Prevent duplicate labels in AddressBook and Row * Add a box shadow and use `invalid` class insted of custom * Use emphasis vs strong for address in dropdown * Display the label undernearth the input vs. changing it * Isolate AccountAddress into its own component * Introduce interactivity to AccountAddress * Fully incorporate with Redux * Validation for AccountAddress * Add validation notifications for address field on AddressBookTable * Minor formatting * Adjust wrappage for optimal flexboxxing * Make AddressBookTable responsive * Show an invalid input in "real time" instead of only on submit * Real time input validation for AddressBookTableRow * Responsive-ize the To address dropdown * Hide identicons instead at small enough screen sizes * Fix repsonsiveness of dropdown further * Fix responsiveness of table rows and inputs * Truncate account info and switch identicons to the right for consistency * Use classnames instead of targetting element directly for DWM * Display a notice if the entered query doesnt match a label and isnt an addr * Don't show an error on the To address if its a label entry * Display an error under AddressBookTableRow in real time * Display errors in real time for AddressBookTable temp inputs * Add realtime validation to AccountAddress * Ensure toChecksumAddress is used when entering labels to address manager * Show errors even after blurring. * Only show errors on address/label entry if they have been blurred * On certain inputs, show an invalid input immediately * Add displayed errors for labels with 0x and labels containing ens * Move ENS checking validation out * Add a saga for addLabelForAddress * Completely revamp the redux side of Address Manager and test it all * Adjust components to use new redux addressBook * Incorporate new redux into AddressBookTableRow and clean up for linter * Make linter and tests happy * Another reduxy overhaul * Still fixing it * More redux updates * Finalize redux stuff. * Incorporate new reduxy way into AddressBookTable & Row * Incorporate redux changes into Account Address * Small tests fix * Add and fix some selector tests * Addressing Will's comments * Shortened visibility class for line length reasons.
2018-05-21 18:10:51 -05:00
getState: () => state
},
handleRemoveAddressLabelEntry,
action
);
expect(dispatched).toEqual([clearAddressLabel(address), clearAddressLabelEntry(id)]);
});
});
});