2017-11-30 20:16:30 +00:00
|
|
|
import { toChecksumAddress, isValidPrivate } from 'ethereumjs-util';
|
|
|
|
import { stripHexPrefix } from 'libs/values';
|
2017-06-26 23:27:26 +00:00
|
|
|
import WalletAddressValidator from 'wallet-address-validator';
|
2017-06-26 22:27:55 +00:00
|
|
|
import { normalise } from './ens';
|
2017-11-30 05:35:17 +00:00
|
|
|
import { Validator } from 'jsonschema';
|
|
|
|
import { JsonRpcResponse } from './nodes/rpc/types';
|
Productionize Transaction Stack (#456)
* export conditional input and hoc
* Move typings and fields out of send transaction
* Move fields into their own component for decoupled handling, use conditional inputs to simplify disabled components
* Handle hex and non hex strings automatically in BN conversion
* Fix handling of strings and numbers for BN
* add web3 fixes & comments
* Display short balances on deterministic modals
* add more tests, fix rounding
* Add spacer to balance sidebar network name
* Fix tsc error
* Add offline render CB
* Make more render callbacks
* Transform NonceField into its self contained component
* Remove styling from nonce field
* Better network handling in nonce cb
* Move network nonce initialization to componentDidMount
* Remove unessesary conditional input
* Make nonce component return a BN
* Simplify Query render cb
* Add gas query and token query render cbs
* Re-write address field component, strip out ENS name functionality for now
* Add address and data as unit types
* Cleanup Address Field component
* Export gas query
* Re-write gas field component
* Cleanup gas estimation check
* Re-write Data field
* Transaction field skeleton
* Export transaction field actions
* Rename fields to map to ethtx fields
* Make reducers for fields
* Fix reducer module exports
* Export reducer
* Formatting fix
* Type return of GasQuery
* Add transaction field getter / setter component
* Make transaction fields more flexible
* Formatting fix
* Split transaction fields component into two
* Remove erroneous prop
* Fix field naming to follow ethereum transaction fields
* Merge valid prop into componeent
* Change address field to be redux based
* Convert nonce field to redux based
* Make component for passing in current transaction
* Re-write Gas component to use redux state
* Reduxify data field component
* seperate transaction fields redux state into field data and meta data
* Rename SetTransactionFields to be singular
* Make render callback components for getting/setting meta fields
* Add non-zero option prop for token balance render cb
* re-write unit dropdown component to be redux based
* Make ether the first option
* Fix tsc error on tokenquery
* Handle query string default values in unit drop down
* Add thunks to package
* Add helper function for encoding transfer data
* Handle co-dependencies between fields via thunks, seperate value fields into ether and token based
* Fix wrong typing
* Add token metafield as export
* Start scaffolding out amount field component
* Make render cbs for conditional selection of value and balance
* Make render callbacks nullable
* Progress commit -- get dynaming swapping between tokens and ether working
* Get gas estimation working between ether and tokens
* Remove nonce from breaking gas estimation
* Add better validation for amount field
* Add 500ms debounce to gas saga
* Self contain custom message component
* Add web3 awareness to wallet render cb
* Add render cb for checking if wallet is unlocked
* Cleanup inline typing
* export available params
* Add render cb to render component when a query string exists
* Add boolean callback param that check that the transaction is filled by user
* Remove uneeded typings from send transaction
* Fix misnomer
* Self contain generate transaction button
* Compartmentalize more send transaction components
* Add query string warning, custom message and generate tx button to fields
* Cleanup send tx component with new components
* export render callbacks
* saga transaction scaffolding
* make gas saga fully declarative
* transaction lib renaming
* Seperate gasprice into its own generator
* Make action creators for tx sign actions
* Clean up signing saga, introduce reducer for signing, make HW wallet libs compatible with new tx format, fix some typing with ethereumjs-tx
* Add TransactionComparison component
* Add pushTx
* Progress commit -- Streamline web3 and local signing / broadcasting flows. Need to still implement reducers for broadcasting and notifications
* Get local transaction broadcasting working
* re-write confirmation modal to be redux based
* Fix spacing and import
* Move confirmation modal to be attached to send button, create send button
* Properly handle broadcasting for conf modal
* Handle gas cost > balance for send everything
* Add signing status as its own component (#454)
* Fix ledger errors not showing on notifs
* Make dedicated actions for swapping from tokens to ether and ether to tokens
* Split actionTypes file
* Cleanup comments
* Cleanup comments
* Fix various tsc errors
* Lay down infrastructure for saving configurations per-wallet.
* Add pending and rejected states properly to token values.
* Add custom token form improvements.
* Fix metamask transaction errors
* Fix send entire balance estimation
* Fix add token form from never being enabled.
* Initial pass at account tab with send and view wallet tabs.
* Fix inactive tab.
* Hide private key, toggling
* Progress commit -- Replacing render callbacks with selectors, put validation logic in sagas
* Moved the restore keystore functionality to view wallet info, and put it in a modal / util file.
* Fix navigation link active
* Force read only wallets to info tab.
* Remove commented code
* Saga-ify send everything
* Scan for new tokens, track saved tokens, only request tracked tokens on initial load.
* Add custom token to current wallets tracked tokens.
* Rework remove token icon.
* Adjust button margin
* Remove the rest of the needless render callbacks for selectors, sagaify nonce
* Bug fix send transaction
* remove unused redux-thunk
* Move fields to general components
* Clean up saga structure
* Refactor broadcast tx
* Implement better validation logic, get contract deploy working
* PR feedback.
* Convert tokenbalances component to connected redux component.
* Addressed feedback from Henry.
* Progress commit -- Implement Interact logic, needs manual testing
* Get rid of commented code
* move exports after declarations
* add tests, rough draft
* Get contract method calls working
* Bugfix contracts
* Cleanup hex prefixing
* Reset transaction state on wallet change
* Get rid of old send transaction component
* Disable sign transaction button when network request is underway
* Flatten send button tree, make nonce human readable in confirmation modal
* Add ghetto cost breakdown component, fix token field validation
* Create Generic SubTab and use in Send
* MVP of mnemonics with sub-tabs in Create Wallet view.
* Do dynamic revalidation
* move exports after declarations
* add forgotten signing tests
* update token spec
* update currentValue spec
* update validationHelpers spec
* Address TODO - use injected history to push navigation state instead of hardcoding window.location
* Use SubTabs in Contracts
* Fix revertPath prop for AcceptOrRedirectModal
* Use subtabs in SignAndVerifyMessage
* Routing for subtabs
* Fix routes, adjust sizing.
* Remove unused import
* Request nonce in base 10
* Add offline override to unit display
* Make cost breakdown less buggy
* Add non standard transaction warning
* Fix amount validity
* Cleanup datafield validity
* Display notif on gas estimation failure
* Add post-signing verification against fields, clean up gas price
* Fix tsc errors
* Code cleanup
* add exports to functions
* add specs for sendEverything and reset sagas
* delete duplicate files
* make tslint happy
* Merge develop
* Fix develop regressions
* Delegate nonce pulling to wallet being set
* Clarify non standard transaction
* Make address a buffer to avoid leading 0's bug
* Clarify validation helper comment
* Increase debounce time, add console error
* Better validation for non-standard transactions
* Add verification skipping for broadcasting txs
* Fix state and wallet resetting for contract tabs
* Fix some spec files, remove contract.spec
* Remove broadcasting specs from wallet
* Close DeterministicWalletModal on confirm
* Revert "Close DeterministicWalletModal on confirm"
This reverts commit 16c860e854ca29e9de754164d8be5e24f722cbad.
* Reset hardware wallet state on unlocking. Dont render walletdecrypt content when its hidden.
* Fix client side broadcast checking
* Add more state resetters in error scenarios
* Fix gas estimation
* Add validation for value transactions to contract creation
* Add transaction comparaision differentiation depending on wallet type
* Fix token row display balance showing twice
* Properly handle failed transactions
* Handle bad error messages
* fix broken tests
* fix broken test
* Progress commit -- Implement generic subtab types
* Remove react router v3
* Remove unused routes
* Clean up Tabbing code, add onTabChange handler
* Fix tests
* Add nav fix
* revert opinionated sub-tab implementation
* additional reverts
* Add decimal validation
* Make gas price single source of truth, dont save any transaction state other than gas price
* Get rid of old wallet.spec reducer tests
* Add decimal validation when re-validating gasCost
* remove utilities view
* Remove cost breakdown
* Remove local gas estimation warning
* Create getShownTokenBalances selector; use in UnitDropDown and Equivalent Values
* Convert reducers to switch case
* Clean tsc errors
* Fix failing test
* fix tscheck error
* Add number validation to gas field
* Fix misaligned input dropdown
* Revert "Fix misaligned input dropdown"
This reverts commit a40a4c0e8d52471dea01e6727f741a737b798695.
* Set window timeout long enough for node switch to be persisted to state
* Transaction Refactor Style Fixes (#615)
* Fix unit dropdown alignment by rendering it in AmountField, and fixing a missed bootstrap case.
* Fix modal amount and gas text.
* Fix misaligned dropdown
* Update conditions for NavLink is-active class
2017-12-18 21:23:31 +00:00
|
|
|
import { isPositiveInteger } from 'utils/helpers';
|
2018-01-21 18:41:20 +00:00
|
|
|
import {
|
|
|
|
GAS_LIMIT_LOWER_BOUND,
|
|
|
|
GAS_LIMIT_UPPER_BOUND,
|
|
|
|
GAS_PRICE_GWEI_LOWER_BOUND,
|
|
|
|
GAS_PRICE_GWEI_UPPER_BOUND
|
|
|
|
} from 'config/constants';
|
2018-04-16 23:07:00 +00:00
|
|
|
import { dPathRegex, ETC_LEDGER, ETH_SINGULAR } from 'config/dpaths';
|
2018-04-14 22:21:33 +00:00
|
|
|
import { EAC_SCHEDULING_CONFIG } from './scheduling';
|
|
|
|
import BN from 'bn.js';
|
2017-06-26 22:27:55 +00:00
|
|
|
|
Productionize Transaction Stack (#456)
* export conditional input and hoc
* Move typings and fields out of send transaction
* Move fields into their own component for decoupled handling, use conditional inputs to simplify disabled components
* Handle hex and non hex strings automatically in BN conversion
* Fix handling of strings and numbers for BN
* add web3 fixes & comments
* Display short balances on deterministic modals
* add more tests, fix rounding
* Add spacer to balance sidebar network name
* Fix tsc error
* Add offline render CB
* Make more render callbacks
* Transform NonceField into its self contained component
* Remove styling from nonce field
* Better network handling in nonce cb
* Move network nonce initialization to componentDidMount
* Remove unessesary conditional input
* Make nonce component return a BN
* Simplify Query render cb
* Add gas query and token query render cbs
* Re-write address field component, strip out ENS name functionality for now
* Add address and data as unit types
* Cleanup Address Field component
* Export gas query
* Re-write gas field component
* Cleanup gas estimation check
* Re-write Data field
* Transaction field skeleton
* Export transaction field actions
* Rename fields to map to ethtx fields
* Make reducers for fields
* Fix reducer module exports
* Export reducer
* Formatting fix
* Type return of GasQuery
* Add transaction field getter / setter component
* Make transaction fields more flexible
* Formatting fix
* Split transaction fields component into two
* Remove erroneous prop
* Fix field naming to follow ethereum transaction fields
* Merge valid prop into componeent
* Change address field to be redux based
* Convert nonce field to redux based
* Make component for passing in current transaction
* Re-write Gas component to use redux state
* Reduxify data field component
* seperate transaction fields redux state into field data and meta data
* Rename SetTransactionFields to be singular
* Make render callback components for getting/setting meta fields
* Add non-zero option prop for token balance render cb
* re-write unit dropdown component to be redux based
* Make ether the first option
* Fix tsc error on tokenquery
* Handle query string default values in unit drop down
* Add thunks to package
* Add helper function for encoding transfer data
* Handle co-dependencies between fields via thunks, seperate value fields into ether and token based
* Fix wrong typing
* Add token metafield as export
* Start scaffolding out amount field component
* Make render cbs for conditional selection of value and balance
* Make render callbacks nullable
* Progress commit -- get dynaming swapping between tokens and ether working
* Get gas estimation working between ether and tokens
* Remove nonce from breaking gas estimation
* Add better validation for amount field
* Add 500ms debounce to gas saga
* Self contain custom message component
* Add web3 awareness to wallet render cb
* Add render cb for checking if wallet is unlocked
* Cleanup inline typing
* export available params
* Add render cb to render component when a query string exists
* Add boolean callback param that check that the transaction is filled by user
* Remove uneeded typings from send transaction
* Fix misnomer
* Self contain generate transaction button
* Compartmentalize more send transaction components
* Add query string warning, custom message and generate tx button to fields
* Cleanup send tx component with new components
* export render callbacks
* saga transaction scaffolding
* make gas saga fully declarative
* transaction lib renaming
* Seperate gasprice into its own generator
* Make action creators for tx sign actions
* Clean up signing saga, introduce reducer for signing, make HW wallet libs compatible with new tx format, fix some typing with ethereumjs-tx
* Add TransactionComparison component
* Add pushTx
* Progress commit -- Streamline web3 and local signing / broadcasting flows. Need to still implement reducers for broadcasting and notifications
* Get local transaction broadcasting working
* re-write confirmation modal to be redux based
* Fix spacing and import
* Move confirmation modal to be attached to send button, create send button
* Properly handle broadcasting for conf modal
* Handle gas cost > balance for send everything
* Add signing status as its own component (#454)
* Fix ledger errors not showing on notifs
* Make dedicated actions for swapping from tokens to ether and ether to tokens
* Split actionTypes file
* Cleanup comments
* Cleanup comments
* Fix various tsc errors
* Lay down infrastructure for saving configurations per-wallet.
* Add pending and rejected states properly to token values.
* Add custom token form improvements.
* Fix metamask transaction errors
* Fix send entire balance estimation
* Fix add token form from never being enabled.
* Initial pass at account tab with send and view wallet tabs.
* Fix inactive tab.
* Hide private key, toggling
* Progress commit -- Replacing render callbacks with selectors, put validation logic in sagas
* Moved the restore keystore functionality to view wallet info, and put it in a modal / util file.
* Fix navigation link active
* Force read only wallets to info tab.
* Remove commented code
* Saga-ify send everything
* Scan for new tokens, track saved tokens, only request tracked tokens on initial load.
* Add custom token to current wallets tracked tokens.
* Rework remove token icon.
* Adjust button margin
* Remove the rest of the needless render callbacks for selectors, sagaify nonce
* Bug fix send transaction
* remove unused redux-thunk
* Move fields to general components
* Clean up saga structure
* Refactor broadcast tx
* Implement better validation logic, get contract deploy working
* PR feedback.
* Convert tokenbalances component to connected redux component.
* Addressed feedback from Henry.
* Progress commit -- Implement Interact logic, needs manual testing
* Get rid of commented code
* move exports after declarations
* add tests, rough draft
* Get contract method calls working
* Bugfix contracts
* Cleanup hex prefixing
* Reset transaction state on wallet change
* Get rid of old send transaction component
* Disable sign transaction button when network request is underway
* Flatten send button tree, make nonce human readable in confirmation modal
* Add ghetto cost breakdown component, fix token field validation
* Create Generic SubTab and use in Send
* MVP of mnemonics with sub-tabs in Create Wallet view.
* Do dynamic revalidation
* move exports after declarations
* add forgotten signing tests
* update token spec
* update currentValue spec
* update validationHelpers spec
* Address TODO - use injected history to push navigation state instead of hardcoding window.location
* Use SubTabs in Contracts
* Fix revertPath prop for AcceptOrRedirectModal
* Use subtabs in SignAndVerifyMessage
* Routing for subtabs
* Fix routes, adjust sizing.
* Remove unused import
* Request nonce in base 10
* Add offline override to unit display
* Make cost breakdown less buggy
* Add non standard transaction warning
* Fix amount validity
* Cleanup datafield validity
* Display notif on gas estimation failure
* Add post-signing verification against fields, clean up gas price
* Fix tsc errors
* Code cleanup
* add exports to functions
* add specs for sendEverything and reset sagas
* delete duplicate files
* make tslint happy
* Merge develop
* Fix develop regressions
* Delegate nonce pulling to wallet being set
* Clarify non standard transaction
* Make address a buffer to avoid leading 0's bug
* Clarify validation helper comment
* Increase debounce time, add console error
* Better validation for non-standard transactions
* Add verification skipping for broadcasting txs
* Fix state and wallet resetting for contract tabs
* Fix some spec files, remove contract.spec
* Remove broadcasting specs from wallet
* Close DeterministicWalletModal on confirm
* Revert "Close DeterministicWalletModal on confirm"
This reverts commit 16c860e854ca29e9de754164d8be5e24f722cbad.
* Reset hardware wallet state on unlocking. Dont render walletdecrypt content when its hidden.
* Fix client side broadcast checking
* Add more state resetters in error scenarios
* Fix gas estimation
* Add validation for value transactions to contract creation
* Add transaction comparaision differentiation depending on wallet type
* Fix token row display balance showing twice
* Properly handle failed transactions
* Handle bad error messages
* fix broken tests
* fix broken test
* Progress commit -- Implement generic subtab types
* Remove react router v3
* Remove unused routes
* Clean up Tabbing code, add onTabChange handler
* Fix tests
* Add nav fix
* revert opinionated sub-tab implementation
* additional reverts
* Add decimal validation
* Make gas price single source of truth, dont save any transaction state other than gas price
* Get rid of old wallet.spec reducer tests
* Add decimal validation when re-validating gasCost
* remove utilities view
* Remove cost breakdown
* Remove local gas estimation warning
* Create getShownTokenBalances selector; use in UnitDropDown and Equivalent Values
* Convert reducers to switch case
* Clean tsc errors
* Fix failing test
* fix tscheck error
* Add number validation to gas field
* Fix misaligned input dropdown
* Revert "Fix misaligned input dropdown"
This reverts commit a40a4c0e8d52471dea01e6727f741a737b798695.
* Set window timeout long enough for node switch to be persisted to state
* Transaction Refactor Style Fixes (#615)
* Fix unit dropdown alignment by rendering it in AmountField, and fixing a missed bootstrap case.
* Fix modal amount and gas text.
* Fix misaligned dropdown
* Update conditions for NavLink is-active class
2017-12-18 21:23:31 +00:00
|
|
|
// FIXME we probably want to do checksum checks sideways
|
2017-06-26 23:27:26 +00:00
|
|
|
export function isValidETHAddress(address: string): boolean {
|
Productionize Transaction Stack (#456)
* export conditional input and hoc
* Move typings and fields out of send transaction
* Move fields into their own component for decoupled handling, use conditional inputs to simplify disabled components
* Handle hex and non hex strings automatically in BN conversion
* Fix handling of strings and numbers for BN
* add web3 fixes & comments
* Display short balances on deterministic modals
* add more tests, fix rounding
* Add spacer to balance sidebar network name
* Fix tsc error
* Add offline render CB
* Make more render callbacks
* Transform NonceField into its self contained component
* Remove styling from nonce field
* Better network handling in nonce cb
* Move network nonce initialization to componentDidMount
* Remove unessesary conditional input
* Make nonce component return a BN
* Simplify Query render cb
* Add gas query and token query render cbs
* Re-write address field component, strip out ENS name functionality for now
* Add address and data as unit types
* Cleanup Address Field component
* Export gas query
* Re-write gas field component
* Cleanup gas estimation check
* Re-write Data field
* Transaction field skeleton
* Export transaction field actions
* Rename fields to map to ethtx fields
* Make reducers for fields
* Fix reducer module exports
* Export reducer
* Formatting fix
* Type return of GasQuery
* Add transaction field getter / setter component
* Make transaction fields more flexible
* Formatting fix
* Split transaction fields component into two
* Remove erroneous prop
* Fix field naming to follow ethereum transaction fields
* Merge valid prop into componeent
* Change address field to be redux based
* Convert nonce field to redux based
* Make component for passing in current transaction
* Re-write Gas component to use redux state
* Reduxify data field component
* seperate transaction fields redux state into field data and meta data
* Rename SetTransactionFields to be singular
* Make render callback components for getting/setting meta fields
* Add non-zero option prop for token balance render cb
* re-write unit dropdown component to be redux based
* Make ether the first option
* Fix tsc error on tokenquery
* Handle query string default values in unit drop down
* Add thunks to package
* Add helper function for encoding transfer data
* Handle co-dependencies between fields via thunks, seperate value fields into ether and token based
* Fix wrong typing
* Add token metafield as export
* Start scaffolding out amount field component
* Make render cbs for conditional selection of value and balance
* Make render callbacks nullable
* Progress commit -- get dynaming swapping between tokens and ether working
* Get gas estimation working between ether and tokens
* Remove nonce from breaking gas estimation
* Add better validation for amount field
* Add 500ms debounce to gas saga
* Self contain custom message component
* Add web3 awareness to wallet render cb
* Add render cb for checking if wallet is unlocked
* Cleanup inline typing
* export available params
* Add render cb to render component when a query string exists
* Add boolean callback param that check that the transaction is filled by user
* Remove uneeded typings from send transaction
* Fix misnomer
* Self contain generate transaction button
* Compartmentalize more send transaction components
* Add query string warning, custom message and generate tx button to fields
* Cleanup send tx component with new components
* export render callbacks
* saga transaction scaffolding
* make gas saga fully declarative
* transaction lib renaming
* Seperate gasprice into its own generator
* Make action creators for tx sign actions
* Clean up signing saga, introduce reducer for signing, make HW wallet libs compatible with new tx format, fix some typing with ethereumjs-tx
* Add TransactionComparison component
* Add pushTx
* Progress commit -- Streamline web3 and local signing / broadcasting flows. Need to still implement reducers for broadcasting and notifications
* Get local transaction broadcasting working
* re-write confirmation modal to be redux based
* Fix spacing and import
* Move confirmation modal to be attached to send button, create send button
* Properly handle broadcasting for conf modal
* Handle gas cost > balance for send everything
* Add signing status as its own component (#454)
* Fix ledger errors not showing on notifs
* Make dedicated actions for swapping from tokens to ether and ether to tokens
* Split actionTypes file
* Cleanup comments
* Cleanup comments
* Fix various tsc errors
* Lay down infrastructure for saving configurations per-wallet.
* Add pending and rejected states properly to token values.
* Add custom token form improvements.
* Fix metamask transaction errors
* Fix send entire balance estimation
* Fix add token form from never being enabled.
* Initial pass at account tab with send and view wallet tabs.
* Fix inactive tab.
* Hide private key, toggling
* Progress commit -- Replacing render callbacks with selectors, put validation logic in sagas
* Moved the restore keystore functionality to view wallet info, and put it in a modal / util file.
* Fix navigation link active
* Force read only wallets to info tab.
* Remove commented code
* Saga-ify send everything
* Scan for new tokens, track saved tokens, only request tracked tokens on initial load.
* Add custom token to current wallets tracked tokens.
* Rework remove token icon.
* Adjust button margin
* Remove the rest of the needless render callbacks for selectors, sagaify nonce
* Bug fix send transaction
* remove unused redux-thunk
* Move fields to general components
* Clean up saga structure
* Refactor broadcast tx
* Implement better validation logic, get contract deploy working
* PR feedback.
* Convert tokenbalances component to connected redux component.
* Addressed feedback from Henry.
* Progress commit -- Implement Interact logic, needs manual testing
* Get rid of commented code
* move exports after declarations
* add tests, rough draft
* Get contract method calls working
* Bugfix contracts
* Cleanup hex prefixing
* Reset transaction state on wallet change
* Get rid of old send transaction component
* Disable sign transaction button when network request is underway
* Flatten send button tree, make nonce human readable in confirmation modal
* Add ghetto cost breakdown component, fix token field validation
* Create Generic SubTab and use in Send
* MVP of mnemonics with sub-tabs in Create Wallet view.
* Do dynamic revalidation
* move exports after declarations
* add forgotten signing tests
* update token spec
* update currentValue spec
* update validationHelpers spec
* Address TODO - use injected history to push navigation state instead of hardcoding window.location
* Use SubTabs in Contracts
* Fix revertPath prop for AcceptOrRedirectModal
* Use subtabs in SignAndVerifyMessage
* Routing for subtabs
* Fix routes, adjust sizing.
* Remove unused import
* Request nonce in base 10
* Add offline override to unit display
* Make cost breakdown less buggy
* Add non standard transaction warning
* Fix amount validity
* Cleanup datafield validity
* Display notif on gas estimation failure
* Add post-signing verification against fields, clean up gas price
* Fix tsc errors
* Code cleanup
* add exports to functions
* add specs for sendEverything and reset sagas
* delete duplicate files
* make tslint happy
* Merge develop
* Fix develop regressions
* Delegate nonce pulling to wallet being set
* Clarify non standard transaction
* Make address a buffer to avoid leading 0's bug
* Clarify validation helper comment
* Increase debounce time, add console error
* Better validation for non-standard transactions
* Add verification skipping for broadcasting txs
* Fix state and wallet resetting for contract tabs
* Fix some spec files, remove contract.spec
* Remove broadcasting specs from wallet
* Close DeterministicWalletModal on confirm
* Revert "Close DeterministicWalletModal on confirm"
This reverts commit 16c860e854ca29e9de754164d8be5e24f722cbad.
* Reset hardware wallet state on unlocking. Dont render walletdecrypt content when its hidden.
* Fix client side broadcast checking
* Add more state resetters in error scenarios
* Fix gas estimation
* Add validation for value transactions to contract creation
* Add transaction comparaision differentiation depending on wallet type
* Fix token row display balance showing twice
* Properly handle failed transactions
* Handle bad error messages
* fix broken tests
* fix broken test
* Progress commit -- Implement generic subtab types
* Remove react router v3
* Remove unused routes
* Clean up Tabbing code, add onTabChange handler
* Fix tests
* Add nav fix
* revert opinionated sub-tab implementation
* additional reverts
* Add decimal validation
* Make gas price single source of truth, dont save any transaction state other than gas price
* Get rid of old wallet.spec reducer tests
* Add decimal validation when re-validating gasCost
* remove utilities view
* Remove cost breakdown
* Remove local gas estimation warning
* Create getShownTokenBalances selector; use in UnitDropDown and Equivalent Values
* Convert reducers to switch case
* Clean tsc errors
* Fix failing test
* fix tscheck error
* Add number validation to gas field
* Fix misaligned input dropdown
* Revert "Fix misaligned input dropdown"
This reverts commit a40a4c0e8d52471dea01e6727f741a737b798695.
* Set window timeout long enough for node switch to be persisted to state
* Transaction Refactor Style Fixes (#615)
* Fix unit dropdown alignment by rendering it in AmountField, and fixing a missed bootstrap case.
* Fix modal amount and gas text.
* Fix misaligned dropdown
* Update conditions for NavLink is-active class
2017-12-18 21:23:31 +00:00
|
|
|
if (address === '0x0000000000000000000000000000000000000000') {
|
2017-07-02 05:49:06 +00:00
|
|
|
return false;
|
|
|
|
}
|
Productionize Transaction Stack (#456)
* export conditional input and hoc
* Move typings and fields out of send transaction
* Move fields into their own component for decoupled handling, use conditional inputs to simplify disabled components
* Handle hex and non hex strings automatically in BN conversion
* Fix handling of strings and numbers for BN
* add web3 fixes & comments
* Display short balances on deterministic modals
* add more tests, fix rounding
* Add spacer to balance sidebar network name
* Fix tsc error
* Add offline render CB
* Make more render callbacks
* Transform NonceField into its self contained component
* Remove styling from nonce field
* Better network handling in nonce cb
* Move network nonce initialization to componentDidMount
* Remove unessesary conditional input
* Make nonce component return a BN
* Simplify Query render cb
* Add gas query and token query render cbs
* Re-write address field component, strip out ENS name functionality for now
* Add address and data as unit types
* Cleanup Address Field component
* Export gas query
* Re-write gas field component
* Cleanup gas estimation check
* Re-write Data field
* Transaction field skeleton
* Export transaction field actions
* Rename fields to map to ethtx fields
* Make reducers for fields
* Fix reducer module exports
* Export reducer
* Formatting fix
* Type return of GasQuery
* Add transaction field getter / setter component
* Make transaction fields more flexible
* Formatting fix
* Split transaction fields component into two
* Remove erroneous prop
* Fix field naming to follow ethereum transaction fields
* Merge valid prop into componeent
* Change address field to be redux based
* Convert nonce field to redux based
* Make component for passing in current transaction
* Re-write Gas component to use redux state
* Reduxify data field component
* seperate transaction fields redux state into field data and meta data
* Rename SetTransactionFields to be singular
* Make render callback components for getting/setting meta fields
* Add non-zero option prop for token balance render cb
* re-write unit dropdown component to be redux based
* Make ether the first option
* Fix tsc error on tokenquery
* Handle query string default values in unit drop down
* Add thunks to package
* Add helper function for encoding transfer data
* Handle co-dependencies between fields via thunks, seperate value fields into ether and token based
* Fix wrong typing
* Add token metafield as export
* Start scaffolding out amount field component
* Make render cbs for conditional selection of value and balance
* Make render callbacks nullable
* Progress commit -- get dynaming swapping between tokens and ether working
* Get gas estimation working between ether and tokens
* Remove nonce from breaking gas estimation
* Add better validation for amount field
* Add 500ms debounce to gas saga
* Self contain custom message component
* Add web3 awareness to wallet render cb
* Add render cb for checking if wallet is unlocked
* Cleanup inline typing
* export available params
* Add render cb to render component when a query string exists
* Add boolean callback param that check that the transaction is filled by user
* Remove uneeded typings from send transaction
* Fix misnomer
* Self contain generate transaction button
* Compartmentalize more send transaction components
* Add query string warning, custom message and generate tx button to fields
* Cleanup send tx component with new components
* export render callbacks
* saga transaction scaffolding
* make gas saga fully declarative
* transaction lib renaming
* Seperate gasprice into its own generator
* Make action creators for tx sign actions
* Clean up signing saga, introduce reducer for signing, make HW wallet libs compatible with new tx format, fix some typing with ethereumjs-tx
* Add TransactionComparison component
* Add pushTx
* Progress commit -- Streamline web3 and local signing / broadcasting flows. Need to still implement reducers for broadcasting and notifications
* Get local transaction broadcasting working
* re-write confirmation modal to be redux based
* Fix spacing and import
* Move confirmation modal to be attached to send button, create send button
* Properly handle broadcasting for conf modal
* Handle gas cost > balance for send everything
* Add signing status as its own component (#454)
* Fix ledger errors not showing on notifs
* Make dedicated actions for swapping from tokens to ether and ether to tokens
* Split actionTypes file
* Cleanup comments
* Cleanup comments
* Fix various tsc errors
* Lay down infrastructure for saving configurations per-wallet.
* Add pending and rejected states properly to token values.
* Add custom token form improvements.
* Fix metamask transaction errors
* Fix send entire balance estimation
* Fix add token form from never being enabled.
* Initial pass at account tab with send and view wallet tabs.
* Fix inactive tab.
* Hide private key, toggling
* Progress commit -- Replacing render callbacks with selectors, put validation logic in sagas
* Moved the restore keystore functionality to view wallet info, and put it in a modal / util file.
* Fix navigation link active
* Force read only wallets to info tab.
* Remove commented code
* Saga-ify send everything
* Scan for new tokens, track saved tokens, only request tracked tokens on initial load.
* Add custom token to current wallets tracked tokens.
* Rework remove token icon.
* Adjust button margin
* Remove the rest of the needless render callbacks for selectors, sagaify nonce
* Bug fix send transaction
* remove unused redux-thunk
* Move fields to general components
* Clean up saga structure
* Refactor broadcast tx
* Implement better validation logic, get contract deploy working
* PR feedback.
* Convert tokenbalances component to connected redux component.
* Addressed feedback from Henry.
* Progress commit -- Implement Interact logic, needs manual testing
* Get rid of commented code
* move exports after declarations
* add tests, rough draft
* Get contract method calls working
* Bugfix contracts
* Cleanup hex prefixing
* Reset transaction state on wallet change
* Get rid of old send transaction component
* Disable sign transaction button when network request is underway
* Flatten send button tree, make nonce human readable in confirmation modal
* Add ghetto cost breakdown component, fix token field validation
* Create Generic SubTab and use in Send
* MVP of mnemonics with sub-tabs in Create Wallet view.
* Do dynamic revalidation
* move exports after declarations
* add forgotten signing tests
* update token spec
* update currentValue spec
* update validationHelpers spec
* Address TODO - use injected history to push navigation state instead of hardcoding window.location
* Use SubTabs in Contracts
* Fix revertPath prop for AcceptOrRedirectModal
* Use subtabs in SignAndVerifyMessage
* Routing for subtabs
* Fix routes, adjust sizing.
* Remove unused import
* Request nonce in base 10
* Add offline override to unit display
* Make cost breakdown less buggy
* Add non standard transaction warning
* Fix amount validity
* Cleanup datafield validity
* Display notif on gas estimation failure
* Add post-signing verification against fields, clean up gas price
* Fix tsc errors
* Code cleanup
* add exports to functions
* add specs for sendEverything and reset sagas
* delete duplicate files
* make tslint happy
* Merge develop
* Fix develop regressions
* Delegate nonce pulling to wallet being set
* Clarify non standard transaction
* Make address a buffer to avoid leading 0's bug
* Clarify validation helper comment
* Increase debounce time, add console error
* Better validation for non-standard transactions
* Add verification skipping for broadcasting txs
* Fix state and wallet resetting for contract tabs
* Fix some spec files, remove contract.spec
* Remove broadcasting specs from wallet
* Close DeterministicWalletModal on confirm
* Revert "Close DeterministicWalletModal on confirm"
This reverts commit 16c860e854ca29e9de754164d8be5e24f722cbad.
* Reset hardware wallet state on unlocking. Dont render walletdecrypt content when its hidden.
* Fix client side broadcast checking
* Add more state resetters in error scenarios
* Fix gas estimation
* Add validation for value transactions to contract creation
* Add transaction comparaision differentiation depending on wallet type
* Fix token row display balance showing twice
* Properly handle failed transactions
* Handle bad error messages
* fix broken tests
* fix broken test
* Progress commit -- Implement generic subtab types
* Remove react router v3
* Remove unused routes
* Clean up Tabbing code, add onTabChange handler
* Fix tests
* Add nav fix
* revert opinionated sub-tab implementation
* additional reverts
* Add decimal validation
* Make gas price single source of truth, dont save any transaction state other than gas price
* Get rid of old wallet.spec reducer tests
* Add decimal validation when re-validating gasCost
* remove utilities view
* Remove cost breakdown
* Remove local gas estimation warning
* Create getShownTokenBalances selector; use in UnitDropDown and Equivalent Values
* Convert reducers to switch case
* Clean tsc errors
* Fix failing test
* fix tscheck error
* Add number validation to gas field
* Fix misaligned input dropdown
* Revert "Fix misaligned input dropdown"
This reverts commit a40a4c0e8d52471dea01e6727f741a737b798695.
* Set window timeout long enough for node switch to be persisted to state
* Transaction Refactor Style Fixes (#615)
* Fix unit dropdown alignment by rendering it in AmountField, and fixing a missed bootstrap case.
* Fix modal amount and gas text.
* Fix misaligned dropdown
* Update conditions for NavLink is-active class
2017-12-18 21:23:31 +00:00
|
|
|
if (address.substring(0, 2) !== '0x') {
|
|
|
|
return false;
|
|
|
|
} else if (!/^(0x)?[0-9a-f]{40}$/i.test(address)) {
|
2017-09-25 02:06:28 +00:00
|
|
|
return false;
|
Productionize Transaction Stack (#456)
* export conditional input and hoc
* Move typings and fields out of send transaction
* Move fields into their own component for decoupled handling, use conditional inputs to simplify disabled components
* Handle hex and non hex strings automatically in BN conversion
* Fix handling of strings and numbers for BN
* add web3 fixes & comments
* Display short balances on deterministic modals
* add more tests, fix rounding
* Add spacer to balance sidebar network name
* Fix tsc error
* Add offline render CB
* Make more render callbacks
* Transform NonceField into its self contained component
* Remove styling from nonce field
* Better network handling in nonce cb
* Move network nonce initialization to componentDidMount
* Remove unessesary conditional input
* Make nonce component return a BN
* Simplify Query render cb
* Add gas query and token query render cbs
* Re-write address field component, strip out ENS name functionality for now
* Add address and data as unit types
* Cleanup Address Field component
* Export gas query
* Re-write gas field component
* Cleanup gas estimation check
* Re-write Data field
* Transaction field skeleton
* Export transaction field actions
* Rename fields to map to ethtx fields
* Make reducers for fields
* Fix reducer module exports
* Export reducer
* Formatting fix
* Type return of GasQuery
* Add transaction field getter / setter component
* Make transaction fields more flexible
* Formatting fix
* Split transaction fields component into two
* Remove erroneous prop
* Fix field naming to follow ethereum transaction fields
* Merge valid prop into componeent
* Change address field to be redux based
* Convert nonce field to redux based
* Make component for passing in current transaction
* Re-write Gas component to use redux state
* Reduxify data field component
* seperate transaction fields redux state into field data and meta data
* Rename SetTransactionFields to be singular
* Make render callback components for getting/setting meta fields
* Add non-zero option prop for token balance render cb
* re-write unit dropdown component to be redux based
* Make ether the first option
* Fix tsc error on tokenquery
* Handle query string default values in unit drop down
* Add thunks to package
* Add helper function for encoding transfer data
* Handle co-dependencies between fields via thunks, seperate value fields into ether and token based
* Fix wrong typing
* Add token metafield as export
* Start scaffolding out amount field component
* Make render cbs for conditional selection of value and balance
* Make render callbacks nullable
* Progress commit -- get dynaming swapping between tokens and ether working
* Get gas estimation working between ether and tokens
* Remove nonce from breaking gas estimation
* Add better validation for amount field
* Add 500ms debounce to gas saga
* Self contain custom message component
* Add web3 awareness to wallet render cb
* Add render cb for checking if wallet is unlocked
* Cleanup inline typing
* export available params
* Add render cb to render component when a query string exists
* Add boolean callback param that check that the transaction is filled by user
* Remove uneeded typings from send transaction
* Fix misnomer
* Self contain generate transaction button
* Compartmentalize more send transaction components
* Add query string warning, custom message and generate tx button to fields
* Cleanup send tx component with new components
* export render callbacks
* saga transaction scaffolding
* make gas saga fully declarative
* transaction lib renaming
* Seperate gasprice into its own generator
* Make action creators for tx sign actions
* Clean up signing saga, introduce reducer for signing, make HW wallet libs compatible with new tx format, fix some typing with ethereumjs-tx
* Add TransactionComparison component
* Add pushTx
* Progress commit -- Streamline web3 and local signing / broadcasting flows. Need to still implement reducers for broadcasting and notifications
* Get local transaction broadcasting working
* re-write confirmation modal to be redux based
* Fix spacing and import
* Move confirmation modal to be attached to send button, create send button
* Properly handle broadcasting for conf modal
* Handle gas cost > balance for send everything
* Add signing status as its own component (#454)
* Fix ledger errors not showing on notifs
* Make dedicated actions for swapping from tokens to ether and ether to tokens
* Split actionTypes file
* Cleanup comments
* Cleanup comments
* Fix various tsc errors
* Lay down infrastructure for saving configurations per-wallet.
* Add pending and rejected states properly to token values.
* Add custom token form improvements.
* Fix metamask transaction errors
* Fix send entire balance estimation
* Fix add token form from never being enabled.
* Initial pass at account tab with send and view wallet tabs.
* Fix inactive tab.
* Hide private key, toggling
* Progress commit -- Replacing render callbacks with selectors, put validation logic in sagas
* Moved the restore keystore functionality to view wallet info, and put it in a modal / util file.
* Fix navigation link active
* Force read only wallets to info tab.
* Remove commented code
* Saga-ify send everything
* Scan for new tokens, track saved tokens, only request tracked tokens on initial load.
* Add custom token to current wallets tracked tokens.
* Rework remove token icon.
* Adjust button margin
* Remove the rest of the needless render callbacks for selectors, sagaify nonce
* Bug fix send transaction
* remove unused redux-thunk
* Move fields to general components
* Clean up saga structure
* Refactor broadcast tx
* Implement better validation logic, get contract deploy working
* PR feedback.
* Convert tokenbalances component to connected redux component.
* Addressed feedback from Henry.
* Progress commit -- Implement Interact logic, needs manual testing
* Get rid of commented code
* move exports after declarations
* add tests, rough draft
* Get contract method calls working
* Bugfix contracts
* Cleanup hex prefixing
* Reset transaction state on wallet change
* Get rid of old send transaction component
* Disable sign transaction button when network request is underway
* Flatten send button tree, make nonce human readable in confirmation modal
* Add ghetto cost breakdown component, fix token field validation
* Create Generic SubTab and use in Send
* MVP of mnemonics with sub-tabs in Create Wallet view.
* Do dynamic revalidation
* move exports after declarations
* add forgotten signing tests
* update token spec
* update currentValue spec
* update validationHelpers spec
* Address TODO - use injected history to push navigation state instead of hardcoding window.location
* Use SubTabs in Contracts
* Fix revertPath prop for AcceptOrRedirectModal
* Use subtabs in SignAndVerifyMessage
* Routing for subtabs
* Fix routes, adjust sizing.
* Remove unused import
* Request nonce in base 10
* Add offline override to unit display
* Make cost breakdown less buggy
* Add non standard transaction warning
* Fix amount validity
* Cleanup datafield validity
* Display notif on gas estimation failure
* Add post-signing verification against fields, clean up gas price
* Fix tsc errors
* Code cleanup
* add exports to functions
* add specs for sendEverything and reset sagas
* delete duplicate files
* make tslint happy
* Merge develop
* Fix develop regressions
* Delegate nonce pulling to wallet being set
* Clarify non standard transaction
* Make address a buffer to avoid leading 0's bug
* Clarify validation helper comment
* Increase debounce time, add console error
* Better validation for non-standard transactions
* Add verification skipping for broadcasting txs
* Fix state and wallet resetting for contract tabs
* Fix some spec files, remove contract.spec
* Remove broadcasting specs from wallet
* Close DeterministicWalletModal on confirm
* Revert "Close DeterministicWalletModal on confirm"
This reverts commit 16c860e854ca29e9de754164d8be5e24f722cbad.
* Reset hardware wallet state on unlocking. Dont render walletdecrypt content when its hidden.
* Fix client side broadcast checking
* Add more state resetters in error scenarios
* Fix gas estimation
* Add validation for value transactions to contract creation
* Add transaction comparaision differentiation depending on wallet type
* Fix token row display balance showing twice
* Properly handle failed transactions
* Handle bad error messages
* fix broken tests
* fix broken test
* Progress commit -- Implement generic subtab types
* Remove react router v3
* Remove unused routes
* Clean up Tabbing code, add onTabChange handler
* Fix tests
* Add nav fix
* revert opinionated sub-tab implementation
* additional reverts
* Add decimal validation
* Make gas price single source of truth, dont save any transaction state other than gas price
* Get rid of old wallet.spec reducer tests
* Add decimal validation when re-validating gasCost
* remove utilities view
* Remove cost breakdown
* Remove local gas estimation warning
* Create getShownTokenBalances selector; use in UnitDropDown and Equivalent Values
* Convert reducers to switch case
* Clean tsc errors
* Fix failing test
* fix tscheck error
* Add number validation to gas field
* Fix misaligned input dropdown
* Revert "Fix misaligned input dropdown"
This reverts commit a40a4c0e8d52471dea01e6727f741a737b798695.
* Set window timeout long enough for node switch to be persisted to state
* Transaction Refactor Style Fixes (#615)
* Fix unit dropdown alignment by rendering it in AmountField, and fixing a missed bootstrap case.
* Fix modal amount and gas text.
* Fix misaligned dropdown
* Update conditions for NavLink is-active class
2017-12-18 21:23:31 +00:00
|
|
|
} else if (/^(0x)?[0-9a-f]{40}$/.test(address) || /^(0x)?[0-9A-F]{40}$/.test(address)) {
|
|
|
|
return true;
|
|
|
|
} else {
|
|
|
|
return isChecksumAddress(address);
|
2017-09-25 02:06:28 +00:00
|
|
|
}
|
2017-06-26 23:27:26 +00:00
|
|
|
}
|
|
|
|
|
2018-01-15 09:57:09 +00:00
|
|
|
export const isCreationAddress = (address: string): boolean =>
|
|
|
|
address === '0x0' || address === '0x0000000000000000000000000000000000000000';
|
|
|
|
|
2017-06-26 23:27:26 +00:00
|
|
|
export function isValidBTCAddress(address: string): boolean {
|
2017-07-02 05:49:06 +00:00
|
|
|
return WalletAddressValidator.validate(address, 'BTC');
|
2017-06-26 23:27:26 +00:00
|
|
|
}
|
|
|
|
|
2017-06-26 22:27:55 +00:00
|
|
|
export function isValidHex(str: string): boolean {
|
2017-09-25 02:06:28 +00:00
|
|
|
if (str === '') {
|
|
|
|
return true;
|
|
|
|
}
|
Productionize Transaction Stack (#456)
* export conditional input and hoc
* Move typings and fields out of send transaction
* Move fields into their own component for decoupled handling, use conditional inputs to simplify disabled components
* Handle hex and non hex strings automatically in BN conversion
* Fix handling of strings and numbers for BN
* add web3 fixes & comments
* Display short balances on deterministic modals
* add more tests, fix rounding
* Add spacer to balance sidebar network name
* Fix tsc error
* Add offline render CB
* Make more render callbacks
* Transform NonceField into its self contained component
* Remove styling from nonce field
* Better network handling in nonce cb
* Move network nonce initialization to componentDidMount
* Remove unessesary conditional input
* Make nonce component return a BN
* Simplify Query render cb
* Add gas query and token query render cbs
* Re-write address field component, strip out ENS name functionality for now
* Add address and data as unit types
* Cleanup Address Field component
* Export gas query
* Re-write gas field component
* Cleanup gas estimation check
* Re-write Data field
* Transaction field skeleton
* Export transaction field actions
* Rename fields to map to ethtx fields
* Make reducers for fields
* Fix reducer module exports
* Export reducer
* Formatting fix
* Type return of GasQuery
* Add transaction field getter / setter component
* Make transaction fields more flexible
* Formatting fix
* Split transaction fields component into two
* Remove erroneous prop
* Fix field naming to follow ethereum transaction fields
* Merge valid prop into componeent
* Change address field to be redux based
* Convert nonce field to redux based
* Make component for passing in current transaction
* Re-write Gas component to use redux state
* Reduxify data field component
* seperate transaction fields redux state into field data and meta data
* Rename SetTransactionFields to be singular
* Make render callback components for getting/setting meta fields
* Add non-zero option prop for token balance render cb
* re-write unit dropdown component to be redux based
* Make ether the first option
* Fix tsc error on tokenquery
* Handle query string default values in unit drop down
* Add thunks to package
* Add helper function for encoding transfer data
* Handle co-dependencies between fields via thunks, seperate value fields into ether and token based
* Fix wrong typing
* Add token metafield as export
* Start scaffolding out amount field component
* Make render cbs for conditional selection of value and balance
* Make render callbacks nullable
* Progress commit -- get dynaming swapping between tokens and ether working
* Get gas estimation working between ether and tokens
* Remove nonce from breaking gas estimation
* Add better validation for amount field
* Add 500ms debounce to gas saga
* Self contain custom message component
* Add web3 awareness to wallet render cb
* Add render cb for checking if wallet is unlocked
* Cleanup inline typing
* export available params
* Add render cb to render component when a query string exists
* Add boolean callback param that check that the transaction is filled by user
* Remove uneeded typings from send transaction
* Fix misnomer
* Self contain generate transaction button
* Compartmentalize more send transaction components
* Add query string warning, custom message and generate tx button to fields
* Cleanup send tx component with new components
* export render callbacks
* saga transaction scaffolding
* make gas saga fully declarative
* transaction lib renaming
* Seperate gasprice into its own generator
* Make action creators for tx sign actions
* Clean up signing saga, introduce reducer for signing, make HW wallet libs compatible with new tx format, fix some typing with ethereumjs-tx
* Add TransactionComparison component
* Add pushTx
* Progress commit -- Streamline web3 and local signing / broadcasting flows. Need to still implement reducers for broadcasting and notifications
* Get local transaction broadcasting working
* re-write confirmation modal to be redux based
* Fix spacing and import
* Move confirmation modal to be attached to send button, create send button
* Properly handle broadcasting for conf modal
* Handle gas cost > balance for send everything
* Add signing status as its own component (#454)
* Fix ledger errors not showing on notifs
* Make dedicated actions for swapping from tokens to ether and ether to tokens
* Split actionTypes file
* Cleanup comments
* Cleanup comments
* Fix various tsc errors
* Lay down infrastructure for saving configurations per-wallet.
* Add pending and rejected states properly to token values.
* Add custom token form improvements.
* Fix metamask transaction errors
* Fix send entire balance estimation
* Fix add token form from never being enabled.
* Initial pass at account tab with send and view wallet tabs.
* Fix inactive tab.
* Hide private key, toggling
* Progress commit -- Replacing render callbacks with selectors, put validation logic in sagas
* Moved the restore keystore functionality to view wallet info, and put it in a modal / util file.
* Fix navigation link active
* Force read only wallets to info tab.
* Remove commented code
* Saga-ify send everything
* Scan for new tokens, track saved tokens, only request tracked tokens on initial load.
* Add custom token to current wallets tracked tokens.
* Rework remove token icon.
* Adjust button margin
* Remove the rest of the needless render callbacks for selectors, sagaify nonce
* Bug fix send transaction
* remove unused redux-thunk
* Move fields to general components
* Clean up saga structure
* Refactor broadcast tx
* Implement better validation logic, get contract deploy working
* PR feedback.
* Convert tokenbalances component to connected redux component.
* Addressed feedback from Henry.
* Progress commit -- Implement Interact logic, needs manual testing
* Get rid of commented code
* move exports after declarations
* add tests, rough draft
* Get contract method calls working
* Bugfix contracts
* Cleanup hex prefixing
* Reset transaction state on wallet change
* Get rid of old send transaction component
* Disable sign transaction button when network request is underway
* Flatten send button tree, make nonce human readable in confirmation modal
* Add ghetto cost breakdown component, fix token field validation
* Create Generic SubTab and use in Send
* MVP of mnemonics with sub-tabs in Create Wallet view.
* Do dynamic revalidation
* move exports after declarations
* add forgotten signing tests
* update token spec
* update currentValue spec
* update validationHelpers spec
* Address TODO - use injected history to push navigation state instead of hardcoding window.location
* Use SubTabs in Contracts
* Fix revertPath prop for AcceptOrRedirectModal
* Use subtabs in SignAndVerifyMessage
* Routing for subtabs
* Fix routes, adjust sizing.
* Remove unused import
* Request nonce in base 10
* Add offline override to unit display
* Make cost breakdown less buggy
* Add non standard transaction warning
* Fix amount validity
* Cleanup datafield validity
* Display notif on gas estimation failure
* Add post-signing verification against fields, clean up gas price
* Fix tsc errors
* Code cleanup
* add exports to functions
* add specs for sendEverything and reset sagas
* delete duplicate files
* make tslint happy
* Merge develop
* Fix develop regressions
* Delegate nonce pulling to wallet being set
* Clarify non standard transaction
* Make address a buffer to avoid leading 0's bug
* Clarify validation helper comment
* Increase debounce time, add console error
* Better validation for non-standard transactions
* Add verification skipping for broadcasting txs
* Fix state and wallet resetting for contract tabs
* Fix some spec files, remove contract.spec
* Remove broadcasting specs from wallet
* Close DeterministicWalletModal on confirm
* Revert "Close DeterministicWalletModal on confirm"
This reverts commit 16c860e854ca29e9de754164d8be5e24f722cbad.
* Reset hardware wallet state on unlocking. Dont render walletdecrypt content when its hidden.
* Fix client side broadcast checking
* Add more state resetters in error scenarios
* Fix gas estimation
* Add validation for value transactions to contract creation
* Add transaction comparaision differentiation depending on wallet type
* Fix token row display balance showing twice
* Properly handle failed transactions
* Handle bad error messages
* fix broken tests
* fix broken test
* Progress commit -- Implement generic subtab types
* Remove react router v3
* Remove unused routes
* Clean up Tabbing code, add onTabChange handler
* Fix tests
* Add nav fix
* revert opinionated sub-tab implementation
* additional reverts
* Add decimal validation
* Make gas price single source of truth, dont save any transaction state other than gas price
* Get rid of old wallet.spec reducer tests
* Add decimal validation when re-validating gasCost
* remove utilities view
* Remove cost breakdown
* Remove local gas estimation warning
* Create getShownTokenBalances selector; use in UnitDropDown and Equivalent Values
* Convert reducers to switch case
* Clean tsc errors
* Fix failing test
* fix tscheck error
* Add number validation to gas field
* Fix misaligned input dropdown
* Revert "Fix misaligned input dropdown"
This reverts commit a40a4c0e8d52471dea01e6727f741a737b798695.
* Set window timeout long enough for node switch to be persisted to state
* Transaction Refactor Style Fixes (#615)
* Fix unit dropdown alignment by rendering it in AmountField, and fixing a missed bootstrap case.
* Fix modal amount and gas text.
* Fix misaligned dropdown
* Update conditions for NavLink is-active class
2017-12-18 21:23:31 +00:00
|
|
|
str = str.substring(0, 2) === '0x' ? str.substring(2).toUpperCase() : str.toUpperCase();
|
2017-10-17 04:01:28 +00:00
|
|
|
const re = /^[0-9A-F]*$/g; // Match 0 -> unlimited times, 0 being "0x" case
|
2017-07-02 05:49:06 +00:00
|
|
|
return re.test(str);
|
2017-06-26 22:27:55 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
export function isValidENSorEtherAddress(address: string): boolean {
|
2017-07-02 05:49:06 +00:00
|
|
|
return isValidETHAddress(address) || isValidENSAddress(address);
|
2017-06-26 22:27:55 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
export function isValidENSName(str: string) {
|
2017-07-02 05:49:06 +00:00
|
|
|
try {
|
Productionize Transaction Stack (#456)
* export conditional input and hoc
* Move typings and fields out of send transaction
* Move fields into their own component for decoupled handling, use conditional inputs to simplify disabled components
* Handle hex and non hex strings automatically in BN conversion
* Fix handling of strings and numbers for BN
* add web3 fixes & comments
* Display short balances on deterministic modals
* add more tests, fix rounding
* Add spacer to balance sidebar network name
* Fix tsc error
* Add offline render CB
* Make more render callbacks
* Transform NonceField into its self contained component
* Remove styling from nonce field
* Better network handling in nonce cb
* Move network nonce initialization to componentDidMount
* Remove unessesary conditional input
* Make nonce component return a BN
* Simplify Query render cb
* Add gas query and token query render cbs
* Re-write address field component, strip out ENS name functionality for now
* Add address and data as unit types
* Cleanup Address Field component
* Export gas query
* Re-write gas field component
* Cleanup gas estimation check
* Re-write Data field
* Transaction field skeleton
* Export transaction field actions
* Rename fields to map to ethtx fields
* Make reducers for fields
* Fix reducer module exports
* Export reducer
* Formatting fix
* Type return of GasQuery
* Add transaction field getter / setter component
* Make transaction fields more flexible
* Formatting fix
* Split transaction fields component into two
* Remove erroneous prop
* Fix field naming to follow ethereum transaction fields
* Merge valid prop into componeent
* Change address field to be redux based
* Convert nonce field to redux based
* Make component for passing in current transaction
* Re-write Gas component to use redux state
* Reduxify data field component
* seperate transaction fields redux state into field data and meta data
* Rename SetTransactionFields to be singular
* Make render callback components for getting/setting meta fields
* Add non-zero option prop for token balance render cb
* re-write unit dropdown component to be redux based
* Make ether the first option
* Fix tsc error on tokenquery
* Handle query string default values in unit drop down
* Add thunks to package
* Add helper function for encoding transfer data
* Handle co-dependencies between fields via thunks, seperate value fields into ether and token based
* Fix wrong typing
* Add token metafield as export
* Start scaffolding out amount field component
* Make render cbs for conditional selection of value and balance
* Make render callbacks nullable
* Progress commit -- get dynaming swapping between tokens and ether working
* Get gas estimation working between ether and tokens
* Remove nonce from breaking gas estimation
* Add better validation for amount field
* Add 500ms debounce to gas saga
* Self contain custom message component
* Add web3 awareness to wallet render cb
* Add render cb for checking if wallet is unlocked
* Cleanup inline typing
* export available params
* Add render cb to render component when a query string exists
* Add boolean callback param that check that the transaction is filled by user
* Remove uneeded typings from send transaction
* Fix misnomer
* Self contain generate transaction button
* Compartmentalize more send transaction components
* Add query string warning, custom message and generate tx button to fields
* Cleanup send tx component with new components
* export render callbacks
* saga transaction scaffolding
* make gas saga fully declarative
* transaction lib renaming
* Seperate gasprice into its own generator
* Make action creators for tx sign actions
* Clean up signing saga, introduce reducer for signing, make HW wallet libs compatible with new tx format, fix some typing with ethereumjs-tx
* Add TransactionComparison component
* Add pushTx
* Progress commit -- Streamline web3 and local signing / broadcasting flows. Need to still implement reducers for broadcasting and notifications
* Get local transaction broadcasting working
* re-write confirmation modal to be redux based
* Fix spacing and import
* Move confirmation modal to be attached to send button, create send button
* Properly handle broadcasting for conf modal
* Handle gas cost > balance for send everything
* Add signing status as its own component (#454)
* Fix ledger errors not showing on notifs
* Make dedicated actions for swapping from tokens to ether and ether to tokens
* Split actionTypes file
* Cleanup comments
* Cleanup comments
* Fix various tsc errors
* Lay down infrastructure for saving configurations per-wallet.
* Add pending and rejected states properly to token values.
* Add custom token form improvements.
* Fix metamask transaction errors
* Fix send entire balance estimation
* Fix add token form from never being enabled.
* Initial pass at account tab with send and view wallet tabs.
* Fix inactive tab.
* Hide private key, toggling
* Progress commit -- Replacing render callbacks with selectors, put validation logic in sagas
* Moved the restore keystore functionality to view wallet info, and put it in a modal / util file.
* Fix navigation link active
* Force read only wallets to info tab.
* Remove commented code
* Saga-ify send everything
* Scan for new tokens, track saved tokens, only request tracked tokens on initial load.
* Add custom token to current wallets tracked tokens.
* Rework remove token icon.
* Adjust button margin
* Remove the rest of the needless render callbacks for selectors, sagaify nonce
* Bug fix send transaction
* remove unused redux-thunk
* Move fields to general components
* Clean up saga structure
* Refactor broadcast tx
* Implement better validation logic, get contract deploy working
* PR feedback.
* Convert tokenbalances component to connected redux component.
* Addressed feedback from Henry.
* Progress commit -- Implement Interact logic, needs manual testing
* Get rid of commented code
* move exports after declarations
* add tests, rough draft
* Get contract method calls working
* Bugfix contracts
* Cleanup hex prefixing
* Reset transaction state on wallet change
* Get rid of old send transaction component
* Disable sign transaction button when network request is underway
* Flatten send button tree, make nonce human readable in confirmation modal
* Add ghetto cost breakdown component, fix token field validation
* Create Generic SubTab and use in Send
* MVP of mnemonics with sub-tabs in Create Wallet view.
* Do dynamic revalidation
* move exports after declarations
* add forgotten signing tests
* update token spec
* update currentValue spec
* update validationHelpers spec
* Address TODO - use injected history to push navigation state instead of hardcoding window.location
* Use SubTabs in Contracts
* Fix revertPath prop for AcceptOrRedirectModal
* Use subtabs in SignAndVerifyMessage
* Routing for subtabs
* Fix routes, adjust sizing.
* Remove unused import
* Request nonce in base 10
* Add offline override to unit display
* Make cost breakdown less buggy
* Add non standard transaction warning
* Fix amount validity
* Cleanup datafield validity
* Display notif on gas estimation failure
* Add post-signing verification against fields, clean up gas price
* Fix tsc errors
* Code cleanup
* add exports to functions
* add specs for sendEverything and reset sagas
* delete duplicate files
* make tslint happy
* Merge develop
* Fix develop regressions
* Delegate nonce pulling to wallet being set
* Clarify non standard transaction
* Make address a buffer to avoid leading 0's bug
* Clarify validation helper comment
* Increase debounce time, add console error
* Better validation for non-standard transactions
* Add verification skipping for broadcasting txs
* Fix state and wallet resetting for contract tabs
* Fix some spec files, remove contract.spec
* Remove broadcasting specs from wallet
* Close DeterministicWalletModal on confirm
* Revert "Close DeterministicWalletModal on confirm"
This reverts commit 16c860e854ca29e9de754164d8be5e24f722cbad.
* Reset hardware wallet state on unlocking. Dont render walletdecrypt content when its hidden.
* Fix client side broadcast checking
* Add more state resetters in error scenarios
* Fix gas estimation
* Add validation for value transactions to contract creation
* Add transaction comparaision differentiation depending on wallet type
* Fix token row display balance showing twice
* Properly handle failed transactions
* Handle bad error messages
* fix broken tests
* fix broken test
* Progress commit -- Implement generic subtab types
* Remove react router v3
* Remove unused routes
* Clean up Tabbing code, add onTabChange handler
* Fix tests
* Add nav fix
* revert opinionated sub-tab implementation
* additional reverts
* Add decimal validation
* Make gas price single source of truth, dont save any transaction state other than gas price
* Get rid of old wallet.spec reducer tests
* Add decimal validation when re-validating gasCost
* remove utilities view
* Remove cost breakdown
* Remove local gas estimation warning
* Create getShownTokenBalances selector; use in UnitDropDown and Equivalent Values
* Convert reducers to switch case
* Clean tsc errors
* Fix failing test
* fix tscheck error
* Add number validation to gas field
* Fix misaligned input dropdown
* Revert "Fix misaligned input dropdown"
This reverts commit a40a4c0e8d52471dea01e6727f741a737b798695.
* Set window timeout long enough for node switch to be persisted to state
* Transaction Refactor Style Fixes (#615)
* Fix unit dropdown alignment by rendering it in AmountField, and fixing a missed bootstrap case.
* Fix modal amount and gas text.
* Fix misaligned dropdown
* Update conditions for NavLink is-active class
2017-12-18 21:23:31 +00:00
|
|
|
return str.length > 6 && normalise(str) !== '' && str.substring(0, 2) !== '0x';
|
2017-07-02 05:49:06 +00:00
|
|
|
} catch (e) {
|
|
|
|
return false;
|
|
|
|
}
|
2017-06-26 22:27:55 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
export function isValidENSAddress(address: string): boolean {
|
2017-07-02 05:49:06 +00:00
|
|
|
try {
|
|
|
|
const normalized = normalise(address);
|
2017-09-25 02:06:28 +00:00
|
|
|
const tld = normalized.substr(normalized.lastIndexOf('.') + 1);
|
|
|
|
const validTLDs = {
|
2017-07-02 05:49:06 +00:00
|
|
|
eth: true,
|
|
|
|
test: true,
|
|
|
|
reverse: true
|
|
|
|
};
|
2017-12-19 22:46:34 +00:00
|
|
|
if (validTLDs[tld as keyof typeof validTLDs]) {
|
2017-09-25 02:06:28 +00:00
|
|
|
return true;
|
|
|
|
}
|
2017-07-02 05:49:06 +00:00
|
|
|
} catch (e) {
|
2017-06-26 22:27:55 +00:00
|
|
|
return false;
|
2017-07-02 05:49:06 +00:00
|
|
|
}
|
|
|
|
return false;
|
2017-06-26 22:27:55 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
function isChecksumAddress(address: string): boolean {
|
2017-09-25 02:06:28 +00:00
|
|
|
return address === toChecksumAddress(address);
|
2017-06-26 22:27:55 +00:00
|
|
|
}
|
|
|
|
|
2017-08-20 20:28:47 +00:00
|
|
|
export function isValidPrivKey(privkey: string | Buffer): boolean {
|
|
|
|
if (typeof privkey === 'string') {
|
2017-11-30 20:16:30 +00:00
|
|
|
const strippedKey = stripHexPrefix(privkey);
|
|
|
|
const initialCheck = strippedKey.length === 64;
|
|
|
|
if (initialCheck) {
|
|
|
|
const keyBuffer = Buffer.from(strippedKey, 'hex');
|
|
|
|
return isValidPrivate(keyBuffer);
|
|
|
|
}
|
|
|
|
return false;
|
2017-08-20 20:28:47 +00:00
|
|
|
} else if (privkey instanceof Buffer) {
|
2017-11-30 20:16:30 +00:00
|
|
|
return privkey.length === 32 && isValidPrivate(privkey);
|
2017-08-20 20:28:47 +00:00
|
|
|
} else {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
export function isValidEncryptedPrivKey(privkey: string): boolean {
|
|
|
|
if (typeof privkey === 'string') {
|
|
|
|
return privkey.length === 128 || privkey.length === 132;
|
|
|
|
} else {
|
|
|
|
return false;
|
|
|
|
}
|
2017-06-29 23:03:11 +00:00
|
|
|
}
|
2017-07-13 21:02:39 +00:00
|
|
|
|
2018-03-14 19:51:37 +00:00
|
|
|
export const validNumber = (num: number) => isFinite(num) && num >= 0;
|
|
|
|
export const validPositiveNumber = (num: number) => validNumber(num) && num !== 0;
|
2017-08-08 03:25:23 +00:00
|
|
|
|
Productionize Transaction Stack (#456)
* export conditional input and hoc
* Move typings and fields out of send transaction
* Move fields into their own component for decoupled handling, use conditional inputs to simplify disabled components
* Handle hex and non hex strings automatically in BN conversion
* Fix handling of strings and numbers for BN
* add web3 fixes & comments
* Display short balances on deterministic modals
* add more tests, fix rounding
* Add spacer to balance sidebar network name
* Fix tsc error
* Add offline render CB
* Make more render callbacks
* Transform NonceField into its self contained component
* Remove styling from nonce field
* Better network handling in nonce cb
* Move network nonce initialization to componentDidMount
* Remove unessesary conditional input
* Make nonce component return a BN
* Simplify Query render cb
* Add gas query and token query render cbs
* Re-write address field component, strip out ENS name functionality for now
* Add address and data as unit types
* Cleanup Address Field component
* Export gas query
* Re-write gas field component
* Cleanup gas estimation check
* Re-write Data field
* Transaction field skeleton
* Export transaction field actions
* Rename fields to map to ethtx fields
* Make reducers for fields
* Fix reducer module exports
* Export reducer
* Formatting fix
* Type return of GasQuery
* Add transaction field getter / setter component
* Make transaction fields more flexible
* Formatting fix
* Split transaction fields component into two
* Remove erroneous prop
* Fix field naming to follow ethereum transaction fields
* Merge valid prop into componeent
* Change address field to be redux based
* Convert nonce field to redux based
* Make component for passing in current transaction
* Re-write Gas component to use redux state
* Reduxify data field component
* seperate transaction fields redux state into field data and meta data
* Rename SetTransactionFields to be singular
* Make render callback components for getting/setting meta fields
* Add non-zero option prop for token balance render cb
* re-write unit dropdown component to be redux based
* Make ether the first option
* Fix tsc error on tokenquery
* Handle query string default values in unit drop down
* Add thunks to package
* Add helper function for encoding transfer data
* Handle co-dependencies between fields via thunks, seperate value fields into ether and token based
* Fix wrong typing
* Add token metafield as export
* Start scaffolding out amount field component
* Make render cbs for conditional selection of value and balance
* Make render callbacks nullable
* Progress commit -- get dynaming swapping between tokens and ether working
* Get gas estimation working between ether and tokens
* Remove nonce from breaking gas estimation
* Add better validation for amount field
* Add 500ms debounce to gas saga
* Self contain custom message component
* Add web3 awareness to wallet render cb
* Add render cb for checking if wallet is unlocked
* Cleanup inline typing
* export available params
* Add render cb to render component when a query string exists
* Add boolean callback param that check that the transaction is filled by user
* Remove uneeded typings from send transaction
* Fix misnomer
* Self contain generate transaction button
* Compartmentalize more send transaction components
* Add query string warning, custom message and generate tx button to fields
* Cleanup send tx component with new components
* export render callbacks
* saga transaction scaffolding
* make gas saga fully declarative
* transaction lib renaming
* Seperate gasprice into its own generator
* Make action creators for tx sign actions
* Clean up signing saga, introduce reducer for signing, make HW wallet libs compatible with new tx format, fix some typing with ethereumjs-tx
* Add TransactionComparison component
* Add pushTx
* Progress commit -- Streamline web3 and local signing / broadcasting flows. Need to still implement reducers for broadcasting and notifications
* Get local transaction broadcasting working
* re-write confirmation modal to be redux based
* Fix spacing and import
* Move confirmation modal to be attached to send button, create send button
* Properly handle broadcasting for conf modal
* Handle gas cost > balance for send everything
* Add signing status as its own component (#454)
* Fix ledger errors not showing on notifs
* Make dedicated actions for swapping from tokens to ether and ether to tokens
* Split actionTypes file
* Cleanup comments
* Cleanup comments
* Fix various tsc errors
* Lay down infrastructure for saving configurations per-wallet.
* Add pending and rejected states properly to token values.
* Add custom token form improvements.
* Fix metamask transaction errors
* Fix send entire balance estimation
* Fix add token form from never being enabled.
* Initial pass at account tab with send and view wallet tabs.
* Fix inactive tab.
* Hide private key, toggling
* Progress commit -- Replacing render callbacks with selectors, put validation logic in sagas
* Moved the restore keystore functionality to view wallet info, and put it in a modal / util file.
* Fix navigation link active
* Force read only wallets to info tab.
* Remove commented code
* Saga-ify send everything
* Scan for new tokens, track saved tokens, only request tracked tokens on initial load.
* Add custom token to current wallets tracked tokens.
* Rework remove token icon.
* Adjust button margin
* Remove the rest of the needless render callbacks for selectors, sagaify nonce
* Bug fix send transaction
* remove unused redux-thunk
* Move fields to general components
* Clean up saga structure
* Refactor broadcast tx
* Implement better validation logic, get contract deploy working
* PR feedback.
* Convert tokenbalances component to connected redux component.
* Addressed feedback from Henry.
* Progress commit -- Implement Interact logic, needs manual testing
* Get rid of commented code
* move exports after declarations
* add tests, rough draft
* Get contract method calls working
* Bugfix contracts
* Cleanup hex prefixing
* Reset transaction state on wallet change
* Get rid of old send transaction component
* Disable sign transaction button when network request is underway
* Flatten send button tree, make nonce human readable in confirmation modal
* Add ghetto cost breakdown component, fix token field validation
* Create Generic SubTab and use in Send
* MVP of mnemonics with sub-tabs in Create Wallet view.
* Do dynamic revalidation
* move exports after declarations
* add forgotten signing tests
* update token spec
* update currentValue spec
* update validationHelpers spec
* Address TODO - use injected history to push navigation state instead of hardcoding window.location
* Use SubTabs in Contracts
* Fix revertPath prop for AcceptOrRedirectModal
* Use subtabs in SignAndVerifyMessage
* Routing for subtabs
* Fix routes, adjust sizing.
* Remove unused import
* Request nonce in base 10
* Add offline override to unit display
* Make cost breakdown less buggy
* Add non standard transaction warning
* Fix amount validity
* Cleanup datafield validity
* Display notif on gas estimation failure
* Add post-signing verification against fields, clean up gas price
* Fix tsc errors
* Code cleanup
* add exports to functions
* add specs for sendEverything and reset sagas
* delete duplicate files
* make tslint happy
* Merge develop
* Fix develop regressions
* Delegate nonce pulling to wallet being set
* Clarify non standard transaction
* Make address a buffer to avoid leading 0's bug
* Clarify validation helper comment
* Increase debounce time, add console error
* Better validation for non-standard transactions
* Add verification skipping for broadcasting txs
* Fix state and wallet resetting for contract tabs
* Fix some spec files, remove contract.spec
* Remove broadcasting specs from wallet
* Close DeterministicWalletModal on confirm
* Revert "Close DeterministicWalletModal on confirm"
This reverts commit 16c860e854ca29e9de754164d8be5e24f722cbad.
* Reset hardware wallet state on unlocking. Dont render walletdecrypt content when its hidden.
* Fix client side broadcast checking
* Add more state resetters in error scenarios
* Fix gas estimation
* Add validation for value transactions to contract creation
* Add transaction comparaision differentiation depending on wallet type
* Fix token row display balance showing twice
* Properly handle failed transactions
* Handle bad error messages
* fix broken tests
* fix broken test
* Progress commit -- Implement generic subtab types
* Remove react router v3
* Remove unused routes
* Clean up Tabbing code, add onTabChange handler
* Fix tests
* Add nav fix
* revert opinionated sub-tab implementation
* additional reverts
* Add decimal validation
* Make gas price single source of truth, dont save any transaction state other than gas price
* Get rid of old wallet.spec reducer tests
* Add decimal validation when re-validating gasCost
* remove utilities view
* Remove cost breakdown
* Remove local gas estimation warning
* Create getShownTokenBalances selector; use in UnitDropDown and Equivalent Values
* Convert reducers to switch case
* Clean tsc errors
* Fix failing test
* fix tscheck error
* Add number validation to gas field
* Fix misaligned input dropdown
* Revert "Fix misaligned input dropdown"
This reverts commit a40a4c0e8d52471dea01e6727f741a737b798695.
* Set window timeout long enough for node switch to be persisted to state
* Transaction Refactor Style Fixes (#615)
* Fix unit dropdown alignment by rendering it in AmountField, and fixing a missed bootstrap case.
* Fix modal amount and gas text.
* Fix misaligned dropdown
* Update conditions for NavLink is-active class
2017-12-18 21:23:31 +00:00
|
|
|
export const validDecimal = (input: string, decimal: number) => {
|
|
|
|
const arr = input.split('.');
|
|
|
|
const fractionPortion = arr[1];
|
|
|
|
if (!fractionPortion || fractionPortion.length === 0) {
|
|
|
|
return true;
|
2017-08-08 03:25:23 +00:00
|
|
|
}
|
Productionize Transaction Stack (#456)
* export conditional input and hoc
* Move typings and fields out of send transaction
* Move fields into their own component for decoupled handling, use conditional inputs to simplify disabled components
* Handle hex and non hex strings automatically in BN conversion
* Fix handling of strings and numbers for BN
* add web3 fixes & comments
* Display short balances on deterministic modals
* add more tests, fix rounding
* Add spacer to balance sidebar network name
* Fix tsc error
* Add offline render CB
* Make more render callbacks
* Transform NonceField into its self contained component
* Remove styling from nonce field
* Better network handling in nonce cb
* Move network nonce initialization to componentDidMount
* Remove unessesary conditional input
* Make nonce component return a BN
* Simplify Query render cb
* Add gas query and token query render cbs
* Re-write address field component, strip out ENS name functionality for now
* Add address and data as unit types
* Cleanup Address Field component
* Export gas query
* Re-write gas field component
* Cleanup gas estimation check
* Re-write Data field
* Transaction field skeleton
* Export transaction field actions
* Rename fields to map to ethtx fields
* Make reducers for fields
* Fix reducer module exports
* Export reducer
* Formatting fix
* Type return of GasQuery
* Add transaction field getter / setter component
* Make transaction fields more flexible
* Formatting fix
* Split transaction fields component into two
* Remove erroneous prop
* Fix field naming to follow ethereum transaction fields
* Merge valid prop into componeent
* Change address field to be redux based
* Convert nonce field to redux based
* Make component for passing in current transaction
* Re-write Gas component to use redux state
* Reduxify data field component
* seperate transaction fields redux state into field data and meta data
* Rename SetTransactionFields to be singular
* Make render callback components for getting/setting meta fields
* Add non-zero option prop for token balance render cb
* re-write unit dropdown component to be redux based
* Make ether the first option
* Fix tsc error on tokenquery
* Handle query string default values in unit drop down
* Add thunks to package
* Add helper function for encoding transfer data
* Handle co-dependencies between fields via thunks, seperate value fields into ether and token based
* Fix wrong typing
* Add token metafield as export
* Start scaffolding out amount field component
* Make render cbs for conditional selection of value and balance
* Make render callbacks nullable
* Progress commit -- get dynaming swapping between tokens and ether working
* Get gas estimation working between ether and tokens
* Remove nonce from breaking gas estimation
* Add better validation for amount field
* Add 500ms debounce to gas saga
* Self contain custom message component
* Add web3 awareness to wallet render cb
* Add render cb for checking if wallet is unlocked
* Cleanup inline typing
* export available params
* Add render cb to render component when a query string exists
* Add boolean callback param that check that the transaction is filled by user
* Remove uneeded typings from send transaction
* Fix misnomer
* Self contain generate transaction button
* Compartmentalize more send transaction components
* Add query string warning, custom message and generate tx button to fields
* Cleanup send tx component with new components
* export render callbacks
* saga transaction scaffolding
* make gas saga fully declarative
* transaction lib renaming
* Seperate gasprice into its own generator
* Make action creators for tx sign actions
* Clean up signing saga, introduce reducer for signing, make HW wallet libs compatible with new tx format, fix some typing with ethereumjs-tx
* Add TransactionComparison component
* Add pushTx
* Progress commit -- Streamline web3 and local signing / broadcasting flows. Need to still implement reducers for broadcasting and notifications
* Get local transaction broadcasting working
* re-write confirmation modal to be redux based
* Fix spacing and import
* Move confirmation modal to be attached to send button, create send button
* Properly handle broadcasting for conf modal
* Handle gas cost > balance for send everything
* Add signing status as its own component (#454)
* Fix ledger errors not showing on notifs
* Make dedicated actions for swapping from tokens to ether and ether to tokens
* Split actionTypes file
* Cleanup comments
* Cleanup comments
* Fix various tsc errors
* Lay down infrastructure for saving configurations per-wallet.
* Add pending and rejected states properly to token values.
* Add custom token form improvements.
* Fix metamask transaction errors
* Fix send entire balance estimation
* Fix add token form from never being enabled.
* Initial pass at account tab with send and view wallet tabs.
* Fix inactive tab.
* Hide private key, toggling
* Progress commit -- Replacing render callbacks with selectors, put validation logic in sagas
* Moved the restore keystore functionality to view wallet info, and put it in a modal / util file.
* Fix navigation link active
* Force read only wallets to info tab.
* Remove commented code
* Saga-ify send everything
* Scan for new tokens, track saved tokens, only request tracked tokens on initial load.
* Add custom token to current wallets tracked tokens.
* Rework remove token icon.
* Adjust button margin
* Remove the rest of the needless render callbacks for selectors, sagaify nonce
* Bug fix send transaction
* remove unused redux-thunk
* Move fields to general components
* Clean up saga structure
* Refactor broadcast tx
* Implement better validation logic, get contract deploy working
* PR feedback.
* Convert tokenbalances component to connected redux component.
* Addressed feedback from Henry.
* Progress commit -- Implement Interact logic, needs manual testing
* Get rid of commented code
* move exports after declarations
* add tests, rough draft
* Get contract method calls working
* Bugfix contracts
* Cleanup hex prefixing
* Reset transaction state on wallet change
* Get rid of old send transaction component
* Disable sign transaction button when network request is underway
* Flatten send button tree, make nonce human readable in confirmation modal
* Add ghetto cost breakdown component, fix token field validation
* Create Generic SubTab and use in Send
* MVP of mnemonics with sub-tabs in Create Wallet view.
* Do dynamic revalidation
* move exports after declarations
* add forgotten signing tests
* update token spec
* update currentValue spec
* update validationHelpers spec
* Address TODO - use injected history to push navigation state instead of hardcoding window.location
* Use SubTabs in Contracts
* Fix revertPath prop for AcceptOrRedirectModal
* Use subtabs in SignAndVerifyMessage
* Routing for subtabs
* Fix routes, adjust sizing.
* Remove unused import
* Request nonce in base 10
* Add offline override to unit display
* Make cost breakdown less buggy
* Add non standard transaction warning
* Fix amount validity
* Cleanup datafield validity
* Display notif on gas estimation failure
* Add post-signing verification against fields, clean up gas price
* Fix tsc errors
* Code cleanup
* add exports to functions
* add specs for sendEverything and reset sagas
* delete duplicate files
* make tslint happy
* Merge develop
* Fix develop regressions
* Delegate nonce pulling to wallet being set
* Clarify non standard transaction
* Make address a buffer to avoid leading 0's bug
* Clarify validation helper comment
* Increase debounce time, add console error
* Better validation for non-standard transactions
* Add verification skipping for broadcasting txs
* Fix state and wallet resetting for contract tabs
* Fix some spec files, remove contract.spec
* Remove broadcasting specs from wallet
* Close DeterministicWalletModal on confirm
* Revert "Close DeterministicWalletModal on confirm"
This reverts commit 16c860e854ca29e9de754164d8be5e24f722cbad.
* Reset hardware wallet state on unlocking. Dont render walletdecrypt content when its hidden.
* Fix client side broadcast checking
* Add more state resetters in error scenarios
* Fix gas estimation
* Add validation for value transactions to contract creation
* Add transaction comparaision differentiation depending on wallet type
* Fix token row display balance showing twice
* Properly handle failed transactions
* Handle bad error messages
* fix broken tests
* fix broken test
* Progress commit -- Implement generic subtab types
* Remove react router v3
* Remove unused routes
* Clean up Tabbing code, add onTabChange handler
* Fix tests
* Add nav fix
* revert opinionated sub-tab implementation
* additional reverts
* Add decimal validation
* Make gas price single source of truth, dont save any transaction state other than gas price
* Get rid of old wallet.spec reducer tests
* Add decimal validation when re-validating gasCost
* remove utilities view
* Remove cost breakdown
* Remove local gas estimation warning
* Create getShownTokenBalances selector; use in UnitDropDown and Equivalent Values
* Convert reducers to switch case
* Clean tsc errors
* Fix failing test
* fix tscheck error
* Add number validation to gas field
* Fix misaligned input dropdown
* Revert "Fix misaligned input dropdown"
This reverts commit a40a4c0e8d52471dea01e6727f741a737b798695.
* Set window timeout long enough for node switch to be persisted to state
* Transaction Refactor Style Fixes (#615)
* Fix unit dropdown alignment by rendering it in AmountField, and fixing a missed bootstrap case.
* Fix modal amount and gas text.
* Fix misaligned dropdown
* Update conditions for NavLink is-active class
2017-12-18 21:23:31 +00:00
|
|
|
const decimalLength = fractionPortion.length;
|
|
|
|
return decimalLength <= decimal;
|
|
|
|
};
|
2017-08-08 03:25:23 +00:00
|
|
|
|
Productionize Transaction Stack (#456)
* export conditional input and hoc
* Move typings and fields out of send transaction
* Move fields into their own component for decoupled handling, use conditional inputs to simplify disabled components
* Handle hex and non hex strings automatically in BN conversion
* Fix handling of strings and numbers for BN
* add web3 fixes & comments
* Display short balances on deterministic modals
* add more tests, fix rounding
* Add spacer to balance sidebar network name
* Fix tsc error
* Add offline render CB
* Make more render callbacks
* Transform NonceField into its self contained component
* Remove styling from nonce field
* Better network handling in nonce cb
* Move network nonce initialization to componentDidMount
* Remove unessesary conditional input
* Make nonce component return a BN
* Simplify Query render cb
* Add gas query and token query render cbs
* Re-write address field component, strip out ENS name functionality for now
* Add address and data as unit types
* Cleanup Address Field component
* Export gas query
* Re-write gas field component
* Cleanup gas estimation check
* Re-write Data field
* Transaction field skeleton
* Export transaction field actions
* Rename fields to map to ethtx fields
* Make reducers for fields
* Fix reducer module exports
* Export reducer
* Formatting fix
* Type return of GasQuery
* Add transaction field getter / setter component
* Make transaction fields more flexible
* Formatting fix
* Split transaction fields component into two
* Remove erroneous prop
* Fix field naming to follow ethereum transaction fields
* Merge valid prop into componeent
* Change address field to be redux based
* Convert nonce field to redux based
* Make component for passing in current transaction
* Re-write Gas component to use redux state
* Reduxify data field component
* seperate transaction fields redux state into field data and meta data
* Rename SetTransactionFields to be singular
* Make render callback components for getting/setting meta fields
* Add non-zero option prop for token balance render cb
* re-write unit dropdown component to be redux based
* Make ether the first option
* Fix tsc error on tokenquery
* Handle query string default values in unit drop down
* Add thunks to package
* Add helper function for encoding transfer data
* Handle co-dependencies between fields via thunks, seperate value fields into ether and token based
* Fix wrong typing
* Add token metafield as export
* Start scaffolding out amount field component
* Make render cbs for conditional selection of value and balance
* Make render callbacks nullable
* Progress commit -- get dynaming swapping between tokens and ether working
* Get gas estimation working between ether and tokens
* Remove nonce from breaking gas estimation
* Add better validation for amount field
* Add 500ms debounce to gas saga
* Self contain custom message component
* Add web3 awareness to wallet render cb
* Add render cb for checking if wallet is unlocked
* Cleanup inline typing
* export available params
* Add render cb to render component when a query string exists
* Add boolean callback param that check that the transaction is filled by user
* Remove uneeded typings from send transaction
* Fix misnomer
* Self contain generate transaction button
* Compartmentalize more send transaction components
* Add query string warning, custom message and generate tx button to fields
* Cleanup send tx component with new components
* export render callbacks
* saga transaction scaffolding
* make gas saga fully declarative
* transaction lib renaming
* Seperate gasprice into its own generator
* Make action creators for tx sign actions
* Clean up signing saga, introduce reducer for signing, make HW wallet libs compatible with new tx format, fix some typing with ethereumjs-tx
* Add TransactionComparison component
* Add pushTx
* Progress commit -- Streamline web3 and local signing / broadcasting flows. Need to still implement reducers for broadcasting and notifications
* Get local transaction broadcasting working
* re-write confirmation modal to be redux based
* Fix spacing and import
* Move confirmation modal to be attached to send button, create send button
* Properly handle broadcasting for conf modal
* Handle gas cost > balance for send everything
* Add signing status as its own component (#454)
* Fix ledger errors not showing on notifs
* Make dedicated actions for swapping from tokens to ether and ether to tokens
* Split actionTypes file
* Cleanup comments
* Cleanup comments
* Fix various tsc errors
* Lay down infrastructure for saving configurations per-wallet.
* Add pending and rejected states properly to token values.
* Add custom token form improvements.
* Fix metamask transaction errors
* Fix send entire balance estimation
* Fix add token form from never being enabled.
* Initial pass at account tab with send and view wallet tabs.
* Fix inactive tab.
* Hide private key, toggling
* Progress commit -- Replacing render callbacks with selectors, put validation logic in sagas
* Moved the restore keystore functionality to view wallet info, and put it in a modal / util file.
* Fix navigation link active
* Force read only wallets to info tab.
* Remove commented code
* Saga-ify send everything
* Scan for new tokens, track saved tokens, only request tracked tokens on initial load.
* Add custom token to current wallets tracked tokens.
* Rework remove token icon.
* Adjust button margin
* Remove the rest of the needless render callbacks for selectors, sagaify nonce
* Bug fix send transaction
* remove unused redux-thunk
* Move fields to general components
* Clean up saga structure
* Refactor broadcast tx
* Implement better validation logic, get contract deploy working
* PR feedback.
* Convert tokenbalances component to connected redux component.
* Addressed feedback from Henry.
* Progress commit -- Implement Interact logic, needs manual testing
* Get rid of commented code
* move exports after declarations
* add tests, rough draft
* Get contract method calls working
* Bugfix contracts
* Cleanup hex prefixing
* Reset transaction state on wallet change
* Get rid of old send transaction component
* Disable sign transaction button when network request is underway
* Flatten send button tree, make nonce human readable in confirmation modal
* Add ghetto cost breakdown component, fix token field validation
* Create Generic SubTab and use in Send
* MVP of mnemonics with sub-tabs in Create Wallet view.
* Do dynamic revalidation
* move exports after declarations
* add forgotten signing tests
* update token spec
* update currentValue spec
* update validationHelpers spec
* Address TODO - use injected history to push navigation state instead of hardcoding window.location
* Use SubTabs in Contracts
* Fix revertPath prop for AcceptOrRedirectModal
* Use subtabs in SignAndVerifyMessage
* Routing for subtabs
* Fix routes, adjust sizing.
* Remove unused import
* Request nonce in base 10
* Add offline override to unit display
* Make cost breakdown less buggy
* Add non standard transaction warning
* Fix amount validity
* Cleanup datafield validity
* Display notif on gas estimation failure
* Add post-signing verification against fields, clean up gas price
* Fix tsc errors
* Code cleanup
* add exports to functions
* add specs for sendEverything and reset sagas
* delete duplicate files
* make tslint happy
* Merge develop
* Fix develop regressions
* Delegate nonce pulling to wallet being set
* Clarify non standard transaction
* Make address a buffer to avoid leading 0's bug
* Clarify validation helper comment
* Increase debounce time, add console error
* Better validation for non-standard transactions
* Add verification skipping for broadcasting txs
* Fix state and wallet resetting for contract tabs
* Fix some spec files, remove contract.spec
* Remove broadcasting specs from wallet
* Close DeterministicWalletModal on confirm
* Revert "Close DeterministicWalletModal on confirm"
This reverts commit 16c860e854ca29e9de754164d8be5e24f722cbad.
* Reset hardware wallet state on unlocking. Dont render walletdecrypt content when its hidden.
* Fix client side broadcast checking
* Add more state resetters in error scenarios
* Fix gas estimation
* Add validation for value transactions to contract creation
* Add transaction comparaision differentiation depending on wallet type
* Fix token row display balance showing twice
* Properly handle failed transactions
* Handle bad error messages
* fix broken tests
* fix broken test
* Progress commit -- Implement generic subtab types
* Remove react router v3
* Remove unused routes
* Clean up Tabbing code, add onTabChange handler
* Fix tests
* Add nav fix
* revert opinionated sub-tab implementation
* additional reverts
* Add decimal validation
* Make gas price single source of truth, dont save any transaction state other than gas price
* Get rid of old wallet.spec reducer tests
* Add decimal validation when re-validating gasCost
* remove utilities view
* Remove cost breakdown
* Remove local gas estimation warning
* Create getShownTokenBalances selector; use in UnitDropDown and Equivalent Values
* Convert reducers to switch case
* Clean tsc errors
* Fix failing test
* fix tscheck error
* Add number validation to gas field
* Fix misaligned input dropdown
* Revert "Fix misaligned input dropdown"
This reverts commit a40a4c0e8d52471dea01e6727f741a737b798695.
* Set window timeout long enough for node switch to be persisted to state
* Transaction Refactor Style Fixes (#615)
* Fix unit dropdown alignment by rendering it in AmountField, and fixing a missed bootstrap case.
* Fix modal amount and gas text.
* Fix misaligned dropdown
* Update conditions for NavLink is-active class
2017-12-18 21:23:31 +00:00
|
|
|
export function isPositiveIntegerOrZero(num: number): boolean {
|
|
|
|
if (isNaN(num) || !isFinite(num)) {
|
2017-09-25 02:06:28 +00:00
|
|
|
return false;
|
|
|
|
}
|
Productionize Transaction Stack (#456)
* export conditional input and hoc
* Move typings and fields out of send transaction
* Move fields into their own component for decoupled handling, use conditional inputs to simplify disabled components
* Handle hex and non hex strings automatically in BN conversion
* Fix handling of strings and numbers for BN
* add web3 fixes & comments
* Display short balances on deterministic modals
* add more tests, fix rounding
* Add spacer to balance sidebar network name
* Fix tsc error
* Add offline render CB
* Make more render callbacks
* Transform NonceField into its self contained component
* Remove styling from nonce field
* Better network handling in nonce cb
* Move network nonce initialization to componentDidMount
* Remove unessesary conditional input
* Make nonce component return a BN
* Simplify Query render cb
* Add gas query and token query render cbs
* Re-write address field component, strip out ENS name functionality for now
* Add address and data as unit types
* Cleanup Address Field component
* Export gas query
* Re-write gas field component
* Cleanup gas estimation check
* Re-write Data field
* Transaction field skeleton
* Export transaction field actions
* Rename fields to map to ethtx fields
* Make reducers for fields
* Fix reducer module exports
* Export reducer
* Formatting fix
* Type return of GasQuery
* Add transaction field getter / setter component
* Make transaction fields more flexible
* Formatting fix
* Split transaction fields component into two
* Remove erroneous prop
* Fix field naming to follow ethereum transaction fields
* Merge valid prop into componeent
* Change address field to be redux based
* Convert nonce field to redux based
* Make component for passing in current transaction
* Re-write Gas component to use redux state
* Reduxify data field component
* seperate transaction fields redux state into field data and meta data
* Rename SetTransactionFields to be singular
* Make render callback components for getting/setting meta fields
* Add non-zero option prop for token balance render cb
* re-write unit dropdown component to be redux based
* Make ether the first option
* Fix tsc error on tokenquery
* Handle query string default values in unit drop down
* Add thunks to package
* Add helper function for encoding transfer data
* Handle co-dependencies between fields via thunks, seperate value fields into ether and token based
* Fix wrong typing
* Add token metafield as export
* Start scaffolding out amount field component
* Make render cbs for conditional selection of value and balance
* Make render callbacks nullable
* Progress commit -- get dynaming swapping between tokens and ether working
* Get gas estimation working between ether and tokens
* Remove nonce from breaking gas estimation
* Add better validation for amount field
* Add 500ms debounce to gas saga
* Self contain custom message component
* Add web3 awareness to wallet render cb
* Add render cb for checking if wallet is unlocked
* Cleanup inline typing
* export available params
* Add render cb to render component when a query string exists
* Add boolean callback param that check that the transaction is filled by user
* Remove uneeded typings from send transaction
* Fix misnomer
* Self contain generate transaction button
* Compartmentalize more send transaction components
* Add query string warning, custom message and generate tx button to fields
* Cleanup send tx component with new components
* export render callbacks
* saga transaction scaffolding
* make gas saga fully declarative
* transaction lib renaming
* Seperate gasprice into its own generator
* Make action creators for tx sign actions
* Clean up signing saga, introduce reducer for signing, make HW wallet libs compatible with new tx format, fix some typing with ethereumjs-tx
* Add TransactionComparison component
* Add pushTx
* Progress commit -- Streamline web3 and local signing / broadcasting flows. Need to still implement reducers for broadcasting and notifications
* Get local transaction broadcasting working
* re-write confirmation modal to be redux based
* Fix spacing and import
* Move confirmation modal to be attached to send button, create send button
* Properly handle broadcasting for conf modal
* Handle gas cost > balance for send everything
* Add signing status as its own component (#454)
* Fix ledger errors not showing on notifs
* Make dedicated actions for swapping from tokens to ether and ether to tokens
* Split actionTypes file
* Cleanup comments
* Cleanup comments
* Fix various tsc errors
* Lay down infrastructure for saving configurations per-wallet.
* Add pending and rejected states properly to token values.
* Add custom token form improvements.
* Fix metamask transaction errors
* Fix send entire balance estimation
* Fix add token form from never being enabled.
* Initial pass at account tab with send and view wallet tabs.
* Fix inactive tab.
* Hide private key, toggling
* Progress commit -- Replacing render callbacks with selectors, put validation logic in sagas
* Moved the restore keystore functionality to view wallet info, and put it in a modal / util file.
* Fix navigation link active
* Force read only wallets to info tab.
* Remove commented code
* Saga-ify send everything
* Scan for new tokens, track saved tokens, only request tracked tokens on initial load.
* Add custom token to current wallets tracked tokens.
* Rework remove token icon.
* Adjust button margin
* Remove the rest of the needless render callbacks for selectors, sagaify nonce
* Bug fix send transaction
* remove unused redux-thunk
* Move fields to general components
* Clean up saga structure
* Refactor broadcast tx
* Implement better validation logic, get contract deploy working
* PR feedback.
* Convert tokenbalances component to connected redux component.
* Addressed feedback from Henry.
* Progress commit -- Implement Interact logic, needs manual testing
* Get rid of commented code
* move exports after declarations
* add tests, rough draft
* Get contract method calls working
* Bugfix contracts
* Cleanup hex prefixing
* Reset transaction state on wallet change
* Get rid of old send transaction component
* Disable sign transaction button when network request is underway
* Flatten send button tree, make nonce human readable in confirmation modal
* Add ghetto cost breakdown component, fix token field validation
* Create Generic SubTab and use in Send
* MVP of mnemonics with sub-tabs in Create Wallet view.
* Do dynamic revalidation
* move exports after declarations
* add forgotten signing tests
* update token spec
* update currentValue spec
* update validationHelpers spec
* Address TODO - use injected history to push navigation state instead of hardcoding window.location
* Use SubTabs in Contracts
* Fix revertPath prop for AcceptOrRedirectModal
* Use subtabs in SignAndVerifyMessage
* Routing for subtabs
* Fix routes, adjust sizing.
* Remove unused import
* Request nonce in base 10
* Add offline override to unit display
* Make cost breakdown less buggy
* Add non standard transaction warning
* Fix amount validity
* Cleanup datafield validity
* Display notif on gas estimation failure
* Add post-signing verification against fields, clean up gas price
* Fix tsc errors
* Code cleanup
* add exports to functions
* add specs for sendEverything and reset sagas
* delete duplicate files
* make tslint happy
* Merge develop
* Fix develop regressions
* Delegate nonce pulling to wallet being set
* Clarify non standard transaction
* Make address a buffer to avoid leading 0's bug
* Clarify validation helper comment
* Increase debounce time, add console error
* Better validation for non-standard transactions
* Add verification skipping for broadcasting txs
* Fix state and wallet resetting for contract tabs
* Fix some spec files, remove contract.spec
* Remove broadcasting specs from wallet
* Close DeterministicWalletModal on confirm
* Revert "Close DeterministicWalletModal on confirm"
This reverts commit 16c860e854ca29e9de754164d8be5e24f722cbad.
* Reset hardware wallet state on unlocking. Dont render walletdecrypt content when its hidden.
* Fix client side broadcast checking
* Add more state resetters in error scenarios
* Fix gas estimation
* Add validation for value transactions to contract creation
* Add transaction comparaision differentiation depending on wallet type
* Fix token row display balance showing twice
* Properly handle failed transactions
* Handle bad error messages
* fix broken tests
* fix broken test
* Progress commit -- Implement generic subtab types
* Remove react router v3
* Remove unused routes
* Clean up Tabbing code, add onTabChange handler
* Fix tests
* Add nav fix
* revert opinionated sub-tab implementation
* additional reverts
* Add decimal validation
* Make gas price single source of truth, dont save any transaction state other than gas price
* Get rid of old wallet.spec reducer tests
* Add decimal validation when re-validating gasCost
* remove utilities view
* Remove cost breakdown
* Remove local gas estimation warning
* Create getShownTokenBalances selector; use in UnitDropDown and Equivalent Values
* Convert reducers to switch case
* Clean tsc errors
* Fix failing test
* fix tscheck error
* Add number validation to gas field
* Fix misaligned input dropdown
* Revert "Fix misaligned input dropdown"
This reverts commit a40a4c0e8d52471dea01e6727f741a737b798695.
* Set window timeout long enough for node switch to be persisted to state
* Transaction Refactor Style Fixes (#615)
* Fix unit dropdown alignment by rendering it in AmountField, and fixing a missed bootstrap case.
* Fix modal amount and gas text.
* Fix misaligned dropdown
* Update conditions for NavLink is-active class
2017-12-18 21:23:31 +00:00
|
|
|
return num >= 0 && parseInt(num.toString(), 10) === num;
|
2017-08-08 03:25:23 +00:00
|
|
|
}
|
2017-08-28 17:43:57 +00:00
|
|
|
|
|
|
|
export function isValidPath(dPath: string) {
|
2018-04-16 23:07:00 +00:00
|
|
|
// ETC Ledger is incorrect up due to an extra ' at the end of it
|
|
|
|
if (dPath === ETC_LEDGER.value) {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
// SingularDTV is incorrect due to using a 0 instead of a 44 as the purpose
|
|
|
|
if (dPath === ETH_SINGULAR.value) {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2018-02-27 01:20:41 +00:00
|
|
|
return dPathRegex.test(dPath);
|
2017-08-28 17:43:57 +00:00
|
|
|
}
|
2017-10-17 04:01:28 +00:00
|
|
|
|
|
|
|
export const isValidValue = (value: string) =>
|
2018-05-13 19:24:50 +00:00
|
|
|
!!(value && isFinite(Number(value)) && Number(value) >= 0);
|
2017-10-17 04:01:28 +00:00
|
|
|
|
2018-01-21 18:41:20 +00:00
|
|
|
export const gasLimitValidator = (gasLimit: number | string) => {
|
2018-05-13 19:24:50 +00:00
|
|
|
const gasLimitFloat = typeof gasLimit === 'string' ? Number(gasLimit) : gasLimit;
|
2018-01-21 18:41:20 +00:00
|
|
|
return (
|
|
|
|
validNumber(gasLimitFloat) &&
|
|
|
|
gasLimitFloat >= GAS_LIMIT_LOWER_BOUND &&
|
|
|
|
gasLimitFloat <= GAS_LIMIT_UPPER_BOUND
|
|
|
|
);
|
|
|
|
};
|
|
|
|
|
|
|
|
export const gasPriceValidator = (gasPrice: number | string): boolean => {
|
2018-05-13 19:24:50 +00:00
|
|
|
const gasPriceFloat = typeof gasPrice === 'string' ? Number(gasPrice) : gasPrice;
|
2018-01-21 18:41:20 +00:00
|
|
|
return (
|
|
|
|
validNumber(gasPriceFloat) &&
|
|
|
|
gasPriceFloat >= GAS_PRICE_GWEI_LOWER_BOUND &&
|
|
|
|
gasPriceFloat <= GAS_PRICE_GWEI_UPPER_BOUND
|
|
|
|
);
|
|
|
|
};
|
2017-10-17 04:01:28 +00:00
|
|
|
|
2018-04-14 22:21:33 +00:00
|
|
|
export const timeBountyValidator = (timeBounty: BN | number | string | null): boolean => {
|
|
|
|
if (!timeBounty) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (timeBounty instanceof BN) {
|
|
|
|
return (
|
|
|
|
timeBounty.gte(EAC_SCHEDULING_CONFIG.TIME_BOUNTY_MIN) &&
|
|
|
|
timeBounty.lte(EAC_SCHEDULING_CONFIG.TIME_BOUNTY_MAX)
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2018-05-13 19:24:50 +00:00
|
|
|
const timeBountyFloat = typeof timeBounty === 'string' ? Number(timeBounty) : timeBounty;
|
2018-04-14 22:21:33 +00:00
|
|
|
|
|
|
|
return validNumber(timeBountyFloat);
|
|
|
|
};
|
|
|
|
|
2017-10-17 04:01:28 +00:00
|
|
|
export const isValidByteCode = (byteCode: string) =>
|
|
|
|
byteCode && byteCode.length > 0 && byteCode.length % 2 === 0;
|
|
|
|
|
|
|
|
export const isValidAbiJson = (abiJson: string) =>
|
|
|
|
abiJson && abiJson.startsWith('[') && abiJson.endsWith(']');
|
2017-11-30 05:35:17 +00:00
|
|
|
|
|
|
|
// JSONSchema Validations for Rpc responses
|
|
|
|
const v = new Validator();
|
|
|
|
|
|
|
|
export const schema = {
|
|
|
|
RpcNode: {
|
|
|
|
type: 'object',
|
|
|
|
additionalProperties: false,
|
|
|
|
properties: {
|
|
|
|
jsonrpc: { type: 'string' },
|
|
|
|
id: { oneOf: [{ type: 'string' }, { type: 'integer' }] },
|
2018-02-16 16:57:23 +00:00
|
|
|
result: {
|
|
|
|
oneOf: [{ type: 'string' }, { type: 'array' }, { type: 'object' }]
|
|
|
|
},
|
2017-11-30 05:35:17 +00:00
|
|
|
status: { type: 'string' },
|
|
|
|
message: { type: 'string', maxLength: 2 }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
Productionize Transaction Stack (#456)
* export conditional input and hoc
* Move typings and fields out of send transaction
* Move fields into their own component for decoupled handling, use conditional inputs to simplify disabled components
* Handle hex and non hex strings automatically in BN conversion
* Fix handling of strings and numbers for BN
* add web3 fixes & comments
* Display short balances on deterministic modals
* add more tests, fix rounding
* Add spacer to balance sidebar network name
* Fix tsc error
* Add offline render CB
* Make more render callbacks
* Transform NonceField into its self contained component
* Remove styling from nonce field
* Better network handling in nonce cb
* Move network nonce initialization to componentDidMount
* Remove unessesary conditional input
* Make nonce component return a BN
* Simplify Query render cb
* Add gas query and token query render cbs
* Re-write address field component, strip out ENS name functionality for now
* Add address and data as unit types
* Cleanup Address Field component
* Export gas query
* Re-write gas field component
* Cleanup gas estimation check
* Re-write Data field
* Transaction field skeleton
* Export transaction field actions
* Rename fields to map to ethtx fields
* Make reducers for fields
* Fix reducer module exports
* Export reducer
* Formatting fix
* Type return of GasQuery
* Add transaction field getter / setter component
* Make transaction fields more flexible
* Formatting fix
* Split transaction fields component into two
* Remove erroneous prop
* Fix field naming to follow ethereum transaction fields
* Merge valid prop into componeent
* Change address field to be redux based
* Convert nonce field to redux based
* Make component for passing in current transaction
* Re-write Gas component to use redux state
* Reduxify data field component
* seperate transaction fields redux state into field data and meta data
* Rename SetTransactionFields to be singular
* Make render callback components for getting/setting meta fields
* Add non-zero option prop for token balance render cb
* re-write unit dropdown component to be redux based
* Make ether the first option
* Fix tsc error on tokenquery
* Handle query string default values in unit drop down
* Add thunks to package
* Add helper function for encoding transfer data
* Handle co-dependencies between fields via thunks, seperate value fields into ether and token based
* Fix wrong typing
* Add token metafield as export
* Start scaffolding out amount field component
* Make render cbs for conditional selection of value and balance
* Make render callbacks nullable
* Progress commit -- get dynaming swapping between tokens and ether working
* Get gas estimation working between ether and tokens
* Remove nonce from breaking gas estimation
* Add better validation for amount field
* Add 500ms debounce to gas saga
* Self contain custom message component
* Add web3 awareness to wallet render cb
* Add render cb for checking if wallet is unlocked
* Cleanup inline typing
* export available params
* Add render cb to render component when a query string exists
* Add boolean callback param that check that the transaction is filled by user
* Remove uneeded typings from send transaction
* Fix misnomer
* Self contain generate transaction button
* Compartmentalize more send transaction components
* Add query string warning, custom message and generate tx button to fields
* Cleanup send tx component with new components
* export render callbacks
* saga transaction scaffolding
* make gas saga fully declarative
* transaction lib renaming
* Seperate gasprice into its own generator
* Make action creators for tx sign actions
* Clean up signing saga, introduce reducer for signing, make HW wallet libs compatible with new tx format, fix some typing with ethereumjs-tx
* Add TransactionComparison component
* Add pushTx
* Progress commit -- Streamline web3 and local signing / broadcasting flows. Need to still implement reducers for broadcasting and notifications
* Get local transaction broadcasting working
* re-write confirmation modal to be redux based
* Fix spacing and import
* Move confirmation modal to be attached to send button, create send button
* Properly handle broadcasting for conf modal
* Handle gas cost > balance for send everything
* Add signing status as its own component (#454)
* Fix ledger errors not showing on notifs
* Make dedicated actions for swapping from tokens to ether and ether to tokens
* Split actionTypes file
* Cleanup comments
* Cleanup comments
* Fix various tsc errors
* Lay down infrastructure for saving configurations per-wallet.
* Add pending and rejected states properly to token values.
* Add custom token form improvements.
* Fix metamask transaction errors
* Fix send entire balance estimation
* Fix add token form from never being enabled.
* Initial pass at account tab with send and view wallet tabs.
* Fix inactive tab.
* Hide private key, toggling
* Progress commit -- Replacing render callbacks with selectors, put validation logic in sagas
* Moved the restore keystore functionality to view wallet info, and put it in a modal / util file.
* Fix navigation link active
* Force read only wallets to info tab.
* Remove commented code
* Saga-ify send everything
* Scan for new tokens, track saved tokens, only request tracked tokens on initial load.
* Add custom token to current wallets tracked tokens.
* Rework remove token icon.
* Adjust button margin
* Remove the rest of the needless render callbacks for selectors, sagaify nonce
* Bug fix send transaction
* remove unused redux-thunk
* Move fields to general components
* Clean up saga structure
* Refactor broadcast tx
* Implement better validation logic, get contract deploy working
* PR feedback.
* Convert tokenbalances component to connected redux component.
* Addressed feedback from Henry.
* Progress commit -- Implement Interact logic, needs manual testing
* Get rid of commented code
* move exports after declarations
* add tests, rough draft
* Get contract method calls working
* Bugfix contracts
* Cleanup hex prefixing
* Reset transaction state on wallet change
* Get rid of old send transaction component
* Disable sign transaction button when network request is underway
* Flatten send button tree, make nonce human readable in confirmation modal
* Add ghetto cost breakdown component, fix token field validation
* Create Generic SubTab and use in Send
* MVP of mnemonics with sub-tabs in Create Wallet view.
* Do dynamic revalidation
* move exports after declarations
* add forgotten signing tests
* update token spec
* update currentValue spec
* update validationHelpers spec
* Address TODO - use injected history to push navigation state instead of hardcoding window.location
* Use SubTabs in Contracts
* Fix revertPath prop for AcceptOrRedirectModal
* Use subtabs in SignAndVerifyMessage
* Routing for subtabs
* Fix routes, adjust sizing.
* Remove unused import
* Request nonce in base 10
* Add offline override to unit display
* Make cost breakdown less buggy
* Add non standard transaction warning
* Fix amount validity
* Cleanup datafield validity
* Display notif on gas estimation failure
* Add post-signing verification against fields, clean up gas price
* Fix tsc errors
* Code cleanup
* add exports to functions
* add specs for sendEverything and reset sagas
* delete duplicate files
* make tslint happy
* Merge develop
* Fix develop regressions
* Delegate nonce pulling to wallet being set
* Clarify non standard transaction
* Make address a buffer to avoid leading 0's bug
* Clarify validation helper comment
* Increase debounce time, add console error
* Better validation for non-standard transactions
* Add verification skipping for broadcasting txs
* Fix state and wallet resetting for contract tabs
* Fix some spec files, remove contract.spec
* Remove broadcasting specs from wallet
* Close DeterministicWalletModal on confirm
* Revert "Close DeterministicWalletModal on confirm"
This reverts commit 16c860e854ca29e9de754164d8be5e24f722cbad.
* Reset hardware wallet state on unlocking. Dont render walletdecrypt content when its hidden.
* Fix client side broadcast checking
* Add more state resetters in error scenarios
* Fix gas estimation
* Add validation for value transactions to contract creation
* Add transaction comparaision differentiation depending on wallet type
* Fix token row display balance showing twice
* Properly handle failed transactions
* Handle bad error messages
* fix broken tests
* fix broken test
* Progress commit -- Implement generic subtab types
* Remove react router v3
* Remove unused routes
* Clean up Tabbing code, add onTabChange handler
* Fix tests
* Add nav fix
* revert opinionated sub-tab implementation
* additional reverts
* Add decimal validation
* Make gas price single source of truth, dont save any transaction state other than gas price
* Get rid of old wallet.spec reducer tests
* Add decimal validation when re-validating gasCost
* remove utilities view
* Remove cost breakdown
* Remove local gas estimation warning
* Create getShownTokenBalances selector; use in UnitDropDown and Equivalent Values
* Convert reducers to switch case
* Clean tsc errors
* Fix failing test
* fix tscheck error
* Add number validation to gas field
* Fix misaligned input dropdown
* Revert "Fix misaligned input dropdown"
This reverts commit a40a4c0e8d52471dea01e6727f741a737b798695.
* Set window timeout long enough for node switch to be persisted to state
* Transaction Refactor Style Fixes (#615)
* Fix unit dropdown alignment by rendering it in AmountField, and fixing a missed bootstrap case.
* Fix modal amount and gas text.
* Fix misaligned dropdown
* Update conditions for NavLink is-active class
2017-12-18 21:23:31 +00:00
|
|
|
export const isValidNonce = (value: string): boolean => {
|
|
|
|
let valid;
|
|
|
|
if (value === '0') {
|
|
|
|
valid = true;
|
|
|
|
} else if (!value) {
|
|
|
|
valid = false;
|
|
|
|
} else {
|
|
|
|
valid = isPositiveInteger(+value);
|
|
|
|
}
|
|
|
|
return valid;
|
|
|
|
};
|
|
|
|
|
2018-03-07 23:36:05 +00:00
|
|
|
function isValidResult(response: JsonRpcResponse, schemaFormat: typeof schema.RpcNode): boolean {
|
2017-11-30 05:35:17 +00:00
|
|
|
return v.validate(response, schemaFormat).valid;
|
|
|
|
}
|
|
|
|
|
|
|
|
function formatErrors(response: JsonRpcResponse, apiType: string) {
|
|
|
|
if (response.error) {
|
2018-01-29 22:17:58 +00:00
|
|
|
// Metamask errors are sometimes full-blown stacktraces, no bueno. Instead,
|
|
|
|
// We'll just take the first line of it, and the last thing after all of
|
|
|
|
// the colons. An example error message would be:
|
|
|
|
// "Error: Metamask Sign Tx Error: User rejected the signature."
|
|
|
|
const lines = response.error.message.split('\n');
|
|
|
|
if (lines.length > 2) {
|
|
|
|
return lines[0].split(':').pop();
|
|
|
|
} else {
|
|
|
|
return `${response.error.message} ${response.error.data || ''}`;
|
|
|
|
}
|
2017-11-30 05:35:17 +00:00
|
|
|
}
|
|
|
|
return `Invalid ${apiType} Error`;
|
|
|
|
}
|
|
|
|
|
2018-03-07 23:36:05 +00:00
|
|
|
enum API_NAME {
|
|
|
|
Get_Balance = 'Get Balance',
|
|
|
|
Estimate_Gas = 'Estimate Gas',
|
|
|
|
Call_Request = 'Call Request',
|
|
|
|
Token_Balance = 'Token Balance',
|
|
|
|
Transaction_Count = 'Transaction Count',
|
|
|
|
Current_Block = 'Current Block',
|
|
|
|
Raw_Tx = 'Raw Tx',
|
|
|
|
Send_Transaction = 'Send Transaction',
|
|
|
|
Sign_Message = 'Sign Message',
|
|
|
|
Get_Accounts = 'Get Accounts',
|
|
|
|
Net_Version = 'Net Version',
|
|
|
|
Transaction_By_Hash = 'Transaction By Hash',
|
|
|
|
Transaction_Receipt = 'Transaction Receipt'
|
|
|
|
}
|
|
|
|
|
2017-12-19 22:46:34 +00:00
|
|
|
const isValidEthCall = (response: JsonRpcResponse, schemaType: typeof schema.RpcNode) => (
|
2018-03-07 23:36:05 +00:00
|
|
|
apiName: API_NAME,
|
|
|
|
cb?: (res: JsonRpcResponse) => any
|
2017-12-19 22:46:34 +00:00
|
|
|
) => {
|
2017-11-30 05:35:17 +00:00
|
|
|
if (!isValidResult(response, schemaType)) {
|
|
|
|
if (cb) {
|
|
|
|
return cb(response);
|
|
|
|
}
|
|
|
|
throw new Error(formatErrors(response, apiName));
|
|
|
|
}
|
|
|
|
return response;
|
|
|
|
};
|
|
|
|
|
|
|
|
export const isValidGetBalance = (response: JsonRpcResponse) =>
|
2018-03-07 23:36:05 +00:00
|
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Get_Balance);
|
2017-11-30 05:35:17 +00:00
|
|
|
|
|
|
|
export const isValidEstimateGas = (response: JsonRpcResponse) =>
|
2018-03-07 23:36:05 +00:00
|
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Estimate_Gas);
|
2017-11-30 05:35:17 +00:00
|
|
|
|
|
|
|
export const isValidCallRequest = (response: JsonRpcResponse) =>
|
2018-03-07 23:36:05 +00:00
|
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Call_Request);
|
2017-11-30 05:35:17 +00:00
|
|
|
|
|
|
|
export const isValidTokenBalance = (response: JsonRpcResponse) =>
|
2018-03-07 23:36:05 +00:00
|
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Token_Balance, () => ({
|
2017-11-30 05:35:17 +00:00
|
|
|
result: 'Failed'
|
|
|
|
}));
|
|
|
|
|
|
|
|
export const isValidTransactionCount = (response: JsonRpcResponse) =>
|
2018-03-07 23:36:05 +00:00
|
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Transaction_Count);
|
2017-11-30 05:35:17 +00:00
|
|
|
|
2018-02-16 16:57:23 +00:00
|
|
|
export const isValidTransactionByHash = (response: JsonRpcResponse) =>
|
2018-03-07 23:36:05 +00:00
|
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Transaction_By_Hash);
|
2018-02-16 16:57:23 +00:00
|
|
|
|
|
|
|
export const isValidTransactionReceipt = (response: JsonRpcResponse) =>
|
2018-03-07 23:36:05 +00:00
|
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Transaction_Receipt);
|
2018-02-16 16:57:23 +00:00
|
|
|
|
2017-11-30 05:35:17 +00:00
|
|
|
export const isValidCurrentBlock = (response: JsonRpcResponse) =>
|
2018-03-07 23:36:05 +00:00
|
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Current_Block);
|
2017-11-30 05:35:17 +00:00
|
|
|
|
|
|
|
export const isValidRawTxApi = (response: JsonRpcResponse) =>
|
2018-03-07 23:36:05 +00:00
|
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Raw_Tx);
|
2017-12-01 16:32:29 +00:00
|
|
|
|
|
|
|
export const isValidSendTransaction = (response: JsonRpcResponse) =>
|
2018-03-07 23:36:05 +00:00
|
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Send_Transaction);
|
2017-12-01 16:32:29 +00:00
|
|
|
|
|
|
|
export const isValidSignMessage = (response: JsonRpcResponse) =>
|
2018-03-07 23:36:05 +00:00
|
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Sign_Message);
|
2017-12-01 16:32:29 +00:00
|
|
|
|
|
|
|
export const isValidGetAccounts = (response: JsonRpcResponse) =>
|
2018-03-07 23:36:05 +00:00
|
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Get_Accounts);
|
2017-12-01 16:32:29 +00:00
|
|
|
|
|
|
|
export const isValidGetNetVersion = (response: JsonRpcResponse) =>
|
2018-03-07 23:36:05 +00:00
|
|
|
isValidEthCall(response, schema.RpcNode)(API_NAME.Net_Version);
|
2018-02-16 16:57:23 +00:00
|
|
|
export const isValidTxHash = (hash: string) =>
|
|
|
|
hash.substring(0, 2) === '0x' && hash.length === 66 && isValidHex(hash);
|