MyCrypto/common/libs/transaction.ts

280 lines
7.6 KiB
TypeScript
Raw Normal View History

Migrate to Typescript (#224) * Refactor babel/types * Refactor entry point * Refactor actions * Refactor api * Full project refactor -- Broad type fixing sweep * - completely fix merge conflicts - handle various type errors * Add tslint to package.json * Dependency cleanup * Fix module resolution * Work on type definitions for untyped libs * progress commit * Add more definition typing * various type additions * Add unit types * Fix sagaiterator + unit types * various types added * additional type additions * Fix typing on Sagas * remove flowfixmes; swap translate for translateRaw * Get rid of contracts - awaiting Henry's contract PR * Remove contracts from routing * Fix most of actions/reducers * refactor actions directory structure * fix reducer action type imports * Fix most of type errors pre-actions refactor * fix action creator imports in containers * Refactor more * Refactor index of actions * fix action imports; use module level index export * package-lock.json updated * Use action types in props * Type up action creators * Fix most of connect errors * Typefixing progress * More types * Fix run-time errors * Caching improvements for webpack * Remove path resolve from webpack * Update non-breaking packages to latest version * Fix token typing * Remove unused color code * Fix wallet decrypt dispatch * Set redux-form related props/functions to ANY, since we're stripping it out later on * Revert BigNumber.js package changes * Extend window to custom object for Perf * Format Navigation * Typecase keystore errors as any (since we shouldnt touch this) * Push wallet context fix * - find/replace value->payload in swap - properly type swap state properties - extract inline reducer into reducer function * - type local storage retrieved items as generic * - bind all RPCClient methods with fat arrow * - reformat * Change to enums for constants * Change state into any * Fix swap errors * ensure that seconds are passed into state as integers * Fix rest of errors * use parseInt explicitly instead of type coercion * Fix derivation-checker, remove flow command, add tslint command, add tslint-react, tell travis to use tslint instead of flow. * Whoops, remove those tests. * Remove unsupported (yet) config option. * Fix precommit to target ts and tsx files. * Fix some errors, ignore some silly rules. * Revert jest to v19, use ts-jest and make all tests typescript. Fixes all but one. * Get rid of saga tests * Fix tslint errors
2017-09-25 02:06:28 +00:00
import { Token } from 'config/data';
import EthTx from 'ethereumjs-tx';
import { addHexPrefix, padToEven, toChecksumAddress } from 'ethereumjs-util';
import ERC20 from 'libs/erc20';
import { TransactionWithoutGas } from 'libs/messages';
Migrate to Typescript (#224) * Refactor babel/types * Refactor entry point * Refactor actions * Refactor api * Full project refactor -- Broad type fixing sweep * - completely fix merge conflicts - handle various type errors * Add tslint to package.json * Dependency cleanup * Fix module resolution * Work on type definitions for untyped libs * progress commit * Add more definition typing * various type additions * Add unit types * Fix sagaiterator + unit types * various types added * additional type additions * Fix typing on Sagas * remove flowfixmes; swap translate for translateRaw * Get rid of contracts - awaiting Henry's contract PR * Remove contracts from routing * Fix most of actions/reducers * refactor actions directory structure * fix reducer action type imports * Fix most of type errors pre-actions refactor * fix action creator imports in containers * Refactor more * Refactor index of actions * fix action imports; use module level index export * package-lock.json updated * Use action types in props * Type up action creators * Fix most of connect errors * Typefixing progress * More types * Fix run-time errors * Caching improvements for webpack * Remove path resolve from webpack * Update non-breaking packages to latest version * Fix token typing * Remove unused color code * Fix wallet decrypt dispatch * Set redux-form related props/functions to ANY, since we're stripping it out later on * Revert BigNumber.js package changes * Extend window to custom object for Perf * Format Navigation * Typecase keystore errors as any (since we shouldnt touch this) * Push wallet context fix * - find/replace value->payload in swap - properly type swap state properties - extract inline reducer into reducer function * - type local storage retrieved items as generic * - bind all RPCClient methods with fat arrow * - reformat * Change to enums for constants * Change state into any * Fix swap errors * ensure that seconds are passed into state as integers * Fix rest of errors * use parseInt explicitly instead of type coercion * Fix derivation-checker, remove flow command, add tslint command, add tslint-react, tell travis to use tslint instead of flow. * Whoops, remove those tests. * Remove unsupported (yet) config option. * Fix precommit to target ts and tsx files. * Fix some errors, ignore some silly rules. * Revert jest to v19, use ts-jest and make all tests typescript. Fixes all but one. * Get rid of saga tests * Fix tslint errors
2017-09-25 02:06:28 +00:00
import { RPCNode } from 'libs/nodes';
import { INode } from 'libs/nodes/INode';
import { Ether, toTokenUnit, UnitKey, Wei } from 'libs/units';
import { isValidETHAddress } from 'libs/validators';
import { stripHexPrefixAndLower, valueToHex } from 'libs/values';
import { IWallet } from 'libs/wallet';
import translate, { translateRaw } from 'translations';
Offline Send (#276) * offline-send mvp * cleanup unneeded imports * - create pollOfflineStatus action, action creator, interface * expand UnlockHeader when collapse-button is clicked, instead of div * kick-off pollOfflineStatus upon SendTransaction mount. * Create sagas for polling offline status * remove comment * - create CONFIG_FORCE_OFFLINE action, action creator, interface * Adjust OfflineToggle terms to "Force Online/Offline", and understand when forced offline and when really offline. * - Assume offline in SendTransaction when either offline or forcedOffline * - handle forceOffline action in reducer - adjust state type / provide default state for forceOffline in config reducer * adjust test to pass with different key name * fix incorrect import * - allow size to be specified in offline toggle * - Decode and display nonce in confirmation modal * - set default nonces when forced offline and have online connectivity based on transaction count - pass nonce to generateCompleteTransaction - refactor componentDidUpdate * Allow optional nonce to be passed to generateCompleteTransaction * - create stripHexPrefix function * - cleanup sagas * move getParam into helper util * update address on component update * - show spinner while transaction is being signed - reset state when wallet instance changes (new wallet instantiated via UnlockHeader) * center-align offline message * Adjust force offline/online button text * - validate nonces when offline - only estimate gas when online - don't show send tx button when offline * - break generateCompleteTransactionFromRawTransaction into multiple functions. - support offline generation in generateCompleteTransaction (and generateCompleteTransactionFromRawTransaction). Balance checking is now only done when not offline to support offline generation. * Create Help component (to be used as a tooltip) * Disable hardware wallets when offline. * Hide Send Entire Balance when balance is falsy * Show help icon in nonce field. * - show helper instructions on how to broadcast when user is offline after generating a tx - hardcoded gas limits when offline - refactors * create isPositiveInteger helper function * fix nonce validation * really fix nonce validation (specifically the input highlighting) * remove stray // @flow's * remove offline tab nav * remove unused action arg * address PR comments
2017-10-11 05:04:49 +00:00
import Big, { BigNumber } from 'bignumber.js';
Migrate to Typescript (#224) * Refactor babel/types * Refactor entry point * Refactor actions * Refactor api * Full project refactor -- Broad type fixing sweep * - completely fix merge conflicts - handle various type errors * Add tslint to package.json * Dependency cleanup * Fix module resolution * Work on type definitions for untyped libs * progress commit * Add more definition typing * various type additions * Add unit types * Fix sagaiterator + unit types * various types added * additional type additions * Fix typing on Sagas * remove flowfixmes; swap translate for translateRaw * Get rid of contracts - awaiting Henry's contract PR * Remove contracts from routing * Fix most of actions/reducers * refactor actions directory structure * fix reducer action type imports * Fix most of type errors pre-actions refactor * fix action creator imports in containers * Refactor more * Refactor index of actions * fix action imports; use module level index export * package-lock.json updated * Use action types in props * Type up action creators * Fix most of connect errors * Typefixing progress * More types * Fix run-time errors * Caching improvements for webpack * Remove path resolve from webpack * Update non-breaking packages to latest version * Fix token typing * Remove unused color code * Fix wallet decrypt dispatch * Set redux-form related props/functions to ANY, since we're stripping it out later on * Revert BigNumber.js package changes * Extend window to custom object for Perf * Format Navigation * Typecase keystore errors as any (since we shouldnt touch this) * Push wallet context fix * - find/replace value->payload in swap - properly type swap state properties - extract inline reducer into reducer function * - type local storage retrieved items as generic * - bind all RPCClient methods with fat arrow * - reformat * Change to enums for constants * Change state into any * Fix swap errors * ensure that seconds are passed into state as integers * Fix rest of errors * use parseInt explicitly instead of type coercion * Fix derivation-checker, remove flow command, add tslint command, add tslint-react, tell travis to use tslint instead of flow. * Whoops, remove those tests. * Remove unsupported (yet) config option. * Fix precommit to target ts and tsx files. * Fix some errors, ignore some silly rules. * Revert jest to v19, use ts-jest and make all tests typescript. Fixes all but one. * Get rid of saga tests * Fix tslint errors
2017-09-25 02:06:28 +00:00
export interface TransactionInput {
token?: Token | null;
unit: UnitKey;
value: string;
to: string;
data: string;
}
Migrate to Typescript (#224) * Refactor babel/types * Refactor entry point * Refactor actions * Refactor api * Full project refactor -- Broad type fixing sweep * - completely fix merge conflicts - handle various type errors * Add tslint to package.json * Dependency cleanup * Fix module resolution * Work on type definitions for untyped libs * progress commit * Add more definition typing * various type additions * Add unit types * Fix sagaiterator + unit types * various types added * additional type additions * Fix typing on Sagas * remove flowfixmes; swap translate for translateRaw * Get rid of contracts - awaiting Henry's contract PR * Remove contracts from routing * Fix most of actions/reducers * refactor actions directory structure * fix reducer action type imports * Fix most of type errors pre-actions refactor * fix action creator imports in containers * Refactor more * Refactor index of actions * fix action imports; use module level index export * package-lock.json updated * Use action types in props * Type up action creators * Fix most of connect errors * Typefixing progress * More types * Fix run-time errors * Caching improvements for webpack * Remove path resolve from webpack * Update non-breaking packages to latest version * Fix token typing * Remove unused color code * Fix wallet decrypt dispatch * Set redux-form related props/functions to ANY, since we're stripping it out later on * Revert BigNumber.js package changes * Extend window to custom object for Perf * Format Navigation * Typecase keystore errors as any (since we shouldnt touch this) * Push wallet context fix * - find/replace value->payload in swap - properly type swap state properties - extract inline reducer into reducer function * - type local storage retrieved items as generic * - bind all RPCClient methods with fat arrow * - reformat * Change to enums for constants * Change state into any * Fix swap errors * ensure that seconds are passed into state as integers * Fix rest of errors * use parseInt explicitly instead of type coercion * Fix derivation-checker, remove flow command, add tslint command, add tslint-react, tell travis to use tslint instead of flow. * Whoops, remove those tests. * Remove unsupported (yet) config option. * Fix precommit to target ts and tsx files. * Fix some errors, ignore some silly rules. * Revert jest to v19, use ts-jest and make all tests typescript. Fixes all but one. * Get rid of saga tests * Fix tslint errors
2017-09-25 02:06:28 +00:00
export interface BroadcastTransactionStatus {
isBroadcasting: boolean;
signedTx: string;
successfullyBroadcast: boolean;
}
Migrate to Typescript (#224) * Refactor babel/types * Refactor entry point * Refactor actions * Refactor api * Full project refactor -- Broad type fixing sweep * - completely fix merge conflicts - handle various type errors * Add tslint to package.json * Dependency cleanup * Fix module resolution * Work on type definitions for untyped libs * progress commit * Add more definition typing * various type additions * Add unit types * Fix sagaiterator + unit types * various types added * additional type additions * Fix typing on Sagas * remove flowfixmes; swap translate for translateRaw * Get rid of contracts - awaiting Henry's contract PR * Remove contracts from routing * Fix most of actions/reducers * refactor actions directory structure * fix reducer action type imports * Fix most of type errors pre-actions refactor * fix action creator imports in containers * Refactor more * Refactor index of actions * fix action imports; use module level index export * package-lock.json updated * Use action types in props * Type up action creators * Fix most of connect errors * Typefixing progress * More types * Fix run-time errors * Caching improvements for webpack * Remove path resolve from webpack * Update non-breaking packages to latest version * Fix token typing * Remove unused color code * Fix wallet decrypt dispatch * Set redux-form related props/functions to ANY, since we're stripping it out later on * Revert BigNumber.js package changes * Extend window to custom object for Perf * Format Navigation * Typecase keystore errors as any (since we shouldnt touch this) * Push wallet context fix * - find/replace value->payload in swap - properly type swap state properties - extract inline reducer into reducer function * - type local storage retrieved items as generic * - bind all RPCClient methods with fat arrow * - reformat * Change to enums for constants * Change state into any * Fix swap errors * ensure that seconds are passed into state as integers * Fix rest of errors * use parseInt explicitly instead of type coercion * Fix derivation-checker, remove flow command, add tslint command, add tslint-react, tell travis to use tslint instead of flow. * Whoops, remove those tests. * Remove unsupported (yet) config option. * Fix precommit to target ts and tsx files. * Fix some errors, ignore some silly rules. * Revert jest to v19, use ts-jest and make all tests typescript. Fixes all but one. * Get rid of saga tests * Fix tslint errors
2017-09-25 02:06:28 +00:00
export interface BaseTransaction {
to: string;
value: string;
data: string;
gasLimit: BigNumber | string;
gasPrice: Wei | string;
chainId: number;
}
Migrate to Typescript (#224) * Refactor babel/types * Refactor entry point * Refactor actions * Refactor api * Full project refactor -- Broad type fixing sweep * - completely fix merge conflicts - handle various type errors * Add tslint to package.json * Dependency cleanup * Fix module resolution * Work on type definitions for untyped libs * progress commit * Add more definition typing * various type additions * Add unit types * Fix sagaiterator + unit types * various types added * additional type additions * Fix typing on Sagas * remove flowfixmes; swap translate for translateRaw * Get rid of contracts - awaiting Henry's contract PR * Remove contracts from routing * Fix most of actions/reducers * refactor actions directory structure * fix reducer action type imports * Fix most of type errors pre-actions refactor * fix action creator imports in containers * Refactor more * Refactor index of actions * fix action imports; use module level index export * package-lock.json updated * Use action types in props * Type up action creators * Fix most of connect errors * Typefixing progress * More types * Fix run-time errors * Caching improvements for webpack * Remove path resolve from webpack * Update non-breaking packages to latest version * Fix token typing * Remove unused color code * Fix wallet decrypt dispatch * Set redux-form related props/functions to ANY, since we're stripping it out later on * Revert BigNumber.js package changes * Extend window to custom object for Perf * Format Navigation * Typecase keystore errors as any (since we shouldnt touch this) * Push wallet context fix * - find/replace value->payload in swap - properly type swap state properties - extract inline reducer into reducer function * - type local storage retrieved items as generic * - bind all RPCClient methods with fat arrow * - reformat * Change to enums for constants * Change state into any * Fix swap errors * ensure that seconds are passed into state as integers * Fix rest of errors * use parseInt explicitly instead of type coercion * Fix derivation-checker, remove flow command, add tslint command, add tslint-react, tell travis to use tslint instead of flow. * Whoops, remove those tests. * Remove unsupported (yet) config option. * Fix precommit to target ts and tsx files. * Fix some errors, ignore some silly rules. * Revert jest to v19, use ts-jest and make all tests typescript. Fixes all but one. * Get rid of saga tests * Fix tslint errors
2017-09-25 02:06:28 +00:00
export interface RawTransaction extends BaseTransaction {
nonce: string;
}
Migrate to Typescript (#224) * Refactor babel/types * Refactor entry point * Refactor actions * Refactor api * Full project refactor -- Broad type fixing sweep * - completely fix merge conflicts - handle various type errors * Add tslint to package.json * Dependency cleanup * Fix module resolution * Work on type definitions for untyped libs * progress commit * Add more definition typing * various type additions * Add unit types * Fix sagaiterator + unit types * various types added * additional type additions * Fix typing on Sagas * remove flowfixmes; swap translate for translateRaw * Get rid of contracts - awaiting Henry's contract PR * Remove contracts from routing * Fix most of actions/reducers * refactor actions directory structure * fix reducer action type imports * Fix most of type errors pre-actions refactor * fix action creator imports in containers * Refactor more * Refactor index of actions * fix action imports; use module level index export * package-lock.json updated * Use action types in props * Type up action creators * Fix most of connect errors * Typefixing progress * More types * Fix run-time errors * Caching improvements for webpack * Remove path resolve from webpack * Update non-breaking packages to latest version * Fix token typing * Remove unused color code * Fix wallet decrypt dispatch * Set redux-form related props/functions to ANY, since we're stripping it out later on * Revert BigNumber.js package changes * Extend window to custom object for Perf * Format Navigation * Typecase keystore errors as any (since we shouldnt touch this) * Push wallet context fix * - find/replace value->payload in swap - properly type swap state properties - extract inline reducer into reducer function * - type local storage retrieved items as generic * - bind all RPCClient methods with fat arrow * - reformat * Change to enums for constants * Change state into any * Fix swap errors * ensure that seconds are passed into state as integers * Fix rest of errors * use parseInt explicitly instead of type coercion * Fix derivation-checker, remove flow command, add tslint command, add tslint-react, tell travis to use tslint instead of flow. * Whoops, remove those tests. * Remove unsupported (yet) config option. * Fix precommit to target ts and tsx files. * Fix some errors, ignore some silly rules. * Revert jest to v19, use ts-jest and make all tests typescript. Fixes all but one. * Get rid of saga tests * Fix tslint errors
2017-09-25 02:06:28 +00:00
export interface ExtendedRawTransaction extends RawTransaction {
// non-standard, legacy
Migrate to Typescript (#224) * Refactor babel/types * Refactor entry point * Refactor actions * Refactor api * Full project refactor -- Broad type fixing sweep * - completely fix merge conflicts - handle various type errors * Add tslint to package.json * Dependency cleanup * Fix module resolution * Work on type definitions for untyped libs * progress commit * Add more definition typing * various type additions * Add unit types * Fix sagaiterator + unit types * various types added * additional type additions * Fix typing on Sagas * remove flowfixmes; swap translate for translateRaw * Get rid of contracts - awaiting Henry's contract PR * Remove contracts from routing * Fix most of actions/reducers * refactor actions directory structure * fix reducer action type imports * Fix most of type errors pre-actions refactor * fix action creator imports in containers * Refactor more * Refactor index of actions * fix action imports; use module level index export * package-lock.json updated * Use action types in props * Type up action creators * Fix most of connect errors * Typefixing progress * More types * Fix run-time errors * Caching improvements for webpack * Remove path resolve from webpack * Update non-breaking packages to latest version * Fix token typing * Remove unused color code * Fix wallet decrypt dispatch * Set redux-form related props/functions to ANY, since we're stripping it out later on * Revert BigNumber.js package changes * Extend window to custom object for Perf * Format Navigation * Typecase keystore errors as any (since we shouldnt touch this) * Push wallet context fix * - find/replace value->payload in swap - properly type swap state properties - extract inline reducer into reducer function * - type local storage retrieved items as generic * - bind all RPCClient methods with fat arrow * - reformat * Change to enums for constants * Change state into any * Fix swap errors * ensure that seconds are passed into state as integers * Fix rest of errors * use parseInt explicitly instead of type coercion * Fix derivation-checker, remove flow command, add tslint command, add tslint-react, tell travis to use tslint instead of flow. * Whoops, remove those tests. * Remove unsupported (yet) config option. * Fix precommit to target ts and tsx files. * Fix some errors, ignore some silly rules. * Revert jest to v19, use ts-jest and make all tests typescript. Fixes all but one. * Get rid of saga tests * Fix tslint errors
2017-09-25 02:06:28 +00:00
from: string;
}
Migrate to Typescript (#224) * Refactor babel/types * Refactor entry point * Refactor actions * Refactor api * Full project refactor -- Broad type fixing sweep * - completely fix merge conflicts - handle various type errors * Add tslint to package.json * Dependency cleanup * Fix module resolution * Work on type definitions for untyped libs * progress commit * Add more definition typing * various type additions * Add unit types * Fix sagaiterator + unit types * various types added * additional type additions * Fix typing on Sagas * remove flowfixmes; swap translate for translateRaw * Get rid of contracts - awaiting Henry's contract PR * Remove contracts from routing * Fix most of actions/reducers * refactor actions directory structure * fix reducer action type imports * Fix most of type errors pre-actions refactor * fix action creator imports in containers * Refactor more * Refactor index of actions * fix action imports; use module level index export * package-lock.json updated * Use action types in props * Type up action creators * Fix most of connect errors * Typefixing progress * More types * Fix run-time errors * Caching improvements for webpack * Remove path resolve from webpack * Update non-breaking packages to latest version * Fix token typing * Remove unused color code * Fix wallet decrypt dispatch * Set redux-form related props/functions to ANY, since we're stripping it out later on * Revert BigNumber.js package changes * Extend window to custom object for Perf * Format Navigation * Typecase keystore errors as any (since we shouldnt touch this) * Push wallet context fix * - find/replace value->payload in swap - properly type swap state properties - extract inline reducer into reducer function * - type local storage retrieved items as generic * - bind all RPCClient methods with fat arrow * - reformat * Change to enums for constants * Change state into any * Fix swap errors * ensure that seconds are passed into state as integers * Fix rest of errors * use parseInt explicitly instead of type coercion * Fix derivation-checker, remove flow command, add tslint command, add tslint-react, tell travis to use tslint instead of flow. * Whoops, remove those tests. * Remove unsupported (yet) config option. * Fix precommit to target ts and tsx files. * Fix some errors, ignore some silly rules. * Revert jest to v19, use ts-jest and make all tests typescript. Fixes all but one. * Get rid of saga tests * Fix tslint errors
2017-09-25 02:06:28 +00:00
export interface CompleteTransaction extends RawTransaction {
rawTx: string;
signedTx: string;
}
// Get useable fields from an EthTx object.
export function getTransactionFields(tx: EthTx) {
// For some crazy reason, toJSON spits out an array, not keyed values.
const [nonce, gasPrice, gasLimit, to, value, data, v, r, s] = tx.toJSON();
return {
// No value comes back as '0x', but most things expect '0x00'
value: value === '0x' ? '0x00' : value,
// If data is 0x, it might as well not be there
data: data === '0x' ? null : data,
// To address is unchecksummed, which could cause mismatches in comparisons
to: toChecksumAddress(to),
// Everything else is as-is
nonce,
gasPrice,
gasLimit,
v,
r,
s
};
}
Offline Send (#276) * offline-send mvp * cleanup unneeded imports * - create pollOfflineStatus action, action creator, interface * expand UnlockHeader when collapse-button is clicked, instead of div * kick-off pollOfflineStatus upon SendTransaction mount. * Create sagas for polling offline status * remove comment * - create CONFIG_FORCE_OFFLINE action, action creator, interface * Adjust OfflineToggle terms to "Force Online/Offline", and understand when forced offline and when really offline. * - Assume offline in SendTransaction when either offline or forcedOffline * - handle forceOffline action in reducer - adjust state type / provide default state for forceOffline in config reducer * adjust test to pass with different key name * fix incorrect import * - allow size to be specified in offline toggle * - Decode and display nonce in confirmation modal * - set default nonces when forced offline and have online connectivity based on transaction count - pass nonce to generateCompleteTransaction - refactor componentDidUpdate * Allow optional nonce to be passed to generateCompleteTransaction * - create stripHexPrefix function * - cleanup sagas * move getParam into helper util * update address on component update * - show spinner while transaction is being signed - reset state when wallet instance changes (new wallet instantiated via UnlockHeader) * center-align offline message * Adjust force offline/online button text * - validate nonces when offline - only estimate gas when online - don't show send tx button when offline * - break generateCompleteTransactionFromRawTransaction into multiple functions. - support offline generation in generateCompleteTransaction (and generateCompleteTransactionFromRawTransaction). Balance checking is now only done when not offline to support offline generation. * Create Help component (to be used as a tooltip) * Disable hardware wallets when offline. * Hide Send Entire Balance when balance is falsy * Show help icon in nonce field. * - show helper instructions on how to broadcast when user is offline after generating a tx - hardcoded gas limits when offline - refactors * create isPositiveInteger helper function * fix nonce validation * really fix nonce validation (specifically the input highlighting) * remove stray // @flow's * remove offline tab nav * remove unused action arg * address PR comments
2017-10-11 05:04:49 +00:00
function getValue(
token: Token | null | undefined,
tx: ExtendedRawTransaction
): BigNumber {
let value;
if (token) {
value = new Big(ERC20.$transfer(tx.data).value);
} else {
value = new Big(tx.value);
}
return value;
}
async function getBalance(
node: INode,
tx: ExtendedRawTransaction,
Migrate to Typescript (#224) * Refactor babel/types * Refactor entry point * Refactor actions * Refactor api * Full project refactor -- Broad type fixing sweep * - completely fix merge conflicts - handle various type errors * Add tslint to package.json * Dependency cleanup * Fix module resolution * Work on type definitions for untyped libs * progress commit * Add more definition typing * various type additions * Add unit types * Fix sagaiterator + unit types * various types added * additional type additions * Fix typing on Sagas * remove flowfixmes; swap translate for translateRaw * Get rid of contracts - awaiting Henry's contract PR * Remove contracts from routing * Fix most of actions/reducers * refactor actions directory structure * fix reducer action type imports * Fix most of type errors pre-actions refactor * fix action creator imports in containers * Refactor more * Refactor index of actions * fix action imports; use module level index export * package-lock.json updated * Use action types in props * Type up action creators * Fix most of connect errors * Typefixing progress * More types * Fix run-time errors * Caching improvements for webpack * Remove path resolve from webpack * Update non-breaking packages to latest version * Fix token typing * Remove unused color code * Fix wallet decrypt dispatch * Set redux-form related props/functions to ANY, since we're stripping it out later on * Revert BigNumber.js package changes * Extend window to custom object for Perf * Format Navigation * Typecase keystore errors as any (since we shouldnt touch this) * Push wallet context fix * - find/replace value->payload in swap - properly type swap state properties - extract inline reducer into reducer function * - type local storage retrieved items as generic * - bind all RPCClient methods with fat arrow * - reformat * Change to enums for constants * Change state into any * Fix swap errors * ensure that seconds are passed into state as integers * Fix rest of errors * use parseInt explicitly instead of type coercion * Fix derivation-checker, remove flow command, add tslint command, add tslint-react, tell travis to use tslint instead of flow. * Whoops, remove those tests. * Remove unsupported (yet) config option. * Fix precommit to target ts and tsx files. * Fix some errors, ignore some silly rules. * Revert jest to v19, use ts-jest and make all tests typescript. Fixes all but one. * Get rid of saga tests * Fix tslint errors
2017-09-25 02:06:28 +00:00
token: Token | null | undefined
Offline Send (#276) * offline-send mvp * cleanup unneeded imports * - create pollOfflineStatus action, action creator, interface * expand UnlockHeader when collapse-button is clicked, instead of div * kick-off pollOfflineStatus upon SendTransaction mount. * Create sagas for polling offline status * remove comment * - create CONFIG_FORCE_OFFLINE action, action creator, interface * Adjust OfflineToggle terms to "Force Online/Offline", and understand when forced offline and when really offline. * - Assume offline in SendTransaction when either offline or forcedOffline * - handle forceOffline action in reducer - adjust state type / provide default state for forceOffline in config reducer * adjust test to pass with different key name * fix incorrect import * - allow size to be specified in offline toggle * - Decode and display nonce in confirmation modal * - set default nonces when forced offline and have online connectivity based on transaction count - pass nonce to generateCompleteTransaction - refactor componentDidUpdate * Allow optional nonce to be passed to generateCompleteTransaction * - create stripHexPrefix function * - cleanup sagas * move getParam into helper util * update address on component update * - show spinner while transaction is being signed - reset state when wallet instance changes (new wallet instantiated via UnlockHeader) * center-align offline message * Adjust force offline/online button text * - validate nonces when offline - only estimate gas when online - don't show send tx button when offline * - break generateCompleteTransactionFromRawTransaction into multiple functions. - support offline generation in generateCompleteTransaction (and generateCompleteTransactionFromRawTransaction). Balance checking is now only done when not offline to support offline generation. * Create Help component (to be used as a tooltip) * Disable hardware wallets when offline. * Hide Send Entire Balance when balance is falsy * Show help icon in nonce field. * - show helper instructions on how to broadcast when user is offline after generating a tx - hardcoded gas limits when offline - refactors * create isPositiveInteger helper function * fix nonce validation * really fix nonce validation (specifically the input highlighting) * remove stray // @flow's * remove offline tab nav * remove unused action arg * address PR comments
2017-10-11 05:04:49 +00:00
) {
const { from } = tx;
const ETHBalance = await node.getBalance(from);
let balance;
if (token) {
balance = toTokenUnit(await node.getTokenBalance(tx.from, token), token);
} else {
balance = ETHBalance.amount;
}
return {
balance,
ETHBalance
};
}
async function balanceCheck(
node: INode,
tx: ExtendedRawTransaction,
token: Token | null | undefined,
value: BigNumber,
gasCost: Wei
) {
// Ensure their balance exceeds the amount they're sending
const { balance, ETHBalance } = await getBalance(node, tx, token);
if (value.gt(balance)) {
throw new Error(translateRaw('GETH_Balance'));
}
// ensure gas cost is not greaterThan current eth balance
// TODO check that eth balance is not lesser than txAmount + gasCost
if (gasCost.amount.gt(ETHBalance.amount)) {
throw new Error(
`gasCost: ${gasCost.amount} greaterThan ETHBalance: ${ETHBalance.amount}`
);
}
}
function generateTxValidation(
to: string,
token: Token | null | undefined,
data: string,
gasLimit: BigNumber | string,
gasPrice: Wei | string
) {
// Reject bad addresses
if (!isValidETHAddress(to)) {
Migrate to Typescript (#224) * Refactor babel/types * Refactor entry point * Refactor actions * Refactor api * Full project refactor -- Broad type fixing sweep * - completely fix merge conflicts - handle various type errors * Add tslint to package.json * Dependency cleanup * Fix module resolution * Work on type definitions for untyped libs * progress commit * Add more definition typing * various type additions * Add unit types * Fix sagaiterator + unit types * various types added * additional type additions * Fix typing on Sagas * remove flowfixmes; swap translate for translateRaw * Get rid of contracts - awaiting Henry's contract PR * Remove contracts from routing * Fix most of actions/reducers * refactor actions directory structure * fix reducer action type imports * Fix most of type errors pre-actions refactor * fix action creator imports in containers * Refactor more * Refactor index of actions * fix action imports; use module level index export * package-lock.json updated * Use action types in props * Type up action creators * Fix most of connect errors * Typefixing progress * More types * Fix run-time errors * Caching improvements for webpack * Remove path resolve from webpack * Update non-breaking packages to latest version * Fix token typing * Remove unused color code * Fix wallet decrypt dispatch * Set redux-form related props/functions to ANY, since we're stripping it out later on * Revert BigNumber.js package changes * Extend window to custom object for Perf * Format Navigation * Typecase keystore errors as any (since we shouldnt touch this) * Push wallet context fix * - find/replace value->payload in swap - properly type swap state properties - extract inline reducer into reducer function * - type local storage retrieved items as generic * - bind all RPCClient methods with fat arrow * - reformat * Change to enums for constants * Change state into any * Fix swap errors * ensure that seconds are passed into state as integers * Fix rest of errors * use parseInt explicitly instead of type coercion * Fix derivation-checker, remove flow command, add tslint command, add tslint-react, tell travis to use tslint instead of flow. * Whoops, remove those tests. * Remove unsupported (yet) config option. * Fix precommit to target ts and tsx files. * Fix some errors, ignore some silly rules. * Revert jest to v19, use ts-jest and make all tests typescript. Fixes all but one. * Get rid of saga tests * Fix tslint errors
2017-09-25 02:06:28 +00:00
throw new Error(translateRaw('ERROR_5'));
}
// Reject token transactions without data
if (token && !data) {
throw new Error('Tokens must be sent with data');
}
Migrate to Typescript (#224) * Refactor babel/types * Refactor entry point * Refactor actions * Refactor api * Full project refactor -- Broad type fixing sweep * - completely fix merge conflicts - handle various type errors * Add tslint to package.json * Dependency cleanup * Fix module resolution * Work on type definitions for untyped libs * progress commit * Add more definition typing * various type additions * Add unit types * Fix sagaiterator + unit types * various types added * additional type additions * Fix typing on Sagas * remove flowfixmes; swap translate for translateRaw * Get rid of contracts - awaiting Henry's contract PR * Remove contracts from routing * Fix most of actions/reducers * refactor actions directory structure * fix reducer action type imports * Fix most of type errors pre-actions refactor * fix action creator imports in containers * Refactor more * Refactor index of actions * fix action imports; use module level index export * package-lock.json updated * Use action types in props * Type up action creators * Fix most of connect errors * Typefixing progress * More types * Fix run-time errors * Caching improvements for webpack * Remove path resolve from webpack * Update non-breaking packages to latest version * Fix token typing * Remove unused color code * Fix wallet decrypt dispatch * Set redux-form related props/functions to ANY, since we're stripping it out later on * Revert BigNumber.js package changes * Extend window to custom object for Perf * Format Navigation * Typecase keystore errors as any (since we shouldnt touch this) * Push wallet context fix * - find/replace value->payload in swap - properly type swap state properties - extract inline reducer into reducer function * - type local storage retrieved items as generic * - bind all RPCClient methods with fat arrow * - reformat * Change to enums for constants * Change state into any * Fix swap errors * ensure that seconds are passed into state as integers * Fix rest of errors * use parseInt explicitly instead of type coercion * Fix derivation-checker, remove flow command, add tslint command, add tslint-react, tell travis to use tslint instead of flow. * Whoops, remove those tests. * Remove unsupported (yet) config option. * Fix precommit to target ts and tsx files. * Fix some errors, ignore some silly rules. * Revert jest to v19, use ts-jest and make all tests typescript. Fixes all but one. * Get rid of saga tests * Fix tslint errors
2017-09-25 02:06:28 +00:00
if (typeof gasLimit === 'string' || typeof gasPrice === 'string') {
throw Error('Gas Limit and Gas Price should be of type bignumber');
}
// Reject gas limit under 21000 (Minimum for transaction)
// Reject if limit over 5000000
// TODO: Make this dynamic, the limit shifts
if (gasLimit.lessThan(21000)) {
throw new Error('Gas limit must be at least 21000 for transactions');
}
// Reject gasLimit over 5000000gwei
if (gasLimit.greaterThan(5000000)) {
Migrate to Typescript (#224) * Refactor babel/types * Refactor entry point * Refactor actions * Refactor api * Full project refactor -- Broad type fixing sweep * - completely fix merge conflicts - handle various type errors * Add tslint to package.json * Dependency cleanup * Fix module resolution * Work on type definitions for untyped libs * progress commit * Add more definition typing * various type additions * Add unit types * Fix sagaiterator + unit types * various types added * additional type additions * Fix typing on Sagas * remove flowfixmes; swap translate for translateRaw * Get rid of contracts - awaiting Henry's contract PR * Remove contracts from routing * Fix most of actions/reducers * refactor actions directory structure * fix reducer action type imports * Fix most of type errors pre-actions refactor * fix action creator imports in containers * Refactor more * Refactor index of actions * fix action imports; use module level index export * package-lock.json updated * Use action types in props * Type up action creators * Fix most of connect errors * Typefixing progress * More types * Fix run-time errors * Caching improvements for webpack * Remove path resolve from webpack * Update non-breaking packages to latest version * Fix token typing * Remove unused color code * Fix wallet decrypt dispatch * Set redux-form related props/functions to ANY, since we're stripping it out later on * Revert BigNumber.js package changes * Extend window to custom object for Perf * Format Navigation * Typecase keystore errors as any (since we shouldnt touch this) * Push wallet context fix * - find/replace value->payload in swap - properly type swap state properties - extract inline reducer into reducer function * - type local storage retrieved items as generic * - bind all RPCClient methods with fat arrow * - reformat * Change to enums for constants * Change state into any * Fix swap errors * ensure that seconds are passed into state as integers * Fix rest of errors * use parseInt explicitly instead of type coercion * Fix derivation-checker, remove flow command, add tslint command, add tslint-react, tell travis to use tslint instead of flow. * Whoops, remove those tests. * Remove unsupported (yet) config option. * Fix precommit to target ts and tsx files. * Fix some errors, ignore some silly rules. * Revert jest to v19, use ts-jest and make all tests typescript. Fixes all but one. * Get rid of saga tests * Fix tslint errors
2017-09-25 02:06:28 +00:00
throw new Error(translateRaw('GETH_GasLimit'));
}
// Reject gasPrice over 1000gwei (1000000000000)
Migrate to Typescript (#224) * Refactor babel/types * Refactor entry point * Refactor actions * Refactor api * Full project refactor -- Broad type fixing sweep * - completely fix merge conflicts - handle various type errors * Add tslint to package.json * Dependency cleanup * Fix module resolution * Work on type definitions for untyped libs * progress commit * Add more definition typing * various type additions * Add unit types * Fix sagaiterator + unit types * various types added * additional type additions * Fix typing on Sagas * remove flowfixmes; swap translate for translateRaw * Get rid of contracts - awaiting Henry's contract PR * Remove contracts from routing * Fix most of actions/reducers * refactor actions directory structure * fix reducer action type imports * Fix most of type errors pre-actions refactor * fix action creator imports in containers * Refactor more * Refactor index of actions * fix action imports; use module level index export * package-lock.json updated * Use action types in props * Type up action creators * Fix most of connect errors * Typefixing progress * More types * Fix run-time errors * Caching improvements for webpack * Remove path resolve from webpack * Update non-breaking packages to latest version * Fix token typing * Remove unused color code * Fix wallet decrypt dispatch * Set redux-form related props/functions to ANY, since we're stripping it out later on * Revert BigNumber.js package changes * Extend window to custom object for Perf * Format Navigation * Typecase keystore errors as any (since we shouldnt touch this) * Push wallet context fix * - find/replace value->payload in swap - properly type swap state properties - extract inline reducer into reducer function * - type local storage retrieved items as generic * - bind all RPCClient methods with fat arrow * - reformat * Change to enums for constants * Change state into any * Fix swap errors * ensure that seconds are passed into state as integers * Fix rest of errors * use parseInt explicitly instead of type coercion * Fix derivation-checker, remove flow command, add tslint command, add tslint-react, tell travis to use tslint instead of flow. * Whoops, remove those tests. * Remove unsupported (yet) config option. * Fix precommit to target ts and tsx files. * Fix some errors, ignore some silly rules. * Revert jest to v19, use ts-jest and make all tests typescript. Fixes all but one. * Get rid of saga tests * Fix tslint errors
2017-09-25 02:06:28 +00:00
const gwei = new Big('1000000000000');
if (gasPrice.amount.greaterThan(gwei)) {
throw new Error(
'Gas price too high. Please contact support if this was not a mistake.'
);
}
Offline Send (#276) * offline-send mvp * cleanup unneeded imports * - create pollOfflineStatus action, action creator, interface * expand UnlockHeader when collapse-button is clicked, instead of div * kick-off pollOfflineStatus upon SendTransaction mount. * Create sagas for polling offline status * remove comment * - create CONFIG_FORCE_OFFLINE action, action creator, interface * Adjust OfflineToggle terms to "Force Online/Offline", and understand when forced offline and when really offline. * - Assume offline in SendTransaction when either offline or forcedOffline * - handle forceOffline action in reducer - adjust state type / provide default state for forceOffline in config reducer * adjust test to pass with different key name * fix incorrect import * - allow size to be specified in offline toggle * - Decode and display nonce in confirmation modal * - set default nonces when forced offline and have online connectivity based on transaction count - pass nonce to generateCompleteTransaction - refactor componentDidUpdate * Allow optional nonce to be passed to generateCompleteTransaction * - create stripHexPrefix function * - cleanup sagas * move getParam into helper util * update address on component update * - show spinner while transaction is being signed - reset state when wallet instance changes (new wallet instantiated via UnlockHeader) * center-align offline message * Adjust force offline/online button text * - validate nonces when offline - only estimate gas when online - don't show send tx button when offline * - break generateCompleteTransactionFromRawTransaction into multiple functions. - support offline generation in generateCompleteTransaction (and generateCompleteTransactionFromRawTransaction). Balance checking is now only done when not offline to support offline generation. * Create Help component (to be used as a tooltip) * Disable hardware wallets when offline. * Hide Send Entire Balance when balance is falsy * Show help icon in nonce field. * - show helper instructions on how to broadcast when user is offline after generating a tx - hardcoded gas limits when offline - refactors * create isPositiveInteger helper function * fix nonce validation * really fix nonce validation (specifically the input highlighting) * remove stray // @flow's * remove offline tab nav * remove unused action arg * address PR comments
2017-10-11 05:04:49 +00:00
}
export async function generateCompleteTransactionFromRawTransaction(
node: INode,
tx: ExtendedRawTransaction,
wallet: IWallet,
token: Token | null | undefined,
offline?: boolean
): Promise<CompleteTransaction> {
const { to, data, gasLimit, gasPrice, chainId, nonce } = tx;
// validation
generateTxValidation(to, token, data, gasLimit, gasPrice);
// duplicated from generateTxValidation -- typescript bug
if (typeof gasLimit === 'string' || typeof gasPrice === 'string') {
throw Error('Gas Limit and Gas Price should be of type bignumber');
}
Offline Send (#276) * offline-send mvp * cleanup unneeded imports * - create pollOfflineStatus action, action creator, interface * expand UnlockHeader when collapse-button is clicked, instead of div * kick-off pollOfflineStatus upon SendTransaction mount. * Create sagas for polling offline status * remove comment * - create CONFIG_FORCE_OFFLINE action, action creator, interface * Adjust OfflineToggle terms to "Force Online/Offline", and understand when forced offline and when really offline. * - Assume offline in SendTransaction when either offline or forcedOffline * - handle forceOffline action in reducer - adjust state type / provide default state for forceOffline in config reducer * adjust test to pass with different key name * fix incorrect import * - allow size to be specified in offline toggle * - Decode and display nonce in confirmation modal * - set default nonces when forced offline and have online connectivity based on transaction count - pass nonce to generateCompleteTransaction - refactor componentDidUpdate * Allow optional nonce to be passed to generateCompleteTransaction * - create stripHexPrefix function * - cleanup sagas * move getParam into helper util * update address on component update * - show spinner while transaction is being signed - reset state when wallet instance changes (new wallet instantiated via UnlockHeader) * center-align offline message * Adjust force offline/online button text * - validate nonces when offline - only estimate gas when online - don't show send tx button when offline * - break generateCompleteTransactionFromRawTransaction into multiple functions. - support offline generation in generateCompleteTransaction (and generateCompleteTransactionFromRawTransaction). Balance checking is now only done when not offline to support offline generation. * Create Help component (to be used as a tooltip) * Disable hardware wallets when offline. * Hide Send Entire Balance when balance is falsy * Show help icon in nonce field. * - show helper instructions on how to broadcast when user is offline after generating a tx - hardcoded gas limits when offline - refactors * create isPositiveInteger helper function * fix nonce validation * really fix nonce validation (specifically the input highlighting) * remove stray // @flow's * remove offline tab nav * remove unused action arg * address PR comments
2017-10-11 05:04:49 +00:00
// computed gas cost (gasprice * gaslimit)
const gasCost: Wei = new Wei(gasPrice.amount.times(gasLimit));
// get amount value (either in ETH or in Token)
const value = getValue(token, tx);
// if not offline, ensure that balance exceeds costs
if (!offline) {
await balanceCheck(node, tx, token, value, gasCost);
}
// Taken from v3's `sanitizeHex`, ensures that the value is a %2 === 0
// prefix'd hex value.
const cleanHex = hex => addHexPrefix(padToEven(stripHexPrefixAndLower(hex)));
const cleanedRawTx = {
nonce: cleanHex(nonce),
gasPrice: cleanHex(gasPrice.toString(16)),
gasLimit: cleanHex(gasLimit.toString(16)),
to: toChecksumAddress(cleanHex(to)),
value: token ? '0x00' : cleanHex(value.toString(16)),
data: data ? cleanHex(data) : '',
chainId: chainId || 1
};
Offline Send (#276) * offline-send mvp * cleanup unneeded imports * - create pollOfflineStatus action, action creator, interface * expand UnlockHeader when collapse-button is clicked, instead of div * kick-off pollOfflineStatus upon SendTransaction mount. * Create sagas for polling offline status * remove comment * - create CONFIG_FORCE_OFFLINE action, action creator, interface * Adjust OfflineToggle terms to "Force Online/Offline", and understand when forced offline and when really offline. * - Assume offline in SendTransaction when either offline or forcedOffline * - handle forceOffline action in reducer - adjust state type / provide default state for forceOffline in config reducer * adjust test to pass with different key name * fix incorrect import * - allow size to be specified in offline toggle * - Decode and display nonce in confirmation modal * - set default nonces when forced offline and have online connectivity based on transaction count - pass nonce to generateCompleteTransaction - refactor componentDidUpdate * Allow optional nonce to be passed to generateCompleteTransaction * - create stripHexPrefix function * - cleanup sagas * move getParam into helper util * update address on component update * - show spinner while transaction is being signed - reset state when wallet instance changes (new wallet instantiated via UnlockHeader) * center-align offline message * Adjust force offline/online button text * - validate nonces when offline - only estimate gas when online - don't show send tx button when offline * - break generateCompleteTransactionFromRawTransaction into multiple functions. - support offline generation in generateCompleteTransaction (and generateCompleteTransactionFromRawTransaction). Balance checking is now only done when not offline to support offline generation. * Create Help component (to be used as a tooltip) * Disable hardware wallets when offline. * Hide Send Entire Balance when balance is falsy * Show help icon in nonce field. * - show helper instructions on how to broadcast when user is offline after generating a tx - hardcoded gas limits when offline - refactors * create isPositiveInteger helper function * fix nonce validation * really fix nonce validation (specifically the input highlighting) * remove stray // @flow's * remove offline tab nav * remove unused action arg * address PR comments
2017-10-11 05:04:49 +00:00
// Sign the transaction
const rawTxJson = JSON.stringify(cleanedRawTx);
const signedTx = await wallet.signRawTransaction(cleanedRawTx);
Offline Send (#276) * offline-send mvp * cleanup unneeded imports * - create pollOfflineStatus action, action creator, interface * expand UnlockHeader when collapse-button is clicked, instead of div * kick-off pollOfflineStatus upon SendTransaction mount. * Create sagas for polling offline status * remove comment * - create CONFIG_FORCE_OFFLINE action, action creator, interface * Adjust OfflineToggle terms to "Force Online/Offline", and understand when forced offline and when really offline. * - Assume offline in SendTransaction when either offline or forcedOffline * - handle forceOffline action in reducer - adjust state type / provide default state for forceOffline in config reducer * adjust test to pass with different key name * fix incorrect import * - allow size to be specified in offline toggle * - Decode and display nonce in confirmation modal * - set default nonces when forced offline and have online connectivity based on transaction count - pass nonce to generateCompleteTransaction - refactor componentDidUpdate * Allow optional nonce to be passed to generateCompleteTransaction * - create stripHexPrefix function * - cleanup sagas * move getParam into helper util * update address on component update * - show spinner while transaction is being signed - reset state when wallet instance changes (new wallet instantiated via UnlockHeader) * center-align offline message * Adjust force offline/online button text * - validate nonces when offline - only estimate gas when online - don't show send tx button when offline * - break generateCompleteTransactionFromRawTransaction into multiple functions. - support offline generation in generateCompleteTransaction (and generateCompleteTransactionFromRawTransaction). Balance checking is now only done when not offline to support offline generation. * Create Help component (to be used as a tooltip) * Disable hardware wallets when offline. * Hide Send Entire Balance when balance is falsy * Show help icon in nonce field. * - show helper instructions on how to broadcast when user is offline after generating a tx - hardcoded gas limits when offline - refactors * create isPositiveInteger helper function * fix nonce validation * really fix nonce validation (specifically the input highlighting) * remove stray // @flow's * remove offline tab nav * remove unused action arg * address PR comments
2017-10-11 05:04:49 +00:00
return {
Offline Send (#276) * offline-send mvp * cleanup unneeded imports * - create pollOfflineStatus action, action creator, interface * expand UnlockHeader when collapse-button is clicked, instead of div * kick-off pollOfflineStatus upon SendTransaction mount. * Create sagas for polling offline status * remove comment * - create CONFIG_FORCE_OFFLINE action, action creator, interface * Adjust OfflineToggle terms to "Force Online/Offline", and understand when forced offline and when really offline. * - Assume offline in SendTransaction when either offline or forcedOffline * - handle forceOffline action in reducer - adjust state type / provide default state for forceOffline in config reducer * adjust test to pass with different key name * fix incorrect import * - allow size to be specified in offline toggle * - Decode and display nonce in confirmation modal * - set default nonces when forced offline and have online connectivity based on transaction count - pass nonce to generateCompleteTransaction - refactor componentDidUpdate * Allow optional nonce to be passed to generateCompleteTransaction * - create stripHexPrefix function * - cleanup sagas * move getParam into helper util * update address on component update * - show spinner while transaction is being signed - reset state when wallet instance changes (new wallet instantiated via UnlockHeader) * center-align offline message * Adjust force offline/online button text * - validate nonces when offline - only estimate gas when online - don't show send tx button when offline * - break generateCompleteTransactionFromRawTransaction into multiple functions. - support offline generation in generateCompleteTransaction (and generateCompleteTransactionFromRawTransaction). Balance checking is now only done when not offline to support offline generation. * Create Help component (to be used as a tooltip) * Disable hardware wallets when offline. * Hide Send Entire Balance when balance is falsy * Show help icon in nonce field. * - show helper instructions on how to broadcast when user is offline after generating a tx - hardcoded gas limits when offline - refactors * create isPositiveInteger helper function * fix nonce validation * really fix nonce validation (specifically the input highlighting) * remove stray // @flow's * remove offline tab nav * remove unused action arg * address PR comments
2017-10-11 05:04:49 +00:00
...cleanedRawTx,
rawTx: rawTxJson,
Migrate to Typescript (#224) * Refactor babel/types * Refactor entry point * Refactor actions * Refactor api * Full project refactor -- Broad type fixing sweep * - completely fix merge conflicts - handle various type errors * Add tslint to package.json * Dependency cleanup * Fix module resolution * Work on type definitions for untyped libs * progress commit * Add more definition typing * various type additions * Add unit types * Fix sagaiterator + unit types * various types added * additional type additions * Fix typing on Sagas * remove flowfixmes; swap translate for translateRaw * Get rid of contracts - awaiting Henry's contract PR * Remove contracts from routing * Fix most of actions/reducers * refactor actions directory structure * fix reducer action type imports * Fix most of type errors pre-actions refactor * fix action creator imports in containers * Refactor more * Refactor index of actions * fix action imports; use module level index export * package-lock.json updated * Use action types in props * Type up action creators * Fix most of connect errors * Typefixing progress * More types * Fix run-time errors * Caching improvements for webpack * Remove path resolve from webpack * Update non-breaking packages to latest version * Fix token typing * Remove unused color code * Fix wallet decrypt dispatch * Set redux-form related props/functions to ANY, since we're stripping it out later on * Revert BigNumber.js package changes * Extend window to custom object for Perf * Format Navigation * Typecase keystore errors as any (since we shouldnt touch this) * Push wallet context fix * - find/replace value->payload in swap - properly type swap state properties - extract inline reducer into reducer function * - type local storage retrieved items as generic * - bind all RPCClient methods with fat arrow * - reformat * Change to enums for constants * Change state into any * Fix swap errors * ensure that seconds are passed into state as integers * Fix rest of errors * use parseInt explicitly instead of type coercion * Fix derivation-checker, remove flow command, add tslint command, add tslint-react, tell travis to use tslint instead of flow. * Whoops, remove those tests. * Remove unsupported (yet) config option. * Fix precommit to target ts and tsx files. * Fix some errors, ignore some silly rules. * Revert jest to v19, use ts-jest and make all tests typescript. Fixes all but one. * Get rid of saga tests * Fix tslint errors
2017-09-25 02:06:28 +00:00
signedTx
};
}
export async function formatTxInput(
wallet: IWallet,
{ token, unit, value, to, data }: TransactionInput
): Promise<TransactionWithoutGas> {
if (unit === 'ether') {
return {
to,
from: await wallet.getAddress(),
value: valueToHex(new Ether(value)),
data
};
} else {
if (!token) {
throw new Error('No matching token');
}
const bigAmount = new Big(value);
const ERC20Data = ERC20.transfer(to, bigAmount);
return {
to: token.address,
from: await wallet.getAddress(),
value: '0x0',
data: ERC20Data
};
}
}
export async function generateCompleteTransaction(
wallet: IWallet,
nodeLib: RPCNode,
gasPrice: Wei,
Migrate to Typescript (#224) * Refactor babel/types * Refactor entry point * Refactor actions * Refactor api * Full project refactor -- Broad type fixing sweep * - completely fix merge conflicts - handle various type errors * Add tslint to package.json * Dependency cleanup * Fix module resolution * Work on type definitions for untyped libs * progress commit * Add more definition typing * various type additions * Add unit types * Fix sagaiterator + unit types * various types added * additional type additions * Fix typing on Sagas * remove flowfixmes; swap translate for translateRaw * Get rid of contracts - awaiting Henry's contract PR * Remove contracts from routing * Fix most of actions/reducers * refactor actions directory structure * fix reducer action type imports * Fix most of type errors pre-actions refactor * fix action creator imports in containers * Refactor more * Refactor index of actions * fix action imports; use module level index export * package-lock.json updated * Use action types in props * Type up action creators * Fix most of connect errors * Typefixing progress * More types * Fix run-time errors * Caching improvements for webpack * Remove path resolve from webpack * Update non-breaking packages to latest version * Fix token typing * Remove unused color code * Fix wallet decrypt dispatch * Set redux-form related props/functions to ANY, since we're stripping it out later on * Revert BigNumber.js package changes * Extend window to custom object for Perf * Format Navigation * Typecase keystore errors as any (since we shouldnt touch this) * Push wallet context fix * - find/replace value->payload in swap - properly type swap state properties - extract inline reducer into reducer function * - type local storage retrieved items as generic * - bind all RPCClient methods with fat arrow * - reformat * Change to enums for constants * Change state into any * Fix swap errors * ensure that seconds are passed into state as integers * Fix rest of errors * use parseInt explicitly instead of type coercion * Fix derivation-checker, remove flow command, add tslint command, add tslint-react, tell travis to use tslint instead of flow. * Whoops, remove those tests. * Remove unsupported (yet) config option. * Fix precommit to target ts and tsx files. * Fix some errors, ignore some silly rules. * Revert jest to v19, use ts-jest and make all tests typescript. Fixes all but one. * Get rid of saga tests * Fix tslint errors
2017-09-25 02:06:28 +00:00
gasLimit: BigNumber,
chainId: number,
Offline Send (#276) * offline-send mvp * cleanup unneeded imports * - create pollOfflineStatus action, action creator, interface * expand UnlockHeader when collapse-button is clicked, instead of div * kick-off pollOfflineStatus upon SendTransaction mount. * Create sagas for polling offline status * remove comment * - create CONFIG_FORCE_OFFLINE action, action creator, interface * Adjust OfflineToggle terms to "Force Online/Offline", and understand when forced offline and when really offline. * - Assume offline in SendTransaction when either offline or forcedOffline * - handle forceOffline action in reducer - adjust state type / provide default state for forceOffline in config reducer * adjust test to pass with different key name * fix incorrect import * - allow size to be specified in offline toggle * - Decode and display nonce in confirmation modal * - set default nonces when forced offline and have online connectivity based on transaction count - pass nonce to generateCompleteTransaction - refactor componentDidUpdate * Allow optional nonce to be passed to generateCompleteTransaction * - create stripHexPrefix function * - cleanup sagas * move getParam into helper util * update address on component update * - show spinner while transaction is being signed - reset state when wallet instance changes (new wallet instantiated via UnlockHeader) * center-align offline message * Adjust force offline/online button text * - validate nonces when offline - only estimate gas when online - don't show send tx button when offline * - break generateCompleteTransactionFromRawTransaction into multiple functions. - support offline generation in generateCompleteTransaction (and generateCompleteTransactionFromRawTransaction). Balance checking is now only done when not offline to support offline generation. * Create Help component (to be used as a tooltip) * Disable hardware wallets when offline. * Hide Send Entire Balance when balance is falsy * Show help icon in nonce field. * - show helper instructions on how to broadcast when user is offline after generating a tx - hardcoded gas limits when offline - refactors * create isPositiveInteger helper function * fix nonce validation * really fix nonce validation (specifically the input highlighting) * remove stray // @flow's * remove offline tab nav * remove unused action arg * address PR comments
2017-10-11 05:04:49 +00:00
transactionInput: TransactionInput,
nonce?: number | null,
offline?: boolean
): Promise<CompleteTransaction> {
const { token } = transactionInput;
const { from, to, value, data } = await formatTxInput(
wallet,
transactionInput
);
const transaction: ExtendedRawTransaction = {
Offline Send (#276) * offline-send mvp * cleanup unneeded imports * - create pollOfflineStatus action, action creator, interface * expand UnlockHeader when collapse-button is clicked, instead of div * kick-off pollOfflineStatus upon SendTransaction mount. * Create sagas for polling offline status * remove comment * - create CONFIG_FORCE_OFFLINE action, action creator, interface * Adjust OfflineToggle terms to "Force Online/Offline", and understand when forced offline and when really offline. * - Assume offline in SendTransaction when either offline or forcedOffline * - handle forceOffline action in reducer - adjust state type / provide default state for forceOffline in config reducer * adjust test to pass with different key name * fix incorrect import * - allow size to be specified in offline toggle * - Decode and display nonce in confirmation modal * - set default nonces when forced offline and have online connectivity based on transaction count - pass nonce to generateCompleteTransaction - refactor componentDidUpdate * Allow optional nonce to be passed to generateCompleteTransaction * - create stripHexPrefix function * - cleanup sagas * move getParam into helper util * update address on component update * - show spinner while transaction is being signed - reset state when wallet instance changes (new wallet instantiated via UnlockHeader) * center-align offline message * Adjust force offline/online button text * - validate nonces when offline - only estimate gas when online - don't show send tx button when offline * - break generateCompleteTransactionFromRawTransaction into multiple functions. - support offline generation in generateCompleteTransaction (and generateCompleteTransactionFromRawTransaction). Balance checking is now only done when not offline to support offline generation. * Create Help component (to be used as a tooltip) * Disable hardware wallets when offline. * Hide Send Entire Balance when balance is falsy * Show help icon in nonce field. * - show helper instructions on how to broadcast when user is offline after generating a tx - hardcoded gas limits when offline - refactors * create isPositiveInteger helper function * fix nonce validation * really fix nonce validation (specifically the input highlighting) * remove stray // @flow's * remove offline tab nav * remove unused action arg * address PR comments
2017-10-11 05:04:49 +00:00
nonce: nonce ? `0x${nonce}` : await nodeLib.getTransactionCount(from),
from,
to,
gasLimit,
value,
data,
chainId,
gasPrice
};
return await generateCompleteTransactionFromRawTransaction(
nodeLib,
transaction,
wallet,
Offline Send (#276) * offline-send mvp * cleanup unneeded imports * - create pollOfflineStatus action, action creator, interface * expand UnlockHeader when collapse-button is clicked, instead of div * kick-off pollOfflineStatus upon SendTransaction mount. * Create sagas for polling offline status * remove comment * - create CONFIG_FORCE_OFFLINE action, action creator, interface * Adjust OfflineToggle terms to "Force Online/Offline", and understand when forced offline and when really offline. * - Assume offline in SendTransaction when either offline or forcedOffline * - handle forceOffline action in reducer - adjust state type / provide default state for forceOffline in config reducer * adjust test to pass with different key name * fix incorrect import * - allow size to be specified in offline toggle * - Decode and display nonce in confirmation modal * - set default nonces when forced offline and have online connectivity based on transaction count - pass nonce to generateCompleteTransaction - refactor componentDidUpdate * Allow optional nonce to be passed to generateCompleteTransaction * - create stripHexPrefix function * - cleanup sagas * move getParam into helper util * update address on component update * - show spinner while transaction is being signed - reset state when wallet instance changes (new wallet instantiated via UnlockHeader) * center-align offline message * Adjust force offline/online button text * - validate nonces when offline - only estimate gas when online - don't show send tx button when offline * - break generateCompleteTransactionFromRawTransaction into multiple functions. - support offline generation in generateCompleteTransaction (and generateCompleteTransactionFromRawTransaction). Balance checking is now only done when not offline to support offline generation. * Create Help component (to be used as a tooltip) * Disable hardware wallets when offline. * Hide Send Entire Balance when balance is falsy * Show help icon in nonce field. * - show helper instructions on how to broadcast when user is offline after generating a tx - hardcoded gas limits when offline - refactors * create isPositiveInteger helper function * fix nonce validation * really fix nonce validation (specifically the input highlighting) * remove stray // @flow's * remove offline tab nav * remove unused action arg * address PR comments
2017-10-11 05:04:49 +00:00
token,
offline
);
}
// TODO determine best place for helper function
export function getBalanceMinusGasCosts(
Migrate to Typescript (#224) * Refactor babel/types * Refactor entry point * Refactor actions * Refactor api * Full project refactor -- Broad type fixing sweep * - completely fix merge conflicts - handle various type errors * Add tslint to package.json * Dependency cleanup * Fix module resolution * Work on type definitions for untyped libs * progress commit * Add more definition typing * various type additions * Add unit types * Fix sagaiterator + unit types * various types added * additional type additions * Fix typing on Sagas * remove flowfixmes; swap translate for translateRaw * Get rid of contracts - awaiting Henry's contract PR * Remove contracts from routing * Fix most of actions/reducers * refactor actions directory structure * fix reducer action type imports * Fix most of type errors pre-actions refactor * fix action creator imports in containers * Refactor more * Refactor index of actions * fix action imports; use module level index export * package-lock.json updated * Use action types in props * Type up action creators * Fix most of connect errors * Typefixing progress * More types * Fix run-time errors * Caching improvements for webpack * Remove path resolve from webpack * Update non-breaking packages to latest version * Fix token typing * Remove unused color code * Fix wallet decrypt dispatch * Set redux-form related props/functions to ANY, since we're stripping it out later on * Revert BigNumber.js package changes * Extend window to custom object for Perf * Format Navigation * Typecase keystore errors as any (since we shouldnt touch this) * Push wallet context fix * - find/replace value->payload in swap - properly type swap state properties - extract inline reducer into reducer function * - type local storage retrieved items as generic * - bind all RPCClient methods with fat arrow * - reformat * Change to enums for constants * Change state into any * Fix swap errors * ensure that seconds are passed into state as integers * Fix rest of errors * use parseInt explicitly instead of type coercion * Fix derivation-checker, remove flow command, add tslint command, add tslint-react, tell travis to use tslint instead of flow. * Whoops, remove those tests. * Remove unsupported (yet) config option. * Fix precommit to target ts and tsx files. * Fix some errors, ignore some silly rules. * Revert jest to v19, use ts-jest and make all tests typescript. Fixes all but one. * Get rid of saga tests * Fix tslint errors
2017-09-25 02:06:28 +00:00
gasLimit: BigNumber,
gasPrice: Wei,
balance: Wei
): Ether {
const weiGasCosts = gasPrice.amount.times(gasLimit);
const weiBalanceMinusGasCosts = balance.amount.minus(weiGasCosts);
return new Ether(weiBalanceMinusGasCosts);
}