The industry standard is to encode signatures as `(bytes32 r, bytes32 s, uint8 v)` in 65 bytes, which is evident here: d3c5bdf4de/contracts/utils/cryptography/ECDSA.sol (L32)
But also in the implementation code which reads the first 32 bytes as r, then the next as s, and the last byte as v
However, it checks if the signature is 66 bytes long, rather than the 65 which it reads. As such I believe this is an error in the example.
* ERC-1271 : Set to Last Call
* Change section title to Reference Implementation
* Update EIPS/eip-1271.md
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
Hi, I'm a bot! This change was automatically merged because:
- It only modifies existing Draft or Last Call EIP(s)
- The PR was approved or written by at least one author of each modified EIP
- The build is passing
I have gone through and updated all existing EIPs to match this rule, including EIP-1.
In some cases, people were using markdown citations, I suspect because the long-form was a bit verbose to inline. Since the relative path is quite short, I moved these to inline but I wouldn't be opposed to putting them back to citation format if that is desired by the authors.
In doing the migration/cleanup, I found some EIP references to EIPs that don't actually exist. In these cases I tried to excise the reference from the EIP as best I could.
It is worth noting that the Readme actually already had this rule, it just wasn't expressed properly in EIP-1 and the "Citation Format" section of the readme I think caused people a bit of confusion (when citing externally, you should use the citation format).
* Try to clarify the meaning of EIP fields
* Remove unhelpful extra comments in the template
* Change EIP-1491 from CRLF to LF
* Remove template comments from EIPs
* Fix heading: Abstarct -> Abstract
* Update EIP-2014
* Change author list of EIP-1
* switch to eipv
* fix
* fix
* 1153 remove trailing whitespace
* remove file name checks
* 615 remo whitespace before comma
* 884 remove extra single-quotes
* 1337 remove whitespace before comma
* 1057 remove extra spaces after comma
* 2470 update created date to Y/M/D format
* 1078 update required eips to be in ascending order
* 2477 update required eips to be in ascending order
* 1271 remove extra whitespace
* 2767 required eipupdated to be in ascending order
* 2525 update created date to Y/M/D format
* 2458 remove trailing whitespace
* 1884 remove trailing whitespace
* 712 authors should be on a single line
* 601 remove extra whitespace
* 1485 remove unneeded parentheses
* 634 remove trailing whitespace
* 2657 update discussions-to to correct spelling
* 2009 remove trailing whitespace
* 998 required eips updated to be in ascending order
* 1186 remove trailing whitespace
* 1470 remove extra whitespace
* 1895 update created date to Y/M/D format
* 2747 remove extra whitespace
* 1613 remove leading whitespace
* 1571 can'have both handle and email in author field
* 1191 remove trailing whitespace
* 1973 remove trailing whitespace
* 196 don't wrap title field
* 1679 required eips must be in ascending order
* 1620 author can't have both handle and email
* 197 don't line wrap title field
* 2378 remove extra newline
* 1355 author can't have both handle and email
* 698 update created date to Y/M/D format
* 2193 required eips must be in ascending order
* 214 remove extra info after author email
* use v0.0.3 of eipv
* 1 remove malformed field
* bump eipv to v0.0.4
* cache eipv build
* 1485 remove extra author info
* 2771 removing extra whitespaces
Hi, I'm a bot! This change was automatically merged because:
- It only modifies existing Draft or Last Call EIP(s)
- The PR was approved or written by at least one author of each modified EIP
- The build is passing
Hi, I'm a bot! This change was automatically merged because:
- It only modifies existing Draft or Last Call EIP(s)
- The PR was approved or written by at least one author of each modified EIP
- The build is passing
Hi, I'm a bot! This change was automatically merged because:
- It only modifies existing Draft or Last Call EIP(s)
- The PR was approved or written by at least one author of each modified EIP
- The build is passing
Hi, I'm a bot! This change was automatically merged because:
- It only modifies existing Draft or Last Call EIP(s)
- The PR was approved or written by at least one author of each modified EIP
- The build is passing
