3 Commits

Author SHA1 Message Date
eth-bot
8ad1cc8cb2
(bot 1272989785) moving EIPS/eip-2256.md to stagnant (#3944)
PR 3944 with changes to EIPS/eip-2256.md was created on 
	(2021-Sep-11th@20.16.56)
which is before the cutoff date of 
	(2021-Sep-12th@00.22.51)
i.e. 2 weeks ago
2021-09-26 00:24:49 -05:00
Micah Zoltu
15f61ed0fd
Adds rule to EIP-1 that references to other EIPs must use relative path format and the first reference must be linked. (#2947)
I have gone through and updated all existing EIPs to match this rule, including EIP-1.

In some cases, people were using markdown citations, I suspect because the long-form was a bit verbose to inline.  Since the relative path is quite short, I moved these to inline but I wouldn't be opposed to putting them back to citation format if that is desired by the authors.

In doing the migration/cleanup, I found some EIP references to EIPs that don't actually exist.  In these cases I tried to excise the reference from the EIP as best I could.

It is worth noting that the Readme actually already had this rule, it just wasn't expressed properly in EIP-1 and the "Citation Format" section of the readme I think caused people a bit of confusion (when citing externally, you should use the citation format).
2020-09-30 12:22:43 +08:00
Loredana Cirstea
4c4dd7dd11 Add ERC for wallet_getOwnedAssets (#2256)
* Add ERC for wallet_getOwnedTokens JSON-RPC method

* Add EIP number & discussions URL to EIP-2256

* Fix wallet_getOwnedTokens input arguments

* Add chainId as argument to wallet_getOwnedTokens

As suggested in https://github.com/ethereum/EIPs/pull/2256#issuecomment-526204181

* Rename EIP-2256 method to wallet_getOwnedAssets, align data struct with EIP-747

Based on the discussions up to and including this comment: https://ethereum-magicians.org/t/eip-2256-add-wallet-getownedassets-json-rpc-method/3600/15

- rename `wallet_getOwnedTokens` to `wallet_getOwnedAssets`
- use `options` in the response field, as EIP-747 proposes, to allow for different asset-specific information to be returned
- use `asset` instead of `token` where generalization is needed
- replace `interface` with `type`, to align with EIP-747
- add `types` as a filter field
- add `decimals` as an optional field in `options`

* Fix category for EIP-2256 - use Interface

As suggested in https://github.com/ethereum/EIPs/pull/2256#discussion_r321153237

* Add justification field for EIP-2256, s/count/limit

- add `justification` field in the request arguments, as suggested in https://github.com/ethereum/EIPs/pull/2256#issuecomment-527683267
- replace `count` with `limit`, as `count` is more ambiguous (as revealed in https://github.com/ethereum/EIPs/pull/2253#discussion_r320140105)
2019-09-06 14:33:09 +01:00