The industry standard is to encode signatures as `(bytes32 r, bytes32 s, uint8 v)` in 65 bytes, which is evident here: d3c5bdf4de/contracts/utils/cryptography/ECDSA.sol (L32)
But also in the implementation code which reads the first 32 bytes as r, then the next as s, and the last byte as v
However, it checks if the signature is 66 bytes long, rather than the 65 which it reads. As such I believe this is an error in the example.
* Renames `tip` to `gas premium` in non-normative content.
* Update EIPS/eip-1559.md
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
* 1559: Use snakecase throughout the spec
* 1559: Update ReceiptPayload to also use snakecase (plus ensure cumulative_transaction_gas_used matches the code)
* ERC-1271 : Set to Last Call
* Change section title to Reference Implementation
* Update EIPS/eip-1271.md
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
* Update EIP-3540 with clarifications and remove 3541-related steps
* Move simplified implementation
* Remove latex syntax
* Change rationale about format to refer to 3541
* Change abstract to remove 2-hardforks
* Fix discussions-to url for 3540/3541
* f
* fix: updating eip-2981 status from 'Review' to 'Last Call'.
* Triggering auto-merge with empty commit.
* fix: Review period needs to be added for last call status.
* fix: Review period needs to be added for last call status.
* update review-period-end
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
The current example implementation is not compiling on Solidity because of some errors (1. interface does not support state variables nor functions that are not external, and 2. there were some mismatches between the names of the variables). This PR proposes a fix to these errors.
* fix: _value is now _salePrice, royaltyInfo() return values no longer have underscore prefix, checkRoyalties function uses IERC165 interface instead of IERC2981 interface,fixed-percentage wording revised, caveats added around percentage calculation, conversation with artist and marketplace cleaned up.
* fix: Grammar mistake.
* fix: typo, not Buyer, but Royalty recipient.
* fix: Formatting on paragraphs and fixed importing IERC165 interface.
* fix: Cleaner wording for salePrice and royaltyAmount unit of account.
