status-im
/
EIPs
mirror of https://github.com/status-im/EIPs.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
1,872 Commits 16 Branches 0 Tags 32 MiB
Commit Graph

35 Commits

Author SHA1 Message Date
Agustin Aguilar 7c10d583d9 Fix Wrong Input Length - ERC165 Example (#1640) 
* Wrong input size - noThrowCall ERC165

Input should be 36 bytes (4 signature bytes + 32 bytes parameter)

Solidity 5 validates the length of msg.data, reverting on the 32 bytes input, all contracts using the broken 'doesContractImplementInterface' will not be able to read an ERC165 implementation targetting Solidity 5.

A legacy-compatible strategy should be defined to make all the "ERC165 readers" sending a 32 bytes sized data compatible with ERC165 contracts compiled targeting this new version of the compiler.

A possible solution could be to add a keyword on Solidity to disable the validation of the calldata length.

* Add version history section to EIP165

* EIP 1640 -> PR 1640
 2019-05-22 13:31:19 +12:00
Alex Beregszaszi af982f1470 Run spelling checks on CI (#2040) 2019-05-19 08:54:10 +02:00
William Entriken 035a021168 Update HTTP->HTTPS when both URLs work (#1714) 2019-03-09 08:56:08 +01:00
Greg Colvin 9ad28e6c7c
Merge pull request #1704 from leejames00/fix-165 
typo fix in EIP165
 2019-01-29 17:29:55 -07:00
Junseok Lee 31f2f61088 typo fix in EIP165 2019-01-17 22:58:12 +09:00
Alex Beregszaszi e0d13b1a24 EIP-165 requires EIP-214 due to its use of staticcall 2019-01-10 20:30:08 +00:00
Lev Dubinets 33907618ab Fix typo in EIP-165, stadardizes->standardizes (#1168) 2018-06-24 20:00:50 +01:00
Nick Johnson 491e5df13e
Move EIP 165 to Final. 2018-04-20 15:28:39 +01:00
Nick Johnson 7038c5f9b9 Add pages for each EIP type, improve listing tables with links 2018-03-21 15:55:18 +00:00
Nick Johnson 4938bcbf91 Lowercase all frontmatter keys 2018-03-21 12:51:05 +00:00
Nick Johnson cdc9c981e9 Fixed headers for existing EIPs to be conformant YAML frontmatter 2018-03-20 15:10:58 +00:00
Nick Savers 2cb6f9177f
Update eip-165.md 2018-02-21 23:43:12 +01:00
William Entriken 03c67d2e08
interfaced -> interacted 
https://github.com/ethereum/EIPs/pull/881#discussion_r169605418
 2018-02-21 13:46:31 -05:00
William Entriken d47923bc1b
Update link 
https://github.com/ethereum/EIPs/pull/881#discussion_r169604965
 2018-02-21 13:45:51 -05:00
William Entriken e902727c36
Nibbles are not bytes, duh 2018-02-21 13:44:16 -05:00
William Entriken 50ad36b0b1
Hex, not string 2018-02-21 13:40:29 -05:00
William Entriken 4ecf584460
32 bytes input 2018-02-20 20:16:39 -05:00
William Entriken 490ce29eca
not a cache 2018-02-20 17:45:23 -05:00
William Entriken 1947d2f676
Complete Homer implementation 2018-02-20 17:39:55 -05:00
William Entriken 12fe0b505c
Switch from a cache to a query contract, cache is out of scope 2018-02-20 17:33:49 -05:00
William Entriken b675b4b3fa
Update zero padding, thank you @veox 2018-02-20 17:22:47 -05:00
William Entriken 734d68b643
Use 32-byte words 2018-02-19 16:54:19 -05:00
William Entriken 881f577abb
Bytes, version 0.4.20, thanks @veox 2018-02-19 16:43:01 -05:00
William Entriken b97350cb1b
Copyediting review 2018-02-16 19:34:44 -05:00
William Entriken 39285480ca
Remove authors @VoR0220 @Souptacular @GriffGreen 2018-02-16 18:57:27 -05:00
William Entriken ad70b8d276
Function selectors are defined by Ethereum, not Solidity 2018-02-16 06:58:03 -05:00
William Entriken 26c91183dc
"uses less than" 2018-02-16 06:56:43 -05:00
William Entriken 529ce1b2ca
Update cache to use explicit return values of 32 byte length 2018-02-16 06:51:50 -05:00
William Entriken 50f59da47f
Updated to use staticcall 2018-02-16 06:35:16 -05:00
William Entriken d39b3885d4
Add author Konrad Feldmeier 
Per @chriseth
 2018-02-15 12:12:05 -05:00
William Entriken 6e4394d6d1
Update caching contract 2018-02-14 22:29:01 -05:00
William Entriken 4b7b91691a
Add author email addresses per latest EIP-X 
Found from git log messages around the world.
 2018-02-14 00:16:03 -05:00
William Entriken 224822c743
Add two competing implementations 2018-02-14 00:05:57 -05:00
William Entriken 7558488487
Discuss optional interfaces per @dete advice 
References: https://github.com/ethereum/EIPs/issues/165#issuecomment-345382512
 2018-02-13 03:07:48 -05:00
William Entriken 5e02514334
A standard for interface detection, fixes #165 2018-02-13 02:35:39 -05:00