diff --git a/EIPS/eip-145.md b/EIPS/eip-145.md index 01844a9e..67370ee9 100644 --- a/EIPS/eip-145.md +++ b/EIPS/eip-145.md @@ -27,51 +27,51 @@ The following instructions are introduced: ### `0x1b`: `SHL` (shift left) -The `SHL` instruction (shift left) pops 2 values from the stack, `arg1` and `arg2`, and pushes on the stack the first popped value `arg1` shifted to the left by the number of bits in the second popped value `arg2`. The result is equal to +The `SHL` instruction (shift left) pops 2 values from the stack, `arg1` and `arg2`, and pushes on the stack the second popped value `arg2` shifted to the left by the number of bits in the first popped value `arg1`. The result is equal to ``` -(arg1 * 2^arg2) mod 2^256 +(arg2 * 2^arg1) mod 2^256 ``` Notes: -- The value (`arg1`) is interpreted as an unsigned number. -- The shift amount (`arg2`) is interpreted as an unsigned number. -- If the shift amount (`arg2`) is greater or equal 256 the result is 0. -- This is equivalent to `SWAP1 PUSH1 2 EXP MUL`. +- The value (`arg2`) is interpreted as an unsigned number. +- The shift amount (`arg1`) is interpreted as an unsigned number. +- If the shift amount (`arg1`) is greater or equal 256 the result is 0. +- This is equivalent to `PUSH1 2 EXP MUL`. ### `0x1c`: `SHR` (logical shift right) -The `SHR` instruction (logical shift right) pops 2 values from the stack, `arg1` and `arg2`, and pushes on the stack the first popped value `arg1` shifted to the right by the number of bits in the second popped value `arg2` with zero fill. The result is equal to +The `SHR` instruction (logical shift right) pops 2 values from the stack, `arg1` and `arg2`, and pushes on the stack the second popped value `arg2` shifted to the right by the number of bits in the first popped value `arg1` with zero fill. The result is equal to ``` -floor(arg1 / 2^arg2) +floor(arg2 / 2^arg1) ``` Notes: -- The value (`arg1`) is interpreted as an unsigned number. -- The shift amount (`arg2`) is interpreted as an unsigned number. -- If the shift amount (`arg2`) is greater or equal 256 the result is 0. -- This is equivalent to `SWAP1 PUSH1 2 EXP DIV`. +- The value (`arg2`) is interpreted as an unsigned number. +- The shift amount (`arg1`) is interpreted as an unsigned number. +- If the shift amount (`arg1`) is greater or equal 256 the result is 0. +- This is equivalent to `PUSH1 2 EXP DIV`. ### `0x1d`: `SAR` (arithmetic shift right) -The `SAR` instruction (arithmetic shift right) pops 2 values from the stack, `arg1` and `arg2`, and pushes on the stack the first popped value `arg1` shifted to the right by the number of bits in the second popped value `arg2` with sign extension. The result is equal to +The `SAR` instruction (arithmetic shift right) pops 2 values from the stack, `arg1` and `arg2`, and pushes on the stack the second popped value `arg2` shifted to the right by the number of bits in the first popped value `arg1` with sign extension. The result is equal to ``` -floor(arg1 / 2^arg2) +floor(arg2 / 2^arg1) ``` Notes: -- The value (`arg1`) is interpreted as a signed number. -- The shift amount (`arg2`) is interpreted as an unsigned number. -- If the shift amount (`arg2`) is greater or equal 256 the result is 0 if `arg1` is non-negative or -1 if `arg1` is negative. -- This is **not** equivalent to `SWAP1 PUSH1 2 EXP SDIV`, since it rounds differently. See `SDIV(-1, 2) == 0`, while `SAR(-1, 1) == -1`. +- The value (`arg2`) is interpreted as a signed number. +- The shift amount (`arg1`) is interpreted as an unsigned number. +- If the shift amount (`arg1`) is greater or equal 256 the result is 0 if `arg2` is non-negative or -1 if `arg2` is negative. +- This is **not** equivalent to `PUSH1 2 EXP SDIV`, since it rounds differently. See `SDIV(-1, 2) == 0`, while `SAR(-1, 1) == -1`. The cost of the shift instructions is set at `verylow` tier (3 gas). ## Rationale -Instruction operands were chosen to match the other logical and arithmetic instructions. +Instruction operands were chosen to fit the more natural use case of shifting a value already on the stack. This means the operand order is swapped compared to most arithmetic insturctions. ## Backwards Compatibility