status-im
/
EIPs
mirror of https://github.com/status-im/EIPs.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Test cases and scalars larger than field order. 

Scalars larger than the field characteristic are allowed because it only makes sense to restrict them to the group order, not the field characteristic and adding the group order as another magic constant here would complicated the specification.
This commit is contained in:
chriseth 2017-02-24 16:27:09 +01:00 committed by GitHub
parent 0ed49ac9b4
commit 8856795031
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
EIPS/ecopts.md
View File

@ -50,7 +50,7 @@ The length of the returned data is always as specified (i.e. it is not "unpadded
### Exact semantics ### Exact semantics
Invalid input: For both contracts, if any input point does not lie on the curve or any of the field elements (point coordinates or scalar) is equal or larger than the field modulus p, the contract fails. Invalid input: For both contracts, if any input point does not lie on the curve or any of the field elements (point coordinates) is equal or larger than the field modulus p, the contract fails. The scalar can be any number between `0` and `2**256-1`.
#### ADD #### ADD
Input: two curve points `(x, y)`. Input: two curve points `(x, y)`.
@ -80,7 +80,14 @@ As with the introduction of any precompiled contract, contracts that already use
## Test Cases ## Test Cases
To be written. Inputs to test:
- Curve points which would be valid if the numbers were taken mod p (should fail).
- Both contracts should succeed on empty input.
- Truncated input that results in a valid curve point.
- Points not on curve (but valid otherwise).
- Multiply point with scalar that lies between the order of the group and the field (should succeed).
- Multiply point with scalar that is larger than the field order (should succeed).
## Implementation ## Implementation