Fix Last Call, remove jekyll-feeds plugin (#1687)

* Removed jekyll-feed plugin -- it only works on posts, EIPs are created as pages

* Edited Last Call feed to work, and to have a header with EIP metadata in the RSS feed, including the discussion-to or Github issue link
This commit is contained in:
Boris Mann 2019-01-11 12:10:54 -08:00 committed by Nick Johnson
parent 058136c9ad
commit 2e33365c49
2 changed files with 20 additions and 9 deletions

View File

@ -36,8 +36,6 @@ twitter:
# Build settings # Build settings
markdown: kramdown markdown: kramdown
theme: minima theme: minima
plugins:
- jekyll-feed
permalink: /:slug permalink: /:slug

View File

@ -8,15 +8,28 @@ layout: null
<description>All EIPs which are in the two-week "last call" status, please help review these and provide your feedback!</description> <description>All EIPs which are in the two-week "last call" status, please help review these and provide your feedback!</description>
<link>{{ site.url }}</link> <link>{{ site.url }}</link>
<atom:link href="{{ site.url }}/last-call.xml" rel="self" type="application/rss+xml" /> <atom:link href="{{ site.url }}/last-call.xml" rel="self" type="application/rss+xml" />
{% assign eips = site.pages|where:"status","Last Call"|sort:"eip" %} <lastBuildDate>{{ site.time }}</lastBuildDate>
{% for page in eips %} {% assign eips = site.pages | sort: 'eip' %}
{% for eip in eips %}
{% if eip.status == "Last Call" %}
{% capture description %}
<p><strong>EIP #{{ eip.eip }} - {{eip.title }}</strong> is in Last Call status. It is authored by {{ eip.author }} and was originally created {{ eip.created }}. It is in the {{ eip.category }} category of type {{ eip.type }}. Please review and note any changes that should block acceptance.</p>
{% if eip.discussions-to %}
<p>The author has requested that discussions happen at the following URL: {{ eip.discussions-to }}</p>
{% else %}
<p>Please visit the [ethereum/EIPs issues to comment](https://github.com/ethereum/EIPs/issues/{{eip.eip}}).</p>
{% endif %}
<hr />
{{ eip.content }}
{% endcapture %}
<item> <item>
<title>{{ page.title | xml_escape }}</title> <title>{{ eip.title | xml_escape }}</title>
<description>{{ page.content | xml_escape }}</description> <description>{{ description | xml_escape }}</description>
<pubDate>{{ page.date | date: "%a, %d %b %Y %H:%M:%S %z" }}</pubDate> <pubDate>{{ eip.date | date: "%a, %d %b %Y %H:%M:%S %z" }}</pubDate>
<link>{{ site.url }}/{{ page.url }}</link> <link>{{ site.url }}/{{ eip.url }}</link>
<guid isPermaLink="true">{{ site.url }}/{{ page.url }}</guid> <guid isPermaLink="true">{{ site.url }}/{{ eip.url }}</guid>
</item> </item>
{% endif %}
{% endfor %} {% endfor %}
</channel> </channel>
</rss> </rss>