From 04fa20bbbe612d7d2052ca6fad0005a970cd34c1 Mon Sep 17 00:00:00 2001 From: Juliano Rizzo Date: Thu, 31 Oct 2019 21:06:52 -0300 Subject: [PATCH] EIP-1191: Change status to Last Call (#2234) * Update eip-1191.md * Adds Abstract and Motivation sections. * adds review-period-end --- EIPS/eip-1191.md | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/EIPS/eip-1191.md b/EIPS/eip-1191.md index 162db6ce..4c247217 100644 --- a/EIPS/eip-1191.md +++ b/EIPS/eip-1191.md @@ -2,16 +2,24 @@ eip: 1191 title: Add chain id to mixed-case checksum address encoding author: Juliano Rizzo (@juli) -status: Draft +status: Last Call +review-period-end: 2019-11-18 type: Standards Track category: ERC created: 2018-03-18 requires: 55, 155 discussions-to: https://github.com/ethereum/EIPs/issues/1121 --- + ## Simple Summary This EIP extends EIP-55 by optionally adding a chain id defined by EIP-155 to the checksum calculation. +## Abstract +The EIP-55 was created to prevent users from losing funds by sending them to invalid addresses. This EIP extends EIP-55 to protect users from losing funds by sending them to addresses that are valid but that where obtained from a client of another network.For example, if this EIP is implemented, a wallet can alert the user that is trying to send funds to an Ethereum Testnet address from an Ethereum Mainnet wallet. + +## Motivation +The motivation of this proposal is to provide a mechanism to allow software to distinguish addresses from different Ethereum based networks. This proposal is necessary because Ethereum addresses are hashes of public keys and do not include any metadata. By extending the EIP-55 checksum algorithm it is possible to achieve this objective. + ## Specification Convert the address using the same algorithm defined by EIP-55 but if a registered chain id is provided, add it to the input of the hash function. If the chain id passed to the function belongs to a network that opted for using this checksum variant, prefix the address with the chain id and the `0x` separator before calculating the hash. Then convert the address to hexadecimal, but if the ith digit is a letter (ie. it's one of `abcdef`) print it in uppercase if the 4*ith bit of the calculated hash is 1 otherwise print it in lowercase. @@ -89,12 +97,14 @@ for chainid, cases in test_cases.items(): | RSK Testnet | 31 | Yes | ### Implementation Table -| Wallet | Adopted this EIP | Implementation | +| Project | Adopted this EIP | Implementation | |----------------|------------------| -------------- | | MyCrypto | Yes | [JavaScript](https://github.com/MyCryptoHQ/MyCrypto/blob/develop/common/utils/formatters.ts#L126) | | MyEtherWallet | Yes | [JavaScript](https://github.com/MyEtherWallet/MyEtherWallet/blob/73c4a24f8f67c655749ac990c5b62efd92a2b11a/src/helpers/addressUtils.js#L22) | | Ledger | Yes | [C](https://github.com/LedgerHQ/ledger-app-eth/blob/master/src_common/ethUtils.c#L203) | | Trezor | Yes | [Python](https://github.com/trezor/trezor-core/blob/270bf732121d004a4cd1ab129adaccf7346ff1db/src/apps/ethereum/get_address.py#L32) and [C](https://github.com/trezor/trezor-crypto/blob/4153e662b60a0d83c1be15150f18483a37e9092c/address.c#L62) | +| Web3.js | Yes | [JavaScript](https://github.com/ethereum/web3.js/blob/aaf26c8806bc9fb60cf6dcb6658104963c6c7fc7/packages/web3-utils/src/Utils.js#L140) | +| EthereumJS-util | Yes | [JavaScript](https://github.com/ethereumjs/ethereumjs-util/pull/204/commits/cdf0b3c996b05ac5b1f758f17ea9f9ed1847c1eb) | ## Copyright