Moved address-to-string translation code to blocks that depend on the 'verbose' flag.

This commit is contained in:
Thomas Pornin 2016-11-12 16:49:27 +01:00
parent 133705ee65
commit f3ac21cb00
2 changed files with 34 additions and 29 deletions

View File

@ -57,6 +57,7 @@ host_connect(const char *host, const char *port, int verbose)
} }
fd = -1; fd = -1;
for (p = si; p != NULL; p = p->ai_next) { for (p = si; p != NULL; p = p->ai_next) {
if (verbose) {
struct sockaddr *sa; struct sockaddr *sa;
void *addr; void *addr;
char tmp[INET6_ADDRSTRLEN + 50]; char tmp[INET6_ADDRSTRLEN + 50];
@ -70,14 +71,15 @@ host_connect(const char *host, const char *port, int verbose)
addr = NULL; addr = NULL;
} }
if (addr != NULL) { if (addr != NULL) {
if (!inet_ntop(p->ai_family, addr, tmp, sizeof tmp)) { if (!inet_ntop(p->ai_family, addr,
tmp, sizeof tmp))
{
strcpy(tmp, "<invalid>"); strcpy(tmp, "<invalid>");
} }
} else { } else {
sprintf(tmp, "<unknown family: %d>", sprintf(tmp, "<unknown family: %d>",
(int)sa->sa_family); (int)sa->sa_family);
} }
if (verbose) {
fprintf(stderr, "connecting to: %s\n", tmp); fprintf(stderr, "connecting to: %s\n", tmp);
} }
fd = socket(p->ai_family, p->ai_socktype, p->ai_protocol); fd = socket(p->ai_family, p->ai_socktype, p->ai_protocol);

View File

@ -62,7 +62,6 @@ host_bind(const char *host, const char *port, int verbose)
struct sockaddr_in6 sa6; struct sockaddr_in6 sa6;
size_t sa_len; size_t sa_len;
void *addr; void *addr;
char tmp[INET6_ADDRSTRLEN + 50];
int opt; int opt;
sa = (struct sockaddr *)p->ai_addr; sa = (struct sockaddr *)p->ai_addr;
@ -86,15 +85,19 @@ host_bind(const char *host, const char *port, int verbose)
addr = NULL; addr = NULL;
sa_len = p->ai_addrlen; sa_len = p->ai_addrlen;
} }
if (verbose) {
char tmp[INET6_ADDRSTRLEN + 50];
if (addr != NULL) { if (addr != NULL) {
if (!inet_ntop(p->ai_family, addr, tmp, sizeof tmp)) { if (!inet_ntop(p->ai_family, addr,
tmp, sizeof tmp))
{
strcpy(tmp, "<invalid>"); strcpy(tmp, "<invalid>");
} }
} else { } else {
sprintf(tmp, "<unknown family: %d>", sprintf(tmp, "<unknown family: %d>",
(int)sa->sa_family); (int)sa->sa_family);
} }
if (verbose) {
fprintf(stderr, "binding to: %s\n", tmp); fprintf(stderr, "binding to: %s\n", tmp);
} }
fd = socket(p->ai_family, p->ai_socktype, p->ai_protocol); fd = socket(p->ai_family, p->ai_socktype, p->ai_protocol);