sartography/uva-covid19-testing-communicator
1
0
Fork 0
mirror of https://github.com/sartography/uva-covid19-testing-communicator.git synced 2025-02-23 20:38:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't recurse indefinitely in code that only executes in production.

Browse Source
This commit is contained in:
Dan 2021-02-26 18:32:35 -05:00
parent 18f584364e
commit 562de0026f
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
communicator/services/user_service.py
View File

@ -35,12 +35,15 @@ class UserService(object):
uid = request.headers.get("X-Remote-Uid")
if not uid:
raise CommError(1100, "invalid_sso_credentials", r"'Uid' nor 'X-Remote-Uid' were present in the headers: %s"% str(request.headers))
return User(uid, cn, self.is_valid_user())
return User(uid, cn, self.uid_is_admin(uid))
else:
return User('testUser', "Test User", True)
def uid_is_admin(self, uid):
valid_ids = [x for x in re.compile('\s*[,|\s+]\s*').split(app.config['ADMINS'])]
return uid in valid_ids
def is_valid_user(self):
user = self.get_user_info()
valid_ids = [x for x in re.compile('\s*[,|\s+]\s*').split(app.config['ADMINS'])]
return user.uid in valid_ids
return self.uid_is_admin(user.uid)