diff --git a/src/react_editor.js b/src/react_editor.js index 1c6f3fc..62a83da 100644 --- a/src/react_editor.js +++ b/src/react_editor.js @@ -5,31 +5,30 @@ import { } from 'bpmn-js-properties-panel'; import React, { useEffect, useState } from "react"; -// import "bpmn-js/dist/assets/diagram-js.css" -// import "bpmn-js/dist/assets/bpmn-js.css" -// import "bpmn-js/dist/assets/bpmn-font/css/bpmn-embedded.css" - import "bpmn-js-properties-panel/dist/assets/properties-panel.css" import './bpmn-js-properties-panel.css'; - console.log("WE CALL HERE1"); - const bpmnViewer = new BpmnModeler({ - container: "#canvas", - keyboard: { - bindTo: document - }, - propertiesPanel: { - parent: '#js-properties-panel' - }, - additionalModules: [ - BpmnPropertiesPanelModule, - BpmnPropertiesProviderModule - ] - }); + +// instantiating this here so it doesn't get +// reinstantiate below when useEffect is called +// multiple times by react +// +// if we could reliabley store this in a var or state +// then we may not need this out here +const bpmnViewer = new BpmnModeler({ + container: "#canvas", + keyboard: { + bindTo: document + }, + propertiesPanel: { + parent: '#js-properties-panel' + }, + additionalModules: [ + BpmnPropertiesPanelModule, + BpmnPropertiesProviderModule + ] +}); export default function ReactEditor(props) { - console.log("WE CALL HERE2"); - // const containerRef = React.useRef(); - // const container = containerRef.current; const [diagramXML, setDiagramXML] = useState(""); const [loaded, setLoaded] = useState(false); @@ -37,22 +36,6 @@ export default function ReactEditor(props) { if (loaded) { return; } - console.log("HERE1"); - // console.log("loaded", loaded) - // const bpmnViewer = new BpmnModeler({ - // container: "#canvas", - // keyboard: { - // bindTo: document - // }, - // propertiesPanel: { - // parent: '#js-properties-panel' - // }, - // additionalModules: [ - // BpmnPropertiesPanelModule, - // BpmnPropertiesProviderModule - // ] - // }); - console.log("HERE2"); bpmnViewer.on('import.done', (event) => { const { @@ -65,19 +48,15 @@ export default function ReactEditor(props) { bpmnViewer.get('canvas').zoom('fit-viewport'); }); - console.log("HERE3"); if (diagramXML) { - console.log("HERE4"); return displayDiagram(bpmnViewer, diagramXML); } if (props.url && !diagramXML) { - console.log("HERE5"); return fetchDiagram(props.url); } - console.log("HERE6"); return () => { bpmnViewer.destroy(); @@ -100,12 +79,9 @@ export default function ReactEditor(props) { function displayDiagram(bpmnViewerToUse, diagramXMLToDisplay) { setLoaded(true); bpmnViewerToUse.importXML(diagramXMLToDisplay); - console.log("loadedSet", loaded) } - // }, [props, diagramXML, container, loaded]); }, [props, diagramXML, loaded]); - // console.log("WE RETURN") return (
//