From 8fd0cbafc675237500db117788559a95d994de78 Mon Sep 17 00:00:00 2001 From: Dan Date: Wed, 9 Nov 2022 12:03:55 -0500 Subject: [PATCH 1/2] fixing up routes for launching editor. Also some fixes in the bpmn-js-spiffworkflow to avoid locking up the browser if no files are available. --- package-lock.json | 8 ++++---- package.json | 2 +- src/routes/ProcessModelEditDiagram.tsx | 10 ++++------ 3 files changed, 9 insertions(+), 11 deletions(-) diff --git a/package-lock.json b/package-lock.json index 5ee7bda..42c0fad 100644 --- a/package-lock.json +++ b/package-lock.json @@ -31,7 +31,7 @@ "bootstrap": "^5.2.0", "bpmn-js": "^9.3.2", "bpmn-js-properties-panel": "^1.10.0", - "bpmn-js-spiffworkflow": "sartography/bpmn-js-spiffworkflow#feature/more_launch_buttons_and_dropdowns", + "bpmn-js-spiffworkflow": "sartography/bpmn-js-spiffworkflow#main", "craco": "^0.0.3", "date-fns": "^2.28.0", "diagram-js": "^8.5.0", @@ -7485,7 +7485,7 @@ }, "node_modules/bpmn-js-spiffworkflow": { "version": "0.0.8", - "resolved": "git+ssh://git@github.com/sartography/bpmn-js-spiffworkflow.git#84593aee1ead7328efdc7da03ab3c9cd34364496", + "resolved": "git+ssh://git@github.com/sartography/bpmn-js-spiffworkflow.git#24c2cc36067adf8fed75990c6bf4a1a67bc9122b", "license": "MIT", "dependencies": { "inherits": "^2.0.4", @@ -35755,8 +35755,8 @@ } }, "bpmn-js-spiffworkflow": { - "version": "git+ssh://git@github.com/sartography/bpmn-js-spiffworkflow.git#84593aee1ead7328efdc7da03ab3c9cd34364496", - "from": "bpmn-js-spiffworkflow@sartography/bpmn-js-spiffworkflow#feature/more_launch_buttons_and_dropdowns", + "version": "git+ssh://git@github.com/sartography/bpmn-js-spiffworkflow.git#24c2cc36067adf8fed75990c6bf4a1a67bc9122b", + "from": "bpmn-js-spiffworkflow@sartography/bpmn-js-spiffworkflow#main", "requires": { "inherits": "^2.0.4", "inherits-browser": "^0.0.1", diff --git a/package.json b/package.json index 37f9e34..92ba23a 100644 --- a/package.json +++ b/package.json @@ -26,7 +26,7 @@ "bootstrap": "^5.2.0", "bpmn-js": "^9.3.2", "bpmn-js-properties-panel": "^1.10.0", - "bpmn-js-spiffworkflow": "sartography/bpmn-js-spiffworkflow#feature/more_launch_buttons_and_dropdowns", + "bpmn-js-spiffworkflow": "sartography/bpmn-js-spiffworkflow#main", "craco": "^0.0.3", "date-fns": "^2.28.0", "diagram-js": "^8.5.0", diff --git a/src/routes/ProcessModelEditDiagram.tsx b/src/routes/ProcessModelEditDiagram.tsx index ede6d85..050a312 100644 --- a/src/routes/ProcessModelEditDiagram.tsx +++ b/src/routes/ProcessModelEditDiagram.tsx @@ -689,9 +689,8 @@ export default function ProcessModelEditDiagram() { const file = findFileNameForReferenceId(processId, 'bpmn'); if (file) { const path = generatePath( - '/admin/process-models/:process_group_id/:process_model_id/files/:file_name', + '/admin/process-models/:process_model_id/files/:file_name', { - process_group_id: params.process_group_id, process_model_id: params.process_model_id, file_name: file.name, } @@ -701,9 +700,8 @@ export default function ProcessModelEditDiagram() { }; const onLaunchJsonEditor = (fileName: string) => { const path = generatePath( - '/admin/process-models/:process_group_id/:process_model_id/form/:file_name', + '/admin/process-models/:process_model_id/files/:file_name', { - process_group_id: params.process_group_id, process_model_id: params.process_model_id, file_name: fileName, } @@ -713,10 +711,10 @@ export default function ProcessModelEditDiagram() { const onLaunchDmnEditor = (processId: string) => { const file = findFileNameForReferenceId(processId, 'dmn'); if (file) { + console.log() const path = generatePath( - '/admin/process-models/:process_group_id/:process_model_id/files/:file_name', + '/admin/process-models/:process_model_id/files/:file_name', { - process_group_id: params.process_group_id, process_model_id: params.process_model_id, file_name: file.name, } From db4ff901983374b5e1568e89a24bd6040dd665bd Mon Sep 17 00:00:00 2001 From: burnettk Date: Wed, 9 Nov 2022 12:09:23 -0500 Subject: [PATCH 2/2] kill a few consoles --- src/routes/ProcessModelEditDiagram.tsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/routes/ProcessModelEditDiagram.tsx b/src/routes/ProcessModelEditDiagram.tsx index 050a312..7d539c3 100644 --- a/src/routes/ProcessModelEditDiagram.tsx +++ b/src/routes/ProcessModelEditDiagram.tsx @@ -107,7 +107,6 @@ export default function ProcessModelEditDiagram() { }; if (params.file_name) { - console.log(`processModelPath: ${processModelPath}`); HttpService.makeCallToBackend({ path: `/${processModelPath}/files/${params.file_name}`, successCallback: fileResult, @@ -711,7 +710,6 @@ export default function ProcessModelEditDiagram() { const onLaunchDmnEditor = (processId: string) => { const file = findFileNameForReferenceId(processId, 'dmn'); if (file) { - console.log() const path = generatePath( '/admin/process-models/:process_model_id/files/:file_name', {