do not start mysql if using sqlite and fix flake8 with pre-commit to ignore the migrations dir w/ burnettk

.flake8

@@ -10,3 +10,7 @@ rst-directives = deprecated
 per-file-ignores =
     # prefer naming tests descriptively rather than forcing comments
     tests/*:S101,D103
+
+    # the exclude=./migrations option doesn't seem to work with pre-commit
+    # migrations are autogenerated from "flask db migration" so ignore them
+    migrations/*:D

.github/workflows/tests.yml

@@ -80,25 +80,15 @@ jobs:
 
     services:
       mysql:
+        if: matrix.database == 'mysql'
         image: mariadb:10.3
         env:
           MYSQL_DATABASE: spiff_workflow_webapp_testing
           MYSQL_ALLOW_EMPTY_PASSWORD: yes
           MYSQL_ROOT_PASSWORD:
         ports:
-        - 3306:3306
+          - 3306:3306
         options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
-      # mysql:
-      #   image: mysql:8.0
-      #   env:
-      #     MYSQL_DATABASE: spiff_workflow_webapp_testing
-      #     # MYSQL_ALLOW_EMPTY_PASSWORD: yes
-      #     # MYSQL_USER: root
-      #     MYSQL_PASSWORD: password
-      #     MYSQL_ROOT_PASSWORD: password
-      #   ports:
-      #     - 3306:3306
-      #   options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
 
     steps:
       - name: Check out the repository

migrations/env.py

@@ -1,11 +1,8 @@
-from __future__ import with_statement
-
 import logging
 from logging.config import fileConfig
 
-from flask import current_app
-
 from alembic import context
+from flask import current_app
 
 # this is the Alembic Config object, which provides
 # access to the values within the .ini file in use.
@@ -14,17 +11,17 @@ config = context.config
 # Interpret the config file for Python logging.
 # This line sets up loggers basically.
 fileConfig(config.config_file_name)
-logger = logging.getLogger('alembic.env')
+logger = logging.getLogger("alembic.env")
 
 # add your model's MetaData object here
 # for 'autogenerate' support
 # from myapp import mymodel
 # target_metadata = mymodel.Base.metadata
 config.set_main_option(
-    'sqlalchemy.url',
-    str(current_app.extensions['migrate'].db.get_engine().url).replace(
-        '%', '%%'))
-target_metadata = current_app.extensions['migrate'].db.metadata
+    "sqlalchemy.url",
+    str(current_app.extensions["migrate"].db.get_engine().url).replace("%", "%%"),
+)
+target_metadata = current_app.extensions["migrate"].db.metadata
 
 # other values from the config, defined by the needs of env.py,
 # can be acquired:
@@ -45,9 +42,7 @@ def run_migrations_offline():
 
     """
     url = config.get_main_option("sqlalchemy.url")
-    context.configure(
-        url=url, target_metadata=target_metadata, literal_binds=True
-    )
+    context.configure(url=url, target_metadata=target_metadata, literal_binds=True)
 
     with context.begin_transaction():
         context.run_migrations()
@@ -65,20 +60,20 @@ def run_migrations_online():
     # when there are no changes to the schema
     # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html
     def process_revision_directives(context, revision, directives):
-        if getattr(config.cmd_opts, 'autogenerate', False):
+        if getattr(config.cmd_opts, "autogenerate", False):
             script = directives[0]
             if script.upgrade_ops.is_empty():
                 directives[:] = []
-                logger.info('No changes in schema detected.')
+                logger.info("No changes in schema detected.")
 
-    connectable = current_app.extensions['migrate'].db.get_engine()
+    connectable = current_app.extensions["migrate"].db.get_engine()
 
     with connectable.connect() as connection:
         context.configure(
             connection=connection,
             target_metadata=target_metadata,
             process_revision_directives=process_revision_directives,
-            **current_app.extensions['migrate'].configure_args
+            **current_app.extensions["migrate"].configure_args
         )
 
         with context.begin_transaction():

migrations/versions/1f7b1ad256dc_.py

@@ -1,16 +1,16 @@
 """empty message
 
 Revision ID: 1f7b1ad256dc
-Revises: 
+Revises:
 Create Date: 2022-05-20 14:21:53.581395
 
 """
-from alembic import op
 import sqlalchemy as sa
+from alembic import op
 
 
 # revision identifiers, used by Alembic.
-revision = '1f7b1ad256dc'
+revision = "1f7b1ad256dc"
 down_revision = None
 branch_labels = None
 depends_on = None
@@ -18,41 +18,51 @@ depends_on = None
 
 def upgrade():
     # ### commands auto generated by Alembic - please adjust! ###
-    op.create_table('group',
-    sa.Column('id', sa.Integer(), nullable=False),
-    sa.Column('name', sa.String(length=255), nullable=True),
-    sa.Column('new_name_two', sa.String(length=255), nullable=True),
-    sa.PrimaryKeyConstraint('id')
+    op.create_table(
+        "group",
+        sa.Column("id", sa.Integer(), nullable=False),
+        sa.Column("name", sa.String(length=255), nullable=True),
+        sa.Column("new_name_two", sa.String(length=255), nullable=True),
+        sa.PrimaryKeyConstraint("id"),
     )
-    op.create_table('process_model',
-    sa.Column('id', sa.Integer(), nullable=False),
-    sa.Column('bpmn_json', sa.JSON(), nullable=True),
-    sa.PrimaryKeyConstraint('id')
+    op.create_table(
+        "process_model",
+        sa.Column("id", sa.Integer(), nullable=False),
+        sa.Column("bpmn_json", sa.JSON(), nullable=True),
+        sa.PrimaryKeyConstraint("id"),
     )
-    op.create_table('user',
-    sa.Column('id', sa.Integer(), nullable=False),
-    sa.Column('username', sa.String(length=50), nullable=False),
-    sa.Column('name', sa.String(length=50), nullable=True),
-    sa.Column('email', sa.String(length=50), nullable=True),
-    sa.PrimaryKeyConstraint('id'),
-    sa.UniqueConstraint('username')
+    op.create_table(
+        "user",
+        sa.Column("id", sa.Integer(), nullable=False),
+        sa.Column("username", sa.String(length=50), nullable=False),
+        sa.Column("name", sa.String(length=50), nullable=True),
+        sa.Column("email", sa.String(length=50), nullable=True),
+        sa.PrimaryKeyConstraint("id"),
+        sa.UniqueConstraint("username"),
     )
-    op.create_table('user_group_assignment',
-    sa.Column('id', sa.Integer(), nullable=False),
-    sa.Column('user_id', sa.Integer(), nullable=False),
-    sa.Column('group_id', sa.Integer(), nullable=False),
-    sa.ForeignKeyConstraint(['group_id'], ['group.id'], ),
-    sa.ForeignKeyConstraint(['user_id'], ['user.id'], ),
-    sa.PrimaryKeyConstraint('id'),
-    sa.UniqueConstraint('user_id', 'group_id', name='user_group_assignment_unique')
+    op.create_table(
+        "user_group_assignment",
+        sa.Column("id", sa.Integer(), nullable=False),
+        sa.Column("user_id", sa.Integer(), nullable=False),
+        sa.Column("group_id", sa.Integer(), nullable=False),
+        sa.ForeignKeyConstraint(
+            ["group_id"],
+            ["group.id"],
+        ),
+        sa.ForeignKeyConstraint(
+            ["user_id"],
+            ["user.id"],
+        ),
+        sa.PrimaryKeyConstraint("id"),
+        sa.UniqueConstraint("user_id", "group_id", name="user_group_assignment_unique"),
     )
     # ### end Alembic commands ###
 
 
 def downgrade():
     # ### commands auto generated by Alembic - please adjust! ###
-    op.drop_table('user_group_assignment')
-    op.drop_table('user')
-    op.drop_table('process_model')
-    op.drop_table('group')
+    op.drop_table("user_group_assignment")
+    op.drop_table("user")
+    op.drop_table("process_model")
+    op.drop_table("group")
     # ### end Alembic commands ###