mypy

src/spiffworkflow_backend/services/secret_service.py

@@ -55,7 +55,7 @@ class SecretService:
     def get_secret(key: str) -> SecretModel:
         """Get_secret."""
         secret = db.session.query(SecretModel).filter(SecretModel.key == key).first()
-        if secret is not None:
+        if isinstance(secret, SecretModel):
             return secret
         else:
             raise ApiError(

src/spiffworkflow_backend/services/user_service.py

@@ -262,7 +262,7 @@ class UserService:
             .filter(PrincipalModel.user_id == user_id)
             .first()
         )
-        if principal:
+        if isinstance(principal, PrincipalModel):
             return principal
         raise ApiError(
             error_code="no_principal_found",