Commit Graph

1260 Commits

Author SHA1 Message Date
jasquat b54ace56a2 fixed get call activity task data w/ burnettk 2023-03-01 12:23:04 -05:00
jasquat e2891425fc store the process instance data id on the process instance and not the other way around w/ burnettk 2023-03-01 11:39:03 -05:00
jasquat ab50e7ac03 all backend tests except for report tests are now passing 2023-03-01 10:58:12 -05:00
jasquat 035475f58f unit tests are passing except for test_process_instance_report which cannot work currently 2023-03-01 10:36:11 -05:00
jasquat 6257a402db save full_bpmn_json in a var 2023-03-01 09:55:20 -05:00
jasquat abe21db517 must add data to db 2023-03-01 09:42:41 -05:00
jasquat 950106fe21 most unit tests are passing now and the use of bpmn_json is almost gone in src 2023-03-01 09:22:38 -05:00
jasquat f74ce0f568 some logic to attempt to use the new bpmn json tables w/ burnettk 2023-02-28 17:46:14 -05:00
jasquat d5acd5a16d added new table and some notes on how to get a delta w/ burnettk jbirddog 2023-02-28 16:30:52 -05:00
jasquat 27f3da2458 added config to turn on sentry profiling w/ burnettk 2023-02-28 11:23:50 -05:00
jasquat b00de0d1a7 fixed python 3.9 syntax issue 2023-02-28 08:56:44 -05:00
burnettk a5c6d262b8 slam migrations file one last-ish time, increase task_name column length 2023-02-27 22:03:42 -05:00
burnettk 350daf0b3d allow task_name to be long 2023-02-27 22:01:08 -05:00
burnettk a1ec494ab3 let env var work on windows and fixing typing issue on python 3.9 w/ messaging stuff 2023-02-27 19:16:06 -05:00
jasquat 45feb38168 recreated all migrations to resolve postgres migration failures w/ burnettk 2023-02-27 17:27:53 -05:00
jasquat 5a873a9e2d do not run mysql commands if not doing mysql w/ burnettk 2023-02-27 17:19:03 -05:00
jasquat 35c93e3f7e do not return human tasks from errored process instances w/ burnettk 2023-02-27 16:11:26 -05:00
jasquat 09a46712d4 added debug logging when adding spiff step details w/ burnettk 2023-02-27 15:53:56 -05:00
Dan 24839a34dd Merge branch 'main' of github.com:sartography/spiff-arena into main 2023-02-27 14:40:52 -05:00
Dan 43e41fe848 Point to the latest spiffworkflow 2023-02-27 14:40:47 -05:00
jasquat 7c12709fdd fixed conflict with db migrations w/ burnettk 2023-02-27 14:33:55 -05:00
jasquat dfac872606 Merge remote-tracking branch 'origin/main' into feature/script_get_last_user_completing_task 2023-02-27 14:28:23 -05:00
jasquat 29ada38904 added script to get process initiator w/ burnettk 2023-02-27 14:28:19 -05:00
Dan e00fbdb490 run_pyl 2023-02-27 14:21:22 -05:00
Dan f16150b02b Merging main 2023-02-27 14:17:10 -05:00
Dan 150b95070c run_pyl 2023-02-27 14:05:00 -05:00
Dan e060e28c28 Needed an additional check for empty correlation keys - which on a RECEIVE message, should always match anything.
When finding messages to match a send, assure they are RECIEVE messages.

Fix some of the json output for messages sent to the front end
2023-02-27 14:01:21 -05:00
jasquat 6a4dc0f14e remove unwanted test files w/ burnettk 2023-02-27 12:08:40 -05:00
jasquat 9f84564457 script to get last user completing a task is working w/ burnettk 2023-02-27 12:08:07 -05:00
jasquat e07a122674 Merge remote-tracking branch 'origin/main' into feature/script_get_last_user_completing_task 2023-02-27 10:45:04 -05:00
Jon Herron a766e7d9a6 poetry remove orjson 2023-02-27 09:35:51 -05:00
burnettk e9b3ababc1 wip for get_last_user_completing_task script task 2023-02-25 23:31:23 -05:00
burnettk f7dc076f75 postgres really will just order however it wants if you do not specify an order_by clause 2023-02-25 22:35:46 -05:00
burnettk 647d5ee92a add ppg.ba4.sme and ba5 2023-02-24 23:42:19 -05:00
burnettk 5eb9da00f1 fix postgres db name and comment out debug job 2023-02-24 16:57:53 -05:00
jasquat b71419616d removed some unused code from task and fixed the logs table a bit w/ burnettk 2023-02-24 16:18:49 -05:00
Dan ff069cb862 run_pyl 2023-02-24 15:02:03 -05:00
jasquat 425cf3f8c1 skip failing test if postgres and added comment about cause w/ burnettk 2023-02-24 14:57:17 -05:00
Dan 0dc2bc3316 # SpiffWorkflow:
1) Type Safe checking on correlation properties (no more str())
2) A running workflows Correlations are once again at the key level.

# Backend
1) Both send and receive messages can have correlation_keys - and we compare these to each other to quickly assure a match (if they both exist - otherwise we fall back to comparing the properties on the receive to the sending messages payload)
2) Cleaned up the migrations to just one file
2023-02-24 14:53:22 -05:00
jasquat d5712a915c look users up by service and username instead of service_id since usernames have to be unique anyway w/ burnettk 2023-02-24 10:41:57 -05:00
jasquat 7a1e712c14 avoid using task-data endpoint for task data and only use it to get tasks based on spiff step instead 2023-02-24 09:21:21 -05:00
jasquat 4651eaee94 put back the task data code when getting tasks 2023-02-23 18:32:59 -05:00
jasquat 1f95fe7037 Merge remote-tracking branch 'origin/main' into feature/task_data_api_refactor 2023-02-23 17:10:23 -05:00
jasquat d53b79b18a removed commented out code w/ burnettk 2023-02-23 17:09:33 -05:00
jasquat a4c1eb96b5 removed task-data endpoints since we no longer need them w/ burnettk 2023-02-23 17:07:53 -05:00
burnettk 441bd62652 turn off profiling again 2023-02-23 16:54:38 -05:00
burnettk 5c43967ee9 add two users and update one 2023-02-23 16:39:30 -05:00
Dan 5a3b4b8792 BPMN Parser was returning all retrieval expressions, rather than the ones specific to a correlation property, as was intended.
Adding a correlation cache - so we have a reference of all the messages and properties (though still lacking a description of keys)
Adding yet another migration, maybe should squash em.
2023-02-23 16:36:32 -05:00
jasquat a9694c7678 added api to get task data and do not return from task data list anymore w/ burnettk 2023-02-23 15:59:19 -05:00
Dan 0d468a825a run_pyl (part 2) 2023-02-23 15:09:22 -05:00
jasquat 15b00bcceb Merge branch 'main' of github.com:sartography/spiff-arena 2023-02-23 15:06:27 -05:00
jasquat 68a5fe3f16 added comment about refactoring getting task data w/ burnettk jbirddog 2023-02-23 15:06:23 -05:00
burnettk ab631aab99 lint 2023-02-23 15:01:45 -05:00
burnettk 973be69df5 add test users 2023-02-23 14:58:14 -05:00
Dan 8466d823c2 Adding Migration. 2023-02-23 14:42:00 -05:00
jasquat 49fb41eff9 remove task size check since it can take a long time to run and we do not do anything with it w/ burnettk jbirddog 2023-02-23 14:41:45 -05:00
Dan 7c12dffe41 Merge remote-tracking branch 'origin/main' into feature/message_fixes 2023-02-23 14:26:04 -05:00
Dan 0030a46938 run_pyl 2023-02-23 14:17:22 -05:00
Dan 0f3ef00d72 BPMN.io -- Just show the message names not the ids - to assure we are only exposing the names.
SpiffWorkflow -
    - start_messages function should return message names, not ids.
    - don't catch external thrown messages within the same workflow process
    - add an expected value to the Correlation Property Model so we can use this well defined class as an external communication tool (rather than building an arbitrary dictionary)
    - Added a "get_awaiting_correlations" to an event, so we can get a list of the correlation properties related to the workflows currently defined correlation values.
    - workflows.waiting_events() function now returns the above awaiting correlations as the value on returned message events
 Backend
    - Dropping MessageModel and MessageCorrelationProperties - at least for now.  We don't need them to send / receive messages though we may eventually want to track the messages and correlations defined across the system - these things (which are ever changing) should not be directly connected to the Messages which may be in flux - and the cross relationships between the tables could cause unexpected and unceissary errors.  Commented out the caching logic so we can turn this back on later.
    - Slight improvement to API Errors
    - MessageInstances are no longer in a many-to-many relationship with Correlations - Each message instance has a unique set of message correlations specific to the instance.
    - Message Instances have users, and can be linked through a "counterpart_id" so you can see what send is connected to what recieve.
    - Message Correlations are connected to  recieving message instances.  It is not to a process instance, and not to a message model.  They now include the expected value and retrieval expression required to validate an incoming message.
    - A process instance is not connected to message correlations.
    - Message Instances are not always tied to a process instance (for example, a Send Message from an API)
    - API calls to create a message use the same logic as all other message catching code.
    - Make use of the new waiting_events() method to check for any new recieve messages in the workflow (much easier than
    churning through all of the tasks)
    - One giant mother of a migration.
2023-02-23 13:53:03 -05:00
jasquat 216bd799bf do not call serialize if we can use the cached bpmn_json instead w/ burnettk 2023-02-23 13:48:27 -05:00
jasquat 7dd72c72e1 Merge branch 'main' of github.com:sartography/spiff-arena 2023-02-23 11:19:26 -05:00
jasquat 2bf31fc135 turn on sentry detailed tracing for task-data w/ burnettk 2023-02-23 11:19:22 -05:00
burnettk 55f3b765ee update spiff 2023-02-23 11:02:40 -05:00
Kevin Burnett c65aeafbe3 Merge pull request #145 from sartography/data_size_script
Data size script
2023-02-22 17:36:31 -08:00
jasquat 44f31ffc36 Merge branch 'main' of github.com:sartography/spiff-arena 2023-02-22 15:35:02 -05:00
jasquat a3126da7ef set git user configs explicitly using the env vars w/ burnettk 2023-02-22 15:34:47 -05:00
burnettk 1a29e123c1 so we do not lose our minds when debugging on a server 2023-02-22 15:16:13 -05:00
jasquat 9b14510cd1 Merge branch 'main' of github.com:sartography/spiff-arena 2023-02-22 14:42:46 -05:00
jasquat c6b45dbdc3 show help text for textareas as well w/ burnettk 2023-02-22 14:42:43 -05:00
burnettk 9fb490c7f9 why not dict, too 2023-02-22 14:36:26 -05:00
Jon Herron 7fe8955adf Cleanup 2023-02-22 13:42:45 -05:00
Jon Herron 7f2d69163e Getting ./bin/pyl to pass 2023-02-22 13:34:26 -05:00
Jon Herron 488abc03ea Provide info about keys in task data and python env 2023-02-22 13:13:28 -05:00
Jon Herron 2afc19175e Unfactor to fix size calculation/type hint issues 2023-02-22 11:17:23 -05:00
Jon Herron a4c0dd52ae Getting ./bin/pyl to pass 2023-02-22 11:04:07 -05:00
Jon Herron d5fa8eae21 Adding python env size 2023-02-22 10:55:09 -05:00
Jon Herron 2fa4623876 Add cumulative task data size to script 2023-02-22 10:39:35 -05:00
burnettk bb6dd35bbd remove start and end events from simple logs view 2023-02-21 22:43:23 -05:00
burnettk 54248ca568 copy env so we are doing additive stuff rather than completely rewriting it 2023-02-21 22:00:02 -05:00
jasquat 012f5c20aa fix git bash script unbound error w/ burnettk 2023-02-21 17:08:09 -05:00
jasquat 90de749ab9 more git config updates w/ burnettk 2023-02-21 16:43:52 -05:00
jasquat c5d611f03b disable strict host checking for git commands w/ burnettk 2023-02-21 16:42:11 -05:00
jasquat e5b83d0919 fixed tests w/ burnettk 2023-02-21 15:28:54 -05:00
jasquat b0d132fc1e give access to download process data files if a user has access to start a process model w/ burnettk 2023-02-21 15:08:19 -05:00
Jakub Sokołowski 819415d487 backend: create SSH key file when contents provided
Signed-off-by: Jakub Sokołowski <jakub@status.im>
2023-02-21 20:02:16 +01:00
Jakub Sokołowski 56a913e33c backend: use sensible lock filename for git
Signed-off-by: Jakub Sokołowski <jakub@status.im>
2023-02-21 19:58:39 +01:00
Jakub Sokołowski 1bbf3a264c backend: specify --rebase when using git pull
Otherwise it fails with:
```
Pulling without specifying how to reconcile divergent branches is discouraged.
```

Signed-off-by: Jakub Sokołowski <jakub@status.im>
2023-02-21 19:58:38 +01:00
Jakub Sokołowski 1e8e6a7968 backend: fix use of SSH private key for git ops
Primarily this is supposed to fix the `git pull` aciton triggered by
webhooks from GitHub. But in addition to that the point is to simplify
that committing wrapper which has far too much in it.

Instead of passing everything as CLI arguments one should make use of
already supported environment variables and the `env` argument to
`subprocess` functions like `run()`. Writing extra logic in the wrapper
only makes it unnecessarily complicated.

By passing both user, email, and the SSH options in `run_shell_command`
we avoid the need to repeat the same boilerplate to provide Git config
and SSH credentials.

Signed-off-by: Jakub Sokołowski <jakub@status.im>
2023-02-21 19:58:36 +01:00
jbirddog 01a95011ad Look in task data/script engine environment for data, not just workflow data. (#143) 2023-02-20 18:12:50 -05:00
Dan 790483a421 run_pyl 2023-02-20 12:34:42 -05:00
Dan 5f6a61c93f * SpiffWorkflow event_definitions wanted to return a message event's correlation properties mested within correlation keys. But messages are directly related to properties, not to keys - and it forced a number of conversions that made for tricky code. So Messages now contain a dictionary of correlation properties only.
* SpiffWorkflow did not serialize correlations - so they were lost between save and retrieve.

* When comparing Correlation Property values - we are storing these values as strings in the database and can't convert them back to integers later, so I'm changing everying everywhere to compare after conversion to a string.  Don't feel great about this one.
* By using an SQL Alchemy join table, there is a lot of db queries we don't need to write.
* A few handy fucntions on db models to make it easier to work with correlations.
* Updated tests because I changed some of the BPMN models we were testing against.
* Database migration to use the new constraint names with the alternate form of the join table between correlation mesages to instance messages.
2023-02-20 11:50:35 -05:00
burnettk a600736e67 delint 2023-02-20 10:58:04 -05:00
Jakub Sokołowski fb024a49f7 backend/git_service: accept webhook test requests
https://docs.github.com/en/webhooks-and-events/webhooks/testing-webhooks

Signed-off-by: Jakub Sokołowski <jakub@status.im>
2023-02-20 13:11:21 +01:00
Jakub Sokołowski e47c0752db backend/git_service: check repo URLs from webhook
Since we are cloning a private repo we are using `ssh_url` in our case.

Signed-off-by: Jakub Sokołowski <jakub@status.im>
2023-02-20 13:02:54 +01:00
Dan d46502cd2b Allow people to run commands like "flask db upgrade" without setting specific environment variables like FLASK_SESSION_SECRET_KEY everytime - they just need to add in their own /instance/config.py with their local configuration. 2023-02-19 10:37:00 -05:00
Dan 2a800e844f * Re-work message tests so I could wrap my simple head around what was happening - just needed an example that made sense to me.
* Clear out complex get_message_instance_receive how that many-to-many works.
* Create decent error messages when correlations fail
* Move correlation checks into the MessageInstance class
* The APIError could bomb out ugly if it hit a workflow exception with not Task Spec.
2023-02-18 13:09:58 -05:00
Dan f2ca47e798 bump spiffworkflow hash 2023-02-17 13:08:45 -05:00
Dan ecbd30af00 failing test. 2023-02-17 12:10:32 -05:00
Dan ef4297331d Merge branch 'main' into feature/message_fixes 2023-02-17 12:01:38 -05:00
Dan 8e257600af work in progress -
* Link between message instance and correlations is now a link table and many-to-many relationships as recommended by SQLAlchemy
* Use the correlation keys, not the process id when accepting api messages.
2023-02-17 10:45:01 -05:00
jasquat b22c33e1d6 put the env vars in the env section of the github action configs w/ burnettk 2023-02-16 15:19:01 -05:00
jasquat 0839214fa5 added test for quickstart guide w/ burnettk 2023-02-16 15:05:55 -05:00
jasquat 435dc147df pyl 2023-02-16 14:38:19 -05:00
jasquat f5a5059ce0 Merge remote-tracking branch 'origin/main' into feature/support_local_openid_in_cypress_tests 2023-02-16 14:25:51 -05:00
burnettk 9f3bb283b3 use _GIT_SOURCE_BRANCH instead of _GIT_BRANCH 2023-02-16 14:10:31 -05:00
burnettk 888547642e fix unprefixed config 2023-02-16 13:56:48 -05:00
burnettk 5918501083 update configs for publish feature 2023-02-16 13:47:26 -05:00
jasquat a98892be32 added some support for using the backend openid server for cypress tests w/ burnettk 2023-02-16 12:09:44 -05:00
burnettk 76a701e9dd add new uses and delete ppg.ba.sme1 2023-02-16 11:53:08 -05:00
jasquat 39763c8c79 the equal sign is not apart of the env var w/ burnettk 2023-02-16 11:18:50 -05:00
jasquat cc17f31958 updated terraform deployed env config name w/ burnettk 2023-02-16 10:51:05 -05:00
jasquat 641d237e83 more config updates w/ burnettk 2023-02-16 10:21:02 -05:00
jasquat 97f23e6d4f cleaned up the default config file a bit 2023-02-16 09:05:40 -05:00
jasquat 6a6c17d71e pyl 2023-02-16 08:33:39 -05:00
jasquat c9c1ae4c16 fixed some env vars for ci 2023-02-16 07:59:51 -05:00
jasquat 5707e2c4e5 pyl 2023-02-16 07:39:40 -05:00
jasquat 7689380411 Merge remote-tracking branch 'origin/main' into feature/update_configs_with_prefix 2023-02-16 07:17:39 -05:00
burnettk 1650486a32 remove unused import 2023-02-16 06:34:03 -05:00
burnettk 01668368e7 all tests pass w/ spiff lib upgrade, thanks for the help elizabeth 2023-02-15 22:56:12 -05:00
burnettk 3cfd81efa6 format 2023-02-15 22:35:55 -05:00
jasquat 26875f13bf updated remaining configs manually w/ burnettk 2023-02-15 17:21:37 -05:00
jasquat 9b93504945 updated secret config names as well w/ burnettk 2023-02-15 17:17:47 -05:00
jasquat 3e4fc1259f updated configs to use the prefix using the script w/ burnettk 2023-02-15 17:07:12 -05:00
jasquat 909060e985 updated default user group var name for better prefix w/ burnettk 2023-02-15 16:43:40 -05:00
jasquat 09f3921236 save task data to spiff step details when copmleting a user task as well w/ burnettk jbirddog 2023-02-15 15:34:51 -05:00
jasquat 5a2e810fd6 append OPEN_ID to TENANT_SPECIFIC_FIELDS for clarification on what it is from w/ burnettk 2023-02-15 11:12:30 -05:00
jasquat 7b96335221 do not remove the default user group when refreshing permissions w/ burnettk 2023-02-15 11:09:04 -05:00
Dan 759b2bffa5 Merge branch 'main' of github.com:sartography/spiff-arena into main 2023-02-14 19:39:46 -05:00
Dan c8a83f80b6 The aud in a json web token can be a string or an array -- so also deal with the case that it is an array 2023-02-14 19:39:35 -05:00
jasquat 84f27082d4 updates to user import scripts w/ burnettk 2023-02-14 17:39:42 -05:00
jasquat 4dd8896de7 commit user if it has changed any attributes w/ burnettk 2023-02-14 15:08:25 -05:00
jasquat 4d81907966 fix for mypy on python 3.9 w/ burnettk 2023-02-14 11:34:45 -05:00
jasquat 91bd2d0710 give some leeway to iat when validating auth w/ burnettk 2023-02-14 10:51:11 -05:00
jasquat 35f8e6bfde add in debug logging when failing to login to help debug auth failures 2023-02-14 09:59:29 -05:00
jbirddog 646d803be0 Don't try to complete a ready task to move the process instance diagram to the next yellow. (#136) 2023-02-13 18:52:06 -05:00
Dan Funk 6621a7979b Merge pull request #137 from sartography/failing_test
Check the End Event to fix the failing test
2023-02-13 17:04:32 -05:00
jasquat 8b7a408f21 allow overriding keycloak url in add user script w/ burnettk 2023-02-13 16:16:43 -05:00
jasquat c9cfe8cd0b updated add test users script to use realm admin w/ burnettk 2023-02-13 16:04:57 -05:00
Jon Herron 491d30b9b3 The End Event has a spiff step 2023-02-13 14:13:34 -05:00
jasquat 683c1ee2c1 added script to import users w/ burnettk 2023-02-13 12:15:00 -05:00
jasquat 098aa69216 added api endpoint to allow logging in for the first time with an openid access_token w/ burnettk 2023-02-13 11:57:31 -05:00
Dan Funk 4caa880603 Merge pull request #135 from sartography/bug/len
This should fix the len issue - though there may be better ways to fix
2023-02-13 10:38:32 -05:00
Dan 6373761a4c run_pyl 2023-02-13 10:38:21 -05:00
burnettk bee3872842 delete 15 users that are no longer needed 2023-02-13 10:36:03 -05:00
Dan af8caeb985 Merge remote-tracking branch 'origin/main' into bug/len 2023-02-13 10:35:20 -05:00
burnettk 0e612e53f9 commit before removing users 2023-02-13 10:30:07 -05:00
Dan aaa402579f This should fix the len issue - though there may be better ways to fix
this.
This reverts commit 52b496d105.
2023-02-13 10:13:51 -05:00
Dan 52b496d105 Revert "more finally for better len"
This reverts commit feb25c286d.
2023-02-13 10:12:31 -05:00
Dan feb25c286d more finally for better len
added a fixme for raising errors
fixed up an error message
2023-02-13 10:10:23 -05:00
burnettk 45ea3b76d9 fix employee id 2023-02-12 23:43:56 -05:00
Dan 76bd40cb09 Update Spiffworkflow so we have the better error messages on service tasks. 2023-02-12 16:19:40 -05:00
Dan 014d24fbda don't default to a broken environment. 2023-02-12 15:00:17 -05:00
burnettk e18a0702d4 add five test users, rename peopleops users, delete two 2023-02-12 13:35:09 -05:00
Dan 0d0e26281d Remove version from docker-compose, as this is causing issues for people still using docker-compose v2. 2023-02-12 12:24:25 -05:00
burnettk 47ee1f73cc turn off profiling for now to see if that is what is causing segfaults 2023-02-10 09:52:23 -05:00
jbirddog ed52f07251 Save logs in finally (#134) 2023-02-10 09:18:04 -05:00
jasquat 1748a0ae7f link to the spiff step from a task on the frontend and use the correct db in ci 2023-02-09 17:07:36 -05:00
jasquat cd41be4455 pyl w/ burnettk 2023-02-09 16:03:26 -05:00
jasquat 0c30751946 call activities are also working w/ burnettk 2023-02-09 15:52:00 -05:00
jasquat 012d2bd367 tasks and subprocesses can are setting the task states properly now when getting task data w/ burnettk jbirddog 2023-02-09 15:29:45 -05:00
jasquat 7347c73d6a pyl w/ burnettk 2023-02-09 10:28:36 -05:00
Jon Herron 70f5836a2d Merge branch 'save_step_data' of github.com:sartography/spiff-arena into save_step_data 2023-02-09 09:45:50 -05:00
Jon Herron a5dc669509 Fix bug where deletes from the environment were not removed from the task data as well 2023-02-09 09:45:31 -05:00
jasquat f0de4959ae Merge remote-tracking branch 'origin/main' into save_step_data 2023-02-09 09:37:03 -05:00
Dan Funk 3ba9827670 Merge pull request #132 from sartography/feature/no_more_current_user
Feature/no more current user
2023-02-08 18:23:25 -05:00
jasquat df5451685f updated controller to use spiff step details to find correct task data to show w/ burnettk 2023-02-08 17:31:20 -05:00
Dan 18c481e3d4 run_pyl 2023-02-08 17:10:57 -05:00
Dan eb39b61488 remove the "current_user" from being added to the task_data. 2023-02-08 15:53:14 -05:00
jasquat 56249ac68a Merge remote-tracking branch 'origin/main' into save_step_data 2023-02-08 14:08:27 -05:00
jasquat c7b132ffc5 Merge remote-tracking branch 'origin/main' into save_step_data 2023-02-08 14:02:24 -05:00
burnettk d5a8475be6 pyl 2023-02-08 14:02:17 -05:00
Dan Funk a6cd94d011 Merge pull request #131 from sartography/feature/improved_service_task_errors
Feature/improved service task errors
2023-02-08 13:38:51 -05:00
Dan cbbaab482a If you have an instance/config.py to override local development it would also override testing. 2023-02-08 13:37:56 -05:00
Dan b5cd11ef37 Use a mock when making external calls in tests. 2023-02-08 13:14:42 -05:00
Dan b1d4eee781 Merge remote-tracking branch 'origin/main' into feature/improved_service_task_errors 2023-02-08 13:11:53 -05:00
burnettk 1921d0d174 Merge branch 'main' of github.com:sartography/spiff-arena 2023-02-08 12:51:52 -05:00
burnettk f9de69e511 catch up with environment change 2023-02-08 12:51:48 -05:00
jasquat 1d4a7a9b94 added additional columns to spiff_step_details w/ burnettk jbirddog 2023-02-08 12:43:30 -05:00
Dan f46909ecfb fixing some missing types 2023-02-08 12:27:55 -05:00
Dan c270ababd9 run_pyl 2023-02-08 12:00:27 -05:00
Dan 443a855782 Assure that when something goes wrong calling a service task that we get as much good information about the problem as possible. 2023-02-08 11:53:20 -05:00
jasquat 2dc1e00d69 Merge remote-tracking branch 'origin/main' into save_step_data 2023-02-08 11:47:11 -05:00
jasquat 9b3a2e2fb2 enable faulthandler to hopefully see seg faults in the logs w/ burnettk jbirddog 2023-02-08 11:42:11 -05:00
Jon Herron a0e36854bf Merge branch 'main' into save_step_data 2023-02-08 10:14:07 -05:00
burnettk 368330f561 remove dup 2023-02-08 09:52:40 -05:00
burnettk 81a379a2e9 add users 2023-02-08 08:04:30 -05:00
jasquat 4bf191af31 Merge pull request #114 from sartography/frontend/use-api-subpath
frontend: use /api subpath instead of subdomain
2023-02-07 17:20:45 -05:00
jasquat ec283a2558 allow setting configs for the frontend through env vars w/ burnettk 2023-02-07 17:17:45 -05:00
jasquat 0162821b4c allow configuring gunicorn configs in boot_server_in_docker w/ burnettk 2023-02-07 15:38:29 -05:00
burnettk a644a5b447 sentences need spaces between them 2023-02-07 15:09:49 -05:00
jasquat 559d9a78d8 renamed development env to local_development and testing to unit_testing w/ burnettk 2023-02-07 15:02:47 -05:00
jasquat 80555872ce set up qa2 to only do path based routing w/ burnettk 2023-02-07 14:30:13 -05:00
jasquat c659cc86fc added backend url to qa2 configs 2023-02-07 13:46:54 -05:00
jasquat 884f8bb872 added qa2 configs to use keycloak on qa1 to test different domains w/ burnettk 2023-02-07 11:30:18 -05:00
Dan Funk 462008da5e Merge pull request #128 from sartography/feature/bug_fixes
Feature/bug fixes
2023-02-07 08:20:16 -05:00
Kevin Burnett 721e86f351 Update tasks_controller.py 2023-02-06 16:21:55 -08:00
burnettk c74719d13d update get_token 2023-02-06 17:55:07 -05:00
jasquat 9d8dcc20f1 pass tenant attributes when creating a user w/ burnettk 2023-02-06 17:34:55 -05:00
jasquat 0fa91dc761 pyl w/ burnettk 2023-02-06 16:26:42 -05:00
jasquat d1bf3b69b9 Merge remote-tracking branch 'origin/main' into feature/tenant-specific-fields-from-openid 2023-02-06 16:24:59 -05:00
jasquat ad503ae2cd added bambooid to status users w/ burnettk 2023-02-06 16:24:48 -05:00
Jon Herron 7070503239 POC for saving some data about each step 2023-02-06 15:59:26 -05:00
jasquat b42fa26f14 allow added custom attributes to users when adding to keycloak w/ burnettk 2023-02-06 15:34:55 -05:00
jbirddog f728fc64d5 Backend do_engine_steps performance improvements (#129)
Co-authored-by: Dan <daniel.h.funk@gmail.com>
2023-02-06 15:25:49 -05:00
jasquat 5452b48d08 use our json encoder to dump the user for get_current_user script w/ burnettk 2023-02-06 14:11:15 -05:00
Dan a2f91999e2 Use the same markdown library for displaying as for editing - could enable a security run_pyl 2023-02-06 12:20:29 -05:00
Dan 7a6c63cb85 When catching non-jinja errors from Jinja, raise a good error message, and make a best effort at tracking down the line number and error line if possible. 2023-02-06 12:06:37 -05:00
burnettk 2c3b88042e move towards returning dict in get_current_user 2023-02-06 10:30:38 -05:00
burnettk d6d960e20f Merge remote-tracking branch 'origin/main' into feature/tenant-specific-fields-from-openid 2023-02-06 10:20:40 -05:00
burnettk e813f3e26e add test users 2023-02-06 10:03:51 -05:00
Dan 015036353e run_pyl 2023-02-06 08:05:33 -05:00
Dan a248e868b7 When searching for human tasks to determine if the current user can complete it, filter on the "completed" flag.
Front-end -- enable the form if you receive an onUnathorized error because the thing you are unauthorized to do might have nothing to do with whether you can submit the form.
2023-02-06 08:01:37 -05:00
Jon Herron 38dd1dcf61 Back to inserting every log 2023-02-04 12:55:48 -05:00
burnettk 2b1f534bd8 hoping to fix tests on windows 2023-02-04 00:36:17 -05:00
burnettk 8d6a160ea0 grab bamboo_id from keycloak 2023-02-04 00:12:01 -05:00
burnettk ed34d1c343 lint 2023-02-04 00:09:43 -05:00
burnettk 67667828c2 if there are tenant specific fields in the config, transfer them from openid token to db 2023-02-04 00:03:32 -05:00
Dan 6bd9fa5c00 Merge branch 'main' of github.com:sartography/spiff-arena into main 2023-02-03 17:01:13 -05:00
Dan 92fa390fc9 Fix that dreadful unknown "KeyError" exception that was cropping up.
Adding a bit of detail to the spiffworkflow exceptions when a duplicate process model is found.
Disable the submit button on tasks after you click submit (avoid the double click and give users a better experience)
2023-02-03 17:01:03 -05:00
Kevin Burnett 84f3bd90cf Merge pull request #125 from sartography/feature/dynamically-hide-fields-w-task-data
Feature/dynamically hide fields w/ task data
2023-02-03 13:20:19 -08:00
burnettk e441dc35a1 refactor some stuff in task_show to separate functions 2023-02-03 16:17:36 -05:00
burnettk 11a9e740af show that hiding nested fields works as well 2023-02-03 15:47:35 -05:00
burnettk 1247189bf8 make form schema and form ui schema both dicts, add support for hiding fields based on task data 2023-02-03 15:40:14 -05:00
Dan d82299b997 run_pyl 2023-02-03 13:58:38 -05:00
Dan Funk 009a5b1768 Merge branch 'main' into feature/more_better_errors 2023-02-03 13:21:48 -05:00
burnettk b481de0a61 add more users, and try to prevent sentry notification again 2023-02-03 13:11:39 -05:00
burnettk b782c3faa7 remove service accounts, formalize j, add madhurya 2023-02-03 13:02:50 -05:00
burnettk 18070c5be3 make test_user_lists more complete and correct 2023-02-03 12:51:57 -05:00
burnettk b9783ae0ed clean up sentry notification and avoid logger.exception when we do not want sentry 2023-02-03 11:06:40 -05:00
burnettk a31d89b25a couple last serializer updates 2023-02-02 22:04:34 -05:00
burnettk 58f9d87a00 import EventBasedGatewayConverter from correct package 2023-02-02 21:55:26 -05:00
burnettk 3d5647d166 try to improve exception handling by avoiding raising ApiError from services 2023-02-02 19:00:58 -05:00
burnettk 4934014ba9 simplify spiff integration post serializer update, w/ elizabeth and jon 2023-02-02 15:40:01 -05:00
Jon Herron 643fef7c20 Quick fix for url building 2023-02-02 15:04:57 -05:00
jbirddog 4240946334 File download from workflow data (#122) 2023-02-02 14:44:37 -05:00
jbirddog a815863727 Allow for different Python Environments when executing scripts within SpiffWorkflow (#121) 2023-02-02 10:24:55 -05:00
burnettk 6a0848f895 add keycloak users 2023-02-02 09:54:19 -05:00
burnettk 34800463fd bulk insert logs for performance improvement 2023-02-01 17:06:34 -05:00
burnettk c669aeff27 there is no need to ever sentry_sdk.start_transaction because the flask integration does that 2023-02-01 13:44:12 -05:00
burnettk e460325e60 get some more insight into connector proxy timings 2023-02-01 13:30:45 -05:00
burnettk 48781039c7 avoid poetry installing deps when we have them cached if they do not change 2023-02-01 07:53:35 -05:00
burnettk f58be8fe91 more spans to track performance 2023-02-01 07:45:48 -05:00
burnettk 3abe82af4a more sentry performance tracing 2023-01-31 22:30:15 -05:00
burnettk cb4429e837 folks who can start instances can also view their logs 2023-01-31 17:11:11 -05:00
burnettk 0e94a4f4cf shuffle around Dockerfile to allow to work for background container 2023-01-31 16:14:22 -05:00
Dan Funk 6032486985 Merge pull request #117 from sartography/feature/authorization
move away from using the auth_token from the open id server as a token between the front end and backend.
2023-01-31 12:03:51 -05:00
burnettk 4c47f0b711 allow overriding git related configs w/ env var and log permissions stuff on boot 2023-01-30 18:40:03 -05:00
Dan 2d70d0289b Merge branch 'main' into feature/more_better_errors 2023-01-30 17:08:10 -05:00
Dan Funk 53fc687a54 Merge pull request #115 from sartography/backend/improve-dockerfile
backend: avoid redundant steps in Dockerfile
2023-01-30 17:02:35 -05:00
Dan 2152b3f5a6 Fix typing issue. 2023-01-30 16:50:43 -05:00
Dan d83e5a70bc Use the id_token, not the auth_token from the open id server for authentication with the front end. The auth_token should be kept safe, and not guranteeded to be a json token. 2023-01-30 13:09:23 -05:00
burnettk e1c2af3b52 add four new status users to spiff realm 2023-01-30 11:57:22 -05:00
Jakub Sokołowski 3e82ac5f07 backend: avoid redundant steps in Dockerfile
Use separate `base`, `setup` and `final` to avoid redundat steps.
Avoid runnig `poetry` twice, and add `source` and `description`.

Signed-off-by: Jakub Sokołowski <jakub@status.im>
2023-01-30 16:23:37 +01:00
jasquat 297d0ddb79 removed old pin to spiffworkflow w/ burnettk 2023-01-27 13:21:39 -05:00
jasquat bec1b43cfb tests are passing now w/ burnettk 2023-01-27 13:20:22 -05:00
jasquat 54f795da7b some initial updates w/ burnettk 2023-01-27 12:51:19 -05:00
Jon Herron 917453156d Allow set to be called from scripts 2023-01-27 07:03:45 -05:00
burnettk 909fc6ca89 update lock file in backend and arena, though that one needs pruning 2023-01-26 21:59:02 -05:00
Dan 956c309476 run_pyl 2023-01-26 18:39:51 -05:00
Dan 2b433f419d Workflow Data Exceptions were not getting processed, we now catch the WorkflowDataException through the generic top level SpiffWorkflowException. 2023-01-26 18:26:17 -05:00
jasquat c939a79df3 updated prefix for background instances w/ burnettk 2023-01-26 15:38:14 -05:00
Kevin Burnett 74191e3b45 Merge pull request #110 from sartography/feature/jinja_errors
Feature/jinja errors
2023-01-26 08:24:48 -08:00
burnettk 9522a5fce0 add keycloak users 2023-01-26 09:31:01 -05:00
jasquat 5f7dac332f pyl 2023-01-26 07:46:36 -05:00
jasquat 9e3640b169 set the correct type for task since SpiffTask and a backend task are not the same 2023-01-26 07:35:13 -05:00
jasquat 500b5f0068 increased the task data size 2023-01-25 17:45:47 -05:00
jasquat 9fb2b01e3c added pylint back to lock file 2023-01-25 17:35:22 -05:00
jasquat 13b442f7f8 Merge remote-tracking branch 'origin/main' into feature/jinja_errors 2023-01-25 17:30:55 -05:00
Dan b2fb0dd79f run_pyl had various recommendations that I find a bit of a pain in the butt, but that I did anyway. 2023-01-25 16:43:28 -05:00
jasquat 071f2b5251 Merge pull request #109 from sartography/feature/upgrade_bandit
upgraded bandit and flake8 w/ burnettk
2023-01-25 16:25:21 -05:00
jasquat 80eb29c283 removed debug print statements 2023-01-25 16:25:03 -05:00
jasquat ddb55a0ce1 ensure we are passing the primary file name to the delete file test 2023-01-25 16:20:55 -05:00
jasquat 63e61ba1ec fixed typo w/ burnettk 2023-01-25 16:08:58 -05:00
jasquat 1ce3fbe542 added some debug statements for ci w/ burnettk 2023-01-25 16:02:07 -05:00
jasquat cc85146678 upgraded bandit and flake8 w/ burnettk 2023-01-25 15:44:53 -05:00
Dan a38ecc2e60 Merge remote-tracking branch 'origin/main' into feature/jinja_errors 2023-01-25 15:38:52 -05:00
jasquat ada389b572 allow removing users from groups when refreshing permissions w/ burnettk 2023-01-25 15:12:48 -05:00
Dan 40682d0592 Added useMemo to error context
No longer clear errors in the task bar, as that will constantly remove them as soon as they are shown.
2023-01-25 15:09:05 -05:00
jasquat eb1ac56617 Merge branch 'main' of github.com:sartography/spiff-arena 2023-01-25 14:36:05 -05:00
jasquat 7bf8618267 when changing the primary file name also change the primary process when updating a process model from the api w/ burnettk 2023-01-25 14:36:01 -05:00
Dan d63f0c2a91 Making sure we create informative messages when encountering jinja2 syntax errors. 2023-01-25 14:13:21 -05:00
burnettk def02a5f56 delete legacy flask-rendered html pages from initial prototype, since backend is now API-only 2023-01-25 11:30:19 -05:00
jasquat 5b88f88d31 added the process model identifier for the diagram if it is not the top level w/ burnettk 2023-01-25 10:39:17 -05:00
jasquat 070d589eb0 Merge pull request #107 from sartography/feature/metadata_on_instance_show
Feature/metadata on instance show
2023-01-24 16:54:43 -05:00
jasquat d86c083dfe do not allow deleting primary bpmn file and do not allow instantiating models without a primary bpmn file w/ burnettk 2023-01-24 15:15:48 -05:00
jasquat be1d306a2f show metadata on instance show page but for some reason it reorders elements w/ burnettk 2023-01-24 14:35:27 -05:00
jasquat 4e0ddc7ea5 removed uniqueness constraint from human task so we can loopback to a previous task with a gateway w/ burnettk 2023-01-24 11:03:55 -05:00
jasquat 6371703637 ensure order of permissions in tests 2023-01-24 10:23:47 -05:00
burnettk 5ed1b2e2da document future enhancement 2023-01-23 17:48:06 -05:00
jasquat 2d57c3d45f strip off newlines and spaces when importing secrets and pinning spiffworkflow to working version until we can debug issues with new one w/ burnettk 2023-01-23 17:18:47 -05:00
jasquat 102413326a added locking system for process instances so hopefully background jobs will not take instances currently being run by the user w/ burnettk 2023-01-23 16:45:07 -05:00
jasquat 809c4b055a added uniqueness constraint to spiff step details w/ burnettk 2023-01-23 11:03:17 -05:00
burnettk 1215e18287 add sum and format 2023-01-22 18:10:47 -05:00
jasquat 336923b1e5 expanded functionality of the form builder 2023-01-21 20:51:11 -05:00
burnettk dd68e7556b Revert "allow updating models on staging for a bit"
This reverts commit aff7c5c9e9.
2023-01-20 20:47:00 -05:00
burnettk 3e190387db Revert "commit on save yes for now"
This reverts commit 2a55c05473.
2023-01-20 20:46:52 -05:00
burnettk b4a19f2d71 qa1 2023-01-20 20:44:01 -05:00
burnettk fd2146bd46 since accepting the github host entry programatically is no more secure 2023-01-20 19:06:59 -05:00
burnettk 2a55c05473 commit on save yes for now 2023-01-20 19:00:46 -05:00
burnettk aff7c5c9e9 allow updating models on staging for a bit 2023-01-20 18:07:29 -05:00
jasquat 79958d4ae5 allow getting the GIT SSH key from an app config so we can set it in the secrets file w/ burnettk 2023-01-20 15:43:00 -05:00
jasquat d8cf4b1287 allow specifying an ssh key for git instead of a username and password w/ burnettk 2023-01-20 15:11:23 -05:00
jasquat d1b8e314f4 updated admin user on sartography realm w/ burnettk 2023-01-20 14:09:03 -05:00
jasquat 3da4f1caa1 allow passing a realm name into start keycloak and added admin user to sartography realm 2023-01-20 13:21:52 -05:00
jasquat 3f4781c5ee find the top level process to find the task form when using subprocesses in called activities w/ burnettk danfunk 2023-01-20 12:03:29 -05:00
jasquat c5aff424b6 pyl w/ burnettk 2023-01-19 15:37:55 -05:00
Kevin Burnett ff10754b88 Merge branch 'main' into feature/improved_errors 2023-01-19 12:18:02 -08:00
jasquat d54897828d ensure we have something in the logs w/ burnettk 2023-01-19 15:16:59 -05:00
jasquat 5ef4ea7b62 pyl w/ burnettk 2023-01-19 15:03:33 -05:00
jasquat b529af6142 added configs for sartography env w/ burnettk 2023-01-19 14:54:39 -05:00
Dan d44b7d5d34 pre-commit-in-ci 2023-01-19 14:00:36 -05:00
Dan cf1fcf9966 updating spiffworkflow version, and fixing the run_pyl (by removing the corft I stuck in earlier) 2023-01-19 13:55:35 -05:00
Dan 8496b722fd Merges 2023-01-19 13:26:13 -05:00
Dan 3c12e8ad35 Lots of adjustments from running pyl
Main change is in the ErrorDisplay.tsx to assure all error information is provided. and index.css to make it "pretty"
2023-01-19 12:36:45 -05:00
jasquat 21f7b04039 added new test users for status in keycloak w/ burnettk 2023-01-19 12:21:25 -05:00
jasquat 306676aa11 added script to add test keycloak users and moved all keycloak stuff to keycloak directory w/ burnettk 2023-01-19 12:18:05 -05:00
jasquat dd8427bd32 pin SpiffWorkflow to passing version for CI tests w/ burnettk 2023-01-19 11:10:36 -05:00
jasquat b5be1745d8 Merge pull request #105 from sartography/feature/avoid_logs_when_call_activity_waiting
do not write to logs when a task is inheriting data from the parent w…
2023-01-19 11:08:51 -05:00
jasquat ed86a7f843 disabled flake8 forcing comments to avoid all of the useless comments but still enforcing the formatting of comments if they exist w/ burnettk 2023-01-19 10:41:26 -05:00
jasquat f5b77f9245 show start events in logs as well and added bpmn process identifiers to log table w/ burnettk 2023-01-19 10:06:30 -05:00
burnettk edf11f76cf downgrade spiff and upgrade some other stuff 2023-01-19 07:59:26 -05:00
burnettk cd07be3e28 upgrade certifi to fix security vulnerability 2023-01-19 07:38:57 -05:00
jasquat 238308ca79 do not allow overwriting process models and process groups w/ burnettk 2023-01-18 14:40:03 -05:00
jasquat fa4c3d26d7 added End Event to simple log view w/ burnettk 2023-01-18 12:01:37 -05:00
jasquat 2a9f63e9b8 pyl w/ burnettk 2023-01-18 10:39:53 -05:00
jasquat c2daae0420 skip failing xml test on windows w/ burnettk 2023-01-18 10:38:43 -05:00
jasquat f3c404aa09 use the correct windows path separator in test file 2023-01-18 09:43:19 -05:00
jasquat e977788447 favor user_input_required over waiting status for process instances w/ burnettk 2023-01-17 17:09:26 -05:00
jasquat d6edbe896a fixed broken test w/ burnettk 2023-01-17 16:17:04 -05:00
jasquat 223a49ee5b only show milestones for simple log view w/ burnettk 2023-01-17 16:13:11 -05:00
jasquat fe19a172cf do not resolve entities when parsing xml w/ burnettk 2023-01-17 14:58:54 -05:00
Dan 28a28e353b Removing dependency on flask-bpmn and taking it out of SpiffArena
Slightly updating the APIError code for recent updates to SpiffWorkflow's error refactoring.
2023-01-17 12:56:06 -05:00
jasquat 7194864e6d do not write to logs when a task is inheriting data from the parent w/ burnettk 2023-01-17 12:23:51 -05:00
jasquat afa0256bc3 updated open id url for compose ci 2023-01-16 13:27:44 -05:00
jasquat e062f965d8 pyl 2023-01-16 13:11:25 -05:00
jasquat d70acde4c0 fixed cypress tests 2023-01-16 12:24:02 -05:00
burnettk f46e3604e7 postgres does not have group_concat, and it is stricter about getting back columns when grouping 2023-01-15 00:22:40 -05:00
Kevin Burnett 5d5f1e777c Merge pull request #102 from sartography/feature/waku-fault-message
Feature/waku fault message
2023-01-13 11:47:05 -08:00
Kevin Burnett 81272a55a7 Merge pull request #101 from sartography/task_data_len
Throw an exception if max task data length is exceeded
2023-01-13 11:43:46 -08:00
jasquat 419f23490d Merge branch 'main' of github.com:sartography/spiff-arena 2023-01-13 14:41:55 -05:00
jasquat ae02575183 fixed broken test w/ burnettk 2023-01-13 14:41:51 -05:00
jbirddog 0fe6bbfd80 Skip refresh steps (#103) 2023-01-13 14:32:19 -05:00
jasquat 14397099f4 added tasks table to process instance show page w/ burnettk 2023-01-13 14:31:12 -05:00
mike cullerton be54381830 Merge branch 'main' into feature/waku-fault-message 2023-01-13 12:11:40 -05:00
mike cullerton c3e1dda51e run_pyl changes 2023-01-13 11:50:36 -05:00
Jon Herron 91a0f05b11 Fixed failing test 2023-01-13 11:11:12 -05:00
jasquat 0038f41a88 stop at call activity as well when getting calling subprocesses by child id w/ burnettk 2023-01-13 10:43:25 -05:00
Jon Herron b933743717 Getting ./bin/pyl to pass 2023-01-13 09:45:05 -05:00
Jon Herron 6f536dff86 Merge branch 'main' into task_data_len 2023-01-13 09:37:32 -05:00
Jon Herron 5b5c6e0265 Bump the limit to 1mb 2023-01-13 09:12:41 -05:00