Commit Graph

3036 Commits

Author SHA1 Message Date
jasquat 4059f63fb6 catch and handle exceptions when attempting to complete human tasks (#380)
* catch and handle exceptions when attempting to complete human tasks w/ burnettk

* fix lint

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
Co-authored-by: burnettk <burnettk@users.noreply.github.com>
2023-07-12 19:46:05 +05:30
jasquat c2706c5bde Feature/unlock stale locks (#360)
* set locked_at_in_seconds so we can find stale locks w/ burnettk

* added background job to cleanup old locks w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-07-12 19:45:27 +05:30
jasquat c936c02db0 use mysqlclient instead of mysql-connect w/ burnettk (#358)
* use mysqlclient instead of mysql-connect w/ burnettk

* updated some comments w/ burnettk

* runs tests in parallel in run_pyl

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
Co-authored-by: burnettk <burnettk@users.noreply.github.com>
2023-07-12 19:44:49 +05:30
jasquat 841f3ccc8c Feature/task assignment (#352)
* added an api to assign a list of users to a task w/ burnettk

* use the modal submit and close buttons when saving task data on the instance show page w/ burnettk

* switch save and cancel buttons on secrets new page w/ burnettk

* add some icons, tho still missing event stuff

* finished adding imporoved icons and fixing up task modal w/ burnettk

* added some user search options to assig tasks to w/ burnettk

* cleaned up task details modal and added call to backend to add potential users w/ burnettk

* fixed broken tests w/ burnettk

* removed some merge comments w/ burnettk

* process instance id is an int not a str w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
Co-authored-by: burnettk <burnettk@users.noreply.github.com>
2023-07-12 19:44:01 +05:30
jasquat 93b8c09e90 fixed linting issue 2023-07-12 08:38:38 -04:00
jasquat e2e7808f09 display the validation error message the user input w/ burnettk (#386)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
Co-authored-by: burnettk <burnettk@users.noreply.github.com>
2023-07-12 11:40:48 +05:30
burnettk b7aa82bd08 fix security issue 2023-07-11 15:57:11 -04:00
jasquat 800b61cf36 fixed pagination of log tables and broken cypress tests w/ burnettk (#382)
* fixed pagination of log tables and broken cypress tests w/ burnettk

* wait before clicking the profile button instead of after w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-07-10 14:06:55 -04:00
burnettk 9285358e69 Merge remote-tracking branch 'origin/main' into deploy-app-dev 2023-07-08 11:58:23 -04:00
burnettk 417fe51faf fix compilation issue 2023-07-08 11:57:51 -04:00
Madhurya Liyanage 11ab2ff883 Merge branch 'main' into deploy-app-dev 2023-07-08 10:11:23 +05:30
jasquat 277d37e494 commented out references to how_to doc since how_to was deleted w/ burnettk 2023-07-07 16:56:37 -04:00
Dan Funk 18ea7510c6 Feature/fix_action_column (#357)
* removing action column.

* adding the action column back in, and making it work.
2023-07-07 16:02:27 -04:00
Phillana26 484b93887e in_depth_topics (#376)
* in_depth_topics

* Mostly fixing capitalized names and some foward vs back-slashes in file paths.

---------

Co-authored-by: danfunk <daniel.h.funk@gmail.com>
2023-07-07 16:00:57 -04:00
Dan Funk 2b6d1c334f make sure we have a current processor so we don't return null (#379)
* make sure we have a current processor so we don't return null

* remove sleep

* The background processor now only picks up processes that were last updated more than a minute ago to avoid conflicting with the interstitial page.  With the understanding that we can rmeove this limitation when we can refactor to allow the backend processes to provide updates on what they are doing.

* pyl w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-07-07 15:49:52 -04:00
usama9500 92bd5d8883 Adding Essential Example (#365)
* Adding Essential Example

* fixing lowercase Images

* fixing image size

* fixing build issues

* Image Alignments

* minor tweaks.

---------

Co-authored-by: danfunk <daniel.h.funk@gmail.com>
2023-07-07 15:39:00 -04:00
Phillana26 340af365ff Create how to (#348)
* how_to_section

* how-to-before-index

* Fixed links and image sizes

* fix links and images size

* push

* kill last notion links

---------

Co-authored-by: burnettk <burnettk@users.noreply.github.com>
Co-authored-by: danfunk <daniel.h.funk@gmail.com>
2023-07-07 15:10:24 -04:00
jasquat b7627716df Merge remote-tracking branch 'origin/main' into deploy-app-dev 2023-07-07 11:18:52 -04:00
jasquat c112e65232 fixed linting issue w/ burnettk 2023-07-07 11:18:45 -04:00
jasquat 19d7a008d9 merged in main and resolved conflicts w/ burnettk 2023-07-07 11:04:11 -04:00
jasquat 90bfc53380 use a sha256 value as the id of the page when checking active-users w/ burnettk (#356)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-07-07 20:24:57 +05:30
jasquat 5ffb3e5ae5 restrict to specific user if querying for instances with tasks waiting for me w/ burnettk (#372)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-07-07 20:24:10 +05:30
jasquat 7c3c3af057 also check human task table for completed by user when determining if… (#370)
* also check human task table for completed by user when determining if an instance is associated with a user

* update pygments

* added some comments for clarity w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
Co-authored-by: burnettk <burnettk@users.noreply.github.com>
2023-07-07 20:22:57 +05:30
Kevin Burnett e6094a83a8 do not convert null to a string when clearing out a typeahead field w/ burnettk (#373)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-07-07 20:21:22 +05:30
Dan Funk 1a6a2c0ae9 Feature/fix diagram zoom (#378)
* Revert "set undefined values to null rjsf form data w/ burnettk (#336)"

This reverts commit cca9b147f6.

* Quick test to check if calls are happening correctly to resize the diagram.

* Quick test to check if calls are happening correctly to resize the diagram.

* remove all the logic around fitviewport limitations, which doesn't seem to be requured.  For some reason (modeler as any).constructor.name return '_9' on the dev server, rather than returning 'Modeler', 'Viewer' etal ...

* drop console log

* Clean up comments.

---------

Co-authored-by: Jakub Sokołowski <jakub@status.im>
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
Co-authored-by: burnettk <burnettk@users.noreply.github.com>
Co-authored-by: Madhurya Liyanage <liyanagemadhurya@gmail.com>
2023-07-07 10:11:12 -04:00
danfunk e099fc0edc remove all the logic around fitviewport limitations, which doesn't seem to be requured. For some reason (modeler as any).constructor.name return '_9' on the dev server, rather than returning 'Modeler', 'Viewer' etal ... 2023-07-06 20:03:30 -04:00
danfunk 475417b9a6 Quick test to check if calls are happening correctly to resize the diagram. 2023-07-06 18:30:44 -04:00
danfunk 1b5c3b54cb Quick test to check if calls are happening correctly to resize the diagram. 2023-07-06 17:29:16 -04:00
danfunk 9107263f3a Merge branch 'main' into deploy-app-dev 2023-07-06 16:39:05 -04:00
Dan Funk 746a41c524 Feature/never ending UI tweaks 2 (#377)
* Using a rem based measurement rather than pixels, to better handle 4k displays and their adjusted font sizes - and setting relatively large breakpoints and page width limits that should result in a better view of the tables on the home page.

* Here is the latest:

    * Improved metadata display on the process instance page, with better widths, grayed out text (which I lost at some point).
    * Reduced the End Task "instructions for end user" size, and added a fade out on the bottom.
    * Improved the "chicken buttons" for custom columns on the process instance list filters, which can now accommodate very long names for the columns.
    * Removed the "show-page" which is more consistently handled by the content wrappers for the different routers.
2023-07-06 16:38:44 -04:00
danfunk 7be729ff6c Merge branch 'main' into deploy-app-dev 2023-07-06 16:23:14 -04:00
jasquat 95068495ba Bug/process locking (#375)
* re-enable the move canvas and zoom modules, and try like hell to get the !@#$! display to zoom to fit consistently. As the from_xml does not trigger the "import.done" where the resize is happening.

* Clicking on timestamp should reload the page so we are observing the diagram at the correct point in time.

* Use a grid rather than a stack for the filter buttons, make them a consistent width, and force the close "x" button to the far right.

* Better handling the lots and lots of metadata fields in both the process instance list table, and in the metadata information on the process instance view page.

* Using DL rather than Carbon's grid, because my mind was starting to break.
* Process instance List Tables are set to optimize their max width for readability.

* assure the diagram editor is top aligned - otherwise when the proprties pannel get's super duper long (as with recent additions to multi-instance) we don't end up with weird spaces showing up above a center aligned canvas.

* wip

* updated interstitial to exit at the correct time if already locked

---------

Co-authored-by: danfunk <daniel.h.funk@gmail.com>
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-07-06 16:21:02 -04:00
Madhurya Liyanage 175f8f7d66 Merge branch 'main' into deploy-app-dev 2023-07-06 09:43:20 +05:30
Dan Funk dbe52af9f4 Feature/never ending UI edits (#374)
* Basically shift our ui to something similar to Google's search results page - where we have a strong left padding that offsets against our logo, and a fixed width for our content, that can be breached in some circumstances (such as when tables are very large).  This breaking can happen for both our standard tables, as well as markdown tables.   This does not include the fix for locking - which is still in progress.

* modified routes so that most routes are within a "fixed-width-container" but our BPMN editor can still take up 100% of the screen.
* fixed-width-container has breakpoints at 1056 (remove all padding) and 1400 (limit width to a max of 1280)  but in all cases allow for an overflow of visible - so tables can extend beyond this limit when needed,
* Removed "Messages" as a heading from the tab view - but left on the /messages route.

* Lint fixing
2023-07-06 09:41:18 +05:30
jasquat 25eb8b30f1 give user access to pi for-me with all perm to process group w/ burnettk (#371)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-07-05 14:47:15 -04:00
Madhurya Liyanage 8d7a8a930a Merge branch 'main' into deploy-app-dev 2023-07-04 20:12:54 +05:30
danfunk d56809b141 Lint fixing 2023-07-04 10:22:14 -04:00
Madhurya Liyanage 7715c9acf2 Merge branch 'main' into deploy-app-dev 2023-07-04 09:30:37 +05:30
Dan Funk 771f54b7b4 Bug/UI fixes (#369)
* re-enable the move canvas and zoom modules, and try like hell to get the !@#$! display to zoom to fit consistently. As the from_xml does not trigger the "import.done" where the resize is happening.

* Clicking on timestamp should reload the page so we are observing the diagram at the correct point in time.

* Use a grid rather than a stack for the filter buttons, make them a consistent width, and force the close "x" button to the far right.

* Better handling the lots and lots of metadata fields in both the process instance list table, and in the metadata information on the process instance view page.

* Using DL rather than Carbon's grid, because my mind was starting to break.
* Process instance List Tables are set to optimize their max width for readability.

* assure the diagram editor is top aligned - otherwise when the proprties pannel get's super duper long (as with recent additions to multi-instance) we don't end up with weird spaces showing up above a center aligned canvas.
2023-07-04 09:29:46 +05:30
Madhurya Liyanage 6b9ae6df01 Merge branch 'main' into deploy-app-dev 2023-07-03 22:33:21 +05:30
jasquat c8bdf3a109 print the status of the backgroun processor as well as the instance id (#368)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-07-03 22:32:57 +05:30
Madhurya Liyanage 72519a5260 Merge branch 'main' into deploy-app-dev 2023-07-03 10:55:30 +05:30
jasquat e4bf22f5cf Feature/interstitial summary part 3 (#367)
* throw an error if backend gives a 500 from interstitial page w/ burnettk

* turn unexpected errors for the interstitial page into event stream responses to avoid error misdirection

* pyl

* raise the api_error from the original and make the render_data method private

* Feature/interstitial summary (#337)

* * Process instance logs and messages are now components rather than pages, and are included within tabs on the process instance page, along with the diagram.
* Removed the Zoom and Move modules when showing the readonly
  Diagram.  Assured this readonly view is resized to fit the space when possible.
* Checkbox Widget no longer displays a duplicate label.
* CSS Tweaks
  * All pages are limited to a max display width of 1440, with auto margins to center the main content on the page.
  * "Show" pages, like ProcessInstanceShow, TaskShow have the primary content limited to 1000, also with auto-margins.
  * Paragraphs, headings, blockquotes, list items are limited to a width of 640.
  * Reduced margin bottom on all breadcrumbs.
  * Slightly reduced the width and margin of tiles
  * ordered lists and unordered lists show numbers and bullets now.
* End user Instructions component can, optionally, auto-collapse, so that only a portion is displayed, along with a toggle.  This is how it is set up for the ProcessInstanceShow page.
* Greatly reduced the lag in the interstitial page when doing a re-direct.

* run_pyl

* kill console

* wait for permissionsLoaded too since we are using ability.can

* Previous change removed the top level Messages page - this re-adds it.

* I am always, ALWAYS shocked at how I can not wrap my head around when and where to use "useEffect".

This should cause the show/hide Instructions toggle to only show when useful.

* Minor cleanup on the process instance properties display.

* linting

---------

Co-authored-by: burnettk <burnettk@users.noreply.github.com>

* Fix a linting error.

* minor permissions related fixes for the new ui.

* Revert "Revert "Feature/better subworkflow management (#331)""

This reverts commit 48dcde8faf.

* do not execute tasks from the process instance show page w/ burnettk

* pyl w/ burnettk

* Very minor UI tweak to resolve a number of issues mentioned in SPIFF-316 Notion Ticket:

* Markdown links now open in a new window
* Tables on the home pages are now contained within Grids to better align them with the other content that is in a grid.
* Right aligned the "process instance list link" button to it is flush right with the table underneath
* Gave a little more breathing room the content on the info/metadata in the process instance view .

* updated docker image build action to contain the appropriate version info w/ burnettk

* properly resize to the available columns depending on s/m/l

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
Co-authored-by: Dan Funk <daniel.h.funk@gmail.com>
Co-authored-by: burnettk <burnettk@users.noreply.github.com>
2023-07-03 10:54:54 +05:30
Madhurya Liyanage 291d1e0d0a Merge branch 'main' into deploy-app-dev 2023-06-30 23:34:38 +05:30
Dan Funk 532c0f841f bumping version of BPMN-JS-Spiffworkflow (#366) 2023-06-30 23:17:58 +05:30
Madhurya Liyanage ac429fe652 Merge branch 'main' into deploy-app-dev 2023-06-30 13:04:43 +05:30
jasquat 766a7e491e delete the draft task data when the task has been submitted (#364)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-30 13:03:56 +05:30
jasquat e30488c95b added cascade delete to process instance so task draft data is deleted (#361)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-30 12:57:53 +05:30
jasquat d810d9b01f fixed up the unit test permission yml to better match the way we do permissions (#363)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-29 14:21:15 -04:00
Madhurya Liyanage 99a23b3d8c Merge branch 'main' into deploy-app-dev 2023-06-29 19:05:55 +05:30