Commit Graph

953 Commits

Author SHA1 Message Date
Dan Funk 771f54b7b4 Bug/UI fixes (#369)
* re-enable the move canvas and zoom modules, and try like hell to get the !@#$! display to zoom to fit consistently. As the from_xml does not trigger the "import.done" where the resize is happening.

* Clicking on timestamp should reload the page so we are observing the diagram at the correct point in time.

* Use a grid rather than a stack for the filter buttons, make them a consistent width, and force the close "x" button to the far right.

* Better handling the lots and lots of metadata fields in both the process instance list table, and in the metadata information on the process instance view page.

* Using DL rather than Carbon's grid, because my mind was starting to break.
* Process instance List Tables are set to optimize their max width for readability.

* assure the diagram editor is top aligned - otherwise when the proprties pannel get's super duper long (as with recent additions to multi-instance) we don't end up with weird spaces showing up above a center aligned canvas.
2023-07-04 09:29:46 +05:30
jasquat e4bf22f5cf Feature/interstitial summary part 3 (#367)
* throw an error if backend gives a 500 from interstitial page w/ burnettk

* turn unexpected errors for the interstitial page into event stream responses to avoid error misdirection

* pyl

* raise the api_error from the original and make the render_data method private

* Feature/interstitial summary (#337)

* * Process instance logs and messages are now components rather than pages, and are included within tabs on the process instance page, along with the diagram.
* Removed the Zoom and Move modules when showing the readonly
  Diagram.  Assured this readonly view is resized to fit the space when possible.
* Checkbox Widget no longer displays a duplicate label.
* CSS Tweaks
  * All pages are limited to a max display width of 1440, with auto margins to center the main content on the page.
  * "Show" pages, like ProcessInstanceShow, TaskShow have the primary content limited to 1000, also with auto-margins.
  * Paragraphs, headings, blockquotes, list items are limited to a width of 640.
  * Reduced margin bottom on all breadcrumbs.
  * Slightly reduced the width and margin of tiles
  * ordered lists and unordered lists show numbers and bullets now.
* End user Instructions component can, optionally, auto-collapse, so that only a portion is displayed, along with a toggle.  This is how it is set up for the ProcessInstanceShow page.
* Greatly reduced the lag in the interstitial page when doing a re-direct.

* run_pyl

* kill console

* wait for permissionsLoaded too since we are using ability.can

* Previous change removed the top level Messages page - this re-adds it.

* I am always, ALWAYS shocked at how I can not wrap my head around when and where to use "useEffect".

This should cause the show/hide Instructions toggle to only show when useful.

* Minor cleanup on the process instance properties display.

* linting

---------

Co-authored-by: burnettk <burnettk@users.noreply.github.com>

* Fix a linting error.

* minor permissions related fixes for the new ui.

* Revert "Revert "Feature/better subworkflow management (#331)""

This reverts commit 48dcde8faf.

* do not execute tasks from the process instance show page w/ burnettk

* pyl w/ burnettk

* Very minor UI tweak to resolve a number of issues mentioned in SPIFF-316 Notion Ticket:

* Markdown links now open in a new window
* Tables on the home pages are now contained within Grids to better align them with the other content that is in a grid.
* Right aligned the "process instance list link" button to it is flush right with the table underneath
* Gave a little more breathing room the content on the info/metadata in the process instance view .

* updated docker image build action to contain the appropriate version info w/ burnettk

* properly resize to the available columns depending on s/m/l

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
Co-authored-by: Dan Funk <daniel.h.funk@gmail.com>
Co-authored-by: burnettk <burnettk@users.noreply.github.com>
2023-07-03 10:54:54 +05:30
Dan Funk 532c0f841f bumping version of BPMN-JS-Spiffworkflow (#366) 2023-06-30 23:17:58 +05:30
Kevin Burnett d52e4dae75 when creating a process instance, use for-me path for perms (#354)
Co-authored-by: burnettk <burnettk@users.noreply.github.com>
2023-06-29 16:37:19 +05:30
jasquat 3a8cfd2642 disable form submit buttons when appropriate, lock process instance when sending events, and ensure return events match ones associated with desired guids w/ burnettk (#359)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-29 09:36:47 +05:30
jasquat 15b2947107 Feature/draft data in join table (#355)
* added a new model to store task draft data in a join table

* cleaned up using the join table for draft table w/ burnettk

* created new single migration for changes w/ burnettk

* added hidden form which autosaves without validations w/ burnettk

* change close button name since it does indeed save on close now

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-28 22:23:39 +05:30
jasquat 51cfcfa2a5 Feature/autosave and null form data (#346)
* autosave form data on change w/ burnettk

* tests are now passing and pyl

* do not do anything on autosave success w/ burnettk

* merged autosave and null form data branches together w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-26 18:26:56 +05:30
jasquat a9cc15177f updated usages of task_spec.spec for new spiff (#345)
* updated usages of task_spec.spec for new spiff

* removed unused attributes referring to call activities

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-26 11:57:32 +05:30
jasquat 3d113409b9 fixed lint issues 2023-06-23 08:50:48 -04:00
jbirddog 2c99e17381 Show callers for non primary files (#334)
* WIP - working with multiple process ids, need to return a file's process ids

* Send bpmn process ids back with bpmn files

* Getting ./bin/pyl to pass

* Fix up unit test

* Wire up the front end

* Pre pr cleanup
2023-06-23 11:45:23 +05:30
Kevin Burnett 7de0d97303 Feature/better subworkflow management part 2 (#341)
* Revert "Revert "Feature/better subworkflow management (#331)""

This reverts commit 48dcde8faf.

* updated SpiffWorkflow to fix infinite loop in task trace w/ burnettk

---------

Co-authored-by: burnettk <burnettk@users.noreply.github.com>
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-20 10:37:49 -04:00
burnettk ecf0a423be Revert "processes to process models"
This reverts commit 294eff7873.
2023-06-19 09:08:46 -04:00
burnettk 294eff7873 processes to process models 2023-06-19 08:27:06 -04:00
burnettk 87f32ac687 Revert "set undefined values to null rjsf form data w/ burnettk (#336)"
This reverts commit cca9b147f6.
2023-06-19 08:19:49 -04:00
burnettk 53d73e13a3 Revert "Feature/interstitial summary (#337)"
This reverts commit c48f3a458b.
2023-06-19 08:19:36 -04:00
burnettk 916324404e Revert "Fix a linting error."
This reverts commit d1a1e40f29.
2023-06-19 08:19:29 -04:00
burnettk 5b7a4c10e2 Revert "minor permissions related fixes for the new ui."
This reverts commit 284d12e32c.
2023-06-19 08:19:23 -04:00
danfunk 284d12e32c minor permissions related fixes for the new ui. 2023-06-16 12:00:27 -04:00
danfunk d1a1e40f29 Fix a linting error. 2023-06-16 10:22:50 -04:00
Dan Funk c48f3a458b Feature/interstitial summary (#337)
* * Process instance logs and messages are now components rather than pages, and are included within tabs on the process instance page, along with the diagram.
* Removed the Zoom and Move modules when showing the readonly
  Diagram.  Assured this readonly view is resized to fit the space when possible.
* Checkbox Widget no longer displays a duplicate label.
* CSS Tweaks
  * All pages are limited to a max display width of 1440, with auto margins to center the main content on the page.
  * "Show" pages, like ProcessInstanceShow, TaskShow have the primary content limited to 1000, also with auto-margins.
  * Paragraphs, headings, blockquotes, list items are limited to a width of 640.
  * Reduced margin bottom on all breadcrumbs.
  * Slightly reduced the width and margin of tiles
  * ordered lists and unordered lists show numbers and bullets now.
* End user Instructions component can, optionally, auto-collapse, so that only a portion is displayed, along with a toggle.  This is how it is set up for the ProcessInstanceShow page.
* Greatly reduced the lag in the interstitial page when doing a re-direct.

* run_pyl

* kill console

* wait for permissionsLoaded too since we are using ability.can

* Previous change removed the top level Messages page - this re-adds it.

* I am always, ALWAYS shocked at how I can not wrap my head around when and where to use "useEffect".

This should cause the show/hide Instructions toggle to only show when useful.

* Minor cleanup on the process instance properties display.

* linting

---------

Co-authored-by: burnettk <burnettk@users.noreply.github.com>
2023-06-16 09:53:20 -04:00
jasquat cca9b147f6 set undefined values to null rjsf form data w/ burnettk (#336)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-16 09:52:29 +05:30
burnettk 48dcde8faf Revert "Feature/better subworkflow management (#331)"
This reverts commit 23af5cbbe4.
2023-06-15 15:10:48 -04:00
jasquat 23af5cbbe4 Feature/better subworkflow management (#331)
* WIP: some updates to support new spiff w/ burnettk

* unit tests are passing

* all tests except message tests are passing

* fixed usage of catch message event w/ burnettk

* messages are working again w/ burnettk

* uncommented remaining message tests w/ burnettk

* fixed cypress tests w/ burnettk

* use main for spiffworkflow

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-15 10:31:42 -04:00
jasquat 9b9ec335b3 format date picker helper text width to match the date widget itself … (#330)
* format date picker helper text width to match the date widget itself w/ burnettk

* not sure we need xdoctest

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
Co-authored-by: burnettk <burnettk@users.noreply.github.com>
2023-06-13 20:16:26 +05:30
Elizabeth Esswein 5652f3981b restore loop collection references (#328)
* restore loop collection references

* ignore dmn files when restoring references
2023-06-12 18:32:16 -04:00
Kevin Burnett 7ab4d40ff4 make primary file use font style italics (#324)
Co-authored-by: burnettk <burnettk@users.noreply.github.com>
2023-06-12 06:42:30 -07:00
jasquat 121b3c7cc9 some fixes and updates to help with running an acceptance test model (#323)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-09 11:19:02 -07:00
jasquat ee18052be9 added css to make the hr elements look like they do for bootstrap w/ burnettk (#320)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-09 11:50:42 -04:00
jasquat 48fdb142e1 if the process id of the call activity cannot be found then refresh the list and try again w/ burnettk (#316)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-08 14:27:01 -07:00
jasquat 4fc6b1a193 use carbon components when adding secrets (#312)
* use carbon components when adding secrets

* docker compose pull before running up w/ burnettk

* use all carbon on script task unit test modal w/ burnettk

* removed remaining references to bootstrap from frontend w/ burnettk

* updated usage of hidden to use the class instead of the bootstrap attribute w/ burnettk

* print out docker version for debugging

* docker pull with docker instead of compose

* added comment for docker pull in check docker start script

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-08 14:26:14 -07:00
jasquat 4b2970170c updated permission macros to give admins access to task-data and proc… (#314)
* updated permission macros to give admins access to task-data and process-data w/ burnettk

* do not check for write to process-models if diagram is readonly anyway w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-08 11:39:14 -04:00
jasquat 49950b1639 support validationErrorMessage in rjsf enum w/ burnettk (#311)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-07 09:55:32 -07:00
jbirddog aedcac5082 npm update bpmn-js-spiffworkflow (#308) 2023-06-06 18:26:20 -07:00
jasquat 1506eed204 allow specifying multiple minimum date checks for a field w/ burnettk (#305)
* allow specifying multiple minimum date checks for a field w/ burnettk

* show title of field to compare minimum date with

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-06 18:25:54 -07:00
Madhurya Liyanage 2d55040c6d Fixed an issue in a test cases and updated numbering 2023-06-05 16:58:24 +05:30
Madhurya Liyanage 5abec3046b Added validations to check the user entered data for special character related test case and edit request test cases 2023-06-05 16:14:45 +05:30
Madhurya Liyanage 5549072059 Updated wait time for file upload related test cases and added numbering for test cases. 2023-06-05 16:13:12 +05:30
jasquat a528792257 added a little error handling to the typeahead widget w/ burnettk 2023-06-02 14:07:44 -04:00
burnettk 8e2b94b866 add some ids to completed instances tables for testability 2023-06-02 10:59:26 -04:00
burnettk 609e75c108 add some ids to homepage tables for testability 2023-06-02 10:52:17 -04:00
jasquat 6eb0ab0286 Merge pull request #294 from sartography/feature/typeahead_in_custom_widgets
Feature/typeahead in custom widgets
2023-06-02 10:34:00 -04:00
danfunk 542babba28 Merge remote-tracking branch 'origin/main' into feature/better_interstitial_spinner_and_suspend_message 2023-06-01 15:07:25 -04:00
danfunk 6e9a5bd590 Introduced a small spinner to the interstitial view on the Process Instance Show page.
Display reasonable messages when a processes is suspended or errored. Can't do much with terminated.
Show the spinner more frequently and consistently.
When running ruff, ignore everything in .gitignore
2023-06-01 15:05:59 -04:00
jasquat e45d6c4732 also support placeholder text w/ burnettk 2023-06-01 11:09:58 -04:00
jasquat 80ab47aeff a little cleanup w/ burnettk 2023-06-01 10:55:46 -04:00
Kevin Burnett 80577c6389 Merge pull request #287 from sartography/feature/new-ux-options-for-adding-files
allow markdown uploads and add some different ux options for adding files
2023-06-01 14:44:35 +00:00
jasquat 7e2b4724b5 Merge remote-tracking branch 'origin/main' into feature/typeahead_in_custom_widgets 2023-06-01 10:43:37 -04:00
jasquat 391cf4987c added missing rjsf elements into typeahead widget 2023-06-01 10:43:34 -04:00
burnettk b02c28697d use icons for running unit tests, w/ lantz 2023-06-01 10:43:27 -04:00
burnettk 619f7e41bd update UX after feedback from team 2023-06-01 10:07:01 -04:00