Commit Graph

1291 Commits

Author SHA1 Message Date
Dan 38ffb10fa5 Merge commit '9d58cffa58f8178220dcc7c517cdb5b103fe4e1b' into feature/improved_errors 2023-01-19 12:37:17 -05:00
Dan 9d58cffa58 Squashed 'SpiffWorkflow/' changes from 4195453a4..1f51db962
1f51db962 Merge pull request #283 from sartography/feature/better_errors
69fb4967e Patching up some bugs and logical disconnects as I test out the errors.
cf5be0096 * Making a few more things consistent in the error messages -- so there isn't filename for validation errors, and file_name for WorkflowExceptions.  Same for line_number vs sourceline. * Assure than an error_type is consistently set on exceptions. * ValidationExceptions should not bild up a detailed error message that replicates information available within it.
440ee16c8 Responding to some excellent suggestions from Elizabeth:
655e415e1 Merge pull request #282 from subhakarks/fix-workfowspec-dump
1f6d3cf4e Explain that the error happened in a pre-script or post script.
8119abd14 Added a top level SpiffWorklowException that all exceptions inherit from.  Aside from a message string you can append information to these exceptions with "add_note", which is a new method that all exceptions have starting in python 3.11 Switched arguments to the WorkflowException, WorkflowTaskException - which now always takes a string message as the first argument, and named arguments thereafter to be consistent with all other error messages in Python. Consistently raise ValidationExceptions whenever we encounter an error anywhere during parsing of xml. The BPMN/WorkflowTaskExecException is removed, in favor of just calling a WorkflowTaskException.  There is nothing BPMN Specific in the logic, so no need for this. Consolidated error message logic so that things like "Did you mean" just get added by default if possible.  So we don't have to separately deal with that logic each time. Better Error messages for DMN (include row number as a part of the error information)
13463b5c5 fix for workflowspec dump
be26100bc Merge pull request #280 from sartography/feature/remove-unused-bpmn-attributes-and-methods
23a5c1d70 remove 'entering_* methods
4e5875ec8 remove sequence flow
5eed83ab1 Merge pull request #278 from sartography/feature/remove-old-serializer
614f1c68a remove compact serializer and references
e7e410d4a remove old serializer and references

git-subtree-dir: SpiffWorkflow
git-subtree-split: 1f51db962ccaed5810f5d0f7d76a932f056430ab
2023-01-19 12:37:17 -05:00
Dan 3c12e8ad35 Lots of adjustments from running pyl
Main change is in the ErrorDisplay.tsx to assure all error information is provided. and index.css to make it "pretty"
2023-01-19 12:36:45 -05:00
Dan 48d0643320 Remove the flask-bpmn directory. 2023-01-17 13:13:16 -05:00
Dan 28a28e353b Removing dependency on flask-bpmn and taking it out of SpiffArena
Slightly updating the APIError code for recent updates to SpiffWorkflow's error refactoring.
2023-01-17 12:56:06 -05:00
Kevin Burnett 994620bc5f Merge pull request #104 from sartography/feature/date_form_validations
Feature/date form validations
2023-01-16 15:09:36 -08:00
burnettk 0a485681fa fix lint issues 2023-01-16 18:08:05 -05:00
burnettk 5c3f7ae9ef remove jsonpath 2023-01-16 17:57:07 -05:00
jasquat ccf64e5bcb added proof of concept to validate date fields in json schema form w/ burnettk 2023-01-16 17:01:15 -05:00
jasquat afa0256bc3 updated open id url for compose ci 2023-01-16 13:27:44 -05:00
jasquat e062f965d8 pyl 2023-01-16 13:11:25 -05:00
jasquat d70acde4c0 fixed cypress tests 2023-01-16 12:24:02 -05:00
Kevin Burnett ad6236e9d6 Update README.md 2023-01-14 21:47:01 -08:00
burnettk f46e3604e7 postgres does not have group_concat, and it is stricter about getting back columns when grouping 2023-01-15 00:22:40 -05:00
jasquat 2476c66d0a Merge branch 'main' of github.com:sartography/spiff-arena 2023-01-13 16:55:38 -05:00
jasquat 708c2722d8 added ability to add in custom validation error messages for text input fields w/ burnettk 2023-01-13 16:55:34 -05:00
Kevin Burnett 5d5f1e777c Merge pull request #102 from sartography/feature/waku-fault-message
Feature/waku fault message
2023-01-13 11:47:05 -08:00
Kevin Burnett 81272a55a7 Merge pull request #101 from sartography/task_data_len
Throw an exception if max task data length is exceeded
2023-01-13 11:43:46 -08:00
jasquat 419f23490d Merge branch 'main' of github.com:sartography/spiff-arena 2023-01-13 14:41:55 -05:00
jasquat ae02575183 fixed broken test w/ burnettk 2023-01-13 14:41:51 -05:00
jbirddog 0fe6bbfd80 Skip refresh steps (#103) 2023-01-13 14:32:19 -05:00
jasquat 14397099f4 added tasks table to process instance show page w/ burnettk 2023-01-13 14:31:12 -05:00
mike cullerton be54381830 Merge branch 'main' into feature/waku-fault-message 2023-01-13 12:11:40 -05:00
mike cullerton c3e1dda51e run_pyl changes 2023-01-13 11:50:36 -05:00
jasquat 96cc8b02d0 added tabs to find by id page and install pre commit libraries if they fail to run help w/ burnettk 2023-01-13 11:29:45 -05:00
Jon Herron 91a0f05b11 Fixed failing test 2023-01-13 11:11:12 -05:00
jasquat 0038f41a88 stop at call activity as well when getting calling subprocesses by child id w/ burnettk 2023-01-13 10:43:25 -05:00
Jon Herron b933743717 Getting ./bin/pyl to pass 2023-01-13 09:45:05 -05:00
Jon Herron 6f536dff86 Merge branch 'main' into task_data_len 2023-01-13 09:37:32 -05:00
Jon Herron 5b5c6e0265 Bump the limit to 1mb 2023-01-13 09:12:41 -05:00
Jon Herron 3cb02914ef Better impl 2023-01-13 09:05:35 -05:00
mike cullerton 001db4cd84 reorder imports 2023-01-13 09:03:17 -05:00
mike cullerton d59df48e0c import order 2023-01-13 08:52:43 -05:00
mike cullerton 1b413c5f9e unused imports 2023-01-13 08:40:56 -05:00
mike cullerton d17f3b96d0 Merge branch 'main' into feature/waku-fault-message 2023-01-13 08:29:42 -05:00
Jon Herron b6777ae65c POC checking cumulative task data len 2023-01-12 18:16:06 -05:00
jasquat 6474f74f78 fixed failing test w/ burnettk 2023-01-12 15:35:05 -05:00
jasquat 781c9814c2 added detailed area to process instance show page w/ burnettk 2023-01-12 15:27:32 -05:00
jasquat 89f2e9c562 set the domain for the token cookies w/ burnettk 2023-01-12 11:50:11 -05:00
jasquat 675f3c82e7 Merge pull request #100 from sartography/feature/session_timeouts
Feature/session timeouts
2023-01-12 11:33:45 -05:00
jasquat 761ffd79da a little more cleanup w/ burnettk 2023-01-12 11:32:52 -05:00
jasquat 4224916917 remove several debug print statements 2023-01-12 10:48:42 -05:00
jasquat aa6546656e logout works now and queryparams are getting passed correctly on login now 2023-01-12 10:29:37 -05:00
jasquat 8c3f855246 pyl 2023-01-12 08:12:16 -05:00
mike cullerton 36ee3b9551 Merge branch 'main' into feature/waku-fault-message 2023-01-12 07:19:06 -05:00
mike cullerton b6cd66cb93 Cleaned up the message text 2023-01-12 07:13:35 -05:00
mike cullerton 6e3a79320e Precommit 2023-01-11 18:12:18 -05:00
mike cullerton 1440a91efb linting 2023-01-11 17:47:58 -05:00
mike cullerton 95141a6832 mypy 2023-01-11 17:46:39 -05:00
jasquat 762d15ffa2 remove unneeded protocol variable w/ burnettk 2023-01-11 17:29:08 -05:00