Commit Graph

264 Commits

Author SHA1 Message Date
Kevin Burnett 9313a9f73a Feature/event payloads part 2 (#401)
* Revert "Revert "Feature/event payloads (#393)""

This reverts commit 95fafb7af1.

* Revert "Revert "poet not available in container""

This reverts commit 140220498c.

* Revert "Revert "Run event payloads data migration from background processor (#399)""

This reverts commit 2afced3a51.

* Revert "Revert "using new spiff api to get info about events. w/ elizabeth""

This reverts commit af857fee22.

* Revert "Revert "fix tests for waiting_event_can_be_skipped""

This reverts commit 886e6bd42a.

* push image for preview env

* default scripts to localhost w/ burnettk

* use the bugfix/update-split-task-inputs spiffworkflow branch w/ burnettk

* removed debug json files

* use main for spiffworkflow

* do not attempt to highlight non-diagram boundary items w/ burnettk

* updated SpiffWorkflow to fix multiple signal event issue w/ burnettk

---------

Co-authored-by: burnettk <burnettk@users.noreply.github.com>
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-08-10 18:24:49 +05:30
jasquat 48893cae13 fixed linting issues w/ burnettk 2023-08-03 15:38:02 -04:00
jasquat 3f6fb4d9f5 Feature/pin spiff in ci (#428)
* attempt to use the locked version of SpiffWorkflow in ci w/ burnettk

* fixed regex for spiffworkflow revision replacement

* make sure we also update the lockfile when getting new spiff

* install poetry before we attempt to update hte pyproject

* hardcoding spiffworkflow revision as a test w/ burnettk

* try running tests in ci from bash script w/ burnettk

* print working dir in ci w/ burnettk

* fixed location of instance dir w/ burnettk

* run with mysql in ci

* run typeguard with bash script as well w/ burnettk

* fixed postgres test w/ burnettk

* clean up github action file w/ burnettk

* fixed postgres test again w/ burnettk

* pyl

* attempt to remove nox from ci completely

* omit safety for now to test coverage

* fixed how coverage is being called from not nox

* allow running safety and macos again

* renamed run_not_nox to run_ci_session w/ burnettk

* attempt to only upload if matrix says to w/ burnettk

* attempt to install mysqlclient prereqs for mac and remove noxfile stuff w/ burnettk

* added back the constraints file w/ burnettk

* moved the contributing file to the root of arena w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-08-03 11:49:30 -04:00
jasquat 09794e9302 column names for tables in frontend should only have the first letter… (#425)
* column names for tables in frontend should only have the first letter of the first word capitalized

* forgot a couple field names w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-08-02 14:06:19 +05:30
jasquat 796dc9dbec Feature/extensions api (#423)
* added api and test to run a process model and return task data synchronously w/ burnettk

* added test to make sure we can access db models from extensions api w/ burnettk

* added extensions api to elevated permissions

* fixed permission tests

* do not add extensions permission to all permission for a pg or pm w/ burnettk

* added configs for extensions api w/ burnettk

* added the basis for an extensions list api w/ burnettk

* added tests for extenstions api and do not use serialized as a property

* allow giving a body to an extension when running and some support in frontend to use extensions

* added ability to display markdown and rjsf on extensions page

* added ability to submit the extension form and display the resulting task data

* made frontend extension urls have 2 pieces of information so we can specify multiple routes for the same process-model w/ burnettk

* do not save process instances when running extensions w/ burnettk

* add extension input to a task not the process w/ burnettk

* pyl w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
Co-authored-by: burnettk <burnettk@users.noreply.github.com>
2023-08-02 14:02:53 +05:30
jasquat cdaf2ea6c5 added a loading icon on task show page to avoid blank page when loadi… (#411)
* added a loading icon on task show page to avoid blank page when loading large datasets w/ burnettk

* fixed broken tests w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-07-27 17:00:16 +05:30
jbirddog 43beb916a3 Basic scaffolding for onboarding (#400)
* Wedge between InProgressInstances for default view customization

* Rename to OnboardingView, stubbed out api in the backend

* Flip between InProgressInstances and MyTasks via the backend

* WIP

* WIP

* Basic human task handling

* FE lint

* Getting ./bin/pyl to pass

* Suppress any exceptions during onboarding request

* Script to skip onboarding if already started

* Getting ./bin/pyl to pass

* Better default location

* PR feedback

* PR feedback

* PR feedback - add new endpoint to basic permissions

* Fix basic permissions test

* Add integration tests

* Getting bin_pyl to pass
2023-07-27 11:54:30 +05:30
jasquat 84369a1b20 return the process instance early from the interstitial if it is susp… (#407)
* return the process instance early from the interstitial if it is suspended or terminated

* added a test to make sure the interstitial page returns the process instance if suspended or termianted w/ burnettk

* randomize tests and cleaned up the pyproject file a little bit w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-07-25 22:57:53 +05:30
burnettk 95fafb7af1 Revert "Feature/event payloads (#393)"
This reverts commit f1c5f1ea21.
2023-07-19 11:44:06 -04:00
jasquat f1c5f1ea21 Feature/event payloads (#393)
* some initial changes for event payload changes in spiff

* fixed tests for new spiffworkflow with event payloads w/ burnettk essweine

* pyl w/ burnettk essweine

* updated SpiffWorkflow from branch

* switched SpiffWorkflow back to main w/ burnettk

* added base for migration script to upgrade db w/ burnettk essweine

* some updates to script w/ burnettk

* script has been written, needs to be tested

* pyl w/ burnettk

* updates to migration script so it can work w/ burnettk

* pyl w/ burnettk

* added comment to data migration file

* run the version 1 3 migration on app boot w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-07-18 06:56:24 -07:00
Dan Funk 73aed82f24 Feature/view data stores (#388)
* * Added /data-stores/ endpoint accessible by privileged users that will return a list of all data stores known to the system.
* Added a /data-stores/[type]/[name] endpoint that will return a list of all data stored within a data-store.
* Granted users with "elevated permissions" the right to access the data store.
* Added a "Data Store" link to the navigation bar beside messages.
* And a few useful tests.
* Still a little front end work to do to get it all looking pretty.

* Added a Data Store List component that, well, displays, you guessed it! A list of data stores and their contents.

Also, Carbon's paginator doesn't care how many pages you have, it's going to build the mother of all drop down lists - you got 60,000,000 records? Showing 5 at a time? It's going to be a dropdown list that contains all numbers between 1 and 12,000,000, because that makes sense! So, yea, not doing that, cutting it off at 1000 pages - you got more pages than that, the paginator can't take you there.  As you can show 100 items per page, that means you can access 100,000 items instantly.

* renaming data_store_items_list => data_store_item_list
2023-07-13 20:54:10 +05:30
jasquat 285294967d Feature/error to suspended state (#384)
* fixed suspended message w/ burnettk

* allow manually executing errored tasks when suspended w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-07-12 19:50:24 +05:30
jasquat 841f3ccc8c Feature/task assignment (#352)
* added an api to assign a list of users to a task w/ burnettk

* use the modal submit and close buttons when saving task data on the instance show page w/ burnettk

* switch save and cancel buttons on secrets new page w/ burnettk

* add some icons, tho still missing event stuff

* finished adding imporoved icons and fixing up task modal w/ burnettk

* added some user search options to assig tasks to w/ burnettk

* cleaned up task details modal and added call to backend to add potential users w/ burnettk

* fixed broken tests w/ burnettk

* removed some merge comments w/ burnettk

* process instance id is an int not a str w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
Co-authored-by: burnettk <burnettk@users.noreply.github.com>
2023-07-12 19:44:01 +05:30
jasquat 766a7e491e delete the draft task data when the task has been submitted (#364)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-30 13:03:56 +05:30
jasquat d810d9b01f fixed up the unit test permission yml to better match the way we do permissions (#363)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-29 14:21:15 -04:00
jasquat 51cfcfa2a5 Feature/autosave and null form data (#346)
* autosave form data on change w/ burnettk

* tests are now passing and pyl

* do not do anything on autosave success w/ burnettk

* merged autosave and null form data branches together w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-26 18:26:56 +05:30
jbirddog 2c99e17381 Show callers for non primary files (#334)
* WIP - working with multiple process ids, need to return a file's process ids

* Send bpmn process ids back with bpmn files

* Getting ./bin/pyl to pass

* Fix up unit test

* Wire up the front end

* Pre pr cleanup
2023-06-23 11:45:23 +05:30
Kevin Burnett 35543cc362 add mccabe linter and auto fixes (#302)
Co-authored-by: burnettk <burnettk@users.noreply.github.com>
2023-06-08 14:26:33 -07:00
danfunk 542babba28 Merge remote-tracking branch 'origin/main' into feature/better_interstitial_spinner_and_suspend_message 2023-06-01 15:07:25 -04:00
danfunk 6e9a5bd590 Introduced a small spinner to the interstitial view on the Process Instance Show page.
Display reasonable messages when a processes is suspended or errored. Can't do much with terminated.
Show the spinner more frequently and consistently.
When running ruff, ignore everything in .gitignore
2023-06-01 15:05:59 -04:00
jasquat b756e594ab removed useless def comments that started with and underscore as well 2023-06-01 13:52:07 -04:00
jasquat 43f23cd630 removed useless class and def comments from python code w/ burnettk 2023-05-31 16:28:06 -04:00
burnettk aae043e0a4 add pylint 2023-05-30 19:39:15 -04:00
Kevin Burnett 4bbe10be00 Merge branch 'main' into feature/more-secret-secrets 2023-05-30 18:55:14 +00:00
burnettk 7b2f75c349 remove useless comments matching filenames 2023-05-30 12:21:50 -04:00
burnettk ad3f283098 get compatible with ruff 2023-05-29 17:03:30 -04:00
burnettk 2199214323 only expose value on show, not list, move tests, fix UI 2023-05-29 15:04:38 -04:00
burnettk f8d4a6382b get compatible with ruff pyupgrade 2023-05-27 14:59:52 -04:00
burnettk 2b2875cb6f let ruff sort imports and ditch duplicative pre-commit linters 2023-05-26 20:01:08 -04:00
jasquat 696bfe224c fixed tests related to new permissions w/ burnettk 2023-05-22 14:58:51 -04:00
jasquat a3890afba1 added missing permissions to elevated perm macro and removed api calls from unit tests 2023-05-22 13:50:32 -04:00
jasquat 83f7849685 changed publish endpoint to precede model id so we can grant publish access but read only to a model otherwise w/ burnettk 2023-05-19 12:26:16 -04:00
jasquat 40b3246eb7 support macros in perm yml and pyl 2023-05-18 12:11:40 -04:00
jasquat 233d8a9832 using the new spiff branch and tests are now passing w/ burnettk 2023-05-11 12:41:52 -04:00
jasquat da52b68c84 updated Spiffworkflow and updated terminated test to ensure tasks are deleted from the db w/ burnettk 2023-05-10 16:39:03 -04:00
jasquat 6d5422a9fd added reminder to check remaining tasks once we get new spiff 2023-05-10 13:25:26 -04:00
jasquat 57fcadbd62 save all spiff tasks to the db after terminating a process instance w/ burnettk 2023-05-10 12:02:48 -04:00
jasquat 26310da412 Merge pull request #244 from sartography/feature/check_permissions_on_group_and_model_list
Feature/check permissions on group and model list
2023-05-08 14:29:39 -04:00
jasquat 874fe9052c pyl and i am not sure how mypy missed that one typing issue 2023-05-08 13:20:40 -04:00
jasquat 1b0f71579b pyl 2023-05-08 11:34:45 -04:00
jasquat 6f59d2f828 added tests to make sure users can only list process models and groups that they have access to 2023-05-08 11:31:57 -04:00
jasquat eef920acae do not perform any tasks if instance is suspended from the interstitial page w/ burnettk 2023-05-05 14:01:32 -04:00
jasquat 92cdceb201 fixed test w/ burnettk 2023-05-04 12:45:53 -04:00
jasquat 60db9db296 Merge pull request #241 from sartography/feature/multiple_editor_users
Feature/multiple editor users
2023-05-04 11:40:28 -04:00
jasquat f65b301635 do not raise errors if a process cannot be found in the spec reference cache when trying to get a task trace for an error 2023-05-04 09:45:01 -04:00
jasquat 8655ca0cd0 Merge remote-tracking branch 'origin/main' into feature/multiple_editor_users 2023-05-03 17:38:49 -04:00
Dan Funk 64692f0d59 Merge pull request #237 from sartography/feature/cancel_button
Feature/cancel button
2023-05-03 10:12:02 -04:00
jasquat 38428cb6a4 fixed tests w/ burnettk 2023-05-02 17:09:29 -04:00
Dan ac149c9dcb * Adding signal_buttons to tasks, which will prompt the frontend to display a button that when pressed will cause the signal to fire.
* This alters how the send_event endpoint responds - it originally responded with a process instance, it now responds with the next task, in keeping with how other task completion endpoints behave.
* I was forced to upgrade some of the bpmn-js libraries which fixes some of the linting errors on the front end.
* The "Return to home" button isn't always displayed.  It will not display when it is redirecting, or when the current task is running.
.
2023-05-02 13:40:41 -04:00
jasquat 418ec7d9c9 updated typeguard and fixed issues w/ burnettk 2023-05-01 15:26:29 -04:00