Commit Graph

1538 Commits

Author SHA1 Message Date
Dan e1dbbdf9ab Merge commit 'e4c31a2c9d0c182cef506d7367a84780d9546ee5' into feature/improved_errors 2023-01-19 12:37:17 -05:00
Dan e4c31a2c9d Squashed 'SpiffWorkflow/' changes from 4195453a4..1f51db962
1f51db962 Merge pull request #283 from sartography/feature/better_errors
69fb4967e Patching up some bugs and logical disconnects as I test out the errors.
cf5be0096 * Making a few more things consistent in the error messages -- so there isn't filename for validation errors, and file_name for WorkflowExceptions.  Same for line_number vs sourceline. * Assure than an error_type is consistently set on exceptions. * ValidationExceptions should not bild up a detailed error message that replicates information available within it.
440ee16c8 Responding to some excellent suggestions from Elizabeth:
655e415e1 Merge pull request #282 from subhakarks/fix-workfowspec-dump
1f6d3cf4e Explain that the error happened in a pre-script or post script.
8119abd14 Added a top level SpiffWorklowException that all exceptions inherit from.  Aside from a message string you can append information to these exceptions with "add_note", which is a new method that all exceptions have starting in python 3.11 Switched arguments to the WorkflowException, WorkflowTaskException - which now always takes a string message as the first argument, and named arguments thereafter to be consistent with all other error messages in Python. Consistently raise ValidationExceptions whenever we encounter an error anywhere during parsing of xml. The BPMN/WorkflowTaskExecException is removed, in favor of just calling a WorkflowTaskException.  There is nothing BPMN Specific in the logic, so no need for this. Consolidated error message logic so that things like "Did you mean" just get added by default if possible.  So we don't have to separately deal with that logic each time. Better Error messages for DMN (include row number as a part of the error information)
13463b5c5 fix for workflowspec dump
be26100bc Merge pull request #280 from sartography/feature/remove-unused-bpmn-attributes-and-methods
23a5c1d70 remove 'entering_* methods
4e5875ec8 remove sequence flow
5eed83ab1 Merge pull request #278 from sartography/feature/remove-old-serializer
614f1c68a remove compact serializer and references
e7e410d4a remove old serializer and references

git-subtree-dir: SpiffWorkflow
git-subtree-split: 1f51db962ccaed5810f5d0f7d76a932f056430ab
2023-01-19 12:37:17 -05:00
Dan 628c59dde9 Lots of adjustments from running pyl
Main change is in the ErrorDisplay.tsx to assure all error information is provided. and index.css to make it "pretty"
2023-01-19 12:36:45 -05:00
jasquat ac37d1355c added new test users for status in keycloak w/ burnettk 2023-01-19 12:21:25 -05:00
jasquat 1919ccfaa8 added script to add test keycloak users and moved all keycloak stuff to keycloak directory w/ burnettk 2023-01-19 12:18:05 -05:00
jasquat 73a759fcb2 pin SpiffWorkflow to passing version for CI tests w/ burnettk 2023-01-19 11:10:36 -05:00
jasquat 46c7e25494
Merge pull request #105 from sartography/feature/avoid_logs_when_call_activity_waiting
do not write to logs when a task is inheriting data from the parent w…
2023-01-19 11:08:51 -05:00
jasquat 35ef5cbe54 Squashed 'SpiffWorkflow/' changes from 4195453a4..1f51db962
1f51db962 Merge pull request #283 from sartography/feature/better_errors
69fb4967e Patching up some bugs and logical disconnects as I test out the errors.
cf5be0096 * Making a few more things consistent in the error messages -- so there isn't filename for validation errors, and file_name for WorkflowExceptions.  Same for line_number vs sourceline. * Assure than an error_type is consistently set on exceptions. * ValidationExceptions should not bild up a detailed error message that replicates information available within it.
440ee16c8 Responding to some excellent suggestions from Elizabeth:
655e415e1 Merge pull request #282 from subhakarks/fix-workfowspec-dump
1f6d3cf4e Explain that the error happened in a pre-script or post script.
8119abd14 Added a top level SpiffWorklowException that all exceptions inherit from.  Aside from a message string you can append information to these exceptions with "add_note", which is a new method that all exceptions have starting in python 3.11 Switched arguments to the WorkflowException, WorkflowTaskException - which now always takes a string message as the first argument, and named arguments thereafter to be consistent with all other error messages in Python. Consistently raise ValidationExceptions whenever we encounter an error anywhere during parsing of xml. The BPMN/WorkflowTaskExecException is removed, in favor of just calling a WorkflowTaskException.  There is nothing BPMN Specific in the logic, so no need for this. Consolidated error message logic so that things like "Did you mean" just get added by default if possible.  So we don't have to separately deal with that logic each time. Better Error messages for DMN (include row number as a part of the error information)
13463b5c5 fix for workflowspec dump
be26100bc Merge pull request #280 from sartography/feature/remove-unused-bpmn-attributes-and-methods
23a5c1d70 remove 'entering_* methods
4e5875ec8 remove sequence flow
5eed83ab1 Merge pull request #278 from sartography/feature/remove-old-serializer
614f1c68a remove compact serializer and references
e7e410d4a remove old serializer and references

git-subtree-dir: SpiffWorkflow
git-subtree-split: 1f51db962ccaed5810f5d0f7d76a932f056430ab
2023-01-19 10:47:07 -05:00
jasquat 09e5bf3182 Merge commit '35ef5cbe54a18fc177ab2593001d76ab1412c382' 2023-01-19 10:47:07 -05:00
jasquat 2cd861bdd3 disabled flake8 forcing comments to avoid all of the useless comments but still enforcing the formatting of comments if they exist w/ burnettk 2023-01-19 10:41:26 -05:00
jasquat 6a6bde2788 show start events in logs as well and added bpmn process identifiers to log table w/ burnettk 2023-01-19 10:06:30 -05:00
burnettk 6dca7d3964 downgrade spiff and upgrade some other stuff 2023-01-19 07:59:26 -05:00
burnettk 8280318bc2 upgrade certifi to fix security vulnerability 2023-01-19 07:38:57 -05:00
jasquat 978f5f2180 do not write set data logs at all since they are redundant w/ burnettk 2023-01-18 17:03:55 -05:00
jasquat 7b78ff42da do not navigate away from diagram editor page if there are changes w/ burnettk 2023-01-18 16:43:11 -05:00
jasquat 26de48193c do not allow overwriting process models and process groups w/ burnettk 2023-01-18 14:40:03 -05:00
jasquat cb9d36f714 added End Event to simple log view w/ burnettk 2023-01-18 12:01:37 -05:00
jasquat 3416b2f015 pyl w/ burnettk 2023-01-18 10:39:53 -05:00
jasquat 1d717cff6b skip failing xml test on windows w/ burnettk 2023-01-18 10:38:43 -05:00
jasquat baf60e9cc9 use the correct windows path separator in test file 2023-01-18 09:43:19 -05:00
jasquat e24a62b4ab favor user_input_required over waiting status for process instances w/ burnettk 2023-01-17 17:09:26 -05:00
jasquat 2c6937eb18 fixed broken test w/ burnettk 2023-01-17 16:17:04 -05:00
jasquat 2db07b5f74 only show milestones for simple log view w/ burnettk 2023-01-17 16:13:11 -05:00
jasquat 336fb1d8d2 do not resolve entities when parsing xml w/ burnettk 2023-01-17 14:58:54 -05:00
Dan d495553968 Remove the flask-bpmn directory. 2023-01-17 13:13:16 -05:00
Dan 127eb7868c Removing dependency on flask-bpmn and taking it out of SpiffArena
Slightly updating the APIError code for recent updates to SpiffWorkflow's error refactoring.
2023-01-17 12:56:06 -05:00
jasquat 8fa5866f94 do not write to logs when a task is inheriting data from the parent w/ burnettk 2023-01-17 12:23:51 -05:00
Kevin Burnett 34f6239185
Merge pull request #104 from sartography/feature/date_form_validations
Feature/date form validations
2023-01-16 15:09:36 -08:00
burnettk 494fcfde4f fix lint issues 2023-01-16 18:08:05 -05:00
burnettk 3fd8db9add remove jsonpath 2023-01-16 17:57:07 -05:00
jasquat 3b48e937f9 added proof of concept to validate date fields in json schema form w/ burnettk 2023-01-16 17:01:15 -05:00
jasquat 41706b3355 updated open id url for compose ci 2023-01-16 13:27:44 -05:00
jasquat a91b8c68e8 pyl 2023-01-16 13:11:25 -05:00
jasquat 4055772bde fixed cypress tests 2023-01-16 12:24:02 -05:00
Kevin Burnett 4ad12a515d
Update README.md 2023-01-14 21:47:01 -08:00
burnettk c147cdb47b postgres does not have group_concat, and it is stricter about getting back columns when grouping 2023-01-15 00:22:40 -05:00
jasquat a976674eec Merge branch 'main' of github.com:sartography/spiff-arena 2023-01-13 16:55:38 -05:00
jasquat e533afdce8 added ability to add in custom validation error messages for text input fields w/ burnettk 2023-01-13 16:55:34 -05:00
Kevin Burnett d9574acee8
Merge pull request #102 from sartography/feature/waku-fault-message
Feature/waku fault message
2023-01-13 11:47:05 -08:00
Kevin Burnett 6fc41201b1
Merge pull request #101 from sartography/task_data_len
Throw an exception if max task data length is exceeded
2023-01-13 11:43:46 -08:00
jasquat c0046d1ae5 Merge branch 'main' of github.com:sartography/spiff-arena 2023-01-13 14:41:55 -05:00
jasquat c7817b67c2 fixed broken test w/ burnettk 2023-01-13 14:41:51 -05:00
jbirddog d5d9abe239
Skip refresh steps (#103) 2023-01-13 14:32:19 -05:00
jasquat 2d61bf378e added tasks table to process instance show page w/ burnettk 2023-01-13 14:31:12 -05:00
mike cullerton 043dea0796 Merge branch 'main' into feature/waku-fault-message 2023-01-13 12:11:40 -05:00
mike cullerton 56d61806a9 run_pyl changes 2023-01-13 11:50:36 -05:00
jasquat a2bb41301a added tabs to find by id page and install pre commit libraries if they fail to run help w/ burnettk 2023-01-13 11:29:45 -05:00
Jon Herron 65fa9e4834 Fixed failing test 2023-01-13 11:11:12 -05:00
jasquat 189dbc2712 stop at call activity as well when getting calling subprocesses by child id w/ burnettk 2023-01-13 10:43:25 -05:00
Jon Herron 8cd275a54f Getting ./bin/pyl to pass 2023-01-13 09:45:05 -05:00