Commit Graph

973 Commits

Author SHA1 Message Date
jasquat 841f3ccc8c Feature/task assignment (#352)
* added an api to assign a list of users to a task w/ burnettk

* use the modal submit and close buttons when saving task data on the instance show page w/ burnettk

* switch save and cancel buttons on secrets new page w/ burnettk

* add some icons, tho still missing event stuff

* finished adding imporoved icons and fixing up task modal w/ burnettk

* added some user search options to assig tasks to w/ burnettk

* cleaned up task details modal and added call to backend to add potential users w/ burnettk

* fixed broken tests w/ burnettk

* removed some merge comments w/ burnettk

* process instance id is an int not a str w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
Co-authored-by: burnettk <burnettk@users.noreply.github.com>
2023-07-12 19:44:01 +05:30
jasquat 93b8c09e90 fixed linting issue 2023-07-12 08:38:38 -04:00
jasquat e2e7808f09 display the validation error message the user input w/ burnettk (#386)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
Co-authored-by: burnettk <burnettk@users.noreply.github.com>
2023-07-12 11:40:48 +05:30
jasquat 800b61cf36 fixed pagination of log tables and broken cypress tests w/ burnettk (#382)
* fixed pagination of log tables and broken cypress tests w/ burnettk

* wait before clicking the profile button instead of after w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-07-10 14:06:55 -04:00
burnettk 9285358e69 Merge remote-tracking branch 'origin/main' into deploy-app-dev 2023-07-08 11:58:23 -04:00
burnettk 417fe51faf fix compilation issue 2023-07-08 11:57:51 -04:00
Madhurya Liyanage 11ab2ff883 Merge branch 'main' into deploy-app-dev 2023-07-08 10:11:23 +05:30
Dan Funk 18ea7510c6 Feature/fix_action_column (#357)
* removing action column.

* adding the action column back in, and making it work.
2023-07-07 16:02:27 -04:00
jasquat b7627716df Merge remote-tracking branch 'origin/main' into deploy-app-dev 2023-07-07 11:18:52 -04:00
jasquat c112e65232 fixed linting issue w/ burnettk 2023-07-07 11:18:45 -04:00
jasquat 19d7a008d9 merged in main and resolved conflicts w/ burnettk 2023-07-07 11:04:11 -04:00
jasquat 90bfc53380 use a sha256 value as the id of the page when checking active-users w/ burnettk (#356)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-07-07 20:24:57 +05:30
Kevin Burnett e6094a83a8 do not convert null to a string when clearing out a typeahead field w/ burnettk (#373)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-07-07 20:21:22 +05:30
Dan Funk 1a6a2c0ae9 Feature/fix diagram zoom (#378)
* Revert "set undefined values to null rjsf form data w/ burnettk (#336)"

This reverts commit cca9b147f6.

* Quick test to check if calls are happening correctly to resize the diagram.

* Quick test to check if calls are happening correctly to resize the diagram.

* remove all the logic around fitviewport limitations, which doesn't seem to be requured.  For some reason (modeler as any).constructor.name return '_9' on the dev server, rather than returning 'Modeler', 'Viewer' etal ...

* drop console log

* Clean up comments.

---------

Co-authored-by: Jakub Sokołowski <jakub@status.im>
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
Co-authored-by: burnettk <burnettk@users.noreply.github.com>
Co-authored-by: Madhurya Liyanage <liyanagemadhurya@gmail.com>
2023-07-07 10:11:12 -04:00
danfunk e099fc0edc remove all the logic around fitviewport limitations, which doesn't seem to be requured. For some reason (modeler as any).constructor.name return '_9' on the dev server, rather than returning 'Modeler', 'Viewer' etal ... 2023-07-06 20:03:30 -04:00
danfunk 475417b9a6 Quick test to check if calls are happening correctly to resize the diagram. 2023-07-06 18:30:44 -04:00
danfunk 1b5c3b54cb Quick test to check if calls are happening correctly to resize the diagram. 2023-07-06 17:29:16 -04:00
Dan Funk 746a41c524 Feature/never ending UI tweaks 2 (#377)
* Using a rem based measurement rather than pixels, to better handle 4k displays and their adjusted font sizes - and setting relatively large breakpoints and page width limits that should result in a better view of the tables on the home page.

* Here is the latest:

    * Improved metadata display on the process instance page, with better widths, grayed out text (which I lost at some point).
    * Reduced the End Task "instructions for end user" size, and added a fade out on the bottom.
    * Improved the "chicken buttons" for custom columns on the process instance list filters, which can now accommodate very long names for the columns.
    * Removed the "show-page" which is more consistently handled by the content wrappers for the different routers.
2023-07-06 16:38:44 -04:00
Dan Funk dbe52af9f4 Feature/never ending UI edits (#374)
* Basically shift our ui to something similar to Google's search results page - where we have a strong left padding that offsets against our logo, and a fixed width for our content, that can be breached in some circumstances (such as when tables are very large).  This breaking can happen for both our standard tables, as well as markdown tables.   This does not include the fix for locking - which is still in progress.

* modified routes so that most routes are within a "fixed-width-container" but our BPMN editor can still take up 100% of the screen.
* fixed-width-container has breakpoints at 1056 (remove all padding) and 1400 (limit width to a max of 1280)  but in all cases allow for an overflow of visible - so tables can extend beyond this limit when needed,
* Removed "Messages" as a heading from the tab view - but left on the /messages route.

* Lint fixing
2023-07-06 09:41:18 +05:30
danfunk d56809b141 Lint fixing 2023-07-04 10:22:14 -04:00
Dan Funk 771f54b7b4 Bug/UI fixes (#369)
* re-enable the move canvas and zoom modules, and try like hell to get the !@#$! display to zoom to fit consistently. As the from_xml does not trigger the "import.done" where the resize is happening.

* Clicking on timestamp should reload the page so we are observing the diagram at the correct point in time.

* Use a grid rather than a stack for the filter buttons, make them a consistent width, and force the close "x" button to the far right.

* Better handling the lots and lots of metadata fields in both the process instance list table, and in the metadata information on the process instance view page.

* Using DL rather than Carbon's grid, because my mind was starting to break.
* Process instance List Tables are set to optimize their max width for readability.

* assure the diagram editor is top aligned - otherwise when the proprties pannel get's super duper long (as with recent additions to multi-instance) we don't end up with weird spaces showing up above a center aligned canvas.
2023-07-04 09:29:46 +05:30
jasquat e4bf22f5cf Feature/interstitial summary part 3 (#367)
* throw an error if backend gives a 500 from interstitial page w/ burnettk

* turn unexpected errors for the interstitial page into event stream responses to avoid error misdirection

* pyl

* raise the api_error from the original and make the render_data method private

* Feature/interstitial summary (#337)

* * Process instance logs and messages are now components rather than pages, and are included within tabs on the process instance page, along with the diagram.
* Removed the Zoom and Move modules when showing the readonly
  Diagram.  Assured this readonly view is resized to fit the space when possible.
* Checkbox Widget no longer displays a duplicate label.
* CSS Tweaks
  * All pages are limited to a max display width of 1440, with auto margins to center the main content on the page.
  * "Show" pages, like ProcessInstanceShow, TaskShow have the primary content limited to 1000, also with auto-margins.
  * Paragraphs, headings, blockquotes, list items are limited to a width of 640.
  * Reduced margin bottom on all breadcrumbs.
  * Slightly reduced the width and margin of tiles
  * ordered lists and unordered lists show numbers and bullets now.
* End user Instructions component can, optionally, auto-collapse, so that only a portion is displayed, along with a toggle.  This is how it is set up for the ProcessInstanceShow page.
* Greatly reduced the lag in the interstitial page when doing a re-direct.

* run_pyl

* kill console

* wait for permissionsLoaded too since we are using ability.can

* Previous change removed the top level Messages page - this re-adds it.

* I am always, ALWAYS shocked at how I can not wrap my head around when and where to use "useEffect".

This should cause the show/hide Instructions toggle to only show when useful.

* Minor cleanup on the process instance properties display.

* linting

---------

Co-authored-by: burnettk <burnettk@users.noreply.github.com>

* Fix a linting error.

* minor permissions related fixes for the new ui.

* Revert "Revert "Feature/better subworkflow management (#331)""

This reverts commit 48dcde8faf.

* do not execute tasks from the process instance show page w/ burnettk

* pyl w/ burnettk

* Very minor UI tweak to resolve a number of issues mentioned in SPIFF-316 Notion Ticket:

* Markdown links now open in a new window
* Tables on the home pages are now contained within Grids to better align them with the other content that is in a grid.
* Right aligned the "process instance list link" button to it is flush right with the table underneath
* Gave a little more breathing room the content on the info/metadata in the process instance view .

* updated docker image build action to contain the appropriate version info w/ burnettk

* properly resize to the available columns depending on s/m/l

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
Co-authored-by: Dan Funk <daniel.h.funk@gmail.com>
Co-authored-by: burnettk <burnettk@users.noreply.github.com>
2023-07-03 10:54:54 +05:30
Dan Funk 532c0f841f bumping version of BPMN-JS-Spiffworkflow (#366) 2023-06-30 23:17:58 +05:30
Kevin Burnett d52e4dae75 when creating a process instance, use for-me path for perms (#354)
Co-authored-by: burnettk <burnettk@users.noreply.github.com>
2023-06-29 16:37:19 +05:30
jasquat 3a8cfd2642 disable form submit buttons when appropriate, lock process instance when sending events, and ensure return events match ones associated with desired guids w/ burnettk (#359)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-29 09:36:47 +05:30
jasquat 15b2947107 Feature/draft data in join table (#355)
* added a new model to store task draft data in a join table

* cleaned up using the join table for draft table w/ burnettk

* created new single migration for changes w/ burnettk

* added hidden form which autosaves without validations w/ burnettk

* change close button name since it does indeed save on close now

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-28 22:23:39 +05:30
jasquat 51cfcfa2a5 Feature/autosave and null form data (#346)
* autosave form data on change w/ burnettk

* tests are now passing and pyl

* do not do anything on autosave success w/ burnettk

* merged autosave and null form data branches together w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-26 18:26:56 +05:30
jasquat a9cc15177f updated usages of task_spec.spec for new spiff (#345)
* updated usages of task_spec.spec for new spiff

* removed unused attributes referring to call activities

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-26 11:57:32 +05:30
jasquat 3d113409b9 fixed lint issues 2023-06-23 08:50:48 -04:00
jbirddog 2c99e17381 Show callers for non primary files (#334)
* WIP - working with multiple process ids, need to return a file's process ids

* Send bpmn process ids back with bpmn files

* Getting ./bin/pyl to pass

* Fix up unit test

* Wire up the front end

* Pre pr cleanup
2023-06-23 11:45:23 +05:30
Kevin Burnett 7de0d97303 Feature/better subworkflow management part 2 (#341)
* Revert "Revert "Feature/better subworkflow management (#331)""

This reverts commit 48dcde8faf.

* updated SpiffWorkflow to fix infinite loop in task trace w/ burnettk

---------

Co-authored-by: burnettk <burnettk@users.noreply.github.com>
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-20 10:37:49 -04:00
burnettk ecf0a423be Revert "processes to process models"
This reverts commit 294eff7873.
2023-06-19 09:08:46 -04:00
burnettk 294eff7873 processes to process models 2023-06-19 08:27:06 -04:00
burnettk 87f32ac687 Revert "set undefined values to null rjsf form data w/ burnettk (#336)"
This reverts commit cca9b147f6.
2023-06-19 08:19:49 -04:00
burnettk 53d73e13a3 Revert "Feature/interstitial summary (#337)"
This reverts commit c48f3a458b.
2023-06-19 08:19:36 -04:00
burnettk 916324404e Revert "Fix a linting error."
This reverts commit d1a1e40f29.
2023-06-19 08:19:29 -04:00
burnettk 5b7a4c10e2 Revert "minor permissions related fixes for the new ui."
This reverts commit 284d12e32c.
2023-06-19 08:19:23 -04:00
danfunk 284d12e32c minor permissions related fixes for the new ui. 2023-06-16 12:00:27 -04:00
danfunk d1a1e40f29 Fix a linting error. 2023-06-16 10:22:50 -04:00
Dan Funk c48f3a458b Feature/interstitial summary (#337)
* * Process instance logs and messages are now components rather than pages, and are included within tabs on the process instance page, along with the diagram.
* Removed the Zoom and Move modules when showing the readonly
  Diagram.  Assured this readonly view is resized to fit the space when possible.
* Checkbox Widget no longer displays a duplicate label.
* CSS Tweaks
  * All pages are limited to a max display width of 1440, with auto margins to center the main content on the page.
  * "Show" pages, like ProcessInstanceShow, TaskShow have the primary content limited to 1000, also with auto-margins.
  * Paragraphs, headings, blockquotes, list items are limited to a width of 640.
  * Reduced margin bottom on all breadcrumbs.
  * Slightly reduced the width and margin of tiles
  * ordered lists and unordered lists show numbers and bullets now.
* End user Instructions component can, optionally, auto-collapse, so that only a portion is displayed, along with a toggle.  This is how it is set up for the ProcessInstanceShow page.
* Greatly reduced the lag in the interstitial page when doing a re-direct.

* run_pyl

* kill console

* wait for permissionsLoaded too since we are using ability.can

* Previous change removed the top level Messages page - this re-adds it.

* I am always, ALWAYS shocked at how I can not wrap my head around when and where to use "useEffect".

This should cause the show/hide Instructions toggle to only show when useful.

* Minor cleanup on the process instance properties display.

* linting

---------

Co-authored-by: burnettk <burnettk@users.noreply.github.com>
2023-06-16 09:53:20 -04:00
jasquat cca9b147f6 set undefined values to null rjsf form data w/ burnettk (#336)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-16 09:52:29 +05:30
burnettk 48dcde8faf Revert "Feature/better subworkflow management (#331)"
This reverts commit 23af5cbbe4.
2023-06-15 15:10:48 -04:00
jasquat 23af5cbbe4 Feature/better subworkflow management (#331)
* WIP: some updates to support new spiff w/ burnettk

* unit tests are passing

* all tests except message tests are passing

* fixed usage of catch message event w/ burnettk

* messages are working again w/ burnettk

* uncommented remaining message tests w/ burnettk

* fixed cypress tests w/ burnettk

* use main for spiffworkflow

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-15 10:31:42 -04:00
jasquat 9b9ec335b3 format date picker helper text width to match the date widget itself … (#330)
* format date picker helper text width to match the date widget itself w/ burnettk

* not sure we need xdoctest

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
Co-authored-by: burnettk <burnettk@users.noreply.github.com>
2023-06-13 20:16:26 +05:30
Elizabeth Esswein 5652f3981b restore loop collection references (#328)
* restore loop collection references

* ignore dmn files when restoring references
2023-06-12 18:32:16 -04:00
Kevin Burnett 7ab4d40ff4 make primary file use font style italics (#324)
Co-authored-by: burnettk <burnettk@users.noreply.github.com>
2023-06-12 06:42:30 -07:00
jasquat 121b3c7cc9 some fixes and updates to help with running an acceptance test model (#323)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-09 11:19:02 -07:00
jasquat ee18052be9 added css to make the hr elements look like they do for bootstrap w/ burnettk (#320)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-09 11:50:42 -04:00
jasquat 48fdb142e1 if the process id of the call activity cannot be found then refresh the list and try again w/ burnettk (#316)
Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-08 14:27:01 -07:00
jasquat 4fc6b1a193 use carbon components when adding secrets (#312)
* use carbon components when adding secrets

* docker compose pull before running up w/ burnettk

* use all carbon on script task unit test modal w/ burnettk

* removed remaining references to bootstrap from frontend w/ burnettk

* updated usage of hidden to use the class instead of the bootstrap attribute w/ burnettk

* print out docker version for debugging

* docker pull with docker instead of compose

* added comment for docker pull in check docker start script

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
2023-06-08 14:26:14 -07:00