sartography
/
spiff-arena
mirror of https://github.com/sartography/spiff-arena.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

more finally for better len 

added a fixme for raising errors
fixed up an error message
This commit is contained in:
Dan 2023-02-13 10:10:23 -05:00
parent 45ea3b76d9
commit feb25c286d
3 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
spiffworkflow-backend/src/spiffworkflow_backend/routes/process_instances_controller.py
View File

@ -125,6 +125,7 @@ def process_instance_run(
raise e raise e
except Exception as e: except Exception as e:
ErrorHandlingService().handle_error(processor, e) ErrorHandlingService().handle_error(processor, e)
# fixme: this is going to point someone to the wrong task - it's misinformation for errors in sub-processes
task = processor.bpmn_process_instance.last_task task = processor.bpmn_process_instance.last_task
raise ApiError.from_task( raise ApiError.from_task(
error_code="unknown_exception", error_code="unknown_exception",

3
spiffworkflow-backend/src/spiffworkflow_backend/services/process_instance_processor.py
View File

@ -208,8 +208,9 @@ class NonTaskDataBasedScriptEngineEnvironment(BasePythonScriptEngineEnvironment)
self.state.update(self.globals) self.state.update(self.globals)
self.state.update(external_methods or {}) self.state.update(external_methods or {})
self.state.update(context) self.state.update(context)
try:
exec(script, self.state) # noqa exec(script, self.state) # noqa
finally:
# since the task data is not directly mutated when the script executes, need to determine which keys # since the task data is not directly mutated when the script executes, need to determine which keys
# have been deleted from the environment and remove them from task data if present. # have been deleted from the environment and remove them from task data if present.
context_keys_to_drop = context.keys() - self.state.keys() context_keys_to_drop = context.keys() - self.state.keys()

2
spiffworkflow-backend/src/spiffworkflow_backend/services/service_task_service.py
View File

@ -113,7 +113,7 @@ class ServiceTaskDelegate:
message = ServiceTaskDelegate.get_message_for_status( message = ServiceTaskDelegate.get_message_for_status(
proxied_response.status_code proxied_response.status_code
) )
error = f"Received an unexpected response from the service : {message}" error = f"Received an unexpected response from service {name} : {message}"
if "error" in parsed_response: if "error" in parsed_response:
error += parsed_response["error"] error += parsed_response["error"]
if json_parse_error: if json_parse_error: