From d53b79b18a8549eb12081eddb026c4e283b5b3fa Mon Sep 17 00:00:00 2001 From: jasquat Date: Thu, 23 Feb 2023 17:09:33 -0500 Subject: [PATCH] removed commented out code w/ burnettk --- .../routes/tasks_controller.py | 81 ------------------- 1 file changed, 81 deletions(-) diff --git a/spiffworkflow-backend/src/spiffworkflow_backend/routes/tasks_controller.py b/spiffworkflow-backend/src/spiffworkflow_backend/routes/tasks_controller.py index eb836f495..82fd88996 100644 --- a/spiffworkflow-backend/src/spiffworkflow_backend/routes/tasks_controller.py +++ b/spiffworkflow-backend/src/spiffworkflow_backend/routes/tasks_controller.py @@ -197,87 +197,6 @@ def task_data_show( status_code=400, ) - # step_details = step_detail_query.all() - # bpmn_json = json.loads(process_instance.bpmn_json or "{}") - # tasks = bpmn_json["tasks"] - # subprocesses = bpmn_json["subprocesses"] - # - # steps_by_id = {step_detail.task_id: step_detail for step_detail in step_details} - # - # # FIXME: never evaluate task data in this call and instead create a new api getter - # # that will return the task data for a given step only. We think processing this - # # data is what is causing long load times on the processInstanceShowPage. - # subprocess_state_overrides = {} - # if step_detail.task_id in tasks: - # task_data = ( - # step_detail.task_json["task_data"] | step_detail.task_json["python_env"] - # ) - # if task_data is None: - # task_data = {} - # tasks[step_detail.task_id]["data"] = task_data - # tasks[step_detail.task_id]["state"] = Task.task_state_name_to_int( - # step_detail.task_state - # ) - # else: - # for subprocess_id, subprocess_info in subprocesses.items(): - # if step_detail.task_id in subprocess_info["tasks"]: - # task_data = ( - # step_detail.task_json["task_data"] - # | step_detail.task_json["python_env"] - # ) - # if task_data is None: - # task_data = {} - # subprocess_info["tasks"][step_detail.task_id]["data"] = task_data - # subprocess_info["tasks"][step_detail.task_id]["state"] = ( - # Task.task_state_name_to_int(step_detail.task_state) - # ) - # subprocess_state_overrides[subprocess_id] = TaskState.WAITING - # - # for subprocess_info in subprocesses.values(): - # for spiff_task_id in subprocess_info["tasks"]: - # if spiff_task_id not in steps_by_id: - # subprocess_info["tasks"][spiff_task_id]["data"] = {} - # subprocess_info["tasks"][spiff_task_id]["state"] = ( - # subprocess_state_overrides.get(spiff_task_id, TaskState.FUTURE) - # ) - # for spiff_task_id in tasks: - # if spiff_task_id not in steps_by_id: - # tasks[spiff_task_id]["data"] = {} - # tasks[spiff_task_id]["state"] = subprocess_state_overrides.get( - # spiff_task_id, TaskState.FUTURE - # ) - # - # process_instance.bpmn_json = json.dumps(bpmn_json) - # - # processor = ProcessInstanceProcessor(process_instance) - # spiff_task = processor.__class__.get_task_by_bpmn_identifier( - # step_details[-1].bpmn_task_identifier, processor.bpmn_process_instance - # ) - # if spiff_task is not None and spiff_task.state != TaskState.READY: - # spiff_task.complete() - # - # spiff_tasks = None - # if all_tasks: - # spiff_tasks = processor.bpmn_process_instance.get_tasks(TaskState.ANY_MASK) - # else: - # spiff_tasks = processor.get_all_user_tasks() - # - # ( - # subprocesses_by_child_task_ids, - # task_typename_by_task_id, - # ) = processor.get_subprocesses_by_child_task_ids() - # processor.get_highest_level_calling_subprocesses_by_child_task_ids( - # subprocesses_by_child_task_ids, task_typename_by_task_id - # ) - # - # tasks = [] - # for spiff_task in spiff_tasks: - # task_spiff_step: Optional[int] = None - # if str(spiff_task.id) in steps_by_id: - # task_spiff_step = steps_by_id[str(spiff_task.id)].spiff_step - # calling_subprocess_task_id = subprocesses_by_child_task_ids.get( - # str(spiff_task.id), None - # ) processor = ProcessInstanceProcessor(process_instance) spiff_task = processor.__class__.get_task_by_bpmn_identifier( step_detail.bpmn_task_identifier, processor.bpmn_process_instance