From c9127bdac26b5cc0cb6b7db40348a26f2796544b Mon Sep 17 00:00:00 2001
From: burnettk <burnettk@users.noreply.github.com>
Date: Mon, 26 Dec 2022 22:54:51 -0500
Subject: [PATCH] add an underscorize helper and use it for form fields where
 they need to be python identifiers

---
 spiffworkflow-frontend/src/helpers.test.tsx          | 12 +++++++++++-
 spiffworkflow-frontend/src/helpers.tsx               |  4 ++++
 .../src/routes/JsonSchemaFormBuilder.tsx             |  8 ++++++--
 3 files changed, 21 insertions(+), 3 deletions(-)

diff --git a/spiffworkflow-frontend/src/helpers.test.tsx b/spiffworkflow-frontend/src/helpers.test.tsx
index 5a0352b82..660f65f67 100644
--- a/spiffworkflow-frontend/src/helpers.test.tsx
+++ b/spiffworkflow-frontend/src/helpers.test.tsx
@@ -1,4 +1,8 @@
-import { convertSecondsToFormattedDateString, slugifyString } from './helpers';
+import {
+  convertSecondsToFormattedDateString,
+  slugifyString,
+  underscorizeString,
+} from './helpers';
 
 test('it can slugify a string', () => {
   expect(slugifyString('hello---world_ and then Some such-')).toEqual(
@@ -6,6 +10,12 @@ test('it can slugify a string', () => {
   );
 });
 
+test('it can underscorize a string', () => {
+  expect(underscorizeString('hello---world_ and then Some such-')).toEqual(
+    'hello_world_and_then_some_such'
+  );
+});
+
 test('it can keep the correct date when converting seconds to date', () => {
   const dateString = convertSecondsToFormattedDateString(1666325400);
   expect(dateString).toEqual('2022-10-21');
diff --git a/spiffworkflow-frontend/src/helpers.tsx b/spiffworkflow-frontend/src/helpers.tsx
index 8f6255335..d0f8e6f16 100644
--- a/spiffworkflow-frontend/src/helpers.tsx
+++ b/spiffworkflow-frontend/src/helpers.tsx
@@ -20,6 +20,10 @@ export const slugifyString = (str: any) => {
     .replace(/-+$/g, '');
 };
 
+export const underscorizeString = (inputString: string) => {
+  return slugifyString(inputString).replace(/-/g, '_');
+};
+
 export const capitalizeFirstLetter = (string: any) => {
   return string.charAt(0).toUpperCase() + string.slice(1);
 };
diff --git a/spiffworkflow-frontend/src/routes/JsonSchemaFormBuilder.tsx b/spiffworkflow-frontend/src/routes/JsonSchemaFormBuilder.tsx
index 6d1011014..d4a9c2b44 100644
--- a/spiffworkflow-frontend/src/routes/JsonSchemaFormBuilder.tsx
+++ b/spiffworkflow-frontend/src/routes/JsonSchemaFormBuilder.tsx
@@ -3,7 +3,11 @@ import { useEffect, useState } from 'react';
 import { Button, Select, SelectItem, TextInput } from '@carbon/react';
 import { useParams } from 'react-router-dom';
 import { FormField } from '../interfaces';
-import { modifyProcessIdentifierForPathParam, slugifyString } from '../helpers';
+import {
+  modifyProcessIdentifierForPathParam,
+  slugifyString,
+  underscorizeString,
+} from '../helpers';
 import HttpService from '../services/HttpService';
 
 export default function JsonSchemaFormBuilder() {
@@ -75,7 +79,7 @@ export default function JsonSchemaFormBuilder() {
       formFieldIdHasBeenUpdatedByUser
     );
     if (!formFieldIdHasBeenUpdatedByUser) {
-      setFormFieldId(slugifyString(newFormFieldTitle));
+      setFormFieldId(underscorizeString(newFormFieldTitle));
     }
     setFormFieldTitle(newFormFieldTitle);
   };