From bb6dd35bbd7439fe881e4cd966ab3fc2d5447da1 Mon Sep 17 00:00:00 2001 From: burnettk Date: Tue, 21 Feb 2023 22:43:23 -0500 Subject: [PATCH] remove start and end events from simple logs view --- .../routes/process_instances_controller.py | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/spiffworkflow-backend/src/spiffworkflow_backend/routes/process_instances_controller.py b/spiffworkflow-backend/src/spiffworkflow_backend/routes/process_instances_controller.py index 634d21285..7d0b48379 100644 --- a/spiffworkflow-backend/src/spiffworkflow_backend/routes/process_instances_controller.py +++ b/spiffworkflow-backend/src/spiffworkflow_backend/routes/process_instances_controller.py @@ -199,16 +199,18 @@ def process_instance_log_list( ) if not detailed: log_query = log_query.filter( - # this was the previous implementation, where we only show completed tasks and skipped tasks. - # maybe we want to iterate on this in the future (in a third tab under process instance logs?) - # or_( - # SpiffLoggingModel.message.in_(["State change to COMPLETED"]), # type: ignore - # SpiffLoggingModel.message.like("Skipped task %"), # type: ignore - # ) + # 1. this was the previous implementation, where we only show completed tasks and skipped tasks. + # maybe we want to iterate on this in the future (in a third tab under process instance logs?) + # or_( + # SpiffLoggingModel.message.in_(["State change to COMPLETED"]), # type: ignore + # SpiffLoggingModel.message.like("Skipped task %"), # type: ignore + # ) + # 2. We included ["End Event", "Default Start Event"] along with Default Throwing Event, but feb 2023 + # we decided to remove them, since they get really chatty when there are lots of subprocesses and call activities. and_( SpiffLoggingModel.message.in_(["State change to COMPLETED"]), # type: ignore SpiffLoggingModel.bpmn_task_type.in_( # type: ignore - ["Default Throwing Event", "End Event", "Default Start Event"] + ["Default Throwing Event"] ), ) )