From b02c28697d1e1d85e6a42a5d3f48095d5a0ace33 Mon Sep 17 00:00:00 2001
From: burnettk <burnettk@users.noreply.github.com>
Date: Thu, 1 Jun 2023 10:43:27 -0400
Subject: [PATCH] use icons for running unit tests, w/ lantz

---
 .../src/components/ProcessModelTestRun.tsx    | 39 +++++++------------
 .../src/routes/ProcessModelShow.tsx           | 25 +++++-------
 2 files changed, 22 insertions(+), 42 deletions(-)

diff --git a/spiffworkflow-frontend/src/components/ProcessModelTestRun.tsx b/spiffworkflow-frontend/src/components/ProcessModelTestRun.tsx
index 9938431a0..231b86b20 100644
--- a/spiffworkflow-frontend/src/components/ProcessModelTestRun.tsx
+++ b/spiffworkflow-frontend/src/components/ProcessModelTestRun.tsx
@@ -1,4 +1,4 @@
-import { PlayOutline, Checkmark, Close } from '@carbon/icons-react';
+import { Rule, Checkmark, Close } from '@carbon/icons-react';
 import { Button, Modal } from '@carbon/react';
 import { useState } from 'react';
 import { useUriListForPermissions } from '../hooks/UriListForPermissions';
@@ -11,12 +11,12 @@ import {
 
 type OwnProps = {
   processModelFile?: ProcessFile;
-  buttonType?: string;
+  titleText: string;
 };
 
 export default function ProcessModelTestRun({
   processModelFile,
-  buttonType = 'icon',
+  titleText,
 }: OwnProps) {
   const [testCaseResults, setTestCaseResults] =
     useState<TestCaseResults | null>(null);
@@ -153,29 +153,16 @@ export default function ProcessModelTestRun({
   };
 
   const buttonElement = () => {
-    if (buttonType === 'icon') {
-      return (
-        <Button
-          kind="ghost"
-          renderIcon={PlayOutline}
-          iconDescription="Run BPMN unit tests defined in this file"
-          hasIconOnly
-          size="lg"
-          onClick={() => onProcessModelTestRun()}
-        />
-      );
-    }
-    if (buttonType === 'text') {
-      return (
-        <Button
-          onClick={() => onProcessModelTestRun()}
-          title="Run all BPMN unit tests for this process model"
-        >
-          Run Unit Tests
-        </Button>
-      );
-    }
-    return null;
+    return (
+      <Button
+        kind="ghost"
+        renderIcon={Rule}
+        iconDescription={titleText}
+        hasIconOnly
+        size="lg"
+        onClick={() => onProcessModelTestRun()}
+      />
+    );
   };
 
   return (
diff --git a/spiffworkflow-frontend/src/routes/ProcessModelShow.tsx b/spiffworkflow-frontend/src/routes/ProcessModelShow.tsx
index fa136da5f..2c84b632a 100644
--- a/spiffworkflow-frontend/src/routes/ProcessModelShow.tsx
+++ b/spiffworkflow-frontend/src/routes/ProcessModelShow.tsx
@@ -324,7 +324,10 @@ export default function ProcessModelShow() {
     if (isTestCaseFile(processModelFile)) {
       elements.push(
         <Can I="POST" a={targetUris.processModelTestsPath} ability={ability}>
-          <ProcessModelTestRun processModelFile={processModelFile} />
+          <ProcessModelTestRun
+            processModelFile={processModelFile}
+            titleText="Run BPMN unit tests defined in this file"
+          />
         </Can>
       );
     }
@@ -664,6 +667,11 @@ export default function ProcessModelShow() {
               disabled={publishDisabled}
             />
           </Can>
+          <Can I="POST" a={targetUris.processModelTestsPath} ability={ability}>
+            {hasTestCaseFiles ? (
+              <ProcessModelTestRun titleText="Run all BPMN unit tests for this process model" />
+            ) : null}
+          </Can>
         </Stack>
         <p className="process-description">{processModel.description}</p>
         <Stack orientation="horizontal" gap={3}>
@@ -681,21 +689,6 @@ export default function ProcessModelShow() {
               <br />
             </>
           </Can>
-          <Can
-            I="POST"
-            a={targetUris.processModelPublishPath}
-            ability={ability}
-          >
-            <Can
-              I="POST"
-              a={targetUris.processModelTestsPath}
-              ability={ability}
-            >
-              {hasTestCaseFiles ? (
-                <ProcessModelTestRun buttonType="text" />
-              ) : null}
-            </Can>
-          </Can>
         </Stack>
         {processModelFilesSection()}
         <Can I="GET" a={targetUris.processInstanceListPath} ability={ability}>