From ac1bebeb76c73c70515c3df4b91ef52543bd2449 Mon Sep 17 00:00:00 2001
From: jasquat <jasquat@users.noreply.github.com>
Date: Tue, 26 Sep 2023 10:30:11 -0400
Subject: [PATCH] fixed cypress tests

---
 .../cypress/e2e/process_instances.cy.js              | 12 ++++++------
 .../src/routes/ProcessModelShow.tsx                  |  8 +++++---
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/spiffworkflow-frontend/cypress/e2e/process_instances.cy.js b/spiffworkflow-frontend/cypress/e2e/process_instances.cy.js
index bfeaf91c1..c5ef671dc 100644
--- a/spiffworkflow-frontend/cypress/e2e/process_instances.cy.js
+++ b/spiffworkflow-frontend/cypress/e2e/process_instances.cy.js
@@ -97,28 +97,28 @@ describe('process-instances', () => {
     cy.runPrimaryBpmnFile();
 
     // Change dmn
-    cy.getBySel('files-accordion').click();
+    cy.getBySel('process-model-files').click();
     cy.getBySel(`edit-file-${dmnFile.replace('.', '-')}`).click();
     updateDmnText(originalDmnOutputForKevin, newDmnOutputForKevin);
 
     cy.contains(acceptanceTestOneDisplayName).click();
     cy.runPrimaryBpmnFile();
 
-    cy.getBySel('files-accordion').click();
+    cy.getBySel('process-model-files').click();
     cy.getBySel(`edit-file-${dmnFile.replace('.', '-')}`).click();
     updateDmnText(newDmnOutputForKevin, originalDmnOutputForKevin);
     cy.contains(acceptanceTestOneDisplayName).click();
     cy.runPrimaryBpmnFile();
 
     // Change bpmn
-    cy.getBySel('files-accordion').click();
+    cy.getBySel('process-model-files').click();
     cy.getBySel(`edit-file-${bpmnFile.replace('.', '-')}`).click();
     cy.contains(`Process Model File: ${bpmnFile}`);
     updateBpmnPythonScript(newPythonScript);
     cy.contains(acceptanceTestOneDisplayName).click();
     cy.runPrimaryBpmnFile();
 
-    cy.getBySel('files-accordion').click();
+    cy.getBySel('process-model-files').click();
     cy.getBySel(`edit-file-${bpmnFile.replace('.', '-')}`).click();
     updateBpmnPythonScript(originalPythonScript);
     cy.contains(acceptanceTestOneDisplayName).click();
@@ -133,14 +133,14 @@ describe('process-instances', () => {
   //   const bpmnFile = 'process_model_one.bpmn';
   //
   //   // Change bpmn
-  //   cy.getBySel('files-accordion').click();
+  //   cy.getBySel('process-model-files').click();
   //   cy.getBySel(`edit-file-${bpmnFile.replace('.', '-')}`).click();
   //   cy.contains(`Process Model File: ${bpmnFile}`);
   //   updateBpmnPythonScriptWithMonaco(newPythonScript);
   //   cy.contains('acceptance-tests-model-1').click();
   //   cy.runPrimaryBpmnFile();
   //
-  //   cy.getBySel('files-accordion').click();
+  //   cy.getBySel('process-model-files').click();
   //   cy.getBySel(`edit-file-${bpmnFile.replace('.', '-')}`).click();
   //   cy.contains(`Process Model File: ${bpmnFile}`);
   //   updateBpmnPythonScriptWithMonaco(originalPythonScript);
diff --git a/spiffworkflow-frontend/src/routes/ProcessModelShow.tsx b/spiffworkflow-frontend/src/routes/ProcessModelShow.tsx
index 7efca7827..742539934 100644
--- a/spiffworkflow-frontend/src/routes/ProcessModelShow.tsx
+++ b/spiffworkflow-frontend/src/routes/ProcessModelShow.tsx
@@ -641,8 +641,8 @@ export default function ProcessModelShow() {
       <Tabs selectedIndex={selectedTabIndex} onChange={updateSelectedTab}>
         <TabList aria-label="List of tabs">
           <Tab>About</Tab>
-          <Tab>Files</Tab>
-          <Tab>My process instances</Tab>
+          <Tab data-qa="process-model-files">Files</Tab>
+          <Tab data-qa="process-instance-list-link">My process instances</Tab>
         </TabList>
         <TabPanels>
           <TabPanel>{readmeFileArea()}</TabPanel>
@@ -687,7 +687,6 @@ export default function ProcessModelShow() {
                   perPageOptions={[2, 5, 25]}
                   showReports={false}
                 />
-                <span data-qa="process-model-show-permissions-loaded" />
               </Can>
             )}
           </TabPanel>
@@ -799,6 +798,9 @@ export default function ProcessModelShow() {
         <p className="process-description">{processModel.description}</p>
         {processModel.primary_file_name ? processStartButton : null}
         <div className="with-top-margin">{tabArea()}</div>
+        {permissionsLoaded ? (
+          <span data-qa="process-model-show-permissions-loaded" />
+        ) : null}
       </>
     );
   }