diff --git a/spiffworkflow-backend/src/spiffworkflow_backend/routes/tasks_controller.py b/spiffworkflow-backend/src/spiffworkflow_backend/routes/tasks_controller.py index df9f5818b..4c5bf15c6 100644 --- a/spiffworkflow-backend/src/spiffworkflow_backend/routes/tasks_controller.py +++ b/spiffworkflow-backend/src/spiffworkflow_backend/routes/tasks_controller.py @@ -430,20 +430,21 @@ def _interstitial_stream(process_instance: ProcessInstanceModel) -> Generator[st break # No more tasks to report spiff_task = processor.next_task() - task = ProcessInstanceService.spiff_task_to_api_task(processor, processor.next_task()) - if task.id not in reported_ids: - try: - instructions = render_instructions(spiff_task) - except Exception as e: - api_error = ApiError( - error_code="engine_steps_error", - message=f"Failed to complete an automated task. Error was: {str(e)}", - status_code=400, - ) - yield render_data("error", api_error) - raise e - task.properties = {"instructionsForEndUser": instructions} - yield render_data("task", task) + if spiff_task is not None: + task = ProcessInstanceService.spiff_task_to_api_task(processor, spiff_task) + if task.id not in reported_ids: + try: + instructions = render_instructions(spiff_task) + except Exception as e: + api_error = ApiError( + error_code="engine_steps_error", + message=f"Failed to complete an automated task. Error was: {str(e)}", + status_code=400, + ) + yield render_data("error", api_error) + raise e + task.properties = {"instructionsForEndUser": instructions} + yield render_data("task", task) def get_ready_engine_step_count(bpmn_process_instance: BpmnWorkflow) -> int: diff --git a/spiffworkflow-backend/src/spiffworkflow_backend/services/process_instance_service.py b/spiffworkflow-backend/src/spiffworkflow_backend/services/process_instance_service.py index f342f5f0a..109832d79 100644 --- a/spiffworkflow-backend/src/spiffworkflow_backend/services/process_instance_service.py +++ b/spiffworkflow-backend/src/spiffworkflow_backend/services/process_instance_service.py @@ -514,7 +514,6 @@ class ProcessInstanceService: add_docs_and_forms: bool = False, calling_subprocess_task_id: str | None = None, ) -> Task: - """Spiff_task_to_api_task.""" task_type = spiff_task.task_spec.description props = {} diff --git a/spiffworkflow-frontend/src/components/ProcessInterstitial.tsx b/spiffworkflow-frontend/src/components/ProcessInterstitial.tsx index 639b5bb92..3c06d05e4 100644 --- a/spiffworkflow-frontend/src/components/ProcessInterstitial.tsx +++ b/spiffworkflow-frontend/src/components/ProcessInterstitial.tsx @@ -15,12 +15,14 @@ type OwnProps = { processInstanceId: number; processInstanceShowPageUrl: string; allowRedirect: boolean; + redirectToHomeWhenNoTasks?: boolean; }; export default function ProcessInterstitial({ processInstanceId, allowRedirect, processInstanceShowPageUrl, + redirectToHomeWhenNoTasks = true, }: OwnProps) { const [data, setData] = useState([]); const [lastTask, setLastTask] = useState(null); @@ -49,7 +51,6 @@ export default function ProcessInterstitial({ } }, onclose() { - console.log('The state is closed.'); setState('CLOSED'); }, }); @@ -161,7 +162,7 @@ export default function ProcessInterstitial({ /** In the event there is no task information and the connection closed, * redirect to the home page. */ - if (state === 'CLOSED' && lastTask === null) { + if (state === 'CLOSED' && lastTask === null && redirectToHomeWhenNoTasks) { navigate(`/tasks`); } diff --git a/spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx b/spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx index ca7968a2b..74b8bb056 100644 --- a/spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx +++ b/spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx @@ -1113,6 +1113,7 @@ export default function ProcessInstanceShow({ variant }: OwnProps) {