remove the publish button if backend is not configured to publish w/ burnettk (#473)

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
This commit is contained in:
jasquat 2023-09-07 16:03:47 -04:00 committed by GitHub
parent f0fdf51a87
commit a7556dc958
5 changed files with 60 additions and 30 deletions

View File

@ -53,6 +53,8 @@ class ProcessModelInfo:
# TODO: delete these once they no no longer mentioned in current process_model.json files # TODO: delete these once they no no longer mentioned in current process_model.json files
display_order: int | None = 0 display_order: int | None = 0
actions: dict | None = None
def __post_init__(self) -> None: def __post_init__(self) -> None:
self.sort_index = self.id self.sort_index = self.id

View File

@ -157,6 +157,14 @@ def process_model_show(modified_process_model_identifier: str, include_file_refe
current_git_revision = "" current_git_revision = ""
process_model.bpmn_version_control_identifier = current_git_revision process_model.bpmn_version_control_identifier = current_git_revision
available_actions = {}
if GitService.check_for_publish_configs(raise_on_missing=False):
available_actions = {
"publish": {"path": f"/process-model-publish/{modified_process_model_identifier}", "method": "POST"}
}
process_model.actions = available_actions
return make_response(jsonify(process_model), 200) return make_response(jsonify(process_model), 200)

View File

@ -84,26 +84,35 @@ class GitService:
return cls.run_shell_command_to_get_stdout(shell_command) return cls.run_shell_command_to_get_stdout(shell_command)
@classmethod @classmethod
def check_for_basic_configs(cls) -> None: def check_for_basic_configs(cls, raise_on_missing: bool = True) -> bool:
if current_app.config["SPIFFWORKFLOW_BACKEND_GIT_SOURCE_BRANCH"] is None: if current_app.config["SPIFFWORKFLOW_BACKEND_GIT_SOURCE_BRANCH"] is None:
if raise_on_missing:
raise MissingGitConfigsError( raise MissingGitConfigsError(
"Missing config for SPIFFWORKFLOW_BACKEND_GIT_SOURCE_BRANCH. " "Missing config for SPIFFWORKFLOW_BACKEND_GIT_SOURCE_BRANCH. "
"This is required for publishing process models" "This is required for publishing process models"
) )
return False
return True
@classmethod @classmethod
def check_for_publish_configs(cls) -> None: def check_for_publish_configs(cls, raise_on_missing: bool = True) -> bool:
cls.check_for_basic_configs() if not cls.check_for_basic_configs(raise_on_missing=raise_on_missing):
return False
if current_app.config["SPIFFWORKFLOW_BACKEND_GIT_PUBLISH_TARGET_BRANCH"] is None: if current_app.config["SPIFFWORKFLOW_BACKEND_GIT_PUBLISH_TARGET_BRANCH"] is None:
if raise_on_missing:
raise MissingGitConfigsError( raise MissingGitConfigsError(
"Missing config for SPIFFWORKFLOW_BACKEND_GIT_PUBLISH_TARGET_BRANCH. " "Missing config for SPIFFWORKFLOW_BACKEND_GIT_PUBLISH_TARGET_BRANCH. "
"This is required for publishing process models" "This is required for publishing process models"
) )
return False
if current_app.config["SPIFFWORKFLOW_BACKEND_GIT_PUBLISH_CLONE_URL"] is None: if current_app.config["SPIFFWORKFLOW_BACKEND_GIT_PUBLISH_CLONE_URL"] is None:
if raise_on_missing:
raise MissingGitConfigsError( raise MissingGitConfigsError(
"Missing config for SPIFFWORKFLOW_BACKEND_GIT_PUBLISH_CLONE_URL." "Missing config for SPIFFWORKFLOW_BACKEND_GIT_PUBLISH_CLONE_URL."
" This is required for publishing process models" " This is required for publishing process models"
) )
return False
return True
@classmethod @classmethod
def run_shell_command_as_boolean(cls, command: list[str]) -> bool: def run_shell_command_as_boolean(cls, command: list[str]) -> bool:

View File

@ -3,6 +3,14 @@ export interface User {
username: string; username: string;
} }
export interface ApiAction {
path: string;
method: string;
}
export interface ApiActions {
[key: string]: ApiAction;
}
export interface Secret { export interface Secret {
id: number; id: number;
key: string; key: string;
@ -265,6 +273,7 @@ export interface ProcessModel {
fault_or_suspend_on_exception?: string; fault_or_suspend_on_exception?: string;
exception_notification_addresses?: string[]; exception_notification_addresses?: string[];
bpmn_version_control_identifier?: string; bpmn_version_control_identifier?: string;
actions?: ApiActions;
} }
export interface ProcessGroup { export interface ProcessGroup {

View File

@ -680,6 +680,7 @@ export default function ProcessModelShow() {
confirmButtonLabel="Delete" confirmButtonLabel="Delete"
/> />
</Can> </Can>
{!processModel.actions || processModel.actions.publish ? (
<Can <Can
I="POST" I="POST"
a={targetUris.processModelPublishPath} a={targetUris.processModelPublishPath}
@ -695,6 +696,7 @@ export default function ProcessModelShow() {
disabled={publishDisabled} disabled={publishDisabled}
/> />
</Can> </Can>
) : null}
<Can I="POST" a={targetUris.processModelTestsPath} ability={ability}> <Can I="POST" a={targetUris.processModelTestsPath} ability={ability}>
{hasTestCaseFiles ? ( {hasTestCaseFiles ? (
<ProcessModelTestRun titleText="Run all BPMN unit tests for this process model" /> <ProcessModelTestRun titleText="Run all BPMN unit tests for this process model" />