a better fix. just set the extensionUxElements to a blank array instead of creating a new state

This commit is contained in:
jasquat 2024-02-09 10:39:45 -05:00
parent 7a62a8688c
commit 90c49f8e5c
No known key found for this signature in database
2 changed files with 7 additions and 19 deletions

View File

@ -22,12 +22,9 @@ import NavigationBar from './components/NavigationBar';
export default function ContainerForExtensions() {
const [backendIsUp, setBackendIsUp] = useState<boolean | null>(null);
const [extensionUxElements, setExtensionNavigationItems] = useState<
const [extensionUxElements, setExtensionUxElements] = useState<
UiSchemaUxElement[] | null
>(null);
const [canLoadExtensions, setCanLoadExtensions] = useState<boolean | null>(
null
);
let contentClassName = 'main-site-body-centered';
if (window.location.pathname.startsWith('/editor/')) {
@ -70,7 +67,7 @@ export default function ContainerForExtensions() {
})
.flat();
if (eni) {
setExtensionNavigationItems(eni);
setExtensionUxElements(eni);
}
};
@ -80,13 +77,13 @@ export default function ContainerForExtensions() {
return;
}
if (ability.can('GET', targetUris.extensionListPath)) {
setCanLoadExtensions(true);
HttpService.makeCallToBackend({
path: targetUris.extensionListPath,
successCallback: processExtensionResult,
});
} else {
setCanLoadExtensions(false);
// set to an empty array so we know that it loaded
setExtensionUxElements([]);
}
};
@ -107,12 +104,7 @@ export default function ContainerForExtensions() {
<Routes>
<Route
path="/*"
element={
<BaseRoutes
extensionUxElements={extensionUxElements}
canLoadExtensions={canLoadExtensions}
/>
}
element={<BaseRoutes extensionUxElements={extensionUxElements} />}
/>
<Route path="/editor/*" element={<EditorRoutes />} />
<Route path="/extensions/:page_identifier" element={<Extension />} />

View File

@ -19,14 +19,10 @@ import { ExtensionUxElementMap } from '../components/ExtensionUxElementForDispla
import Extension from './Extension';
type OwnProps = {
canLoadExtensions: boolean | null;
extensionUxElements?: UiSchemaUxElement[] | null;
};
export default function BaseRoutes({
canLoadExtensions,
extensionUxElements,
}: OwnProps) {
export default function BaseRoutes({ extensionUxElements }: OwnProps) {
const elementCallback = (uxElement: UiSchemaUxElement) => {
return (
<Route
@ -36,7 +32,7 @@ export default function BaseRoutes({
);
};
if (extensionUxElements || canLoadExtensions === false) {
if (extensionUxElements) {
const extensionRoutes = ExtensionUxElementMap({
displayLocation: 'routes',
elementCallback,