From 8a421bfb2c9819bd5a446d66c63391e0d1aee005 Mon Sep 17 00:00:00 2001 From: jasquat Date: Thu, 16 Feb 2023 13:31:08 -0500 Subject: [PATCH] corrected cypress env var --- .github/workflows/frontend_tests.yml | 2 +- spiffworkflow-frontend/cypress/support/commands.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/frontend_tests.yml b/.github/workflows/frontend_tests.yml index b0ed9bc47..31155b40d 100644 --- a/.github/workflows/frontend_tests.yml +++ b/.github/workflows/frontend_tests.yml @@ -101,7 +101,7 @@ jobs: CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }} # pass GitHub token to allow accurately detecting a build vs a re-run build GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - SPIFFWORKFLOW_FRONTEND_AUTH_WITH_KEYCLOAK: "true" + CYPRESS_SPIFFWORKFLOW_FRONTEND_AUTH_WITH_KEYCLOAK: "true" - name: get_backend_logs_from_docker_compose if: failure() working-directory: ./spiffworkflow-backend diff --git a/spiffworkflow-frontend/cypress/support/commands.js b/spiffworkflow-frontend/cypress/support/commands.js index 6fd478f26..adf3623c7 100644 --- a/spiffworkflow-frontend/cypress/support/commands.js +++ b/spiffworkflow-frontend/cypress/support/commands.js @@ -47,7 +47,7 @@ Cypress.Commands.add('login', (selector, ...args) => { const password = Cypress.env('SPIFFWORKFLOW_FRONTEND_PASSWORD') || 'ciadmin1'; cy.get('#username').type(username); cy.get('#password').type(password); - if (Cypress.env('SPIFFWORKFLOW_FRONTEND_AUTH_WITH_KEYCLOAK') === 'true') { + if (Cypress.env('SPIFFWORKFLOW_FRONTEND_AUTH_WITH_KEYCLOAK') === true) { cy.get('#kc-login').click(); } else { cy.get('#spiff-login-button').click(); @@ -57,7 +57,7 @@ Cypress.Commands.add('login', (selector, ...args) => { Cypress.Commands.add('logout', (selector, ...args) => { cy.getBySel('logout-button').click(); - if (Cypress.env('SPIFFWORKFLOW_FRONTEND_AUTH_WITH_KEYCLOAK') === 'true') { + if (Cypress.env('SPIFFWORKFLOW_FRONTEND_AUTH_WITH_KEYCLOAK') === true) { // otherwise we can click logout, quickly load the next page, and the javascript // doesn't have time to actually sign you out cy.contains('Sign in to your account');