sartography
/
spiff-arena
mirror of https://github.com/sartography/spiff-arena.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Feature/treat blank task as manual (#598) 

* adds basic support to use certain components in extensions w/ burnettk

* treat a blank Task as a manual task on the frontend w/ burnettk

* updated remaining references for ManualTask vs UserTask w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
This commit is contained in:
jasquat 2023-10-27 15:58:02 -04:00 committed by GitHub
parent 234c9646e1
commit 8330c5b383
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
spiffworkflow-frontend/src/components/TaskListTable.tsx
View File

@ -141,7 +141,7 @@ export default function TaskListTable({
// TODO: move this and the code from TaskShow to new component to handle instructions and manual tasks // TODO: move this and the code from TaskShow to new component to handle instructions and manual tasks
let formUiSchema; let formUiSchema;
let jsonSchema = formSubmissionTask.form_schema; let jsonSchema = formSubmissionTask.form_schema;
if (formSubmissionTask.typename === 'ManualTask') { if (formSubmissionTask.typename !== 'UserTask') {
jsonSchema = { jsonSchema = {
type: 'object', type: 'object',
required: [], required: [],

1
spiffworkflow-frontend/src/helpers.tsx
View File

@ -25,6 +25,7 @@ export const HUMAN_TASK_TYPES = [
'Manual Task', 'Manual Task',
'UserTask', 'UserTask',
'ManualTask', 'ManualTask',
'Task',
]; ];
export const underscorizeString = (inputString: string) => { export const underscorizeString = (inputString: string) => {

4
spiffworkflow-frontend/src/routes/TaskShow.tsx
View File

@ -102,7 +102,7 @@ export default function TaskShow() {
// https://github.com/sartography/spiff-arena/blob/182f56a1ad23ce780e8f5b0ed00efac3e6ad117b/spiffworkflow-frontend/src/routes/TaskShow.tsx#L329 // https://github.com/sartography/spiff-arena/blob/182f56a1ad23ce780e8f5b0ed00efac3e6ad117b/spiffworkflow-frontend/src/routes/TaskShow.tsx#L329
const autoSaveTaskData = (formData: any, successCallback?: Function) => { const autoSaveTaskData = (formData: any, successCallback?: Function) => {
// save-draft gets called when a manual task form loads but there's no data to save so don't do it // save-draft gets called when a manual task form loads but there's no data to save so don't do it
if (taskWithTaskData?.typename === 'ManualTask') { if (['ManualTask', 'Task'].includes(taskWithTaskData?.typename || '')) {
return undefined; return undefined;
} }
let successCallbackToUse = successCallback; let successCallbackToUse = successCallback;
@ -240,7 +240,7 @@ export default function TaskShow() {
let formUiSchema; let formUiSchema;
let jsonSchema = taskWithTaskData.form_schema; let jsonSchema = taskWithTaskData.form_schema;
let reactFragmentToHideSubmitButton = null; let reactFragmentToHideSubmitButton = null;
if (taskWithTaskData.typename === 'ManualTask') { if (taskWithTaskData.typename !== 'UserTask') {
jsonSchema = { jsonSchema = {
type: 'object', type: 'object',
required: [], required: [],