sartography/spiff-arena
1
0
Fork 0
mirror of https://github.com/sartography/spiff-arena.git synced 2025-03-01 01:20:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

process all cancelled tasks to see if that fixes error boundary events

Browse Source
This commit is contained in:
jasquat 2023-10-26 10:35:52 -04:00
parent 39edd60fd6
commit 83094c66ce
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
spiffworkflow-backend/src/spiffworkflow_backend/services/workflow_execution_service.py
View File

@ -261,12 +261,15 @@ class TaskModelSavingDelegate(EngineStepDelegate):
): ):
self.task_service.update_task_model_with_spiff_task(waiting_spiff_task) self.task_service.update_task_model_with_spiff_task(waiting_spiff_task)
# FIXME: this may have broken error boundary events getting cancelled.
# Getting all cancelled tasks to see if that fixes it
#
# only process cancelled tasks that were cancelled during this run # only process cancelled tasks that were cancelled during this run
# NOTE: this could mean we do not add task models that we should be adding # NOTE: this could mean we do not add task models that we should be adding
# in which case we may have to remove the updated_ts filter here and # in which case we may have to remove the updated_ts filter here and
# instead just avoid creating the event in update_task_model_with_spiff_task # instead just avoid creating the event in update_task_model_with_spiff_task
cancelled_spiff_tasks = bpmn_process_instance.get_tasks( cancelled_spiff_tasks = bpmn_process_instance.get_tasks(
state=TaskState.CANCELLED, updated_ts=self.run_started_at state=TaskState.CANCELLED # , updated_ts=self.run_started_at
) )
for cancelled_spiff_task in cancelled_spiff_tasks: for cancelled_spiff_task in cancelled_spiff_tasks:
self.task_service.update_task_model_with_spiff_task( self.task_service.update_task_model_with_spiff_task(