sartography
/
spiff-arena
mirror of https://github.com/sartography/spiff-arena.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't save `id` in the process_model json file 

This allows us to move models around on the file system
Add `id` back in when instantiating ProcessModelInfo from json file data
This commit is contained in:
mike cullerton 2022-11-18 08:52:10 -05:00
parent 7f9d028878
commit 64b0490dd5
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
spiffworkflow-backend/src/spiffworkflow_backend/services/process_model_service.py
View File

@ -79,10 +79,16 @@ class ProcessModelService(FileSystemService):
process_model_path = os.path.abspath(os.path.join(FileSystemService.root_path(), process_model.id)) process_model_path = os.path.abspath(os.path.join(FileSystemService.root_path(), process_model.id))
os.makedirs(process_model_path, exist_ok=True) os.makedirs(process_model_path, exist_ok=True)
json_path = os.path.abspath(os.path.join(process_model_path, self.PROCESS_MODEL_JSON_FILE)) json_path = os.path.abspath(os.path.join(process_model_path, self.PROCESS_MODEL_JSON_FILE))
process_model_id = process_model.id
# we don't save id in the json file
# this allows us to move models around on the filesystem
# the id is determined by its location on the filesystem
delattr(process_model, 'id')
with open(json_path, "w") as wf_json: with open(json_path, "w") as wf_json:
json.dump( json.dump(
self.PROCESS_MODEL_SCHEMA.dump(process_model), wf_json, indent=4, sort_keys=True self.PROCESS_MODEL_SCHEMA.dump(process_model), wf_json, indent=4, sort_keys=True
) )
process_model.id = process_model_id
def process_model_delete(self, process_model_id: str) -> None: def process_model_delete(self, process_model_id: str) -> None:
"""Delete Procecss Model.""" """Delete Procecss Model."""
@ -340,6 +346,9 @@ class ProcessModelService(FileSystemService):
data = json.load(wf_json) data = json.load(wf_json)
if "process_group_id" in data: if "process_group_id" in data:
data.pop("process_group_id") data.pop("process_group_id")
# we don't save `id` in the json file, so we add it back in here.
relative_path = os.path.relpath(path, FileSystemService.root_path())
data['id'] = relative_path
process_model_info = ProcessModelInfo(**data) process_model_info = ProcessModelInfo(**data)
if process_model_info is None: if process_model_info is None:
raise ApiError( raise ApiError(