From 5659171fa31da072310334ed5107f913dd56709f Mon Sep 17 00:00:00 2001
From: jbirddog <100367399+jbirddog@users.noreply.github.com>
Date: Wed, 12 Jun 2024 08:00:50 -0400
Subject: [PATCH] Fix dictionary changed size during iteration error (#1711)

---
 .../services/workflow_execution_service.py         | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/spiffworkflow-backend/src/spiffworkflow_backend/services/workflow_execution_service.py b/spiffworkflow-backend/src/spiffworkflow_backend/services/workflow_execution_service.py
index 8b314987b..a4a392ef4 100644
--- a/spiffworkflow-backend/src/spiffworkflow_backend/services/workflow_execution_service.py
+++ b/spiffworkflow-backend/src/spiffworkflow_backend/services/workflow_execution_service.py
@@ -5,6 +5,7 @@ import time
 from abc import abstractmethod
 from collections.abc import Callable
 from datetime import datetime
+from threading import Lock
 from typing import Any
 from uuid import UUID
 
@@ -15,6 +16,7 @@ from SpiffWorkflow.bpmn.exceptions import WorkflowTaskException  # type: ignore
 from SpiffWorkflow.bpmn.serializer.workflow import BpmnWorkflowSerializer  # type: ignore
 from SpiffWorkflow.bpmn.specs.control import UnstructuredJoin  # type: ignore
 from SpiffWorkflow.bpmn.specs.event_definitions.message import MessageEventDefinition  # type: ignore
+from SpiffWorkflow.bpmn.specs.mixins import SubWorkflowTaskMixin  # type: ignore
 from SpiffWorkflow.bpmn.specs.mixins.events.event_types import CatchingEvent  # type: ignore
 from SpiffWorkflow.bpmn.workflow import BpmnWorkflow  # type: ignore
 from SpiffWorkflow.exceptions import SpiffWorkflowException  # type: ignore
@@ -95,6 +97,8 @@ class EngineStepDelegate:
 class ExecutionStrategy:
     """Interface of sorts for a concrete execution strategy."""
 
+    _mutex = Lock()
+
     def __init__(self, delegate: EngineStepDelegate, options: dict | None = None):
         self.delegate = delegate
         self.options = options
@@ -121,7 +125,15 @@ class ExecutionStrategy:
                 tld.process_model_identifier = process_model_identifier
 
             g.user = user
-            spiff_task.run()
+
+            should_lock = any(isinstance(child.task_spec, SubWorkflowTaskMixin) for child in spiff_task.children)
+
+            if should_lock:
+                with self._mutex:
+                    spiff_task.run()
+            else:
+                spiff_task.run()
+
             return spiff_task
 
     def spiff_run(