diff --git a/spiffworkflow-backend/src/spiffworkflow_backend/services/git_service.py b/spiffworkflow-backend/src/spiffworkflow_backend/services/git_service.py index f187a47cb..f972b672b 100644 --- a/spiffworkflow-backend/src/spiffworkflow_backend/services/git_service.py +++ b/spiffworkflow-backend/src/spiffworkflow_backend/services/git_service.py @@ -115,7 +115,7 @@ class GitService: result: subprocess.CompletedProcess[bytes] = cls.run_shell_command( command, return_success_state=False ) # type: ignore - return result.stdout.decode("utf-8") + return result.stdout.decode("utf-8").strip() @classmethod def run_shell_command( diff --git a/spiffworkflow-backend/tests/spiffworkflow_backend/unit/test_git_service.py b/spiffworkflow-backend/tests/spiffworkflow_backend/unit/test_git_service.py new file mode 100644 index 000000000..ad3c814f4 --- /dev/null +++ b/spiffworkflow-backend/tests/spiffworkflow_backend/unit/test_git_service.py @@ -0,0 +1,18 @@ +"""Process Model.""" +from flask.app import Flask +from flask.testing import FlaskClient +from tests.spiffworkflow_backend.helpers.base_test import BaseTest + +from spiffworkflow_backend.services.git_service import GitService + + +class TestGitService(BaseTest): + + def test_strips_output_of_stdout_from_command( + self, + app: Flask, + client: FlaskClient, + with_db_and_bpmn_file_cleanup: None, + ) -> None: + output = GitService.run_shell_command_to_get_stdout(["echo", ' This output should not end in space or newline \n']) + assert output == 'This output should not end in space or newline'