sartography
/
spiff-arena
mirror of https://github.com/sartography/spiff-arena.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

some additional fixes for the numeric range field (#1464) 

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
This commit is contained in:
jasquat 2024-04-29 20:04:21 +00:00 committed by GitHub
parent 23e147793a
commit 1495b7dac8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
spiffworkflow-frontend/src/components/CustomForm.tsx
View File

@ -266,8 +266,8 @@ export default function CustomForm({
errors[propertyKey].addError('must have valid Minimum and Maximum');
}
if (
!formDataToCheck[propertyKey].min.toString().match(matchNumberRegex) ||
!formDataToCheck[propertyKey].max.toString().match(matchNumberRegex)
!formDataToCheck[propertyKey].min?.toString().match(matchNumberRegex) ||
!formDataToCheck[propertyKey].max?.toString().match(matchNumberRegex)
) {
errors[propertyKey].addError('must have valid numbers');
}

2
spiffworkflow-frontend/src/helpers.tsx
View File

@ -9,7 +9,7 @@ export const doNothing = () => {
return undefined;
};
export const matchNumberRegex = /^[0-9,.]*$/;
export const matchNumberRegex = /^[0-9,.-]*$/;
// https://www.30secondsofcode.org/js/s/slugify
export const slugifyString = (str: string) => {

2
spiffworkflow-frontend/src/rjsf/custom_widgets/NumericRangeField/NumericRangeField.tsx
View File

@ -166,6 +166,7 @@ export default function NumericRangeField({
setMinValue(event.target.value);
}}
invalid={commonAttributes.invalid}
invalidText={minHelperText}
helperText={minHelperText}
autofocus={autofocus}
/>
@ -181,6 +182,7 @@ export default function NumericRangeField({
setMaxValue(event.target.value);
}}
invalid={commonAttributes.invalid}
invalidText={maxHelperText}
helperText={maxHelperText}
/>
</div>