sartography
/
spiff-arena
mirror of https://github.com/sartography/spiff-arena.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cleaned up some frontend code and put back logic for script unit tests w/ burnettk danfunk

This commit is contained in:
jasquat 2022-10-31 16:58:10 -04:00
parent 483fabc606
commit 130f74daa5
2 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
spiffworkflow-frontend/src/components/ReactDiagramEditor.tsx
View File

@ -185,8 +185,8 @@ export default function ReactDiagramEditor({
) { ) {
if (onLaunchScriptEditor) { if (onLaunchScriptEditor) {
setPerformingXmlUpdates(true); setPerformingXmlUpdates(true);
// const modeling = diagramModeler.get('modeling'); const modeling = diagramModeler.get('modeling');
onLaunchScriptEditor(element, script, scriptType, eventBus); onLaunchScriptEditor(element, script, scriptType, eventBus, modeling);
} }
} }

19
spiffworkflow-frontend/src/routes/ProcessModelEditDiagram.tsx
View File

@ -280,15 +280,20 @@ export default function ProcessModelEditDiagram() {
const onLaunchScriptEditor = ( const onLaunchScriptEditor = (
element: any, element: any,
script: string, script: string,
scriptType: string, scriptTypeString: string,
eventBus: any eventBus: any,
modeling: any
) => { ) => {
// TODO: modeling is only needed for script unit tests.
// we should update this to act like updating scripts
// where we pass an event to bpmn-js
setScriptModeling(modeling);
setScriptText(script || ''); setScriptText(script || '');
setScriptType(scriptType); setScriptType(scriptTypeString);
setScriptEventBus(eventBus); setScriptEventBus(eventBus);
// setScriptModeling(modeling);
setScriptElement(element); setScriptElement(element);
// setScriptUnitTestElementWithIndex(0, element); setScriptUnitTestElementWithIndex(0, element);
handleShowScriptEditor(); handleShowScriptEditor();
}; };
@ -305,10 +310,6 @@ export default function ProcessModelEditDiagram() {
const handleEditorScriptChange = (value: any) => { const handleEditorScriptChange = (value: any) => {
setScriptText(value); setScriptText(value);
// (scriptModeling as any).updateProperties(scriptElement, {
// scriptFormat: 'python',
// script: value,
// });
}; };
const handleEditorScriptTestUnitInputChange = (value: any) => { const handleEditorScriptTestUnitInputChange = (value: any) => {