sartography
/
spiff-arena
mirror of https://github.com/sartography/spiff-arena.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "Revert "make all browsers act the same way on our site w/ jasquat"" 

This reverts commit 7c4b7b71b7.
This commit is contained in:
jasquat 2023-05-09 09:30:09 -04:00
parent 7c4b7b71b7
commit 0a1daf353a
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
spiffworkflow-frontend/src/themes/carbon/SelectWidget/SelectWidget.tsx
View File

@ -56,6 +56,17 @@ function SelectWidget({
errorMessageForField = rawErrors[0];
}
// ok. so in safari, the select widget showed the first option, whereas in chrome it forced you to select an option.
// this change causes chrome to also show the first option. now all browsers are consistent on our site. you no longer have to select anything.
// setting the value prop causes it to show the first option.
// calling onChange actually gets it set in the form data.
if (value === undefined) {
if (enumOptions) {
value = enumOptions[0].value;
onChange(value);
}
}
// maybe use placeholder somehow. it was previously jammed into the helperText field,
// but allowing ui:help to grab that spot seems much more appropriate.