sartography
/
spiff-arena
mirror of https://github.com/sartography/spiff-arena.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

column names for tables in frontend should only have the first letter… (#425) 

* column names for tables in frontend should only have the first letter of the first word capitalized

* forgot a couple field names w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
This commit is contained in:
jasquat 2023-08-02 04:36:19 -04:00 committed by GitHub
parent 1c84e5bb47
commit 09794e9302
3 changed files with 19 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
spiffworkflow-backend/src/spiffworkflow_backend/services/process_instance_report_service.py
View File

@ -55,8 +55,8 @@ class ProcessInstanceReportService:
"accessor": "process_model_display_name", "accessor": "process_model_display_name",
"filterable": False, "filterable": False,
}, },
{"Header": "Start Time", "accessor": "start_in_seconds", "filterable": False}, {"Header": "Start time", "accessor": "start_in_seconds", "filterable": False},
{"Header": "End Time", "accessor": "end_in_seconds", "filterable": False}, {"Header": "End time", "accessor": "end_in_seconds", "filterable": False},
{"Header": "Status", "accessor": "status", "filterable": False}, {"Header": "Status", "accessor": "status", "filterable": False},
], ],
"filter_by": [ "filter_by": [
@ -89,9 +89,9 @@ class ProcessInstanceReportService:
"filterable": False, "filterable": False,
}, },
{"Header": "Task", "accessor": "task_title", "filterable": False}, {"Header": "Task", "accessor": "task_title", "filterable": False},
{"Header": "Waiting For", "accessor": "waiting_for", "filterable": False}, {"Header": "Waiting for", "accessor": "waiting_for", "filterable": False},
{"Header": "Started", "accessor": "start_in_seconds", "filterable": False}, {"Header": "Started", "accessor": "start_in_seconds", "filterable": False},
{"Header": "Last Updated", "accessor": "task_updated_at_in_seconds", "filterable": False}, {"Header": "Last updated", "accessor": "task_updated_at_in_seconds", "filterable": False},
{"Header": "Status", "accessor": "status", "filterable": False}, {"Header": "Status", "accessor": "status", "filterable": False},
], ],
"filter_by": [ "filter_by": [
@ -114,9 +114,9 @@ class ProcessInstanceReportService:
"filterable": False, "filterable": False,
}, },
{"Header": "Task", "accessor": "task_title", "filterable": False}, {"Header": "Task", "accessor": "task_title", "filterable": False},
{"Header": "Started By", "accessor": "process_initiator_username", "filterable": False}, {"Header": "Started by", "accessor": "process_initiator_username", "filterable": False},
{"Header": "Started", "accessor": "start_in_seconds", "filterable": False}, {"Header": "Started", "accessor": "start_in_seconds", "filterable": False},
{"Header": "Last Updated", "accessor": "task_updated_at_in_seconds", "filterable": False}, {"Header": "Last updated", "accessor": "task_updated_at_in_seconds", "filterable": False},
], ],
"filter_by": [ "filter_by": [
{"field_name": "instances_with_tasks_waiting_for_me", "field_value": True, "operator": "equals"}, {"field_name": "instances_with_tasks_waiting_for_me", "field_value": True, "operator": "equals"},
@ -138,9 +138,9 @@ class ProcessInstanceReportService:
"filterable": False, "filterable": False,
}, },
{"Header": "Task", "accessor": "task_title", "filterable": False}, {"Header": "Task", "accessor": "task_title", "filterable": False},
{"Header": "Started By", "accessor": "process_initiator_username", "filterable": False}, {"Header": "Started by", "accessor": "process_initiator_username", "filterable": False},
{"Header": "Started", "accessor": "start_in_seconds", "filterable": False}, {"Header": "Started", "accessor": "start_in_seconds", "filterable": False},
{"Header": "Last Updated", "accessor": "task_updated_at_in_seconds", "filterable": False}, {"Header": "Last updated", "accessor": "task_updated_at_in_seconds", "filterable": False},
], ],
"filter_by": [ "filter_by": [
{"field_name": "process_status", "field_value": active_status_values, "operator": "equals"}, {"field_name": "process_status", "field_value": active_status_values, "operator": "equals"},
@ -326,7 +326,7 @@ class ProcessInstanceReportService:
{"Header": "Start", "accessor": "start_in_seconds", "filterable": False}, {"Header": "Start", "accessor": "start_in_seconds", "filterable": False},
{"Header": "End", "accessor": "end_in_seconds", "filterable": False}, {"Header": "End", "accessor": "end_in_seconds", "filterable": False},
{ {
"Header": "Started By", "Header": "Started by",
"accessor": "process_initiator_username", "accessor": "process_initiator_username",
"filterable": False, "filterable": False,
}, },
@ -339,7 +339,7 @@ class ProcessInstanceReportService:
"""Columns that are used with certain system reports.""" """Columns that are used with certain system reports."""
return_value: list[ReportMetadataColumn] = [ return_value: list[ReportMetadataColumn] = [
{"Header": "Task", "accessor": "task_title", "filterable": False}, {"Header": "Task", "accessor": "task_title", "filterable": False},
{"Header": "Waiting For", "accessor": "waiting_for", "filterable": False}, {"Header": "Waiting for", "accessor": "waiting_for", "filterable": False},
] ]
return return_value return return_value

12
spiffworkflow-backend/tests/spiffworkflow_backend/integration/test_process_api.py
View File

@ -2772,8 +2772,8 @@ class TestProcessApi(BaseTest):
"columns": [ "columns": [
{"Header": "ID", "accessor": "id", "filterable": False}, {"Header": "ID", "accessor": "id", "filterable": False},
{"Header": "Status", "accessor": "status", "filterable": False}, {"Header": "Status", "accessor": "status", "filterable": False},
{"Header": "Key One", "accessor": "key1", "filterable": False}, {"Header": "Key one", "accessor": "key1", "filterable": False},
{"Header": "Key Two", "accessor": "key2", "filterable": False}, {"Header": "Key two", "accessor": "key2", "filterable": False},
], ],
"order_by": ["status"], "order_by": ["status"],
"filter_by": [], "filter_by": [],
@ -2819,7 +2819,7 @@ class TestProcessApi(BaseTest):
"columns": [ "columns": [
{"Header": "ID", "accessor": "id", "filterable": False}, {"Header": "ID", "accessor": "id", "filterable": False},
{"Header": "Status", "accessor": "status", "filterable": False}, {"Header": "Status", "accessor": "status", "filterable": False},
{"Header": "Process Initiator", "accessor": "username", "filterable": False}, {"Header": "Process initiator", "accessor": "username", "filterable": False},
], ],
"order_by": ["status"], "order_by": ["status"],
"filter_by": [ "filter_by": [
@ -2835,7 +2835,7 @@ class TestProcessApi(BaseTest):
"columns": [ "columns": [
{"Header": "ID", "accessor": "id", "filterable": False}, {"Header": "ID", "accessor": "id", "filterable": False},
{"Header": "Status", "accessor": "status", "filterable": False}, {"Header": "Status", "accessor": "status", "filterable": False},
{"Header": "Process Initiator", "accessor": "username", "filterable": False}, {"Header": "Process initiator", "accessor": "username", "filterable": False},
], ],
"order_by": ["status"], "order_by": ["status"],
"filter_by": [ "filter_by": [
@ -2931,13 +2931,13 @@ class TestProcessApi(BaseTest):
{"Header": "Start", "accessor": "start_in_seconds", "filterable": False}, {"Header": "Start", "accessor": "start_in_seconds", "filterable": False},
{"Header": "End", "accessor": "end_in_seconds", "filterable": False}, {"Header": "End", "accessor": "end_in_seconds", "filterable": False},
{ {
"Header": "Started By", "Header": "Started by",
"accessor": "process_initiator_username", "accessor": "process_initiator_username",
"filterable": False, "filterable": False,
}, },
{"Header": "Status", "accessor": "status", "filterable": False}, {"Header": "Status", "accessor": "status", "filterable": False},
{"Header": "Task", "accessor": "task_title", "filterable": False}, {"Header": "Task", "accessor": "task_title", "filterable": False},
{"Header": "Waiting For", "accessor": "waiting_for", "filterable": False}, {"Header": "Waiting for", "accessor": "waiting_for", "filterable": False},
{"Header": "awesome_var", "accessor": "awesome_var", "filterable": True}, {"Header": "awesome_var", "accessor": "awesome_var", "filterable": True},
{"Header": "invoice_number", "accessor": "invoice_number", "filterable": True}, {"Header": "invoice_number", "accessor": "invoice_number", "filterable": True},
{"Header": "key1", "accessor": "key1", "filterable": True}, {"Header": "key1", "accessor": "key1", "filterable": True},

6
spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx
View File

@ -322,7 +322,7 @@ export default function ProcessInstanceShow({ variant }: OwnProps) {
if (!processInstance) { if (!processInstance) {
return null; return null;
} }
let lastUpdatedTimeLabel = 'Updated At'; let lastUpdatedTimeLabel = 'Updated at';
let lastUpdatedTime = processInstance.task_updated_at_in_seconds; let lastUpdatedTime = processInstance.task_updated_at_in_seconds;
if (processInstance.end_in_seconds) { if (processInstance.end_in_seconds) {
lastUpdatedTimeLabel = 'Completed'; lastUpdatedTimeLabel = 'Completed';
@ -367,12 +367,12 @@ export default function ProcessInstanceShow({ variant }: OwnProps) {
</dd> </dd>
</dl> </dl>
<dl> <dl>
<dt>Started By:</dt> <dt>Started by:</dt>
<dd> {processInstance.process_initiator_username}</dd> <dd> {processInstance.process_initiator_username}</dd>
</dl> </dl>
{processInstance.process_model_with_diagram_identifier ? ( {processInstance.process_model_with_diagram_identifier ? (
<dl> <dl>
<dt>Current Diagram: </dt> <dt>Current diagram: </dt>
<dd> <dd>
<Link <Link
data-qa="go-to-current-diagram-process-model" data-qa="go-to-current-diagram-process-model"