mirror of
https://github.com/sartography/cr-connect-workflow.git
synced 2025-02-23 13:18:35 +00:00
dba41f4759
Added a File class, that we wrap around the FileModel so the api endpoints don't change, but File no longer holds refences to versions or dates of the file_data model, we figure this out based on a clean database structure. The ApprovalFile is directly related to the file_data_model - so no chance that a reviewer would review the incorrect version of a file.py Noticed that our FileType enum called "bpmn" "bpmm", hope this doesn't screw someone up. Workflows are directly related to the data_models that create the workflow spec it needs. So the files should always be there. There are no more hashes, and thus no more hash errors where it can't find the files to rebuild the workflow.py Not much to report here, other than I broke every single test in the system at one point. So I'm super concerned about this, and will be testing it a lot before creating the pull request.
60 lines
3.1 KiB
Python
60 lines
3.1 KiB
Python
from tests.base_test import BaseTest
|
|
from crc import db
|
|
from crc.models.approval import ApprovalModel
|
|
from crc.services.approval_service import ApprovalService
|
|
from crc.services.file_service import FileService
|
|
from crc.services.workflow_processor import WorkflowProcessor
|
|
|
|
|
|
class TestApprovalsService(BaseTest):
|
|
|
|
def test_create_approval_record(self):
|
|
self.create_reference_document()
|
|
workflow = self.create_workflow("empty_workflow")
|
|
FileService.add_workflow_file(workflow_id=workflow.id,
|
|
name="anything.png", content_type="text",
|
|
binary_data=b'5678', irb_doc_code="UVACompl_PRCAppr" )
|
|
|
|
ApprovalService.add_approval(study_id=workflow.study_id, workflow_id=workflow.id, approver_uid="dhf8r")
|
|
self.assertEquals(1, db.session.query(ApprovalModel).count())
|
|
model = db.session.query(ApprovalModel).first()
|
|
self.assertEquals(workflow.study_id, model.study_id)
|
|
self.assertEquals(workflow.id, model.workflow_id)
|
|
self.assertEquals("dhf8r", model.approver_uid)
|
|
self.assertEquals(1, model.version)
|
|
|
|
def test_new_requests_dont_add_if_approval_exists_for_current_workflow(self):
|
|
self.create_reference_document()
|
|
workflow = self.create_workflow("empty_workflow")
|
|
FileService.add_workflow_file(workflow_id=workflow.id,
|
|
name="anything.png", content_type="text",
|
|
binary_data=b'5678', irb_doc_code="UVACompl_PRCAppr" )
|
|
|
|
ApprovalService.add_approval(study_id=workflow.study_id, workflow_id=workflow.id, approver_uid="dhf8r")
|
|
ApprovalService.add_approval(study_id=workflow.study_id, workflow_id=workflow.id, approver_uid="dhf8r")
|
|
self.assertEquals(1, db.session.query(ApprovalModel).count())
|
|
model = db.session.query(ApprovalModel).first()
|
|
self.assertEquals(1, model.version)
|
|
|
|
def test_new_approval_requests_after_file_modification_create_new_requests(self):
|
|
self.load_example_data()
|
|
self.create_reference_document()
|
|
workflow = self.create_workflow('empty_workflow')
|
|
FileService.add_workflow_file(workflow_id=workflow.id,
|
|
name="anything.png", content_type="text",
|
|
binary_data=b'5678', irb_doc_code="AD_CoCAppr")
|
|
|
|
ApprovalService.add_approval(study_id=workflow.study_id, workflow_id=workflow.id, approver_uid="dhf8r")
|
|
|
|
FileService.add_workflow_file(workflow_id=workflow.id,
|
|
name="anything.png", content_type="text",
|
|
binary_data=b'5678', irb_doc_code="UVACompl_PRCAppr")
|
|
|
|
ApprovalService.add_approval(study_id=workflow.study_id, workflow_id=workflow.id, approver_uid="dhf8r")
|
|
self.assertEquals(2, db.session.query(ApprovalModel).count())
|
|
models = db.session.query(ApprovalModel).order_by(ApprovalModel.version).all()
|
|
self.assertEquals(1, models[0].version)
|
|
self.assertEquals(2, models[1].version)
|
|
|
|
|