Commit Graph

1209 Commits

Author SHA1 Message Date
Dan fdce91507c Improve the warning messages that come back when running the master workflow spec. 2021-10-07 14:43:38 -04:00
Dan 548c35a4a3 Merge branch 'dev' into varchar-category-id-483 2021-10-07 11:35:10 -04:00
mike cullerton 10abf51f70 Added workflow_spec_id to WorkflowMetadata model, because the id is the workflow id, not the workflow_spec id.
Then, we use workflow_spec_id in StudyService when looking for workflow status.
2021-10-07 10:02:13 -04:00
alicia pritchett 7b6beae9c1 fixes frontend bailing out
workflow id is workflow id
2021-10-06 14:33:09 -04:00
Dan 84680ea846 Fixing multiple issues that came out of Study Info, as we debugged issue #474 related to navigating back to a previous task.
There was a problem with the python script engine as well that wasn't handling the de-serialize properly and didn't correctly pick back up on the script engine, and the renaming of methods in PythonScriptEngine created some conflicts with the way we override functions.
We were not handling ldap looks up efficiently, and this was also breaking in Study Info.

Finally we had a bug in SpiffWorkflow that did not allow us to reset back to the previous task in some cases where nested call activities happen far later in the process and are currently active when the reset is created.
2021-10-06 12:17:57 -04:00
mike cullerton 572ca1db6b Fixes for backend code after removing `name` column from `workflow_spec` and `workflow_spec_category` tables 2021-10-05 14:17:41 -04:00
mike cullerton fcf538ca92 remove `name` column from workflow_spec and workflow_spec_category 2021-10-05 13:10:36 -04:00
Dan b02731df17 Add some additional checks in the workflow service so we assure the data we are creating during validation can be serialized and deserialized just as it would be through the API. (Was hanging us up on dates)
Assure that if we generate a default value for a date in the task data, it is stored as an ISO String.

remove any unserializable data from the task_data when an error is encountered, rather than just dropping all the task_data. This case seems to happen a lot and it leaves us with nothing to go on.
2021-10-04 15:07:47 -04:00
Dan 448b7b2773 respect proxy configurations. 2021-10-01 15:35:22 -04:00
Dan c3995bfc3e Another try at getting the url correct. This paired with an additional setting on the server maybe. 2021-10-01 14:25:00 -04:00
Dan 5924ee48f4 One more try at getting the currect url. 2021-09-30 16:56:27 -04:00
mike cullerton 5bf7bf3e2e Bug fix for adding master workflow to validation
We now check that a workflow is in the status dictionary before looking up its status.
2021-09-30 15:48:57 -04:00
Dan Funk f898d6f502
Merge pull request #385 from sartography/ids-approval-validation-478
Ids approval validation #478
2021-09-30 13:59:26 -04:00
Dan Funk 6b5a55df4c
Merge pull request #383 from sartography/feature/476_file_url
URL for files
2021-09-30 13:47:37 -04:00
Dan Funk fbfb241c0b
Merge pull request #382 from sartography/feature/381_validate_field_types
fixes #381 Assure that the field type provided is supported.  Catches errors suc…
2021-09-30 13:46:40 -04:00
Dan Funk 615d0e7f89
Merge pull request #384 from sartography/chore/admin-cat-456
Admin flag on category + migration + updated test
2021-09-30 13:37:09 -04:00
Dan Funk 0353161402
Merge branch 'dev' into feature/381_validate_field_types 2021-09-30 13:19:36 -04:00
Dan Funk 1251202244
Merge pull request #379 from sartography/top-level-validation-460
Top level validation #460
2021-09-30 13:11:03 -04:00
mike cullerton 0202b409e1 My checkbox test was in a bad place. Moved it into each of the 2 blocks. 2021-09-30 12:34:46 -04:00
mike cullerton ba2741818d Added the Testing url as example data so we don't have to look it up and type it every time. 2021-09-30 11:36:39 -04:00
mike cullerton 73cd729cac Checkbox enums need to return a list. 2021-09-30 11:35:13 -04:00
Dan e002ffd363 Fixing a broken test. 2021-09-30 10:30:58 -04:00
alicia pritchett d5d4496cd0 Admin flag on category + migration + updated test 2021-09-29 16:53:59 -04:00
Dan 8a4a53f028 Assure that the field type provided is supported. Catches errors such as adding a custom field type of 'text_area' rather than "textarea" 2021-09-29 14:05:45 -04:00
Dan 8e00f16eaa Assure that the field type provided is supported. Catches errors such as adding a custom field type of 'text_area' rather than "textarea" 2021-09-29 11:43:08 -04:00
Dan d0c819dd5f sync was failing because it tried to add the libraries before adding the spec the libraries connect to. 2021-09-29 10:21:24 -04:00
Dan 92b9fea08d fixing a stupid mistake that made all the people I care about suffer yesterday afternoon. 2021-09-29 10:06:17 -04:00
mike cullerton ef5a0a7e45 Check whether a workflow spec is disabled by the master workflow before validating.
Return the master workflow message to the user
2021-09-24 11:05:33 -04:00
Dan Funk e4add14193
Merge pull request #378 from sartography/bug/246_user_ldap_refactor
Bug/246 user ldap refactor
2021-09-22 15:31:34 -04:00
Dan Funk 48d979dd5a
Merge pull request #377 from sartography/study-info-mislabeled-464
Study info mislabeled #464
2021-09-22 15:31:23 -04:00
Dan Funk deff293fff
Merge pull request #376 from sartography/bug/468_missing_file_date
fixes #448 - Missing  file date
2021-09-22 15:29:32 -04:00
Dan Funk e672d46dd0
Merge pull request #375 from sartography/study-info-adds-463
Study info adds #463
2021-09-22 15:28:40 -04:00
Dan 19104303de Refactor of the way we store and return details about users - All the details about a user, or individual associated with a study is returned within in an Ldap model. I've removed duplication between these models. This required some cleanup of the tests, and a migration that will drop the user details. 2021-09-22 13:16:25 -04:00
mike cullerton 8df6c78925 Cleaned up what we return from the description, for the tools/list_scripts API endpoint 2021-09-22 12:12:26 -04:00
mike cullerton d7b7f39128 Added a field `handle` that displays the filename, which is what configurators actually call in a script task. 2021-09-22 12:10:43 -04:00
Dan 4b591a076f Adding importlib-resournces as a dependency, which is suddenly failing on Travis, likely due to different versions of Python as I try to upgrade to 3.9 2021-09-21 14:36:57 -04:00
mike cullerton f101176b13 Add `short_name` and `proposal_name` to the update_study script 2021-09-17 11:54:22 -04:00
mike cullerton 8b8cfde6cb Add `short_name` and `proposal_name` to the study model 2021-09-17 11:53:45 -04:00
mike cullerton 829dc3661e Fixed name vs get_name bug where I had the wrong type of task (API model vs Spiff task) in my test
Also return good json
2021-09-16 13:43:45 -04:00
Dan Funk 72349cacf5
Merge pull request #373 from sartography/zip-documents-379
Bug fix #379
2021-09-15 15:42:35 -04:00
mike cullerton 6ca8ba3e69 Refactored to use Python tempfile 2021-09-15 13:33:55 -04:00
mike cullerton c335390025 Bug fix.
File can already exist if there was a previous problem running the script
2021-09-15 10:30:12 -04:00
Mike Cullerton 66bfbf0a49
Merge pull request #371 from sartography/zip-documents-379
Zip documents #379
2021-09-14 17:42:13 -04:00
Mike Cullerton 787614ee91
Merge pull request #369 from sartography/dmn-from-spreadsheet-395
Dmn from spreadsheet #395
2021-09-14 17:41:01 -04:00
Mike Cullerton 15efc2f3f1
Merge pull request #370 from sartography/library-listing-453
Library listing #453
2021-09-14 16:11:56 -04:00
alicia pritchett a7f032d372 Returns workflow spec categories ordered by display order
sorry to open a whole branch just for this little fix
2021-09-14 10:56:41 -04:00
mike cullerton 654c87489c New version of irb_documents spreadsheet, that includes the `zip_key_words` column 2021-09-14 10:40:47 -04:00
mike cullerton 512cf75df0 Modified to use the new `zip_key_words` column from irb_documents spreadsheet
Moved all the code inside the `if` statement
2021-09-14 10:39:53 -04:00
mike cullerton 444e3fa76d Merge branch 'dev' into zip-documents-379 2021-09-14 09:39:19 -04:00
mike cullerton 7b7c228a81 2 changes
- The `all_specifications` method is now explicit in what it returns; either `library`, `standalone`, or `regular` workflow specs

- When we add/edit a workflow spec, we make sure that `library` and `standalone` workflow specs do not get a category_id
2021-09-13 16:15:18 -04:00