mike cullerton
fa34bee18a
First commit for cleaning up error messages for customers.
...
This is *not* in a working state.
Committing this so I can work on another ticket.
2021-02-04 11:23:05 -05:00
Dan Funk
cccb722e07
Merge pull request #226 from sartography/enum_default_value_expression_162
...
Enum default value expression 162
2021-01-27 10:43:46 -05:00
mike cullerton
420ef0b2b0
Test and data for cleaning up my smell. We now test explicitly whether a task has both a default_value and value_expression. If so, we raise an error.
2021-01-27 10:22:43 -05:00
Dan Funk
98f946c119
Merge pull request #227 from sartography/missing_form_key_163
...
Missing form key 163
2021-01-27 09:42:46 -05:00
mike cullerton
d01f8e1018
This workflow had a form with a missing form key, so it's associated test failed after my changes in this ticket. I added a form key to the form. Test now passes.
2021-01-22 12:16:02 -05:00
mike cullerton
2438779470
Test and workflow file for missing form key. Ticket 163
2021-01-22 12:14:59 -05:00
mike cullerton
1ee6a11d46
Test and associated data files for setting enum default values from value_expression. Ticket 162
2021-01-22 10:01:20 -05:00
Dan
5921ce9f10
Merge branch 'dev' into 152-workflow-spec-pull
2021-01-21 12:30:43 -05:00
Dan Funk
5b13195182
Merge pull request #224 from sartography/restart-with-no-data-99
...
Restart with no data 99
2021-01-20 17:22:18 -05:00
Dan
41dac33039
Removed two tests around soft_reset that are no longer required.
...
Reset should construct the workflow_processor, thus completing the reset process.
Removed the spec argument from init, as it is never used anywhere.
2021-01-20 13:24:53 -05:00
mike cullerton
27a8383898
Not sure about this one. We no longer support the task this test is testing (soft_reset). I commented out that part of the test. We can discuss, if necessary.
2021-01-19 15:44:11 -05:00
mike cullerton
61d366c111
Fixed hard_reset test. Now we reset the workflow and run do_engine_steps
2021-01-19 15:39:59 -05:00
mike cullerton
61b34fd6f4
Fixed hard_reset test. We now call restart_workflow_api.
2021-01-19 15:34:46 -05:00
mike cullerton
1b18b53107
Fixed hard_reset test. We now call restart_workflow_api.
2021-01-19 15:32:38 -05:00
mike cullerton
bfb3871671
Added method for restart_workflow_api. Pulled out some common code with get_workflow_api.
2021-01-19 15:27:44 -05:00
mike cullerton
9281a93abb
New test for new restart_workflow endpoint
2021-01-19 15:15:44 -05:00
mike cullerton
6a9e6d3570
Restart workflow without form data. Committing so Dan can check it out
2021-01-14 15:32:14 -05:00
mike cullerton
99c1d1b129
Test for changes to hard_reset and soft_reset
2021-01-13 16:12:14 -05:00
Kelly McDonald
442a4524c4
Test for new functionality and code coverage
2021-01-12 10:18:35 -05:00
Kelly McDonald
abc17add89
file order was not deterministic - alter test to make sure we updated the 'right' file rather than relying on ordering
2021-01-12 08:54:15 -05:00
Dan
26655b26d3
merging in dev, and fixing a failing test from dev.
2021-01-08 14:42:13 -05:00
Dan Funk
9118517995
Merge pull request #220 from sartography/prevent-duplicate-template-upload-111
...
Users cannot upload a workflow_spec_file that already exists. We rais…
2021-01-08 13:55:19 -05:00
Dan Funk
be288ae048
Merge pull request #219 from sartography/fix-api-call-missing-fieldname-143
...
Fixed ApiError call. Now includes task_id and task_name.
2021-01-08 13:46:26 -05:00
mike cullerton
d274813ae5
We now check form field IDs so they play well with Python and Javascript.
2021-01-07 11:10:31 -05:00
mike cullerton
c9a4a9685f
Users cannot upload a workflow_spec_file that already exists. We raise an error that is displayed on the fron end.
2021-01-04 15:47:45 -05:00
mike cullerton
0ae4448fbe
Fixed ApiError call. Now includes task_id and task_name.
2021-01-04 13:48:34 -05:00
mike cullerton
0c47d09972
Ticket 143. Test whether file is uploaded.
2021-01-04 10:53:21 -05:00
mike cullerton
80d2009573
Modified the test to cover hold, abandon, and open_enrollment. These are tickets 21 and 94
2020-12-31 10:40:27 -05:00
mike cullerton
ede5df4df5
Studies can now be put on hold in the dashboard. We were overriding the status in StudyModel.update_from_protocol_builder.
2020-12-30 17:49:59 -05:00
Dan
96739d99c4
Fixing a failing test because new logic was catching a different error.
2020-12-29 11:14:40 -05:00
Dan
c288a8a2bc
Merge branch 'dev' into check-field-type#143
2020-12-29 11:11:43 -05:00
mike cullerton
052ee40238
Cleanup from test email script changes. Removed commented piece of code containing my private email address.
2020-12-28 18:05:47 -05:00
mike cullerton
06318c87b1
Test and workflow for changes to workflow_service. The workflow does not have a field type. We look for evidence of raised exception in data of response.
2020-12-28 18:03:59 -05:00
Dan
6cfce839c1
Validation now assures that we won't encounter errors when generating navigation lists.
...
Fixing workflow sync paths that were incorrect.
Repairing a suddenly failing test in files, that just don't make no sense.
Bumping spiffworkflow that contains a fix for issue #155
2020-12-28 17:33:38 -05:00
Dan
1f9bf72c59
Merge branch 'dev' into bug/navigation
2020-12-14 11:46:44 -05:00
Dan Funk
4268d0f482
Merge pull request #208 from sartography/152-workflow-spec-pull
...
152 workflow spec pull
2020-12-14 11:35:06 -05:00
Dan
bcb78de225
Merge branch 'dev' into bug/navigation
2020-12-14 11:33:51 -05:00
Dan Funk
e54404e424
Merge pull request #205 from sartography/test-email-script
...
Test email script
2020-12-14 11:28:14 -05:00
Dan
6bf24cc438
fixing some failing tests related to changes in the underlying spiffworkflow library.
2020-12-14 11:27:38 -05:00
Dan
b62a9c7074
Merge remote-tracking branch 'origin/dev' into bug/navigation
2020-12-14 10:40:21 -05:00
Dan
082dee46e0
fixing some failing tests.
2020-12-14 10:37:35 -05:00
Kelly McDonald
d8ac20b1c3
I added a second file to 'random_fact' test workflow, so another test was expecting 2 files in it after adding a new file, but there were 3 -
...
Nothing to see here - move along
2020-12-14 10:37:16 -05:00
Dan
38a6fa782d
Fixing the email script test.
2020-12-14 10:29:53 -05:00
Kelly McDonald
ee3ee9fd4a
Added tests to cover most of the use cases and code, and a bunch of stuff to make the mocks happy
2020-12-14 10:27:40 -05:00
Dan
02ea414b94
Additional fixes to Navigation to allow a nested navigation structure.
2020-12-14 10:07:19 -05:00
mike cullerton
7defc2b02f
Tests for uid in logs. Currently we test for uid in a response. This covers ApiError.
...
Currently, we don't have a test for Sentry. Unsure how to do this.
Also added a script, service and test workflow to help. (Also to learn about adding a script and service.)
2020-12-11 17:47:53 -05:00
Kelly McDonald
3a1160efac
refactored calls into a service
2020-12-11 11:41:32 -05:00
Kelly McDonald
9eea26e019
add workflow_sync test
2020-12-11 08:34:59 -05:00
mike cullerton
32c5060a31
No longer use eval on the email address. It is already parsed.
...
Tests for single and multiple emails, and email error checking.
Still need to figure out how to implement multiple emails.
2020-12-09 12:11:46 -05:00
mike cullerton
730d0ca18f
Email script now uses an email address instead of a UVA LDAP user_id.
2020-12-07 16:23:41 -05:00