602 Commits

Author SHA1 Message Date
Dan
f4f3842059 Fixing a stupid mistake. 2021-11-11 11:45:35 -05:00
Dan
197b75c6bf Quickfix - validation was failing if we had a date object in the task data, but this isn't really a problem. We now use the same JSON serializer as flask does, when doing validations, to better verify behavior with the front end. 2021-11-11 11:18:58 -05:00
Dan Funk
037692f42b
Merge pull request #422 from sartography/chore/group-repeating-validation-536
Fixes #536 - Group + Repeating property validation
2021-11-10 15:28:04 -05:00
Dan Funk
e764bf937d
Merge pull request #421 from sartography/bug/validation_of_enum_label_failing_in_sub_workflows
Validation was failing for enum_label() expressions when called withi…
2021-11-10 15:26:03 -05:00
Dan Funk
81f8aed68b
Merge pull request #420 from sartography/drop-tasklog-on-delete
Delete Task log model when deleting a study
2021-11-10 15:20:11 -05:00
Dan Funk
84f364ce37
Merge branch 'dev' into chore/view-as-382 2021-11-10 15:16:20 -05:00
alicia pritchett
accdd281fa Fixes #536 - Group + Repeating property validation
For now, we should not allow both group and repeat properties on a field together.
2021-11-09 13:21:44 -05:00
Dan
d1eae3c15a Validation was failing for enum_label() expressions when called within a sub-process. Possible (but unlikely) that this would occur outside validation. 2021-11-09 12:55:06 -05:00
alicia pritchett
aa1ba59bb1 Delete Task log model when deleting a study
just a minor fix
2021-11-09 10:42:47 -05:00
Dan Funk
8a6c1e1b51
Merge pull request #416 from sartography/bug/fix-hide-518
Fixes validation for #518
2021-11-01 16:22:24 -04:00
alicia pritchett
1866e6bba9 Fixes validation for #518
Well really what this does is give every field a default value of None. what that does is allow you to use value expressions even without a given default value. this part in the backend fixes validation.
2021-11-01 14:35:30 -04:00
mike cullerton
7722b89faa If a file was archived, users could not update the file.
In some situations, this kept users from re-uploading files that were previously deleted.
We now allow an archived file to be updated and unarchived.
2021-10-29 11:52:27 -04:00
alicia pritchett
702b8eaed6 add ldap endpoint that doesnt require workflow info 2021-10-28 16:19:39 -04:00
Dan
e0d1f63c08 Fix an issue with validation where we didn't properly parse dot notation in fields. 2021-10-26 14:48:06 -04:00
alicia pritchett
7959f8ca3f
Merge pull request #405 from sartography/refactor/enums_as_key_value
Death to enumerated dictionaries
2021-10-25 15:17:17 -04:00
mike cullerton
a7fcaac5ef Better messaging for the configurators.
We were generating 500 errors here
2021-10-22 12:53:26 -04:00
Dan
84ce24243f add an enum_label script that will return the label given a value selection. 2021-10-21 13:57:49 -04:00
mike cullerton
1220f7bef8 Allow embedded templates in Word documents 2021-10-21 13:37:13 -04:00
mike cullerton
3619240bae Move the parts for using Word documents as Jinja templates into JinjaService 2021-10-21 10:29:56 -04:00
mike cullerton
62bf7c50bb Move to new branch 2021-10-20 13:48:20 -04:00
Dan
1c84bd9f1b Merge branch 'dev' into refactor/enums_as_key_value 2021-10-19 12:02:45 -04:00
Dan
5429e7da7d All enumerated lists used in web forms should contain a single value, not a dictionary of value/labels.
Removing the spreadsheet.value.column and data.value.column so we just have value.column for both.
Improving the __str__ function in the ApiError class, to make debugging a little easier.
Adding a "validate_all" flask command, to help us track down any issues with current workflows in production (use this in concert with sync_with_testing)
Fixed logs of tests.
removed fact_runner.py, a very early and crufty bit of code.
2021-10-19 10:13:43 -04:00
mike cullerton
1c02928d04 Merge branch 'dev' into jinja-include-403 2021-10-19 10:09:18 -04:00
Dan Funk
ee839a85ed
Merge pull request #401 from sartography/email-cleanup-498
Email cleanup #498
2021-10-19 08:59:48 -04:00
Dan Funk
e1b72c8edf
Merge pull request #380 from sartography/file-cleanup-466
File cleanup #466
2021-10-19 08:57:14 -04:00
mike cullerton
0122029e30 *** WIP ***
Migrating the complete_template script stuff to JinjaService.
Having trouble with the tools stuff.
Pulled back to spot where test pass using CompleteTemplate
2021-10-18 16:56:03 -04:00
mike cullerton
da9b902c19 Removed old commented code 2021-10-18 16:10:30 -04:00
mike cullerton
983c4104e1 We run the same basic Jinja code in 4 different contexts.
Now call the the Jinja service
2021-10-16 14:20:48 -04:00
mike cullerton
de1c987c85 New service to create and render template with Jinja
Allows us to include Jinja templates within Jinja templates
2021-10-16 14:17:53 -04:00
mike cullerton
7a5de44e1d Merge branch 'dev' into email-cleanup-498 2021-10-13 12:40:58 -04:00
Dan Funk
bfd931e854
Merge pull request #400 from sartography/bug/nav-order-420
one solution for the Parallel nav order problem
2021-10-13 12:11:07 -04:00
alicia pritchett
58e75a1c8f Change one condition to compare only user tasks, not non-user-tasks 2021-10-13 12:08:20 -04:00
mike cullerton
3ae00d190d Raise error if we have a problem sending email.
This should be processed by Spiff ultimately.
2021-10-13 12:03:48 -04:00
Dan Funk
5d5256df3a
Merge pull request #398 from sartography/bug/422_value_expression_enum
When dealing with enum default values, assure that we are looking at …
2021-10-12 15:56:25 -04:00
Dan Funk
6428e4ab0a
Merge pull request #397 from sartography/email-data-script-487
Email data script #487
2021-10-12 15:55:48 -04:00
Dan Funk
dc07d42a9c
Merge pull request #395 from sartography/email-format-489
Email format #489
2021-10-12 15:51:57 -04:00
Dan
5706fb3ad3 Don't error out here until we decide if we are going to fully refactor emums or leave as is. 2021-10-12 14:32:51 -04:00
Dan
00e0bd5dd2 When dealing with enum default values, assure that we are looking at the '.value' attribute, not at the value itself.
Minor change to front end as well, please see companion ticket in the sartography_libraries.
2021-10-12 14:11:00 -04:00
mike cullerton
63df614f41 Change workflow_id to workflow_spec_id 2021-10-12 13:43:29 -04:00
alicia pritchett
1ef18f23aa one solution for the Parallel nav order problem 2021-10-11 11:50:03 -04:00
mike cullerton
5df8f127c7 Fix email formatting.
Markdown was swallowing the carriage returns.
We use the nl2br extension now.
2021-10-08 11:26:30 -04:00
Dan Funk
b0a6af8d5e
Merge pull request #392 from sartography/email-data-script-487
Email data script #487
2021-10-07 14:52:31 -04:00
Dan
fdce91507c Improve the warning messages that come back when running the master workflow spec. 2021-10-07 14:43:38 -04:00
mike cullerton
24932072dc Merge branch 'dev' into email-data-script-487 2021-10-07 12:30:13 -04:00
Dan Funk
a39e0ba219
Merge pull request #390 from sartography/varchar-category-id-483
Varchar category id #483
2021-10-07 12:23:56 -04:00
Dan
548c35a4a3 Merge branch 'dev' into varchar-category-id-483 2021-10-07 11:35:10 -04:00
mike cullerton
10abf51f70 Added workflow_spec_id to WorkflowMetadata model, because the id is the workflow id, not the workflow_spec id.
Then, we use workflow_spec_id in StudyService when looking for workflow status.
2021-10-07 10:02:13 -04:00
mike cullerton
be066b7d59 Add cc, bcc, and workflow_id to the email record, for reporting 2021-10-07 09:22:05 -04:00
Dan
84680ea846 Fixing multiple issues that came out of Study Info, as we debugged issue #474 related to navigating back to a previous task.
There was a problem with the python script engine as well that wasn't handling the de-serialize properly and didn't correctly pick back up on the script engine, and the renaming of methods in PythonScriptEngine created some conflicts with the way we override functions.
We were not handling ldap looks up efficiently, and this was also breaking in Study Info.

Finally we had a bug in SpiffWorkflow that did not allow us to reset back to the previous task in some cases where nested call activities happen far later in the process and are currently active when the reset is created.
2021-10-06 12:17:57 -04:00
mike cullerton
572ca1db6b Fixes for backend code after removing name column from workflow_spec and workflow_spec_category tables 2021-10-05 14:17:41 -04:00