sartography/cr-connect-workflow
1
0
Fork 0
mirror of https://github.com/sartography/cr-connect-workflow.git synced 2025-02-24 05:38:25 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,389 Commits 14 Branches 0 Tags 9 MiB
Commit Graph

149 Commits

Author SHA1 Message Date
Dan
f129509802 Looks like reording the deletes allows us to remove workflow specs a little easier. Tested this with libraries, and seems to work ok. 2021-12-20 14:36:45 -05:00
alicia pritchett
0e28d2c5f5 Fix a test 2021-12-10 12:16:39 -05:00
Dan Funk
0cfa59bfea
Merge pull request #429 from sartography/chore/clear-form-data-553 
Fixes #553 - Don't load Form data
 2021-12-08 10:37:44 -05:00
Dan
ffafc1674a assure we don't overwrite task data with a previous form submission if that data already exists. 2021-12-07 17:04:20 -05:00
mike cullerton
4ea3682dd6 Updated for new ProtocolBuilderCreatorStudy model and schema 
Removed unused imports
 2021-12-06 14:43:07 -05:00
alicia pritchett
22320efad4 test for this ticket 2021-12-03 12:23:57 -05:00
Dan
676321c2e2 Fixing a test. 2021-11-30 12:55:52 -05:00
Dan
ad93b5fae6 We were not correctly handing the possibility of there only being a waiting task (and no ready tasks). 
We also had a problem with the validator throwing a 500 when it was trying tell us it would never finish validation.
 2021-11-30 12:44:35 -05:00
Dan
b12e178288 Fixing a failing test. 2021-11-17 14:12:15 -05:00
alicia pritchett
1866e6bba9 Fixes validation for #518 
Well really what this does is give every field a default value of None. what that does is allow you to use value expressions even without a given default value. this part in the backend fixes validation.
 2021-11-01 14:35:30 -04:00
Dan
539174d4c4 drop unused method 2021-10-21 14:02:19 -04:00
Dan
5429e7da7d All enumerated lists used in web forms should contain a single value, not a dictionary of value/labels. 
Removing the spreadsheet.value.column and data.value.column so we just have value.column for both.
Improving the __str__ function in the ApiError class, to make debugging a little easier.
Adding a "validate_all" flask command, to help us track down any issues with current workflows in production (use this in concert with sync_with_testing)
Fixed logs of tests.
removed fact_runner.py, a very early and crufty bit of code.
 2021-10-19 10:13:43 -04:00
Dan Funk
a39e0ba219
Merge pull request #390 from sartography/varchar-category-id-483 
Varchar category id #483
 2021-10-07 12:23:56 -04:00
mike cullerton
da894219c5 Changes to tests after removing name column from workflow_spec and workflow_spec_category tables. 2021-10-05 14:20:03 -04:00
Dan
b02731df17 Add some additional checks in the workflow service so we assure the data we are creating during validation can be serialized and deserialized just as it would be through the API. (Was hanging us up on dates) 
Assure that if we generate a default value for a date in the task data, it is stored as an ISO String.

remove any unserializable data from the task_data when an error is encountered, rather than just dropping all the task_data. This case seems to happen a lot and it leaves us with nothing to go on.
 2021-10-04 15:07:47 -04:00
Dan Funk
f898d6f502
Merge pull request #385 from sartography/ids-approval-validation-478 
Ids approval validation #478
 2021-09-30 13:59:26 -04:00
Dan Funk
0353161402
Merge branch 'dev' into feature/381_validate_field_types 2021-09-30 13:19:36 -04:00
mike cullerton
2067c7226a Better test. Actually grab data explicitly from the list in Element Documentation 2021-09-30 12:54:03 -04:00
mike cullerton
7676e230e5 Test and bpmn for enum checkbox 2021-09-30 12:10:47 -04:00
Dan
8e00f16eaa Assure that the field type provided is supported. Catches errors such as adding a custom field type of 'text_area' rather than "textarea" 2021-09-29 11:43:08 -04:00
mike cullerton
fb9c3e96ac Test and mocked status data for adding master workflow into validation. 
Make sure we see ApiError for disabled workflow spec
 2021-09-24 11:08:54 -04:00
mike cullerton
9aadaac0df Test to make sure we do not set a category_id for library workflow specs 2021-09-13 16:16:05 -04:00
mike cullerton
5ddff1d1be Merge branch 'dev' into add-reorder-api-endpoints-444 2021-09-09 13:10:54 -04:00
mike cullerton
a35d122a03 Tests for case where we have bad display_order numbers. 
I.e., 0, 1, 1, 1
 2021-09-08 11:18:06 -04:00
mike cullerton
e6a2b9d642 New test and BPMN for changes 2021-08-31 16:18:29 -04:00
mike cullerton
86583aa2d6 Be explicit about loading sample data 
Add category_id when checking order
 2021-08-31 12:19:45 -04:00
mike cullerton
cfd8f3fe74 Test for reordering remaining spec categories after delete 2021-08-30 15:21:42 -04:00
mike cullerton
e317b59bfe Test for reordering workflow specs upon deletion 2021-08-30 14:57:16 -04:00
mike cullerton
c99080845b renamed a test 2021-08-30 13:56:27 -04:00
mike cullerton
dfe967d578 Tests for reordering categories 2021-08-30 13:56:13 -04:00
mike cullerton
d43eb4d6f8 Tests for workflow spec reordering 2021-08-30 12:35:57 -04:00
mike cullerton
543fc1fb4a Start of tests for new reorder API endpoint 
Modified example_data to include a display_order for example spec
 2021-08-27 13:04:11 -04:00
mike cullerton
cd3d17862a Add task_spec_name to a bunch of tests 2021-08-26 10:43:28 -04:00
nilez
b9d4f6c436 assertEquals -> assertEqual 2021-08-16 10:18:29 -04:00
mike cullerton
e0096ebc8e Test and BPMN to make sure we don't process when field is hidden, but do process when field is not hidden 2021-08-11 16:44:45 -04:00
Kelly McDonald
25319a0e6a Make changes to alembic process - fix test for new API 2021-08-02 08:59:24 -04:00
mike cullerton
097dd9f9a3 Included the failing test, with self.assertRaises 
Reworded some of the comments
 2021-07-28 11:22:45 -04:00
Kelly McDonald
217e61eed3 next_task returns the next available task, except when the task is completed when it returns the EndEvent - 
The problem was that it was returning the first EndEvent it found, not the last one. This caused a problem when we had a CallActivity which has its own EndEvent.

Fixes #399
 2021-07-27 09:19:08 -04:00
mike cullerton
2c892560ad Failing test for Call Activity End Events - Ticket 399 2021-07-26 12:12:01 -04:00
Dan
2a45f2fcda Merge branch 'dev' into add-name-error-hint-8 2021-07-07 11:24:00 -04:00
Dan
fb54edac1c Adding additional details to error messages, and cleaning up the cruft around these messages to keep them clear and succinct. 
Most noteable is the addition of the line on which the error occurs for script tasks.  It will report the line number and pass back the content of
the line that failed.
The validator only returns the first error it encounters, as it's clear that all we ever get right now is two of the same error.
Did a lot of work between this and spiffworkflow to remove all the places where we obfuscate or drop details as we converted between workflowExceptions and APIExceptions.
Dropped the python levenshtein dependency, in favor of just rolling a simple one ourselves in Spiffworkflow.
 2021-07-07 00:53:49 -04:00
mike cullerton
2a43230121 Test and workflow for the new name error hint code 2021-07-01 15:39:25 -04:00
Dan Funk
19d63e2aa2
Merge pull request #328 from sartography/restart-workflow-programmatically-347 
Restart workflow programmatically #347
 2021-06-17 10:36:46 -04:00
Dan
a4caae8d64 when validating, we need to take every step to remove the workflows we create during the validation. 2021-06-16 14:40:20 -04:00
mike cullerton
94e730d04e Test script validation 2021-06-15 11:15:31 -04:00
mike cullerton
addf1cab5b Added tests for failing conditions 2021-06-15 10:30:18 -04:00
mike cullerton
9e20025f33 Test and workflow for reset_workflow 2021-06-15 08:37:42 -04:00
mike cullerton
9dc5871848 Added mocked PB data for tests using study_info script. 2021-06-07 10:08:44 -04:00
mike cullerton
37ba46fb8f These tests now require PB Mock because of the validate_study_id changes 2021-06-03 14:30:00 -04:00
Dan
ef7ee284b2 Prefer tasks that share a parent over just the the next available task when returning the next_task in the workflow processor. 2021-05-19 16:26:16 -04:00