sartography/cr-connect-workflow
1
0
Fork 0
mirror of https://github.com/sartography/cr-connect-workflow.git synced 2025-02-24 21:58:32 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,694 Commits 14 Branches 0 Tags 9.1 MiB
Commit Graph

795 Commits

Author SHA1 Message Date
Dan Funk
f15626033d Allow the workflow to be requested without making changes to the workflow - requires that you specify a read_only flag of true, otherwise it assumes that you want a fully prepared workflow with the next ready task set to run. 2020-07-28 13:33:38 -04:00
Kelly McDonald
d617af8565 All tests are passing - may need to refactor a bit, / remove comments 2020-07-28 11:02:49 -04:00
Dan Funk
300026cbc8 Expanding the task events endpoint to accept workflow and study ids as additional filters. 
Removing events from the study endpoint, too noisy.
 2020-07-28 10:16:48 -04:00
Dan Funk
0cb480801b Provide event data on the Study api endpoint. 
Speed up the tests a little, because that got out of hand.  Need to dig into what is causing this problem.
 2020-07-27 17:05:01 -04:00
Dan Funk
452f2c3723 Building out a user service for getting the current user, it will provide a number of functions, one of which will allow administrative users to impersonate other users in some circumstances (but will assure that we log events correctly when an impersonation occures) 2020-07-27 14:38:57 -04:00
Kelly McDonald
70ad3872a7 Fix several bugs, most had an issue with the bpmn document 2020-07-27 12:02:34 -04:00
Kelly McDonald
a124e13c6a Replace all legacy style calls with new calls. 
Still having issues where we try to eval an empty definition, not quite sure why there is a difference from what we had before. I may need to revert some of it and determine what is going on.
 2020-07-24 14:33:24 -04:00
Kelly McDonald
f5ab283538 Test of adding in the ability of augmenting the workflow to include internal scripts like StudyInfo 
This is the first waypoint on a larger effort to make all of the 'special scripts' that currently require a shebang to be just another python function.
 2020-07-24 12:08:46 -04:00
Dan Funk
5ec5fcb4e4 Correcting an issue with the Navigation where it did not correctly handle looking back to a previous task within the workflow. 
In some cases the session was not getting committed, leaving rogue assignments outstanding for a workflow.
 2020-07-23 12:00:24 -04:00
Aaron Louie
855f5544e5 Adds enrollment_date to study model 2020-07-22 09:35:08 -04:00
Dan Funk
6caf44544c Merge branch 'dev' into cr-connect-92-scripting-enhancements 
# Conflicts:
#	crc/static/bpmn/ind_supplement/ind_supplement.bpmn
#	tests/workflow/test_workflow_service.py
 2020-07-20 13:01:23 -04:00
Dan Funk
dd0f984347 Drop backwards compatibility of scripts. While this will cause some initial pain, it's less confusing and error prone, and we are still in the development phase of the project. Were this going straight to production we would likely want to keep this backwards compatibility. 
Don't parse on spaces if this is python code, so we avoid any errors in processing - spaces should be valid.
 2020-07-20 12:26:34 -04:00
Dan Funk
b85869905b Merge branch 'cr-connect-92-scripting-enhancements' of github.com:sartography/cr-connect-workflow into cr-connect-92-scripting-enhancements 2020-07-20 11:40:10 -04:00
Dan Funk
06430550c8 Dropping the RRT-Data-Fix, it should have come out already, but had a failing test, so pulling it out now rather than delve into what is going wrong with obsolete code. 2020-07-20 11:39:50 -04:00
Kelly McDonald
f415f22ccb Add warning message when we fail due to syntax error and then we try to look up the class as a backup 2020-07-20 10:12:15 -04:00
Carlos Lopez
fcb772c900 Reporting to Sentry all captured exceptions and enabling multiple environments 2020-07-19 16:40:33 -06:00
Carlos Lopez
73400ed6c7 Adding proper tests for files publishing 2020-07-17 16:59:25 -06:00
Aaron Louie
e82532aad8 Updates IND workflow spec. Fixes validation process to return lookups for enum values. 2020-07-17 11:51:21 -04:00
Kelly McDonald
de54b63e20 Process scripts with no shebang (#!) as a regular python script. If there is a shebang, we look up the class as we did before. 
I've also made it so that it falls back if we accidentally forget to add a shebang to a study as this would be a breaking change.

With the fallback feature, it should work with unmodified bpmn documents.
 2020-07-17 10:56:04 -04:00
Kelly McDonald
ab5771024e Check in for sanity check 2020-07-17 09:24:53 -04:00
Aaron Louie
d67105332f Merge branch 'dev' into feature/lanes_and_roles 2020-07-16 14:00:53 -04:00
Aaron Louie
d0279a11e5 Fixes failing unit test 2020-07-15 17:44:46 -04:00
Aaron Louie
08fba1a4dc Merge branch 'dev' into feature/dynamic_enum_list 2020-07-15 13:09:02 -04:00
Dan Funk
c7662315aa Assure that any errors that occur during the do_engine_steps is correctly captured and returned to the end user or configurator with enough information for them to act on. 2020-07-15 11:16:35 -04:00
Dan Funk
fa7608053a fixing a failed test. 2020-07-14 22:23:54 -04:00
Dan Funk
d85ca1ce51 Whenever a workflow is loaded or updated, add events to the TaskEvent table with assignments for the next set of ready tasks, along with who should complete those tasks. 
Add the lane information to the Task model.
Drop the foreign key constraint on the user_uid in the task log, as we might create tasks for users before they ever log into the system.
Add a new endpoint to the API called task events.  It should be possible to query this and get a list of all tasks that need a users attention.
The task events returned include detailed information about the workflow and study as sub-models
Rename all the actions in event log to things that are easier to pass over the api as arguments, make this backwards compatible, updating existing names in the database via the migration.
Throughly test the navigation and task details as control of the workflow is passed between two lanes.
 2020-07-14 22:16:44 -04:00
Aaron Louie
d71ff80eac Adds end and start events 2020-07-14 13:42:52 -04:00
Dan Funk
9077ff3ebf It is not possible to use task_data for an auto-complete field. It's too expensive an operation to provide that feature on the backend, and the data already fully resides on the front end anyway. Task-data can be used to populate enum fields if needed, so it can populate dropdowns, radios and checkboxes, just not auto-complete. 2020-07-14 11:38:48 -04:00
Dan Funk
a48322ef6a Partial work on CR Connect Roles. 
Adding checks in the API to assure the correct person is completeing a task based on the task's lane.
Adding lane to the Navigation item.
Adding a check to assure that unique user ids can be identified using task.data
Added some additional ldap entries to make testing and development easier.
Removed a big chunk of duplicate code from task_tests_api
Modified some of the helper functions to make it easier to test as specific users.
Added some additional bpmn models to the tests for testing lanes and roles.
 2020-07-14 10:29:25 -04:00
Aaron Louie
463660f185 Merge branch 'dev' into feature/dynamic_enum_list 2020-07-13 17:47:56 -04:00
Aaron Louie
07066b8a16 Looks up enum options from task data 2020-07-13 17:46:28 -04:00
Dan Funk
9e29a43785 Correct for a race condition where multiple lookup tables are built for the same field and workflow specification, causing it to appear that the models are not updating correctly. 2020-07-13 12:45:51 -04:00
Aaron Louie
b7920989ed WIP: Adds Camunda property for retrieving enum field options from task data. 2020-07-10 14:48:38 -04:00
Aaron Louie
7f0b35ff27 Merge branch 'dev' into feature/enum_lookup_data 2020-07-10 10:27:51 -04:00
Dan Funk
ff7c30b879
Merge pull request #138 from sartography/fix/cleanup_todos 
Cleanup pending  TODOs
 2020-07-10 08:26:47 -04:00
Dan Funk
6a79fb3581 There may be multiple investigators of the same type that come back from the protocol builder, adding some tests and additional code to handle this, but still keep the list flat, currently appends a number to the investigator type when there is more than one. 2020-07-07 17:16:33 -04:00
Carlos Lopez
64f9bd2ca7 Tiny leftover 2020-07-07 08:38:33 -06:00
Carlos Lopez
b4e127b3b7 Cleaning properly previous versions 2020-07-07 08:32:41 -06:00
Carlos Lopez
a302208890 Updating test for study with approvals 2020-07-07 08:32:41 -06:00
Carlos Lopez
c7b864f9c7 Cleaning up old notes 2020-07-07 08:32:20 -06:00
Aaron Louie
517cd8fc91 Merge branch 'dev' into feature/enum_lookup_data 2020-07-06 16:31:19 -04:00
Dan Funk
bb4000ff6d Don't attept to load up the workflows for abandoned studies. 2020-07-06 16:01:43 -04:00
Dan Funk
8a66128189 Bug fixes after bumping the version of Spiffworlflow to the latest - which has fixes for sequential multi-instance. 2020-07-06 15:34:24 -04:00
Dan Funk
419c05e46c
Merge branch 'dev' into fix/more-info-in-exceptions 2020-07-06 12:51:24 -04:00
Dan Funk
a5cef8775e * Modifying the StudyInfo script to return both "investigators" and "roles", the investigators argument will return only the current active investigators according to the protocol builder. The "roles" argument returns all possible roles - it is what "investigators" use to be. 
* The Task.title returned to the front end will now attempt to process the "display_name" property for dot-notation syntax, making it possible to use this for multi-instance tasks,
  but will work in all cases where we want he title to change based on values in the data model.
* Fixing a bug the test_study_api where it wasn't updated when we made recent changes to the different states of a study.
*
 2020-07-06 12:09:21 -04:00
Aaron Louie
1d9fef380a Merge branch 'fix/more-info-in-exceptions' into feature/enum_lookup_data 2020-07-03 14:22:11 -04:00
Aaron Louie
f344fe60c0 WIP: Adds enum field lookup option data 2020-07-03 12:20:10 -04:00
Carlos Lopez
817333f26e Adding proper exception information 2020-07-02 16:10:33 -06:00
Dan Funk
84973d2351 resolving comments from pull request. 2020-06-30 12:24:48 -04:00
Dan Funk
93bf46354b A last minute change to make the API a little clearer and cleaner broke some tests. 2020-06-30 11:12:28 -04:00